From nobody Sat Feb 7 10:44:29 2026 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9351F26B2D2 for ; Fri, 23 Jan 2026 21:19:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769203169; cv=none; b=oAVhjCGI9SIyp7YbXi85IsPEl8HenXTI8PCVAR0o1FZwfbY+W7gxIHtq6D40ZiGDzEsEazQSeQvWsLbLpl8ugJb1A5qxRdlxn2knwHePGLMyK2flG/9ivWsEnQYNce40RqCOGEO50+CVzf6ZHGnZTCyOl895V4AO5M7CvXfz9oY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769203169; c=relaxed/simple; bh=x081jC8JXriAE4oHCAWY2bSuHY7h6TucW0qI94b3sjc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fO3eY0As5xvmoUJx+GZ7C2uktCuCjilcPQ1UtuZOBnbn+nulnEe1ai04hYpWpRBHRehRJTvs6ufaPrN3wYM4atX8Jx+HbkluyUgo+dHVH5j6vpNlZgBcGs8I+O7FgYJx87sYwJmfbN8NKJEo/CE5FqJMQwlrw3zReKt+zJMW8Jw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cu6G1wv+; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cu6G1wv+" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-8230f8f27cfso1077168b3a.0 for ; Fri, 23 Jan 2026 13:19:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769203167; x=1769807967; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MnGBmszyGaByDQK4I91utuBBzBnkbHQvK2pzSg1xsvc=; b=cu6G1wv+m+CuciGev9QguNRMRAsxkJq2DjNLXj/YK5bdAut9Br95by2BGbU03Is1NH E/36EqovF6pDayMTR23lRRyzDRsV4zPqa2A6w7lHk4z03GHkgtJuh5hhuSQiqfuM4qk5 alSptWFza96C1tLFhe9dA0jSfIpf6MtTRXPKU4mpndeP+oPkwL3vp+SpNmg7MZwOtulD spaawniHdMDNav119nJYlUMhsbdOOv/Zu8b8oFbD2hK546COQXBLBGbAheheOBiayqJV 2+/ktOsXan5qpqUiuIO1fNGOtMW8ERx9sCVbPuKAveF1YCfYIBg9B4TIDrbcRX2QexY3 zSUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769203167; x=1769807967; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MnGBmszyGaByDQK4I91utuBBzBnkbHQvK2pzSg1xsvc=; b=RKocGwjypa0YHQKPUWyMRe+A1vJFo8Vg+eczZAXHcxM59miRJvRpJAVvPKUdeHPILf RIKmund0OjgtQskXU7FVA2qPFgYudNFVI5wCcvRaWaVYCuGc6Lb6cUXunQkSmz1yhZsD sduc4sVE3Dus5UXeX/7RTEfpJ6rNEDBJ0c+yUDXAs6HbEQWdFakkVQJZULhVw8XL48h5 usCmSojqs8ZfX1WkF4net5reYt/5q1uJYWxqJJ8Ag7UHxB/aYx5eRQAPxp+Ne0ZMSKDp c9wqwPq9jHWFIq/Ku3SYbDy5Dy3aZ5uqIbCElMjvilg1XB86sqhLNV+9Coccm+f/guoH AWoQ== X-Forwarded-Encrypted: i=1; AJvYcCWdCY2zk1ZyVNpg0FTKL2HahCSqjlNP7M37NJThIHXJVJKeQ3LVOyKENuNh41P6p7pNUgHPeyfKlXtC5jE=@vger.kernel.org X-Gm-Message-State: AOJu0YxEtQ+vPxrN+wI/bXMCjcmvnfh9DpkJWI0L7srj+bZUr0INkexf uBUytZBHqjS13nHd9p9DfFFB6enx6NI1Df59xfL2ncjXT7iQ4dIkkuve X-Gm-Gg: AZuq6aKDWULd4WVpChDq7Q3AsAV2gmjhsKMX9DCIy2X31QI4AL0oeqoKwjaN/KnJlBz Cmj21Q6up8/8mq0vtKFRwDi4jFckbUIS0vsBCQPCCkyTrC7TiVFuKUocNue+k6luhk49GzL3OwK LDqS19v4uukXdJaHz9axJZ5PXB7LD92gl8mhFdHTIzenJGE2umXnQcQavSzQgAhO7MOUCblz7qb jbfWuveMv/afKCtLEleUHOMxylGrpBGlGoZymySgrQCGBWicbQpqQaIFb4d5z65JN5CWX8jsJ83 2ffXey8CeMsn93QMhxEQYuuHWn48PEY5Xri3Lmhf/59KqZYqYtD6o7HPx2vwOMDCfc48wQjXEML S2FLs6k24Gmn0X+ztvYlw3VutKWoR5Q5m0pnt1QoaBddRLQNu1YsW87/tzDBakUQItVhBuSKAIL YA12unEKNvyD61w/ytLPbu62mv6CPuG2Lza7JLGQF4G8c= X-Received: by 2002:a05:6a21:4591:b0:38b:ecae:6718 with SMTP id adf61e73a8af0-38e6f52f48fmr4193861637.0.1769203166623; Fri, 23 Jan 2026 13:19:26 -0800 (PST) Received: from tehuang-Alienware-m16-R2.. ([50.47.240.160]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c635a141fc4sm2779469a12.8.2026.01.23.13.19.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 13:19:26 -0800 (PST) From: Michael Huang To: Greg Kroah-Hartman Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Huang Subject: [PATCH v3 2/2] staging: rtl8723bs: fix line length and coding style issues Date: Fri, 23 Jan 2026 13:19:04 -0800 Message-ID: <20260123211904.64589-3-tehsiu.huang@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260123211904.64589-1-tehsiu.huang@gmail.com> References: <20260123211904.64589-1-tehsiu.huang@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix checkpatch.pl warnings regarding line length exceeding 100 columns, white spaces, and unnecessary braces in rtw_mlme_ext.c. Signed-off-by: Michael Huang --- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 81 ++++++++++--------- 1 file changed, 45 insertions(+), 36 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/stagin= g/rtl8723bs/core/rtw_mlme_ext.c index 0ab3629608ce..848d503ffd1d 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c @@ -1120,11 +1120,10 @@ unsigned int OnAssocReq(struct adapter *padapter, u= nion recv_frame *precv_frame) =20 pstat->flags &=3D ~(WLAN_STA_WPS | WLAN_STA_MAYBE_WPS); if (!wpa_ie) { - if (elems.wps_ie) { + if (elems.wps_ie) pstat->flags |=3D WLAN_STA_WPS; - } else { + else pstat->flags |=3D WLAN_STA_MAYBE_WPS; - } =20 =20 /* AP support WPA/RSN, and sta is going to do WPS, but AP is not ready = */ @@ -4939,7 +4938,9 @@ void _linked_info_dump(struct adapter *padapter) if (padapter->bLinkInfoDump) { =20 if ((pmlmeinfo->state&0x03) =3D=3D WIFI_FW_STATION_STATE) - rtw_hal_get_def_var(padapter, HAL_DEF_UNDERCORATEDSMOOTHEDPWDB, &Undeco= ratedSmoothedPWDB); + rtw_hal_get_def_var(padapter, + HAL_DEF_UNDERCORATEDSMOOTHEDPWDB, + &UndecoratedSmoothedPWDB); =20 for (i =3D 0; i < NUM_STA; i++) { if (pdvobj->macid[i]) { @@ -4978,7 +4979,6 @@ void linked_status_chk(struct adapter *padapter) struct mlme_ext_info *pmlmeinfo =3D &pmlmeext->mlmext_info; struct sta_priv *pstapriv =3D &padapter->stapriv; =20 - if (is_client_associated_to_ap(padapter)) { /* linked infrastructure client mode */ =20 @@ -4994,7 +4994,8 @@ void linked_status_chk(struct adapter *padapter) link_count_limit =3D 7; /* 16 sec */ =20 /* Marked by Kurt 20130715 */ - /* For WiDi 3.5 and latered on, they don't ask WiDi sink to do roaming,= so we could not check rx limit that strictly. */ + /* For WiDi 3.5 and latered on, they don't ask WiDi sink to do roaming,= */ + /* so we could not check rx limit that strictly. */ /* todo: To check why we under miracast session, rx_chk would be false = */ psta =3D rtw_get_stainfo(pstapriv, pmlmeinfo->network.mac_address); if (psta) { @@ -5007,9 +5008,18 @@ void linked_status_chk(struct adapter *padapter) { if (rx_chk !=3D _SUCCESS) { if (pmlmeext->retry =3D=3D 0) { - issue_probereq_ex(padapter, &pmlmeinfo->network.ssid, pmlmeinfo->net= work.mac_address, 0, 0, 0, 0); - issue_probereq_ex(padapter, &pmlmeinfo->network.ssid, pmlmeinfo->net= work.mac_address, 0, 0, 0, 0); - issue_probereq_ex(padapter, &pmlmeinfo->network.ssid, pmlmeinfo->net= work.mac_address, 0, 0, 0, 0); + issue_probereq_ex(padapter, + &pmlmeinfo->network.ssid, + pmlmeinfo->network.mac_address, + 0, 0, 0, 0); + issue_probereq_ex(padapter, + &pmlmeinfo->network.ssid, + pmlmeinfo->network.mac_address, + 0, 0, 0, 0); + issue_probereq_ex(padapter, + &pmlmeinfo->network.ssid, + pmlmeinfo->network.mac_address, + 0, 0, 0, 0); } } =20 @@ -5033,7 +5043,7 @@ void linked_status_chk(struct adapter *padapter) } =20 if (tx_chk =3D=3D _FAIL) { - pmlmeinfo->link_count %=3D (link_count_limit+1); + pmlmeinfo->link_count %=3D (link_count_limit + 1); } else { pxmitpriv->last_tx_pkts =3D pxmitpriv->tx_pkts; pmlmeinfo->link_count =3D 0; @@ -5051,7 +5061,6 @@ void linked_status_chk(struct adapter *padapter) continue; =20 if (pmlmeinfo->FW_sta_info[i].rx_pkt =3D=3D sta_rx_pkts(psta)) { - if (pmlmeinfo->FW_sta_info[i].retry < 3) { pmlmeinfo->FW_sta_info[i].retry++; } else { @@ -5069,9 +5078,7 @@ void linked_status_chk(struct adapter *padapter) } =20 /* set_link_timer(pmlmeext, DISCONNECT_TO); */ - } - } =20 void survey_timer_hdl(struct timer_list *t) @@ -5195,7 +5202,7 @@ u8 setopmode_hdl(struct adapter *padapter, u8 *pbuf) type =3D _HW_STATE_AP_; /* start_ap_mode(padapter); */ } else if (psetop->mode =3D=3D Ndis802_11Infrastructure) { - pmlmeinfo->state &=3D ~(BIT(0)|BIT(1));/* clear state */ + pmlmeinfo->state &=3D ~(BIT(0) | BIT(1));/* clear state */ pmlmeinfo->state |=3D WIFI_FW_STATION_STATE;/* set to STATION_STATE */ type =3D _HW_STATE_STATION_; } else if (psetop->mode =3D=3D Ndis802_11IBSS) { @@ -5214,7 +5221,6 @@ u8 setopmode_hdl(struct adapter *padapter, u8 *pbuf) } =20 return H2C_SUCCESS; - } =20 u8 createbss_hdl(struct adapter *padapter, u8 *pbuf) @@ -5518,8 +5524,11 @@ u8 sitesurvey_cmd_hdl(struct adapter *padapter, u8 *= pbuf) =20 for (i =3D 0; i < RTW_SSID_SCAN_AMOUNT; i++) { if (pparm->ssid[i].ssid_length) { - memcpy(pmlmeext->sitesurvey_res.ssid[i].ssid, pparm->ssid[i].ssid, IW_= ESSID_MAX_SIZE); - pmlmeext->sitesurvey_res.ssid[i].ssid_length =3D pparm->ssid[i].ssid_l= ength; + memcpy(pmlmeext->sitesurvey_res.ssid[i].ssid, + pparm->ssid[i].ssid, + IW_ESSID_MAX_SIZE); + pmlmeext->sitesurvey_res.ssid[i].ssid_length =3D + pparm->ssid[i].ssid_length; } else { pmlmeext->sitesurvey_res.ssid[i].ssid_length =3D 0; } @@ -5547,7 +5556,8 @@ u8 sitesurvey_cmd_hdl(struct adapter *padapter, u8 *p= buf) } } =20 - if ((pmlmeext->sitesurvey_res.state =3D=3D SCAN_START) || (pmlmeext->site= survey_res.state =3D=3D SCAN_TXNULL)) { + if ((pmlmeext->sitesurvey_res.state =3D=3D SCAN_START) || + (pmlmeext->sitesurvey_res.state =3D=3D SCAN_TXNULL)) { /* disable dynamic functions, such as high power, DIG */ Save_DM_Func_Flag(padapter); Switch_DM_Func(padapter, DYNAMIC_FUNC_DISABLE, false); @@ -5571,7 +5581,6 @@ u8 sitesurvey_cmd_hdl(struct adapter *padapter, u8 *p= buf) site_survey(padapter); =20 return H2C_SUCCESS; - } =20 u8 setauth_hdl(struct adapter *padapter, unsigned char *pbuf) @@ -5701,7 +5710,6 @@ u8 add_ba_hdl(struct adapter *padapter, unsigned char= *pbuf) return H2C_SUCCESS; } =20 - u8 chk_bmc_sleepq_cmd(struct adapter *padapter) { struct cmd_obj *ph2c; @@ -5747,8 +5755,8 @@ u8 set_tx_beacon_cmd(struct adapter *padapter) =20 memcpy(&(ptxBeacon_parm->network), &(pmlmeinfo->network), sizeof(struct w= lan_bssid_ex)); =20 - len_diff =3D update_hidden_ssid(ptxBeacon_parm->network.ies+_BEACON_IE_OF= FSET_, - ptxBeacon_parm->network.ie_length-_BEACON_IE_OFFSET_, + len_diff =3D update_hidden_ssid(ptxBeacon_parm->network.ies + _BEACON_IE_= OFFSET_, + ptxBeacon_parm->network.ie_length - _BEACON_IE_OFFSET_, pmlmeinfo->hidden_ssid_mode); ptxBeacon_parm->network.ie_length +=3D len_diff; =20 @@ -5803,8 +5811,8 @@ u8 mlme_evt_hdl(struct adapter *padapter, unsigned ch= ar *pbuf) goto _abort_event_; =20 peventbuf =3D (uint *)pbuf; - evt_sz =3D (u16)(*peventbuf&0xffff); - evt_code =3D (u8)((*peventbuf>>16)&0xff); + evt_sz =3D (u16)(*peventbuf & 0xffff); + evt_code =3D (u8)((*peventbuf >> 16) & 0xff); =20 /* checking if event code is valid */ if (evt_code >=3D MAX_C2HEVT) @@ -5812,7 +5820,7 @@ u8 mlme_evt_hdl(struct adapter *padapter, unsigned ch= ar *pbuf) =20 /* checking if event size match the event parm size */ if ((wlanevents[evt_code].parmsize !=3D 0) && - (wlanevents[evt_code].parmsize !=3D evt_sz)) + (wlanevents[evt_code].parmsize !=3D evt_sz)) goto _abort_event_; =20 atomic_inc(&pevt_priv->event_seq); @@ -5826,12 +5834,8 @@ u8 mlme_evt_hdl(struct adapter *padapter, unsigned c= har *pbuf) pevt_priv->evt_done_cnt++; } =20 - _abort_event_: - - return H2C_SUCCESS; - } =20 u8 h2c_msg_hdl(struct adapter *padapter, unsigned char *pbuf) @@ -5855,7 +5859,7 @@ u8 chk_bmc_sleepq_hdl(struct adapter *padapter, unsig= ned char *pbuf) if (!psta_bmc) return H2C_SUCCESS; =20 - if ((pstapriv->tim_bitmap&BIT(0)) && (psta_bmc->sleepq_len > 0)) { + if ((pstapriv->tim_bitmap & BIT(0)) && (psta_bmc->sleepq_len > 0)) { msleep(10);/* 10ms, ATIM(HIQ) Windows */ =20 /* spin_lock_bh(&psta_bmc->sleep_q.lock); */ @@ -5954,8 +5958,13 @@ u8 set_chplan_hdl(struct adapter *padapter, unsigned= char *pbuf) =20 setChannelPlan_param =3D (struct SetChannelPlan_param *)pbuf; =20 - pmlmeext->max_chan_nums =3D init_channel_set(padapter, setChannelPlan_par= am->channel_plan, pmlmeext->channel_set); - init_channel_list(padapter, pmlmeext->channel_set, pmlmeext->max_chan_num= s, &pmlmeext->channel_list); + pmlmeext->max_chan_nums =3D init_channel_set(padapter, + setChannelPlan_param->channel_plan, + pmlmeext->channel_set); + init_channel_list(padapter, + pmlmeext->channel_set, + pmlmeext->max_chan_nums, + &pmlmeext->channel_list); =20 if (padapter->rtw_wdev && padapter->rtw_wdev->wiphy) { struct regulatory_request request; @@ -5975,9 +5984,10 @@ u8 set_csa_hdl(struct adapter *padapter, unsigned ch= ar *pbuf) /* TDLS_ESTABLISHED : write RCR DATA BIT */ /* TDLS_CS_OFF : go back to the channel linked with AP, terminating chan= nel switch procedure */ /* TDLS_INIT_CH_SEN : init channel sensing, receive all data and mgnt fra= me */ -/* TDLS_DONE_CH_SEN: channel sensing and report candidate channel */ +/* TDLS_DONE_CH_SEN : channel sensing and report candidate channel */ /* TDLS_OFF_CH : first time set channel to off channel */ -/* TDLS_BASE_CH : go back tp the channel linked with AP when set base ch= annel as target channel */ +/* TDLS_BASE_CH : go back tp the channel linked with AP when set */ +/* base channel as target channel */ /* TDLS_P_OFF_CH : periodically go to off channel */ /* TDLS_P_BASE_CH : periodically go back to base channel */ /* TDLS_RS_RCR : restore RCR */ @@ -5991,8 +6001,7 @@ u8 run_in_thread_hdl(struct adapter *padapter, u8 *pb= uf) { struct RunInThread_param *p; =20 - - if (pbuf =3D=3D NULL) + if (!pbuf) return H2C_PARAMETERS_ERROR; p =3D (struct RunInThread_param *)pbuf; =20 --=20 2.43.0