From nobody Sat Feb 7 06:14:42 2026 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 106232F5328 for ; Fri, 23 Jan 2026 21:10:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769202653; cv=none; b=EpAJBkEqBrVAheRS1uPko7gXwY6dWbvjVtzbrp2FlE/P87mn77efwFPQWo+WkAu1KnCqC4ifOGTHDdZvoxvFlDsYMGKD6h7rZ4eqePWXd5J/Me2hR/v7GiPn/cd759FHQoyNKc6f/fHZ32Ug/kci+WH6C2AiUCrdU6PYX4zZv/w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769202653; c=relaxed/simple; bh=Be53D6pKmPcYdTpNJVEfk1jJ3RT4jCyrusGvCtJrluc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LpTxL8A9gb9H9ejlGo8miP/AOXWrUPVnk7Wt+TgerEOwmHX2Negy83x764QRHHv/Qo7Oi6FBwTN4Pjjjk90ldR7H2kYdnjkSgTLfZ1rc7O5h6yG6or/YJ4xcgOIoQupeT3CnT4aqSDdMglX+TT81Pm8qPBevYlSDEPKgU5NkFbM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QMaj5Fc4; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QMaj5Fc4" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2a12ebe4b74so29041005ad.0 for ; Fri, 23 Jan 2026 13:10:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769202650; x=1769807450; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XaIB4jAIwQJAbyKIhxwkktHEa0cxLoXn5gAW3Xs2KS4=; b=QMaj5Fc4sVJ2T15Gw1v5TM8gWSuEnypf7OmCUx9joBkgaqCCzZV7jgGlOp/bz6AaSM dks/hDqAIu+0hKBJOKRb5pn6SCescAYfbdPfgiA+B1wMOxkOxylkdku/prfFfrw/QFyf qRpSZTyO6d6+VIcpXy2yjpD62dhREivFYwYTAq3DbqTfVs8MoukEr6BJxiyJR/Bssu9p 6QoLV3IUXDEa0hmOw9k+nODKsB3ue9nFNPLftomklW/r8oFxt9ORFMSYiJWTP++ID252 pDUfBDJTyLbdpaNlEratYc9lOq7J1vfg3mZ18IotiNI58vsUFlR+rng5GXxanX5G02Ky dcAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769202650; x=1769807450; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XaIB4jAIwQJAbyKIhxwkktHEa0cxLoXn5gAW3Xs2KS4=; b=aJH7kwfvIhUrUzZXoj2U9n8o7OQsEvn+7FMRJmYlsiQgG8lLMsVj/jp5caamEweX+x fEuuG5GNiGYRUimpeKF1f53lxAGM6Ecx0TNY2oKypxSw54jbWdQL3zo1nCs6B0vkH9Lv KasaDfzk2cBok9sp5D1Kyp21tMrQlU/nwwehuSHgw8vdjt/T5R2nYx/+Nvs9vDpxC4aY K9WXDQdXRVsjXYafxOkDeRoTpe0LsSDoeyWDmm3FzEKA8HL+uBEp0LZTst5cMF7ZgV7q urC9kTvCnRjN50Lup6N2OTq5bPAwNaehHEDw2isXpfY7VCC+gQnjRRAef3KFAd4rmPlN Rj/Q== X-Forwarded-Encrypted: i=1; AJvYcCW1tfZN4WgxTGBqrMENNdOrU3DFkaPY7rsajEDGX5MenySg6LlYToNrU7mwcbK3dC7WSvRXDOSxLz4Di/c=@vger.kernel.org X-Gm-Message-State: AOJu0YwW2ejK6CvuNthrV+LrC3otird9HoARVHlN0V1xPOViu29lYi4v 9+AiLNuF+CRUMiYT6+lX9jaxJ/Z9jYGaaN/Qc/fB2op+re8GHmeI3/cg+l/GL3FNsVwOyEKCLQ= = X-Gm-Gg: AZuq6aInwlsZ3/fcwhXIx/DvFZnXLnkKBtJRksLlqUs/0tkSfnKAJ1MfpoSDfIAvPrT vVXT+Q5Z7dxbDHAPvPVortidQ0mTEghR6aY82rUQwG52RyWuoUd7y/BEHI0yo/Inq0S7He8tlyj CkLZBx4iKJaBX/9Vpo7wEB1nxUZ/fKFOD+mAoBwv67PDyls4UCrp2PwzGx0QhBM+lbB3xx6QZsg b6z+fUEFlgG28OJN88yUCdHXA8UIkfFbF30MBN6mBThvV0u6zkliekMETPWhvbpVg5YC0U7Xx+2 XGWCr6dzdA9hQe4UgAbqoFOKH5foYYvqEeNO0i+o2CicWUnycxT+2dGd83TXcml+lx/ok3CjSjv zUzdC/oH7vCVmgc6c/gaGp0pHAwy0zR75WwdYXqmIaA5UDm7xDJh7BLDsFo+67z3CBAyYhLu/rY yz0HYi41jc35x9L7E= X-Received: by 2002:a17:902:e5cf:b0:2a0:8be7:e3d7 with SMTP id d9443c01a7336-2a7fe75c6d4mr40090285ad.57.1769202650382; Fri, 23 Jan 2026 13:10:50 -0800 (PST) Received: from DESKTOP-BKIPFGN ([38.76.140.13]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a802f978b8sm27313745ad.46.2026.01.23.13.10.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 13:10:49 -0800 (PST) From: Kery Qi To: jiri@resnulli.us, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kery Qi Subject: [PATCH] rocker: fix memory leak in rocker_world_port_post_fini() Date: Sat, 24 Jan 2026 05:10:31 +0800 Message-ID: <20260123211030.2109-2-qikeyu2017@gmail.com> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In rocker_world_port_pre_init(), rocker_port->wpriv is allocated with kzalloc(wops->port_priv_size, GFP_KERNEL). However, in rocker_world_port_post_fini(), the memory is only freed when wops->port_post_fini callback is set: if (!wops->port_post_fini) return; wops->port_post_fini(rocker_port); kfree(rocker_port->wpriv); Since rocker_ofdpa_ops does not implement port_post_fini callback (it is NULL), the wpriv memory allocated for each port is never freed when ports are removed. This leads to a memory leak of sizeof(struct ofdpa_port) bytes per port on every device removal. Fix this by always calling kfree(rocker_port->wpriv) regardless of whether the port_post_fini callback exists. Fixes: e420114eef4a ("rocker: introduce worlds infrastructure") Signed-off-by: Kery Qi Reviewed-by: Simon Horman --- drivers/net/ethernet/rocker/rocker_main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethern= et/rocker/rocker_main.c index 36af94a2e062..2794f75df8fc 100644 --- a/drivers/net/ethernet/rocker/rocker_main.c +++ b/drivers/net/ethernet/rocker/rocker_main.c @@ -1524,9 +1524,8 @@ static void rocker_world_port_post_fini(struct rocker= _port *rocker_port) { struct rocker_world_ops *wops =3D rocker_port->rocker->wops; =20 - if (!wops->port_post_fini) - return; - wops->port_post_fini(rocker_port); + if (wops->port_post_fini) + wops->port_post_fini(rocker_port); kfree(rocker_port->wpriv); } =20 --=20 2.34.1