From nobody Sat Feb 7 06:14:28 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DC45158DA3 for ; Fri, 23 Jan 2026 19:48:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769197710; cv=none; b=POmTqaZHmnHxJgZJSc/nJbGpNKJcl/Qc2iUGOhmKj25Cr4WI5+p5U4vH/K3PwFBlfqkSeRh1CANIJv4kOzqMHK4NkuF+DK737mlR+eRtU7VRYqpBdxBX/t06+RgkcjTYbq++bUFuhyfv7GwBRHlvpQD2iVWtK87AWBYVzkgVQhQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769197710; c=relaxed/simple; bh=B1c/vr0GUaEtusnH07mu4sq5q8A1cYkBwTJ7qRZS3NI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tvQkMyayET2z5wnIlH7AwtCoJw2xIop2B1/Xd24JFvvSUmlitHE720VqC8OhXWe8qC5TK1sB9dlivl9USlN64WmMcvSFveIABywKe17xBP9JK8Gr7mRl0NNDy2g/g8wvkHB3QTMuHRcgVB6HJcM2iyC5ovG1u37wekWv3i8/gWw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Op7zqKXv; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Op7zqKXv" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-823210d1d8eso448024b3a.1 for ; Fri, 23 Jan 2026 11:48:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769197709; x=1769802509; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=B3R1HFYAHVqM4kzN3/S5Q8P4MgXYgJzeRc7cvT0rLI4=; b=Op7zqKXvfU5ogwzPXBXvV01axqv+ohlWi0Rh25G3HQzM7Nw5WjLwtzsIk3hCduLpQm LfwgeEfOI5fJhL85gpx53v2Pm5MTXWOPeiAExf4/eDesI6HdI56GyyHPwhssUiXqAR0I Ii3F9N/jEcZvASk2/cmwTYFnwtPucAoPHF/oplIqLr2m1f4iyiczWfzOfAmORCymyMmB kuuJZ+8Mgefcpv1npkdc9Am6jIP3E8JZqfp6NTEzOOvBd2ocipMbJ7EOzEw+2dWzWPn/ XyiUGZNEU5/SCbJ4sY6EDnkJoycK7BMTr5dxhJVPy/GOc6v66OD8eiA7E8MqiHjNLgbv y47A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769197709; x=1769802509; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B3R1HFYAHVqM4kzN3/S5Q8P4MgXYgJzeRc7cvT0rLI4=; b=vYs1H4bAMFI4XogVwWCTCamarwtH/qneLQWwdvZfXCkQD8buFObjbo33rVBiHv2le8 hSqPSnkvEBgXBHJSQ7rqagoVCSalkg2tdbS6JX4dytG5vnKVunPlVqJvfWPJIxLPN1XY E02h+i/ibBWi/4lUVNL1TzU2jpq27uDDlFr2pvecuXXOGDuv/D1bIlxKEIsWONoIlj2A fsxTJxcoq8M7v422/8H28N+nifYIPps0eujmYCRbbyX9Ztf2Qbpi3OPhc5jFZLhvEBle IvOsoMgDVKXAMAGq1GT2H4LKaOt3FWH+8CA6RJ41w+nMPFWNzYfV57jQqvjOisvX5viy /bVA== X-Forwarded-Encrypted: i=1; AJvYcCUvwnZpzmQe6qvj0s0UpSDaS6JgdYhzTCGInvxlnA0tuUNKVanDIf/ua6EYjLUFlW4JnRuNGpIuSMBD96I=@vger.kernel.org X-Gm-Message-State: AOJu0YzPB9JNPvxtR3Kjec8nNbtv5G/KqRwU3dGMFH++LFsHXRfjkp11 gDHYgImCHoVS15QJHfs+35lAynzMt/kR0sKQWbxFqA+nZbZcVh8dcU9J X-Gm-Gg: AZuq6aIJ2G4gsN5KRLo1hOaWAXC2ET0cqaLtzEcrd7wrDtu6ZXY3OSL43Q/D3yZ0+1F yjyT9boMAfTDLcnMsEaxOYvlVllURDp2wC9memyPZejVngCIfEqI/Y9MclFXNt+oiucs3doVDyu TgFjHNUDVlDQBG2tLR2TyCQprXSSU1zLnmZ3tdHIv8+N4tSVvDCBqwGFpvEvcCSp94PV1pele4l ph/h9P4+KGFl+WJugWhX/wcw0/7xUzg7woMoojBio25d4hmjB2rKIf8rmINixfR5kkoEWrP9skp GdSr+l2+9hLSeRXW6Z5owTaD714uQkdMsV0amfkNHBptAtVs1au2UJSxn6lxBKfyOquQrEJSyCu hRsTn3Zb37djOEtGE5WXmZFqBk19f0RTq7oRoSZAA8NabZvo63p7CNGUw8fEKGd7XZGXApEkAIO 1syesxX+iC8OSmF2Kmw7nq7ccgl9mrEA9htMQ= X-Received: by 2002:a05:6a00:1f04:b0:81f:528b:c091 with SMTP id d2e1a72fcca58-82317da618cmr3147119b3a.22.1769197708811; Fri, 23 Jan 2026 11:48:28 -0800 (PST) Received: from fedora ([61.74.238.173]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82318644bcasm2884618b3a.2.2026.01.23.11.48.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 11:48:28 -0800 (PST) From: SeungJu Cheon To: antoniu.miclaus@analog.com, lars@metafoo.de, Michael.Hennerich@analog.com, jic23@kernel.org Cc: andriy.shevchenko@intel.com, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, SeungJu Cheon Subject: [PATCH v3] iio:frequency:adf4377: Fix duplicated soft reset mask Date: Sat, 24 Jan 2026 04:47:58 +0900 Message-ID: <20260123194758.15445-1-suunj1331@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The regmap_read_poll_timeout() uses ADF4377_0000_SOFT_RESET_R_MSK twice instead of checking both SOFT_RESET_MSK (bit 0) and SOFT_RESET_R_MSK (bit 7). This causes an incomplete reset status check. The code first sets both SOFT_RESET and SOFT_RESET_R bits to 1 via regmap_update_bits(), then polls for them to be cleared. Since we set both bits before polling, we should be waiting for both to clear. Fix by using both masks as done in regmap_update_bits() above. Fixes: eda549e2e524 ("iio:frequency:adf4377: add support for ADF4377") Signed-off-by: SeungJu Cheon --- v3: - Summarize discussion about why both bits need to be checked v2: - Add Fixes tag drivers/iio/frequency/adf4377.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/frequency/adf4377.c b/drivers/iio/frequency/adf437= 7.c index 08833b7035e4..48aa4b015a14 100644 --- a/drivers/iio/frequency/adf4377.c +++ b/drivers/iio/frequency/adf4377.c @@ -501,7 +501,7 @@ static int adf4377_soft_reset(struct adf4377_state *st) return ret; =20 return regmap_read_poll_timeout(st->regmap, 0x0, read_val, - !(read_val & (ADF4377_0000_SOFT_RESET_R_MSK | + !(read_val & (ADF4377_0000_SOFT_RESET_MSK | ADF4377_0000_SOFT_RESET_R_MSK)), 200, 200 * 100); } =20 --=20 2.52.0