From nobody Mon Feb 9 23:00:44 2026 Received: from mail-yw1-f225.google.com (mail-yw1-f225.google.com [209.85.128.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2FA0A1F75A6 for ; Fri, 23 Jan 2026 19:35:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.225 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769196942; cv=none; b=l/owS6ifWM7tbFmV/6q6pFiLj7ZIdpURgqJivMRD3oHreyz4dne+S67m1/FSk4ko0zrwV7JTLdfaSiRIXOv4HfI3iLO0QZJ8gm17gPMgto0wQkSRUFPHlmvAZ+7QChBzS8iJgD2SjlYXvN/RU6lsLT1tu+RsWdyLM3uwE/hqw6I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769196942; c=relaxed/simple; bh=+Zc6l/SwHKnLCayJhbpyWDPUKoNOWSCBVYgFGpSy/3E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Xz2Uj9RZfyglza9REr/Puqu5hVLqZiK63s0GdTU6srw7HqYx8GzocjM3jEUEIeNNgxnWa1WHOqpYnu8LKjl+1UJwjla64H2FwyXreLISyk48gnt6dQRS9CeAQPFi8wAc1+7DZKGyHmXKm9gG4hZ8HoMbRFrLywmTxN/TZc9y9Hg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Y42DBoai; arc=none smtp.client-ip=209.85.128.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Y42DBoai" Received: by mail-yw1-f225.google.com with SMTP id 00721157ae682-78fdb90b670so24714857b3.2 for ; Fri, 23 Jan 2026 11:35:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769196940; x=1769801740; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PdLE4jDYZgc7is6bLs44R3LFutP/tV6g4ht/06BO8G0=; b=wJXdrvz9J6/sr4lNB/uLS0Fg/6gD4JgKrzDkxY7kuEWECsNvbLVhRcczKAXwmDK6yV dUs30Mk/YPbqcmDoQ+lAdjjBjz7xmSrDiEc9EPw2ScR5LXgvTHAT2g5kwehHINvsFBen krB/TMb7aigdvlvxdepnndArJWjoVEct6HkFlFoRSwVwkmrihqdgHn1jAMQUcTxrNqro kFurQFXG7kXhNd4w5QnnC3mstZ79p6PExq7zpw6mQ1JapzSA0av6cya+fccGaakODsfD BGKvF4JUArL107KmroZrwpjRXYWOzzs7PBLAT82+lSuPsOx4fUN2tcPgpelD7YbD5JcL KFtw== X-Forwarded-Encrypted: i=1; AJvYcCUC+PUlquAQCFfd8gQi3ofOj+dUZCAcdusZU/8Dm9hyfMFthXKTno++uv+m9Ir+DJ+OiAiDWaszRFSIv84=@vger.kernel.org X-Gm-Message-State: AOJu0YyrRf9IbHWu7Fgv26fkbSuQhzTyjqqnADYh/NuSsi7Vd38RKQ+I DzF6JBVxbkcsZBmITHrX9CSPj85ZSkUpyc+TIGCp1ZIpYn88wlmEwjrfW1ALWzXmS+2Ib4J22D7 SItz6H3rssCnN4suHao4xXtb5c6fOpZV/m05gpybHJD/Ii/zNEZ30nk3dVhHmp0QQJP9pFRcb6E uzha6O6GjTGNJ5RtJQBCAnPeHKtTGOzYxRvPqeDLvY9klahKXkMRwxz26P6+TAJoXlO/0GushVZ keqDuGu5RSrjZFg4nd+mrL+Cw== X-Gm-Gg: AZuq6aIYR/HOgy880gUysC8JRBl5Hw1MZAfG070+A+6eOEDXkkpOzkEQQhdPAn7Wrz0 IVivtcprjykfzl9OBtCScWI1OGnM3fIeT3NLfY7n2Ofh6thHXUJkPNu8LOerDfw+bquX9kMilfM x3+60tpbGIdEXCNmciJEz4iL+nckCu6mMFsFkPuuLF5+jpJHNuC9cC3orVmZJSv6ze/ZaYehlYe 5AABVCK0B1GtMwNj1S2l3QNx9nGyFxD35PjKvKtyUC0VWUXgqrz0jcvF2/SKhHZxVw8djPVw+Aq 2M2W4qhZzPvC7RCBxKWOu793p2pXAc8p9it7j0qxRUsx7i18Te27G+MUCq8DB/xX99gS81Z/VON Bobvb14nDO+5La/NRxu9JQxXdyEUuYH5LwJqao8KQ+inKCAQFsyLy7Mv+gfOPO2yB6L3RKnG22J YiWpnoGWhD3cN3f7lNP5MCNeROn+/hr2ISJUwP72q6hNu6vpjd2JmDCA== X-Received: by 2002:a05:690c:d96:b0:784:ad94:ac70 with SMTP id 00721157ae682-794398ecc3cmr34391087b3.9.1769196940028; Fri, 23 Jan 2026 11:35:40 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-100.dlp.protect.broadcom.com. [144.49.247.100]) by smtp-relay.gmail.com with ESMTPS id 00721157ae682-7943af0ebd0sm1728477b3.1.2026.01.23.11.35.39 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Jan 2026 11:35:40 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-81e81fbbb8cso2554100b3a.3 for ; Fri, 23 Jan 2026 11:35:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1769196939; x=1769801739; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PdLE4jDYZgc7is6bLs44R3LFutP/tV6g4ht/06BO8G0=; b=Y42DBoai0Kdqc/pRM6btFJou6qh553VMDaFOiw30TCsmjSAp9Jt708kVFrceAP54B4 dSl8zslAnE+cPlc8uGE3X+ejOwi0i2l5qKnmVfcIybqtb3XM0JTXDuOQKN/oYTUkGRY1 VWgjuaHdzpi18p5t8eCbQPaZOD49qAjeh11lM= X-Forwarded-Encrypted: i=1; AJvYcCVJAqkrTBKUZo0lrvaTxzdkWUyCZQh2WMbPL+7+2RbVAgzzIx1GNHqfXLdZxcz1SoUdCJLemRAqEG97MD4=@vger.kernel.org X-Received: by 2002:a05:6a00:1790:b0:81e:b2ba:5b3a with SMTP id d2e1a72fcca58-82317c13039mr3557632b3a.8.1769196938357; Fri, 23 Jan 2026 11:35:38 -0800 (PST) X-Received: by 2002:a05:6a00:1790:b0:81e:b2ba:5b3a with SMTP id d2e1a72fcca58-82317c13039mr3557611b3a.8.1769196937837; Fri, 23 Jan 2026 11:35:37 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8231873e519sm2843206b3a.49.2026.01.23.11.35.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 11:35:37 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, ajit.khaparde@broadcom.com, Bhargava Marreddy , Rahul Gupta Subject: [v6, net-next 5/8] bng_en: Add ndo_features_check support Date: Sat, 24 Jan 2026 01:05:01 +0530 Message-ID: <20260123193504.285573-6-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260123193504.285573-1-bhargava.marreddy@broadcom.com> References: <20260123193504.285573-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Implement ndo_features_check to validate hardware constraints per-packet: - Disable SG if nr_frags exceeds hardware limit. - Disable GSO if packet/fragment length exceeds supported maximum. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Ajit Kumar Khaparde Reviewed-by: Rahul Gupta --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 1 + .../net/ethernet/broadcom/bnge/bnge_txrx.c | 24 +++++++++++++++++++ .../net/ethernet/broadcom/bnge/bnge_txrx.h | 3 +++ 3 files changed, 28 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 2c1df5d48b5e..2c8f8949d500 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2420,6 +2420,7 @@ static const struct net_device_ops bnge_netdev_ops = =3D { .ndo_open =3D bnge_open, .ndo_stop =3D bnge_close, .ndo_start_xmit =3D bnge_start_xmit, + .ndo_features_check =3D bnge_features_check, }; =20 static void bnge_init_mac_addr(struct bnge_dev *bd) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c b/drivers/net/e= thernet/broadcom/bnge/bnge_txrx.c index efd08c93008a..33f39a57f12d 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c @@ -962,3 +962,27 @@ netdev_tx_t bnge_start_xmit(struct sk_buff *skb, struc= t net_device *dev) dev_core_stats_tx_dropped_inc(dev); return NETDEV_TX_OK; } + +netdev_features_t bnge_features_check(struct sk_buff *skb, + struct net_device *dev, + netdev_features_t features) +{ + u32 len; + + features =3D vlan_features_check(skb, features); +#if (MAX_SKB_FRAGS > TX_MAX_FRAGS) + if (skb_shinfo(skb)->nr_frags > TX_MAX_FRAGS) + features &=3D ~NETIF_F_SG; +#endif + + if (skb_is_gso(skb)) + len =3D bnge_get_gso_hdr_len(skb) + skb_shinfo(skb)->gso_size; + else + len =3D skb->len; + + len >>=3D 9; + if (unlikely(len >=3D ARRAY_SIZE(bnge_lhint_arr))) + features &=3D ~(NETIF_F_CSUM_MASK | NETIF_F_GSO_MASK); + + return features; +} diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.h b/drivers/net/e= thernet/broadcom/bnge/bnge_txrx.h index 81a24d8f9689..32be5eb46870 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.h @@ -119,4 +119,7 @@ irqreturn_t bnge_msix(int irq, void *dev_instance); netdev_tx_t bnge_start_xmit(struct sk_buff *skb, struct net_device *dev); void bnge_reuse_rx_data(struct bnge_rx_ring_info *rxr, u16 cons, void *dat= a); int bnge_napi_poll(struct napi_struct *napi, int budget); +netdev_features_t bnge_features_check(struct sk_buff *skb, + struct net_device *dev, + netdev_features_t features); #endif /* _BNGE_TXRX_H_ */ --=20 2.47.3