From nobody Mon Feb 9 11:30:10 2026 Received: from mail-pl1-f225.google.com (mail-pl1-f225.google.com [209.85.214.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7089296BBB for ; Fri, 23 Jan 2026 19:35:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.225 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769196935; cv=none; b=fLzq/g/gF6mR+DKAr5hAaAo103TXyzbCO+ulIP9fKclLl0WUyAuk5Vb+5GTFmLjKybhhXG2z7xFpT9l6PhdGfHHNCWPbHokapnYOiwrxyWBVN1+IG7vuOLyEo877a+NJgBWboyYX5oCp58Iz5kenrzvRplT3O4o/JRhpLw3qzE4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769196935; c=relaxed/simple; bh=NSKp7+7796MkKBcTdo3o37PF7/jU1LGtASKoU0av4kc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=adCtVj7o0jZh/SnDPb393pXKHtWiMPuwkHvNdR1PZYZs/GgGaP4apIddZTRo8SdV2Q41LEb0iijv5TuaMQnvdN7NoaKFepCKIctm/ltG8BWzEVMxRpR2zEj5chXz/yC1HzyTacu3JEEr+5dri5/ImOsjmaKwi0Aoc+X/btqa3pE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=Jq8d1aMt; arc=none smtp.client-ip=209.85.214.225 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="Jq8d1aMt" Received: by mail-pl1-f225.google.com with SMTP id d9443c01a7336-2a7a23f5915so16291825ad.2 for ; Fri, 23 Jan 2026 11:35:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769196933; x=1769801733; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xdSkCegsAvP47246YGZJCy4msn+ummvP4ChY2ZXTpKs=; b=bIgpzM+yJ4O1fh6MH3kdWDsvoS8HCSCLbYKzJ6wWgJ1XXBYR7fHF76D9ZjeM6XsMqG Vgd9QFfuFwRR7wy0DitSbEwGBgYvHUsggYFaL/sphXPG1c9RmYFtvL8WNZiE1GLV1Rb2 F9wMvCn5LtJHpLiLuI9DR4aq/f+zkz+5SvSzAxAq9fCRsursnHx0dJnZlaCqeHkzXlWm 2eGoffuCPvv7GxiXNgCwwxwPGCRREdc3N4KD1Nsipv27mwmoon0ELbQlJF8EAzQDZMB2 9wWwFjG0JwbNER0xm+Npf0xfKWWSfZRhHRRj6YcZtca6XRaNPmzIprCNi6kW/snqLDnn auWw== X-Forwarded-Encrypted: i=1; AJvYcCVZVx1uVZ39IV7R3wewghsyIM3J5IP2lcdybs6wSFfd/mYEzX/zDcQdbZKXIEHIFA3UdGbYk3z/hPZIZoU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4q9pPCMIlxFSy6m+VVU0wVU653frotWOqCJYtXXz/ZE2bP74V ehB3EOsK3BIr5q7GLCLTkX7L11+I7yo1LYMzoZ8+nTpIVVTz5KiF9O/khxEMZtoFZmkfpLEoml+ YXeIUhgJNQcXrb5KfVJ3A7cq+9GP1Jly6xWOVVKS69x9YEQyVeUX42PR5pBC7ZUJVG4WS5gZowt FR0L1RNWf2igPFBn0bhCrKG5UcLhYHW1/F6cp52QORnQ8ou5o3WOv/w3BQZ/3LAy5kBM2YsJj3P 0mbZlwpMYNnBoxs4gVKy0CLww== X-Gm-Gg: AZuq6aI29zTbPhpXBf40EsJPIzn7In6YLe20yF1gXQZ7PchkjKo9MrzhXyDBdJET2wN VZ+q22Ll/orhMG2o1+54H5NJOmcmjVgeVHe94YGIYt2255Kjev6ZUe7bVQaUMOQ4f1i4naYB7p7 ublgHW98iLZMOJL5nKaTpJ3ugHw2fk1w5u5b2ktTNgtb70FZqlyNKzvS6AZUe+e+kxhtSJzh6To r/tHS5SIsofn4enPSJigYmeXY2hUc0lNOBKi81ZPDvmXbcHJoKUVcE+j1Xkq0wFwhFaevF0f08S pP5awdFslYJzgLqPWYPZ9QRndMRHLnwR9Y0/e+2MRvuDJpUuGmeMw8WkKmO4VGHLfuGQbRwpiwT qI6koiezzVEAoSsN8O0n2nV0+Cq4fye1F8RdpYICnR2Y3s1vBS1oiUf1ZB1qTG5gn0ClrhvvPqC 2/5TMbG5FTJvrOTAWD6Nh96pQx+uvWGrIsgytFz5EH6yv5FD1WUhI= X-Received: by 2002:a17:902:ec8e:b0:2a3:6b54:5d42 with SMTP id d9443c01a7336-2a80ec82615mr22743065ad.59.1769196933148; Fri, 23 Jan 2026 11:35:33 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-77.dlp.protect.broadcom.com. [144.49.247.77]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-2a802fa5fabsm2738495ad.50.2026.01.23.11.35.32 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Jan 2026 11:35:33 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-34c64cd48a8so2640217a91.0 for ; Fri, 23 Jan 2026 11:35:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1769196930; x=1769801730; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xdSkCegsAvP47246YGZJCy4msn+ummvP4ChY2ZXTpKs=; b=Jq8d1aMtFaHzr9VJIRTM7PJrZ+RQj1k8B5+7od2JL6p6R8aqt3QvKtw5/WCrCshiYH 3WICfJBujzWqVylr9Nd01D+gIVe/q0U9Cs55XhC7XTFPJGywyym7lei8hzTsrVE8olO7 jzdvY9ANoj8j8HmP8ltyBxFObPkPJ/P1NUJ7o= X-Forwarded-Encrypted: i=1; AJvYcCXq+M59z+81PfJ0eeJVKYMSXfRM0cLGotYQmmQ2nveDQOzbGxOBbg6k7nts/3Njb3zukK30AD5KnabbKdw=@vger.kernel.org X-Received: by 2002:a17:90b:5145:b0:352:d97d:4bf5 with SMTP id 98e67ed59e1d1-3537af94d91mr1794440a91.27.1769196929556; Fri, 23 Jan 2026 11:35:29 -0800 (PST) X-Received: by 2002:a17:90b:5145:b0:352:d97d:4bf5 with SMTP id 98e67ed59e1d1-3537af94d91mr1794419a91.27.1769196929021; Fri, 23 Jan 2026 11:35:29 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8231873e519sm2843206b3a.49.2026.01.23.11.35.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 11:35:28 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, ajit.khaparde@broadcom.com, Bhargava Marreddy , Rajashekar Hudumula Subject: [v6, net-next 3/8] bng_en: Handle an HWRM completion request Date: Sat, 24 Jan 2026 01:04:59 +0530 Message-ID: <20260123193504.285573-4-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260123193504.285573-1-bhargava.marreddy@broadcom.com> References: <20260123193504.285573-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Since the HWRM completion for a sent request lands on the NQ, add functions to handle the HWRM completion event. Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rajashekar Hudumula --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 3 +- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 1 + .../net/ethernet/broadcom/bnge/bnge_txrx.c | 44 ++++++++++++++++++- 3 files changed, 45 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index aef22f77e583..594e83759802 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -2303,8 +2303,7 @@ static int bnge_open(struct net_device *dev) =20 static int bnge_shutdown_nic(struct bnge_net *bn) { - /* TODO: close_path =3D 0 until we make NAPI functional */ - bnge_hwrm_resource_free(bn, 0); + bnge_hwrm_resource_free(bn, 1); return 0; } =20 diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index 9303305733b4..4cc69b6cf30c 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -77,6 +77,7 @@ struct tx_cmp { #define CMPL_BASE_TYPE_HWRM_FWD_REQ 0x22UL #define CMPL_BASE_TYPE_HWRM_FWD_RESP 0x24UL #define CMPL_BASE_TYPE_HWRM_ASYNC_EVENT 0x2eUL + #define CMPL_BA_TY_HWRM_ASY_EVT CMPL_BASE_TYPE_HWRM_ASYNC_EVENT #define TX_CMP_FLAGS_ERROR (1 << 6) #define TX_CMP_FLAGS_PUSH (1 << 7) u32 tx_cmp_opaque; diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c b/drivers/net/e= thernet/broadcom/bnge/bnge_txrx.c index e4312fcad756..5d16adf2315b 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_txrx.c @@ -379,6 +379,43 @@ static void __bnge_poll_work_done(struct bnge_net *bn,= struct bnge_napi *bnapi, } } =20 +static void +bnge_hwrm_update_token(struct bnge_dev *bd, u16 seq_id, + enum bnge_hwrm_wait_state state) +{ + struct bnge_hwrm_wait_token *token; + + rcu_read_lock(); + hlist_for_each_entry_rcu(token, &bd->hwrm_pending_list, node) { + if (token->seq_id =3D=3D seq_id) { + WRITE_ONCE(token->state, state); + rcu_read_unlock(); + return; + } + } + rcu_read_unlock(); + dev_err(bd->dev, "Invalid hwrm seq id %d\n", seq_id); +} + +static int bnge_hwrm_handler(struct bnge_dev *bd, struct tx_cmp *txcmp) +{ + struct hwrm_cmpl *h_cmpl =3D (struct hwrm_cmpl *)txcmp; + u16 cmpl_type =3D TX_CMP_TYPE(txcmp), seq_id; + + switch (cmpl_type) { + case CMPL_BASE_TYPE_HWRM_DONE: + seq_id =3D le16_to_cpu(h_cmpl->sequence_id); + bnge_hwrm_update_token(bd, seq_id, BNGE_HWRM_COMPLETE); + break; + + case CMPL_BASE_TYPE_HWRM_ASYNC_EVENT: + default: + break; + } + + return 0; +} + static int __bnge_poll_work(struct bnge_net *bn, struct bnge_cp_ring_info = *cpr, int budget) { @@ -429,8 +466,11 @@ static int __bnge_poll_work(struct bnge_net *bn, struc= t bnge_cp_ring_info *cpr, rx_pkts++; else if (rc =3D=3D -EBUSY) /* partial completion */ break; + } else if (unlikely(cmp_type =3D=3D CMPL_BASE_TYPE_HWRM_DONE || + cmp_type =3D=3D CMPL_BASE_TYPE_HWRM_FWD_REQ || + cmp_type =3D=3D CMPL_BA_TY_HWRM_ASY_EVT)) { + bnge_hwrm_handler(bn->bd, txcmp); } - raw_cons =3D NEXT_RAW_CMP(raw_cons); =20 if (rx_pkts && rx_pkts =3D=3D budget) { @@ -548,6 +588,8 @@ int bnge_napi_poll(struct napi_struct *napi, int budget) work_done +=3D __bnge_poll_work(bn, cpr, budget - work_done); nqr->has_more_work |=3D cpr->has_more_work; + } else { + bnge_hwrm_handler(bn->bd, (struct tx_cmp *)nqcmp); } raw_cons =3D NEXT_RAW_CMP(raw_cons); } --=20 2.47.3