From nobody Mon Feb 9 11:47:26 2026 Received: from mail-oa1-f97.google.com (mail-oa1-f97.google.com [209.85.160.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8169B1D7995 for ; Fri, 23 Jan 2026 19:35:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.97 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769196925; cv=none; b=fbx4t3QfCvqYrwlRRmM+31ySxHtQRKK7OrPrFKCrtr2xecYrQ9iFkSDaYQh4an+zgyAnkOqajcAcOyWVoItnlYBNhNgF7fpjEgVhMJIWqjtz8EcP9wjriEhoOE6JN7oGdyUVmIA17C2RWsuDSKfqQjJVfH6YhNRzpyYvIPYJNCM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769196925; c=relaxed/simple; bh=G42HEdK63RMSkNcCPQGCk4X08ncSFrRURRT8K21yxRE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=vDNc8l7Dy2goXH9JjgET2x1Ut3U7vT7ZHVLtRAgP90lMyfcDGeN4VvVONmv7IIvRjuOfezETPWFmlQyEJZ4zKa+ULQOgXtMbV/b6dPr/TnyXVSVs6mSXYqdD0/l+LWMCdX8SUNgH2PRdGWZ50lfbMEI4d4GhChO7tIc9Uvi7HAU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=AML2SMEQ; arc=none smtp.client-ip=209.85.160.97 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="AML2SMEQ" Received: by mail-oa1-f97.google.com with SMTP id 586e51a60fabf-404254ffe8aso1678093fac.0 for ; Fri, 23 Jan 2026 11:35:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769196922; x=1769801722; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P5v6be/rvU1Ddm94jt+LcDTFwMP9w1kpc8KK4AcGhZ4=; b=Ti9EjbiajmOj3LhuUSNys2u8KNT35hNcCt6ko/qc+iesyZMb0LJ5T7zDls1bpt4q/X aO+xLXIQBuf3C+SAdV9NKpYytZc2tCBL6uFm0YJUL/o3Gy3PFDfaQtcqhtjP/VaatHrS nj8QIi505BCS4wo5FPEDVZlXCPBChO8QAbrTH1PBW1iPNPrvoAW4rtb+oFDOCrouxyG3 v5Q1j3vWBL4m6pSl/BUixxnF7tY1ffiYten2quNu9Gd58OSbNJNF0nP4PTH1Bs2DhDil gDbrz7xXgU+hQjIP1MVe1QKjrkAG3QhDsAkP/WXb92F3BuSsXwZW1MnYx6c19ozeLh6S UFZg== X-Forwarded-Encrypted: i=1; AJvYcCWwik78XEmHMNR1/9zW3AR31WOJuVDbgCl8AB4WFO3gRzrs0Ta19oNj8U0PxjN8rc2GgZUIYHRE42m06LU=@vger.kernel.org X-Gm-Message-State: AOJu0YyISeon4O288UbS6IVklxBi7O0kh5FX6TYLWlZEcVX5qIen0xCa qC5j3iOQ1hiE+wKMEvRQX5wqxRyQjN9UKn8SyO6tcC2ND+KXfpxWr4dyBMqnJe7Jg/fPPj5uckj SIcdZiBh+E2me1cB92XzOH4SfPUd/aZr3uasB5JZplnil3MNRvTuFL6psEJI99IUB2RFhKJdfQZ 0AJJkfIZSDVjLXcWSseP0cwKcswponKv4jh6a4iEv75FI7lPZRAoIaQBrxHipRvsXMI+Ya8KyZw Rw5iXas58x2k3J0zj7l9Gm96Q== X-Gm-Gg: AZuq6aKFRTllxROzsF85Fq0rkkMfhuGlhMYlyGPFeIUNZGNE53HXY2oK07lNYwSpovY cN5rBmR82IdwO0iMqBIIeFtPVuWHFjdsGSo8e96nL4PKZgJnKiJBN1QGQrkGbdIus3rvYuABlEZ JojD9+H9Xyi/U1rAKmNHP7oh9/JZRCd+jZkCl5bptN4I8kjTaJIF0EQw9BD6KQSi3NeXFEqThRG XP8aPGcQcXJmOBApltANg1O2egNwvsVEijrbSQIQ5lqv3pPdTM88NQ0yC46leaObtAXJTSaDeGD LT0opqpVEeAJ7jW/Xv9bmTnVToEmSoqH+qT35+RJacs9jM49U643PUdUsxsHK1Ad1YLhL/wgYAB suAsqHr/sGPiN2vlnsfiyJ+2qrXQan4ytjzHzaJWYudpOTeWGrq0bwjSAF5EGsOlsbocZsU0AU7 vOsCZTq9vvpUg3d0clblZ3QnNaJAz+TPwnazZ8iAnbWAI06G16K6mI2w== X-Received: by 2002:a05:6870:2383:b0:3e0:bd2c:f459 with SMTP id 586e51a60fabf-408ac19fb08mr2157012fac.12.1769196922178; Fri, 23 Jan 2026 11:35:22 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-100.dlp.protect.broadcom.com. [144.49.247.100]) by smtp-relay.gmail.com with ESMTPS id 586e51a60fabf-408afba0f93sm304305fac.9.2026.01.23.11.35.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Jan 2026 11:35:22 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-7fc82eff4adso2126654b3a.1 for ; Fri, 23 Jan 2026 11:35:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1769196921; x=1769801721; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P5v6be/rvU1Ddm94jt+LcDTFwMP9w1kpc8KK4AcGhZ4=; b=AML2SMEQiPnbbZz01QQX91jWy+BJISpKoQzm1CevWZ3AHQLiC3eDex/yvTtc3bAWED txOB8IEjjRlfkpPm4kWUUzOSpJK/ZzuFFOAyG99DxsGWPQbW8oggK8OOEx+Sklx0lF+R edx6Rc0DCqMz/yh1qGmBkc7ILkRWJe2VSFcnQ= X-Forwarded-Encrypted: i=1; AJvYcCXfjEuPBnQr/Aqt+auNHThVse2RLop9UU7D/XPYTmPqPBPl8wyRo2fqvZTDD3udpmZSODAIfszSb/OLIJ4=@vger.kernel.org X-Received: by 2002:a05:6a00:894:b0:81f:5acb:55fc with SMTP id d2e1a72fcca58-82317a492f7mr3396665b3a.10.1769196920700; Fri, 23 Jan 2026 11:35:20 -0800 (PST) X-Received: by 2002:a05:6a00:894:b0:81f:5acb:55fc with SMTP id d2e1a72fcca58-82317a492f7mr3396644b3a.10.1769196920158; Fri, 23 Jan 2026 11:35:20 -0800 (PST) Received: from localhost.localdomain ([192.19.203.250]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8231873e519sm2843206b3a.49.2026.01.23.11.35.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 11:35:19 -0800 (PST) From: Bhargava Marreddy To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, michael.chan@broadcom.com, pavan.chebbi@broadcom.com, vsrama-krishna.nemani@broadcom.com, vikas.gupta@broadcom.com, ajit.khaparde@broadcom.com, Bhargava Marreddy , Rajashekar Hudumula Subject: [v6, net-next 1/8] bng_en: Extend bnge_set_ring_params() for rx-copybreak Date: Sat, 24 Jan 2026 01:04:57 +0530 Message-ID: <20260123193504.285573-2-bhargava.marreddy@broadcom.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260123193504.285573-1-bhargava.marreddy@broadcom.com> References: <20260123193504.285573-1-bhargava.marreddy@broadcom.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e Content-Type: text/plain; charset="utf-8" Add rx-copybreak support in bnge_set_ring_params() Signed-off-by: Bhargava Marreddy Reviewed-by: Vikas Gupta Reviewed-by: Rajashekar Hudumula --- .../net/ethernet/broadcom/bnge/bnge_netdev.c | 19 +++++++++++++++++-- .../net/ethernet/broadcom/bnge/bnge_netdev.h | 5 +++-- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.c index 832eeb960bd2..8bd019ea55a2 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include =20 @@ -2295,7 +2296,6 @@ void bnge_set_ring_params(struct bnge_dev *bd) rx_space =3D rx_size + ALIGN(NET_SKB_PAD, 8) + SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); =20 - bn->rx_copy_thresh =3D BNGE_RX_COPY_THRESH; ring_size =3D bn->rx_ring_size; bn->rx_agg_ring_size =3D 0; bn->rx_agg_nr_pages =3D 0; @@ -2334,7 +2334,10 @@ void bnge_set_ring_params(struct bnge_dev *bd) bn->rx_agg_ring_size =3D agg_ring_size; bn->rx_agg_ring_mask =3D (bn->rx_agg_nr_pages * RX_DESC_CNT) - 1; =20 - rx_size =3D SKB_DATA_ALIGN(BNGE_RX_COPY_THRESH + NET_IP_ALIGN); + rx_size =3D max3(BNGE_DEFAULT_RX_COPYBREAK, + bn->rx_copybreak, + bn->netdev->cfg_pending->hds_thresh); + rx_size =3D SKB_DATA_ALIGN(rx_size + NET_IP_ALIGN); rx_space =3D rx_size + NET_SKB_PAD + SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); } @@ -2367,6 +2370,17 @@ void bnge_set_ring_params(struct bnge_dev *bd) bn->cp_ring_mask =3D bn->cp_bit - 1; } =20 +static void bnge_init_ring_params(struct bnge_net *bn) +{ + u32 rx_size; + + bn->rx_copybreak =3D BNGE_DEFAULT_RX_COPYBREAK; + /* Try to fit 4 chunks into a 4k page */ + rx_size =3D SZ_1K - + NET_SKB_PAD - SKB_DATA_ALIGN(sizeof(struct skb_shared_info)); + bn->netdev->cfg->hds_thresh =3D max(BNGE_DEFAULT_RX_COPYBREAK, rx_size); +} + int bnge_netdev_alloc(struct bnge_dev *bd, int max_irqs) { struct net_device *netdev; @@ -2456,6 +2470,7 @@ int bnge_netdev_alloc(struct bnge_dev *bd, int max_ir= qs) bn->rx_dir =3D DMA_FROM_DEVICE; =20 bnge_set_tpa_flags(bd); + bnge_init_ring_params(bn); bnge_set_ring_params(bd); =20 bnge_init_l2_fltr_tbl(bn); diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h b/drivers/net= /ethernet/broadcom/bnge/bnge_netdev.h index fb3b961536ba..557cca472db6 100644 --- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h +++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.h @@ -135,7 +135,8 @@ struct bnge_ring_grp_info { u16 nq_fw_ring_id; }; =20 -#define BNGE_RX_COPY_THRESH 256 +#define BNGE_DEFAULT_RX_COPYBREAK 256 +#define BNGE_MAX_RX_COPYBREAK 1024 =20 #define BNGE_HW_FEATURE_VLAN_ALL_RX \ (NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_HW_VLAN_STAG_RX) @@ -186,7 +187,7 @@ struct bnge_net { u32 rx_buf_size; u32 rx_buf_use_size; /* usable size */ u32 rx_agg_ring_size; - u32 rx_copy_thresh; + u32 rx_copybreak; u32 rx_ring_mask; u32 rx_agg_ring_mask; u16 rx_nr_pages; --=20 2.47.3