From nobody Sat Feb 7 08:44:41 2026 Received: from mail-yx1-f47.google.com (mail-yx1-f47.google.com [74.125.224.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95F9D257821 for ; Fri, 23 Jan 2026 19:12:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769195533; cv=none; b=ppL809LlTV/IWjJ5G1NXI+3D3+Rat9h/ahrys1DeztzWoI7D874yXbseXoSwDIdVypTaMwTWr309LayA5qBK3e0kYw327sdmRof2lFOiGrL/xO645LTuDSFQpZIuOWhY/q1k6FJTYVv+PhBSHv9LL7yOZ87kQNUKQcLwU+4DJh4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769195533; c=relaxed/simple; bh=J0mnRO2he91DDoQm01TRVQcaFvzHEGvtQgydeWbwku0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JHwsxQD8qsXB9B28nipzlSlEBOia4hMINvdrEeKtNlgzAWRm+ar7c/nVj9yAmOZWtlyKBF0X8AJHYAqzRhHhLn/dDys4dtQLKZHry7Kp6UHkG/j8KaQID+F6agb/vAJI8uFPAQXWGTJLNYrEXYvYAadFwAcO749ebd5id37k12M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=M2R7zTzT; arc=none smtp.client-ip=74.125.224.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M2R7zTzT" Received: by mail-yx1-f47.google.com with SMTP id 956f58d0204a3-6494a3d92f5so2895753d50.2 for ; Fri, 23 Jan 2026 11:12:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769195532; x=1769800332; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=vM8RN8nWA2PYNxkbOoDg7XRLtaAPbNgr57UqjED6wwA=; b=M2R7zTzTnV4rW6Z3BUrxCvUOLxPZGpr5EgK6gMHZXS8NNsc+xukiHbQ4NWQ/tQ97v+ 1ZcXEk3D4kLI/n3hD9C+yL+je5k1J19etW+dj6gPadTHP/k0Xq1zB76Wo+gm+Ib+Bm7g HTRNeeObvZssgXT4apPfWPD5kZZj1SIo/N0LtPhVju1Ozl26cNmITmtsLYJjW7uAWK0s I0KOqDELm1IXu1/+Zi+y2Aaf7QVoBnSEVQOfxTlsodKSFxMZGVWk3Nbx7DhGIZYHQfB9 ZC5LRFT4d4GptR2eKGe4MvVClScMkw7T1JXEfWDvkWMVOR1NqSFFGEFt0seM1vK5Ip3c LLzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769195532; x=1769800332; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=vM8RN8nWA2PYNxkbOoDg7XRLtaAPbNgr57UqjED6wwA=; b=GpAD/kbItf7htAAGqvecxTbI6KuImN1po/r1m/0XCbYDoK+83D6rabfgNJ9YiW6ZC8 LosThm6oivq0wYdiNkx8leUaAleUo2v9E3FhAzwN+TkYIHXeMBOag6uApd8hCzxM48F/ K8A4JAM9vCQaW6kjeYVmAkifoLigXwtf3iCMlIB/xkcxGA1dEtwsLwlwhMC7jVNKI6E9 86kIc4G87r/kEx9yXz0nnwUX7zH9aydGW9i8uKUF+9ID3E0BzuuExaKhk/1okDqC4cXf /dK4u1kx7kiN/YDfNBh5qbl/igP6vboF9mv5HKv61SZWM6JjL5Y1rBttiTQEbVYGkEyI KJEw== X-Forwarded-Encrypted: i=1; AJvYcCU4pCh/gAzBfOkbIikFSXD0PFREDKrkJ+puhug/VLaz00TEOY+J2ItTdJfO/mxfhzz1FWBYjobNHKzIlDU=@vger.kernel.org X-Gm-Message-State: AOJu0Yzd2YXnquGtAkcSH3HqNitYfHoRTioo4kAWn4bl1aELmX8TmyiL IDwoXt/Zb/Ip3XxiDsQy4QuSz3e9U1/k7FCL6UPC/KYeiwmfkY8A9IG3 X-Gm-Gg: AZuq6aJMKj5DHXibjECvLFY8pDLgBZZ0UYwhHwkEY2z3TgVbbIQYOs7KkT4miZHi1Ca Vd5+zQZqGPoJcZNvnDC3ScIt/blz9n6PMfzLvdZmrGkf4Fyz8qBuEQ8VFF4xb732o+81aZhjGpL 5CoJrAeantoFsIVj7VIvfLGXYpxm7kbPj87EGlO9hOWWsOrV13gKipliXjTv0q4Vk3gWCWbdLMO 8ilEhLUV9BRZtedW0ph7rmRG3l8x+rwQa+nioZDFD0hyh3Cj6UyNyL1JDsGHYzbhthwrXNumZXm lsa14E6qvspaAUS1FTBMZXVVIyC7lMv315IRkAI+iq5+934wD6OKtY1TkA8NCdHIKjA1mfpIdqC tBGslcBYK+EXRAB+vuhgcsY6nsIwmZuFBvxotI4zgTo3du9R+0YYWtZhjLAF3j4QX0BE= X-Received: by 2002:a05:690e:1441:b0:646:7da0:3aa7 with SMTP id 956f58d0204a3-6495bf9baa3mr3154300d50.48.1769195531607; Fri, 23 Jan 2026 11:12:11 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::89f2]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6495cf9e597sm1557082d50.14.2026.01.23.11.12.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 11:12:11 -0800 (PST) From: Ethan Tidmore To: dan.carpenter@linaro.org, parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v2] staging: most: dim2: replace macro with static function Date: Fri, 23 Jan 2026 13:11:50 -0600 Message-ID: <20260123191150.3281-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace unsafe macro with function to avoid side effects. Signed-off-by: Ethan Tidmore Reviewed-by: Dan Carpenter --- Changes in v2: - Removed 'inline' keyword. - Fix indentation alignment in return statement. drivers/staging/most/dim2/dim2.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index dad2abe6c0c9..80af965356d0 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -113,10 +113,12 @@ static inline struct dim2_hdm *iface_to_hdm(struct mo= st_interface *iface) return container_of(iface, struct dim2_hdm, most_iface); } =20 -/* Macro to identify a network status message */ -#define PACKET_IS_NET_INFO(p) \ - (((p)[1] =3D=3D 0x18) && ((p)[2] =3D=3D 0x05) && ((p)[3] =3D=3D 0x0C) && \ - ((p)[13] =3D=3D 0x3C) && ((p)[14] =3D=3D 0x00) && ((p)[15] =3D=3D 0x0A)) +/* Identify a network status message */ +static bool packet_is_net_info(const u8 *p) +{ + return p[1] =3D=3D 0x18 && p[2] =3D=3D 0x05 && p[3] =3D=3D 0x0C && + p[13] =3D=3D 0x3C && p[14] =3D=3D 0x00 && p[15] =3D=3D 0x0A; +} =20 static ssize_t state_show(struct device *dev, struct device_attribute *att= r, char *buf) @@ -304,7 +306,7 @@ static void service_done_flag(struct dim2_hdm *dev, int= ch_idx) =20 if (hdm_ch->data_type =3D=3D MOST_CH_ASYNC && hdm_ch->direction =3D=3D MOST_CH_RX && - PACKET_IS_NET_INFO(data)) { + packet_is_net_info(data)) { retrieve_netinfo(dev, mbo); =20 spin_lock_irqsave(&dim_lock, flags); --=20 2.52.0