From nobody Mon Feb 9 15:11:48 2026 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A4B833E7 for ; Fri, 23 Jan 2026 19:01:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769194901; cv=none; b=PXzm9JC1osmhfL8D/QpsmtT/Ld6XPGHbGx13Fsa+Oy0y5/vSj/ILK2XLp4QCGSHoN5VLFVcep7qkUgGPRNu2WCQaaQdCa/yK9lrWkaHWM4zqkJxF5uLaaWuWt4vshmx1z2A08+zd1rPnb5j/mTeyHI/KZ+yNC8x/52AQrvLIvjk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769194901; c=relaxed/simple; bh=HcuYJzYDbMRQQHpnpftplVjtYmx59BL//21Y1i5NVTY=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=DOJsBvzzmslCJB/tA/XVMkcnQmuSYm18zN2sLUkx2vJhMiIY1iJP76XU6jo9YRYBVSUi25OCWClY7d581QyiInbasjmAz175KUolkrenqgpemMG+MGEnJSys1xRX9/EpuevbB3HXuxqu5a6c7SC3ZxszLzEqAS7by2NDCAEGC0I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=u.northwestern.edu; spf=pass smtp.mailfrom=u.northwestern.edu; dkim=pass (2048-bit key) header.d=u-northwestern-edu.20230601.gappssmtp.com header.i=@u-northwestern-edu.20230601.gappssmtp.com header.b=FudcMD8x; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=u.northwestern.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=u.northwestern.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=u-northwestern-edu.20230601.gappssmtp.com header.i=@u-northwestern-edu.20230601.gappssmtp.com header.b="FudcMD8x" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-7cfcebf1725so1783936a34.1 for ; Fri, 23 Jan 2026 11:01:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=u-northwestern-edu.20230601.gappssmtp.com; s=20230601; t=1769194898; x=1769799698; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=O8jrwxUFlBk+DWwXkcJaf7D36FV83NCzp5j9poXFdLA=; b=FudcMD8xCpRA7yxwktzW2FeYdfiW6+AmYRgtGCFj4I15Ih996PVdngxS1A9JdXkj5a t1YOvf2ykW345kqun3JagGgbI1J4RMx1P9xgdwwqwV51s+BfJns6kFRzqRIlC5jEkaxS 8udepzdYuSVzOXchpp05jkdstmQWYebHYUK+AEiVIjpJxj3NgRg1fWUGPUGiggjfVmT5 0ZfLnyKNTi0FWbWZq0jLe3Kq9Dt8DaVH7oWQJxZ2FSPHGq5CLe/ShIBttVy3ioIL6eBn JXBScob1/VsHrTQsq9YPffPIzLxGwScAes7ytA1kjlGPlZ38cbE1pom9or7oEPRSA8eR UkEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769194898; x=1769799698; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=O8jrwxUFlBk+DWwXkcJaf7D36FV83NCzp5j9poXFdLA=; b=MtdzMFL+xAraKXdbwAporbkZeC/zcwykvrM7YnzvMURTveqlzD7WKKs7QFlir6C18g RTtUDqTKfabnH2+ARW6kyk+/jF4SSU2sqNe1Avy8WHUSueUxbJ9M042XN90HzF+IsLUb Elr4y/sdH1e1sw1W74E1KdL826RGSq+5KckjvlX3NWaUvMeOepVc37LbXBouH4ydYkdK ou4D/8AtePxZSjOhpCm37kV9ZSy+Mu1QzG6YEMZJNxkX66UriePwTdavv7tDARq92ZiV 5ewreacyPfcaPowIvD8XMLL0sjjywzp11AsM2WgY94iwPJQZmPxsMzJKpG+Pz2zP1B0h 2WNQ== X-Forwarded-Encrypted: i=1; AJvYcCUbJeVkkM4fbOjSD8esfGD8e1Ghmyosty0rBNvr90PrmF06PXNK8S8GpHvL4XBR8ws5NZjKnSCE05QGNI8=@vger.kernel.org X-Gm-Message-State: AOJu0YyFuI4w0buWaBS1VqHR/WwC0PZr4lor+ft42T5kV3CJRPZgvJjq ZI1Drxq32IyOsOM+RxXFyYfn5h0L+rQoXrushKuSoAZjc8IS5v7pQpTcIuDGfhUQPHU= X-Gm-Gg: AZuq6aL49KL+Je8xHuXGmlFlaxl+C97LnWLCkhW+Ij2pmPxv1J6PEH9/jDn7O9lR8m4 fng1VUqTzlHpwOufuoEDE6h9SzQf8pGTzvZMv6SsQnJCoT6Tgij2N4NDNQ1PyYia1q/CESxZSKz Cyc4s80UygdrOiEoZbzkIItyKu+UlWmFXLjVWvqK2mJFk95lSdH2Xjeuc5VdtYeO85wRfLXnug+ FUyzPtlCVJ73cddbqEC7kDHFMzQsFMpm0FWndta38YsBqtE1PZaBtCo19cfbkiKkxvZX/qw95s0 r12dpkIkVoWzeuQZXdvQt/5SdlgjHX6jzN6/7D7hCoVMZVpy9T8BeFeSDAXhWOJztj0Jvpijjac 9W0F8xlxV9Nti+UkYY70ShWuRJAG75GzGMrlLHg0dr/hUjypqh2t5Qs4fySZvFhoIWTGC7lg872 MgHe0rkYc/JwumCCjkXrT2ndAwj+ksoxbJpKzMYPS5HPVN+4kDhujLalTUykf5Q+5RTpz6oYuIb 6/Ml0D2X4ioi5sI2MDtni99UQjEM5w= X-Received: by 2002:a05:6830:3115:b0:7cf:e32f:de72 with SMTP id 46e09a7af769-7d15a5c156bmr2513217a34.6.1769194898222; Fri, 23 Jan 2026 11:01:38 -0800 (PST) Received: from security.cs.northwestern.edu (security.cs.northwestern.edu. [165.124.184.136]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d15b3c01b5sm2327876a34.14.2026.01.23.11.01.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 11:01:37 -0800 (PST) From: Ziyi Guo To: Kalle Valo Cc: Jeff Johnson , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Ziyi Guo Subject: [PATCH] wifi: wil6210: add missing mutex protection in WMI event handlers Date: Fri, 23 Jan 2026 19:01:32 +0000 Message-Id: <20260123190132.1060514-1-n7l8m4@u.northwestern.edu> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" wmi_evt_auth_status() and wmi_evt_reassoc_status() call wil6210_disconnect in their error paths without holding wil->mutex. This eventually leads to wil_ring_fini_tx() and wil_ring_free_edma() being called, both of which require the mutex to be held as indicated by lockdep_assert_held(). Other callers of wil6210_disconnect() (wil_cfg80211_del_station, wil_vif_remove, wil_reset) properly acquire the mutex before calling. Add mutex_lock()/mutex_unlock() around the wil6210_disconnect() calls in the WMI event handlers to fix the missing lock protection. Signed-off-by: Ziyi Guo --- drivers/net/wireless/ath/wil6210/wmi.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/ath/wil6210/wmi.c b/drivers/net/wireless/= ath/wil6210/wmi.c index 6d376f85fbde..2bd09a225ad0 100644 --- a/drivers/net/wireless/ath/wil6210/wmi.c +++ b/drivers/net/wireless/ath/wil6210/wmi.c @@ -1703,7 +1703,9 @@ wmi_evt_auth_status(struct wil6210_vif *vif, int id, = void *d, int len) return; =20 fail: + mutex_lock(&wil->mutex); wil6210_disconnect(vif, NULL, WLAN_REASON_PREV_AUTH_NOT_VALID); + mutex_unlock(&wil->mutex); } =20 static void @@ -1832,7 +1834,9 @@ wmi_evt_reassoc_status(struct wil6210_vif *vif, int i= d, void *d, int len) return; =20 fail: + mutex_lock(&wil->mutex); wil6210_disconnect(vif, NULL, WLAN_REASON_PREV_AUTH_NOT_VALID); + mutex_unlock(&wil->mutex); } =20 static void --=20 2.34.1