From nobody Sat Feb 7 07:43:59 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C674D285050 for ; Fri, 23 Jan 2026 18:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769192538; cv=none; b=FNrs77GcI/G6xRUjWLPwYHCdYqdUPixV0lK7WIqrVBYtJhDmNzKNNEvwHevbXdUVC+XpeRTiOOs7EAbd+QUDrywqiu+LedPiOHvwiVEWCBAEuyKzhTYrmdBwZmHHbwXzmaJx0ESiUXcNs6AYDHVnhBkgXmVbxENi/pozOsMbmMg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769192538; c=relaxed/simple; bh=vKtkU7K3RqQCKIfjSH/DNJHpr6zN6ZGQr3Ky4UrXBdQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bP5DXNF8PyE5w0Fx6Wtu92lk3drRZt8nJGrTLEe12KSBOKRdRuPuC13q0+VJOAC39As3HWi6CqCzfuTkL82v0N7nkSEcbemb1r2T+lmNtZVFJXp2J7p4R5wPqL+Q2InL2nQlMyn8hqB0hMZ4bZlLm9pl6v0BzW33sBMEgAX56g4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FRgL6++q; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FRgL6++q" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-823081bb15fso1316698b3a.3 for ; Fri, 23 Jan 2026 10:22:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769192536; x=1769797336; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=P7PAn6tvHTwmV1TdQFHJFHPiY8QmPdWd/ER1+pyJrOM=; b=FRgL6++qa09KXXcxBLTTqE6V/ZVmsZe3IUjrEO9BrwE/i/bsKc8Yhzrm2n8C9C639G Oi+a/0RLHzlIeE2/1MgkGrfn6WgPDBLlTW/mP0cvsz1OJPhp/aTRhYFxPUz0mvaK3U3h NBGZ/NTJ361FK5Li73zRzWxAkdgnhAGqd3ek1vfuApXXZ9sGMcO3bEQ1yFmX/gDHGUID utdVIJjxoO3jg4tZipw3+Q1HvH03EJ2cPcZTo9pviGyyM1PBWEv3FKCBWg2hJuFIrD18 UiX2y51T7AwnzMaUDxKyvp+K7FhCK6sHgR7iGRzAvbDezA4v285S3zhxmxap2CYP9Bnp arJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769192536; x=1769797336; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P7PAn6tvHTwmV1TdQFHJFHPiY8QmPdWd/ER1+pyJrOM=; b=fmIkOSsjxlfpp6T/HdYfTD4xYzrs9W5x8UOuokMDOLHWDhw298nUpxgacJ6qE3HKXW k2y4LooZM3e0p1zSElUnddAwpwb5bVyzlJUdz4JWPG/JUVPL6lU0/L35QhocdxGgzyu8 vWlXMOT72VwFAzM+y2tqf4WpsOjbDhSNJ3c34RzKivMulwXY96LdsOQIE572Wu3mtwqR MiploaeNMvW3g930t2upM5ANB4p0r9i9a55zvenkhpPXdRiLy1/lFcsgblq3I2+lgx0D jlSd7GOXa53ZcsDgEi76Gw7JDhrmP/KwIchtbm8z9TDrsLzz1Y/7c+rDXdC8FnhkD3i0 jqzQ== X-Forwarded-Encrypted: i=1; AJvYcCXmAos+LKuXhBj6VCRacvzBzG8Q8K5VbUeToEKK7PHEx3OZxMGh0Sz3C0FUTEe7/lTtTfOenEnq1aq2qrI=@vger.kernel.org X-Gm-Message-State: AOJu0YykEl8ViLUeo+Ceat4YB/oos7R3EtezjptUBkdsCrE+RiS848qt GvpnYE6Y2smwAn5X+jtGyIWrU9G5p7YYWHddZlK4MJ6m/p2+aA8ruCil X-Gm-Gg: AZuq6aIQ6Dv/aQvvcUV5J0kqWqTUR74CdyfMziLaODd2jrIFWT8Dc5U7RPV5QPSvUre QXEHptou5CDAQNk+BDODy0Fc3npCK/WkJbbBy1+asqXlplaUK6uSArpfWccUPkTOTan+d8kTkGc lDNR+4gshvcfRW6kD45wfsy8+vJ//BjnSDyigG05+MO5WNjzc4P95OxBPcgG/ouG0a856UHTKLh ETYFUJhtx5MfWqOZw0Zmr4rEv6ZCzOZTK+gsEPYaPShBe28gLQuQZkBOYLJpSmPjDL8bY9MtlrL 1H/KM4TUOM/V0ZTN6/+YG5WCEMuRw5jlG7kWZRzVqCRg+CDLV+YS4aBoMQJAtwA+g9/8GwI0DH5 oMTcm8KErJ784jXG+jc1IGrFJl2l6G4b28+FHzk5T4qMd/QpdsbhNLq0hfxylFLEwQipWfhdPNn hy4zu17EpAoSk5DcJtJdNVCnun X-Received: by 2002:a05:6a00:2b88:b0:823:1094:2458 with SMTP id d2e1a72fcca58-82317ad74ecmr2979756b3a.0.1769192536111; Fri, 23 Jan 2026 10:22:16 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82318771569sm2817157b3a.63.2026.01.23.10.22.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 10:22:15 -0800 (PST) Sender: Guenter Roeck From: Guenter Roeck To: linux-hwmon@vger.kernel.org Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Jaroslav Pulchart , "Rafael J . Wysocki" , lihuisong , Guenter Roeck Subject: [PATCH RFT 1/5] hwmon: Handle attribute visibility evaluation in device core Date: Fri, 23 Jan 2026 10:22:04 -0800 Message-ID: <20260123182208.2229670-2-linux@roeck-us.net> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20260123182208.2229670-1-linux@roeck-us.net> References: <20260123182208.2229670-1-linux@roeck-us.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In preparation for supporting sysfs attribute updates, move attribute visibility evaluation into device core. Signed-off-by: Guenter Roeck --- drivers/hwmon/hwmon.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c index 0b4bdcd33c7b..9e9ad42b6d7d 100644 --- a/drivers/hwmon/hwmon.c +++ b/drivers/hwmon/hwmon.c @@ -523,10 +523,12 @@ static struct attribute *hwmon_genattr(const void *dr= vdata, const char *name; bool is_string =3D is_string_attr(type, attr); =20 + /* + * Basic mode sanity check. This is less than perfect since + * attribute visibility and with it the mode can change during + * runtime, but it is the best we can do. + */ mode =3D hwmon_is_visible(ops, drvdata, type, attr, index); - if (!mode) - return ERR_PTR(-ENOENT); - if ((mode & 0444) && ((is_string && !ops->read_string) || (!is_string && !ops->read))) return ERR_PTR(-EINVAL); @@ -557,7 +559,7 @@ static struct attribute *hwmon_genattr(const void *drvd= ata, a =3D &dattr->attr; sysfs_attr_init(a); a->name =3D name; - a->mode =3D mode; + a->mode =3D ops->write ? 0644 : 0444; /* updated when attributes are gene= rated */ =20 return a; } @@ -896,6 +898,17 @@ __hwmon_create_attrs(const void *drvdata, const struct= hwmon_chip_info *chip) return attrs; } =20 +static umode_t hwmon_kobj_is_visible(struct kobject *kobj, struct attribut= e *attr, int n) +{ + struct device_attribute *dattr =3D to_dev_attr(attr); + struct hwmon_device_attribute *hattr =3D to_hwmon_attr(dattr); + struct device *dev =3D kobj_to_dev(kobj); + void *drvdata =3D dev_get_drvdata(dev); + + return hwmon_is_visible(hattr->ops, drvdata, hattr->type, hattr->attr, + hattr->index); +} + static struct device * __hwmon_device_register(struct device *dev, const char *name, void *drvdat= a, const struct hwmon_chip_info *chip, @@ -946,6 +959,7 @@ __hwmon_device_register(struct device *dev, const char = *name, void *drvdata, } =20 hwdev->group.attrs =3D attrs; + hwdev->group.is_visible =3D hwmon_kobj_is_visible; ngroups =3D 0; hwdev->groups[ngroups++] =3D &hwdev->group; =20 --=20 2.45.2