From nobody Sat Feb 7 10:07:57 2026 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE00030DD3B for ; Fri, 23 Jan 2026 16:22:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769185368; cv=none; b=a3bol02cDQxnWjsfECVBXvl7bRMXvu6VMY8GKIso6sy2CUO6ql6p3jO98h0RS9nBXWgTebSpWgl7JCV5UGGjOGTv7H03tZks+xKg+QQSQTfO8R2AW8jO+7Dw/gOYHA0GdeNvrqJsmkXGo8pYny15LAF3ExPtdWtbqKmpZXGKwB8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769185368; c=relaxed/simple; bh=Z8hEHgPPNhf/7h6ZdU08r+TLRxflZ2AGPEEFQtRD3U0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rSqt8bso48XNEx8IEdkh0nNAx1zngSSXp8vvYLGO0K3gxkWbSy7ZJK1CmVdfCqVzrD9t7H8QtvRG6DgEVxdHrxB+3+GC1CwpTVJZelDUIjlBvTDJiz4nAe+K1L0f+jce7GWrLpCoECA2/ax5G9eFH2BtWpL4MeWFpe2J0s3eNfw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zdr6483s; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zdr6483s" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-34c868b197eso2261699a91.2 for ; Fri, 23 Jan 2026 08:22:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769185367; x=1769790167; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OOf3NxBk19JWjxojhs/EHSzPKHmhtF1Po6inLk8Bjqs=; b=Zdr6483sDgfen89EKPyPzUpHwcu9IQMyyZkzPa26ltEuCLXl4F0aBZ7exmVYiCu7t/ 6vTEPn9VEFZvkeg/3Gadbam2vilnTpttIhdPaaF0T6+HStTYt+tY3l6E9PXFNq7jwatE BHnvybwoxV99fIvW0c+IotByXGuUu36Tqk4PyMbQOKqLXIWeO2n3N3+9jQYmtWqGR2Uq ZHb+SVRvtFDXbpfL1M0Y8ww2PBwX5JQrWtV4E89khJq7qn6ZBOTUx8gLqHZM3qJcF9bb 3hhD0rgv96Y2T6lHmb2dbmbx3WykpUB3XraktGpqUEqQx2PkwtacgESww4mlYDDcFV98 6uyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769185367; x=1769790167; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OOf3NxBk19JWjxojhs/EHSzPKHmhtF1Po6inLk8Bjqs=; b=UB0rRtP4YI6Id1vaDHw6vKME8ndwN4S0xTKJ7N9SHzEXNLMOnCaGUtB47kqXmZ+CFr oU4AGLsvp2QwX+cefXXukbSasqUhjn4NW9Iw4y0WMrAYaO6i6cqwF9xTl2d/MOI2K/6o Tt78klBhvH1e71IvHsHBmayupC+J+7WXR+iV2VJay6waT3POty7+HEBwlS+h+sRxSnHP QCd7k5Cb8flQz6YO7r6j/oawRLggZ7Pv5rOoRbEY9LdVCJvUFIFwyGtepkef+vRTb4WQ vePa0Jn7Swr/WZaKYOiCRb+NNRq3xWZrLL9v3xXdMySUBudWyADBd5cHoR+4GDnnkeDr Z6pQ== X-Forwarded-Encrypted: i=1; AJvYcCUixnifoQGNTjXBefW2UesFirN1uWogodE9+ueiBz2z/fUkkreJvyGWZpEfqdSVeM5JeYLS9SrHnFktbL0=@vger.kernel.org X-Gm-Message-State: AOJu0YxaMUdNIdKFJTm6gZtWLqBzA6lFGIxdTLhFnkkJydfscLEBzPjx eYCKOz9nXXJ8pyCi2aS/KUgk70hDreEH1fa6J7q45fPkeZgUUVbqJdNpjb5hxA== X-Gm-Gg: AZuq6aLpqTYiXkdt7c2BF8Uk9SMFa/z1LCjShrdAmPfXQrzyyiqMEYSawqouLANFzBo +i80JYy0g1Z8T0bzkEADb0L5fTh0cG/1alAtFo7GgDjyyHYXicqnx5Ua5599Pa2R9NknGAr4R7K 9B+hexSopIiCaeuGpKrMPDoQl/VBYKeaU6sw/sBWuqk/kYlgxlH5a+dUpZbKkHHmQ/Em2COiiYe 9UN9QcZbw8VBGvtbxikW06PMRGgPGJWNPI47qGZawqPRHKwKy4gh3w0sokO8vFYl4/mIcxq1Nq1 He+wS/3s9WyyFl4KO8qBHINhtzkZ0CVTdHnmo2vIZ5uLd3PnkAK2JKtu4eNjezy/n9HZbJtzWR+ NOVG0pGP0SMR+MglfXrrx6FXpbjQsybXe1wIG4NtK/yeVO6wmdVLWDfridBlvIsBo+9RgSNAbNC 3NbjbkffqK4gFhYKeXEzSFvhPcZ6Req9gu8d9Enm6eK5bEwYOBdpotYsJ9y2b+S7+O X-Received: by 2002:a17:90b:4b0d:b0:353:3934:1449 with SMTP id 98e67ed59e1d1-35367031e8cmr3216513a91.12.1769185366646; Fri, 23 Jan 2026 08:22:46 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3536dc50882sm2496967a91.16.2026.01.23.08.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 08:22:46 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Kuniyuki Iwashima , Guillaume Nault , Breno Leitao , Stanislav Fomichev , linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 6/7] mpls: Fix load tearing with u64_stats Date: Sat, 24 Jan 2026 00:21:38 +0800 Message-ID: <20260123162159.2877941-7-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260123162159.2877941-1-mmyangfl@gmail.com> References: <20260123162159.2877941-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On 64bit arches, struct u64_stats_sync is empty and provides no help against load/store tearing. struct copying should not be considered tear-free. Use u64_stats_reads() instead. Signed-off-by: David Yang --- net/mpls/af_mpls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mpls/af_mpls.c b/net/mpls/af_mpls.c index 580aac112dd2..bd2e02b89d09 100644 --- a/net/mpls/af_mpls.c +++ b/net/mpls/af_mpls.c @@ -1097,7 +1097,7 @@ static void mpls_get_stats(struct mpls_dev *mdev, p =3D per_cpu_ptr(mdev->stats, i); do { start =3D u64_stats_fetch_begin(&p->syncp); - local =3D p->stats; + u64_stats_reads(&local, &p->stats, sizeof(local)); } while (u64_stats_fetch_retry(&p->syncp, start)); =20 stats->rx_packets +=3D local.rx_packets; --=20 2.51.0