From nobody Sat Feb 7 16:00:07 2026 Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5610E31961A for ; Fri, 23 Jan 2026 16:22:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769185365; cv=none; b=KDkSsvPZ6HY4K+KlFphZa9IpGvR4ttIlsDFJ/eFym8JH/zr/OheXWnfo3guWZPocP2aei9wpMDZFF0T3u7/AMeYlviYL+Ll4pXCE8oq472U+OJloIrx0MXsn7KdVDpl0mCjkcS14j/Dccbv+Pp0Vi5kZt5UArFndYGXasx+GTcI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769185365; c=relaxed/simple; bh=uC8RnDXJEyolwirjZwS1oaycN7CLJsgzdDtpCMvAGEU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=W2ZxaphDyT88ShkNX1UMpXFW7ZMbV9Ervdr+U/bloFzD8Q/fwr2MNuPY5zz+2ulxYdoC1GOSBC6yAWPehfPfmid93mEfiNYGdlGKA2/1v3JjRlwU0KM3B+zZph2jiN/eiPtgXcy354GRfEN0GJ4dRDfWliOo3+bGbJNUppSSWl8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BXVB4cKV; arc=none smtp.client-ip=209.85.215.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BXVB4cKV" Received: by mail-pg1-f169.google.com with SMTP id 41be03b00d2f7-b6ce6d1d3dcso927068a12.3 for ; Fri, 23 Jan 2026 08:22:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769185363; x=1769790163; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jUm4PVJC35ODo4dBXeaCbuPGZ0/bE+N+0wlaMBGWiTc=; b=BXVB4cKVPVYymn7LqqwLhIF9Z/wP9uczM17Dgq+w9gzcHvAMP99E36R4n9iOCjN6C6 N9nbKTvEXjn5lYFtewBA148o1m3SKP4M/ZymUWiL67fk3yahX+Xv8FmvEH/oCt16LqV0 uBkmOeaDVun0Z+swzk6MFxKknv6bYM8sOCS0gQ6NFljewd0ks46/R7NP8R08IbFXlZxB S7iijDD/zbjEpGms70jDyv253AaHABH+3UphrKCyHJJdyP6bpun9b+tO4Gc+/F3mhUkf c+BQRT3JPePV2XGN7SEqL1OYNbqoXKyanyAjYlX9J32DEFL4P0/AW3mKcmcav1pz+IrI ELow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769185363; x=1769790163; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=jUm4PVJC35ODo4dBXeaCbuPGZ0/bE+N+0wlaMBGWiTc=; b=eNmBfeOISLmc63iD/Tsknhws1af/FKZN5yR1Aux+L45ILd6WOQHr4XHNhNWF0XSy83 EDsq4te/CcU/GmvkI4QwaDnXolu+3hhAgFR5/6rZ/C33x8MNcLVJCdpmoEABY1Ukq2Ga b9UXih8BStOcfA9dac31lKCOl3kUZDtODYE5D1QFdiWINVreUqdYUaWkz3SMedZFZSA3 vHR5aFUgQISbiEsYUdZm2ZMm3Vk6Iqns2yuWH0zmtP9rxDfrNFQxlYrX22RYWo5Sj8oF NJd1jon7GT7lCTNhevA8aFSKS3v7y6YKAdcUmgfbWdWUskc2jcyiiDkW0acverPc8C9b SHng== X-Forwarded-Encrypted: i=1; AJvYcCVhW3Xc3XJ0BZV8Uy0qugbba+WFpG61fxKtHLo5aJvinBXPShEO83unO6cLfNtswHiQcJPMmtCRsNo0Xcw=@vger.kernel.org X-Gm-Message-State: AOJu0YyvF087by1lxcuXNsIxPy+s2PFyN2k1NxthqHTf8iTW/Dt5o1AZ 6lK7czm9Atb/MWiRC/QxqzurDbmCw7W9rXINAunWtWHXOVkbWqnSBV4P X-Gm-Gg: AZuq6aJVPTt7cOKwTl46eYBWMWkP5zJFSiMtdEpqSRa5cENpa4au9Gsc+XoEVreMf4e fxlaz6Ah0gp7fVP8c2yW1ErLZ6H0FgpNSPNexDxkHcgIs//JoPs2kJPAOxgoeXpMiTcFjiXnKdF CJDjZ7mCnBuQ0Pd7Yka5cIo7LHmqmkEUvPIT8SA5IvNlKxZwwm4mNf5Cg9sTFDGpKZHybWt+f8j TRUwF5UzUUzXLy63y574l9qW1oPxyyJRfxZvnuqxTAbpThAH7sG9KEz4HNR/DoBGQWyO1/Iwgux rWhzEBShoGFqediLG/JaFLnypHdcBCA21SQt0v0fefPdMtR4QfcFtJ9kxHLpEpUIb7r9MgI2ljL WxvPlf8YRt6JsE5okoViMUZVaeHWXcpisyNs8TIUKpPAd0L7TUut/+EVVmUrD2utDZZd0bwnAIM Osk59xF/odtp9KP5SNpi/oydTTEXmeHp6cYsxHIRki1zOE0NXMECeROg== X-Received: by 2002:a17:90b:5690:b0:340:ec6f:5ac5 with SMTP id 98e67ed59e1d1-35366feb391mr2267086a91.2.1769185362417; Fri, 23 Jan 2026 08:22:42 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3536dc50882sm2496967a91.16.2026.01.23.08.22.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 08:22:42 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Sabrina Dubroca , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 5/7] macsec: fix memcpy with u64_stats Date: Sat, 24 Jan 2026 00:21:37 +0800 Message-ID: <20260123162159.2877941-6-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260123162159.2877941-1-mmyangfl@gmail.com> References: <20260123162159.2877941-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On 64bit arches, struct u64_stats_sync is empty and provides no help against load/store tearing. memcpy() should not be considered tear-free. Use u64_stats_reads() instead. Signed-off-by: David Yang --- drivers/net/macsec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c index 5200fd5a10e5..533a64713ea7 100644 --- a/drivers/net/macsec.c +++ b/drivers/net/macsec.c @@ -2806,7 +2806,7 @@ static void get_rx_sc_stats(struct net_device *dev, stats =3D per_cpu_ptr(rx_sc->stats, cpu); do { start =3D u64_stats_fetch_begin(&stats->syncp); - memcpy(&tmp, &stats->stats, sizeof(tmp)); + u64_stats_reads(&tmp, &stats->stats, sizeof(tmp)); } while (u64_stats_fetch_retry(&stats->syncp, start)); =20 sum->InOctetsValidated +=3D tmp.InOctetsValidated; @@ -2887,7 +2887,7 @@ static void get_tx_sc_stats(struct net_device *dev, stats =3D per_cpu_ptr(macsec_priv(dev)->secy.tx_sc.stats, cpu); do { start =3D u64_stats_fetch_begin(&stats->syncp); - memcpy(&tmp, &stats->stats, sizeof(tmp)); + u64_stats_reads(&tmp, &stats->stats, sizeof(tmp)); } while (u64_stats_fetch_retry(&stats->syncp, start)); =20 sum->OutPktsProtected +=3D tmp.OutPktsProtected; @@ -2943,7 +2943,7 @@ static void get_secy_stats(struct net_device *dev, st= ruct macsec_dev_stats *sum) stats =3D per_cpu_ptr(macsec_priv(dev)->stats, cpu); do { start =3D u64_stats_fetch_begin(&stats->syncp); - memcpy(&tmp, &stats->stats, sizeof(tmp)); + u64_stats_reads(&tmp, &stats->stats, sizeof(tmp)); } while (u64_stats_fetch_retry(&stats->syncp, start)); =20 sum->OutPktsUntagged +=3D tmp.OutPktsUntagged; --=20 2.51.0