From nobody Sat Feb 7 10:08:21 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCA2D47A6B for ; Fri, 23 Jan 2026 16:22:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769185345; cv=none; b=Nmpr4+SKqXnvlkOylN83SoUrpk0sf7spZF3+GpQJlNEGD81F0IpCsjnAntV6/pSGvviHipp2uTj3QGZYsjy5E9T0NQvLxjN2eKBWnIbst5HIGRd7RUOJXb7frR/Web/nvL4BbUTYXODLetOuRNu0h649jDOJXPSByREiJ81qtfU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769185345; c=relaxed/simple; bh=w5MIfnlIHaBZE9Sx+nDab+c35nSGwa8xj0TFBnbl3RQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KrAcNgkyaluss/Nz6a8dGQxY2x5xy7lewCm8I6mHNAg1QvhACwz06xI9cSGJQ9ANMaYZZAMO87JqNCqJNAHOFDbgPPFoOtudPg6wo8Y+AzLefTtuWjFb19CAe0i89FkR66wozFU14A3RgLpfTHgj5wuCHBe2dAbfXJP4ZTf5HEo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DYAsjmwx; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DYAsjmwx" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-34b75fba315so1446067a91.3 for ; Fri, 23 Jan 2026 08:22:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769185343; x=1769790143; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j1hAVBooT6RSatSb0JkTTI9JelC7CFfOn3FnTuarbB4=; b=DYAsjmwxu3adShH3XSnF59IQqoBbiazlOzRhwU8sDXDpIni6snHqasTsswFd6vGHdb oP88BvSbTABYhYtrHTxCoTwD6ls9O2ygMjTFXnSeElpsx9gsnplq2qLl01hQvqQpRH9q Fqe3e2p/uwarWt8kEzt00Ls8wBCtFfrj07PqrdlrSgtUvmCDVMeQCUzo1/fxP38JhIwl w8BJTms5Tgs5rAoGP5GIvo0Lg38sUZeYnPb0jh825q1IkgXUGsAtlHKNPMUB+BC4d/mu J/wCjC09I36X/r5gr1ABpx/qRT8Od3D4guo7SMw5BQgr9uMrGYlxVAIBxwLuRy3Veihe gtfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769185343; x=1769790143; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=j1hAVBooT6RSatSb0JkTTI9JelC7CFfOn3FnTuarbB4=; b=Y3DKG9oolR9s38bXhpNW7duwoBj7PEoo6DVh7vVdughomeel3Tvv7F8w5fseuyWoI6 7wyl+dORkoXSB3SKPry5YPjTPBMAdB6I3IZ7MLzZSl0IVxiWWlBr5rp2HOieBa1LuZQh Lgk6A2NIcN6KtwG3jZyLOsSaex8J4UnMTewd0TiN5YIt0wu82RItfq0NORX2JJrgAIp0 jp1agvi8mVTYjHEsL92S4YNakcELs2eI7q94Q9wlg7FrrL3WtG7yDwwm/jTszNipPFhD 8j4fdwe7QGjsYT+vyD3oJCgS95L+IXq/myED5imB5r1RlnMQRa54Q334fYOdeb6Y1b0T tZIA== X-Forwarded-Encrypted: i=1; AJvYcCWbI51OmfFVEbxH8DAxJLcLXUaLtAT55hrsNDFDfPmKJsGuze7lfe5zxvWYrWbdpvcuNthkid3ki6BgCXg=@vger.kernel.org X-Gm-Message-State: AOJu0YzAnI2tqHrgCw3y0kNzx+9DafuMU27Xy2Lj1Ki8WHyNnKYctpYK FodZaTfpAzh/nIJUFVadxZ9kDW8d7Ksrmczhgt+YDqXEH6F9u37b5Izd X-Gm-Gg: AZuq6aKXa3uPGPltcQlPcloBGBjavsAy2dVEObj5wjkq6y+dxqTNPtsaLjl8RcHV822 GItB4kfYhk/zhKqySKyNUcCWv+/MfDc+AWBix1vwlp/i0cTHZLMGsehDlKD8p1ikiwjVaeqEqoV ffjvkpx0gvL+sDDN2/n/qMXpHdt5smujUUG8u6JH/13EaEKSnMe9OQP57QfHLbSgeOgvwo7huQw 8KBau+E1QiezYmVUh2K/24mloEVB14oP7Qv/nMQB4AYMdiShLHtDOXQwg9hEdJAGp40vbknmCtX msrojHzRrxxTRC4HRm1U1DoVRRj2nSKFEhPGFWG0g7FFslzHfpL3cjwyN0TUQxfKur/d09n9CvO XxH2Tc1GEgJKYHz2ZXZ/a6e97BQsHxl4bUSaqUDd21t0DPpnnuTht0VOeekD6WTatjkKYNOhLVL z0XBArhB9qWOVvAy6FwKt9UfL0HX7iXPNkuLvoBIIVcVMhzh6HqYe+eQ== X-Received: by 2002:a17:90b:2244:b0:349:3fe8:170d with SMTP id 98e67ed59e1d1-35378ba82b6mr1242634a91.3.1769185342968; Fri, 23 Jan 2026 08:22:22 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3536dc50882sm2496967a91.16.2026.01.23.08.22.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 08:22:22 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Sabrina Dubroca , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Nikolay Aleksandrov , Ido Schimmel , Simon Horman , Aaron Conole , Eelco Chaudron , Ilya Maximets , Shigeru Yoshida , Stanislav Fomichev , Breno Leitao , Carolina Jubran , Kuniyuki Iwashima , Guillaume Nault , linux-kernel@vger.kernel.org, bridge@lists.linux.dev, dev@openvswitch.org Subject: [PATCH net-next v2 1/7] u64_stats: Introduce u64_stats_reads() Date: Sat, 24 Jan 2026 00:21:33 +0800 Message-ID: <20260123162159.2877941-2-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260123162159.2877941-1-mmyangfl@gmail.com> References: <20260123162159.2877941-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The following pattern was observed in the code tree: do { start =3D u64_stats_fetch_begin(&pstats->syncp); memcpy(&temp, &pstats->stats, sizeof(temp)); } while (u64_stats_fetch_retry(&pstats->syncp, start)); On 64bit arches, struct u64_stats_sync is empty and provides no help against load/store tearing. memcpy() or struct copying does not guarantee tear free, although compilers never generate such instructions in practice. Theoretically the affected code should convert to u64_stats_t, or use atomic operations properly. However since there are needs to copy chunks of statistics, instead of writing loops everywhere, we provide a safe memcpy() variant for that purpose. Signed-off-by: David Yang --- include/linux/u64_stats_sync.h | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/include/linux/u64_stats_sync.h b/include/linux/u64_stats_sync.h index 457879938fc1..15ea4db2a77b 100644 --- a/include/linux/u64_stats_sync.h +++ b/include/linux/u64_stats_sync.h @@ -79,6 +79,14 @@ static inline u64 u64_stats_read(const u64_stats_t *p) return local64_read(&p->v); } =20 +static inline void *u64_stats_reads(void *dst, const void *src, size_t len) +{ + BUILD_BUG_ON(len % sizeof(u64_stats_t)); + for (size_t i =3D 0; i < len; i +=3D sizeof(u64_stats_t)) + *(u64 *)(dst + i) =3D u64_stats_read((const u64_stats_t *)(src + i)); + return dst; +} + static inline void u64_stats_set(u64_stats_t *p, u64 val) { local64_set(&p->v, val); @@ -110,6 +118,7 @@ static inline bool __u64_stats_fetch_retry(const struct= u64_stats_sync *syncp, } =20 #else /* 64 bit */ +#include =20 typedef struct { u64 v; @@ -120,6 +129,12 @@ static inline u64 u64_stats_read(const u64_stats_t *p) return p->v; } =20 +static inline void *u64_stats_reads(void *dst, const void *src, size_t len) +{ + BUILD_BUG_ON(len % sizeof(u64_stats_t)); + return memcpy(dst, src, len); +} + static inline void u64_stats_set(u64_stats_t *p, u64 val) { p->v =3D val; --=20 2.51.0