From nobody Sun Feb 8 04:57:38 2026 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 116B3312835 for ; Fri, 23 Jan 2026 14:03:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769177033; cv=none; b=sZgoGj47lURZmLhJ58Fyr9SoS38xhsvyHU6E7JkV7lG7QuHIgO5miH5K9nzVbsxmFNqOjjErflrvzMJYOxe1NYkFyvChUvC/6XQLHcLt2d39sgodcGUdPL4FXErREuhC4wzEFa11uF0UQpIaBsuWKs6zhIThWNBcRzmpks8W2sw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769177033; c=relaxed/simple; bh=cbwL/YZ4UilhCaiHWa3UUw8jnvLlX8j1XzPaUoH7ovs=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=TIr//oUCh8LiAe4dvfyOkqp50F1sD7UZgNNOhDao4a9iJACusxeAgAWZ9829LnK9OkMP/+/0151exAfmK1g9URh4/nRWSWULUmU2JoH+RO60cV3tF0AaVpIJjI5rA2ee5RwtQYUu2IWPN+z6TdZPK+eiiq8WpwYfplRMdPYlkEU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aleksbgbg.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=umWR+2XV; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aleksbgbg.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="umWR+2XV" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4801e9e7159so19054125e9.1 for ; Fri, 23 Jan 2026 06:03:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769177029; x=1769781829; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=EoeGlA3h5CpIHkfVehuCUZuXt6jRZ7PdOxFkdAMedEI=; b=umWR+2XVuQqTAec8MaWQnORWj6tv3VZnvnveBrMw9R3lDc2jV8jJGwVSOZ/KRjoqqR tsrrN19J/Ospg7ZHqDo32mPMRx3Prz+APyUG442kVtYTjbyJX7LCzTjNdrxTU4CcXux3 V0Jx/aXEH181FjlRWrO2gM+n0b5ybB6Pw1Bv4+gDu9A5SJMVoGm6UA/bcEcfSEuBQni0 J1qoMXX3zJoAoGtqkO7msHAdByeupLZ/pHLpw9N2mzyV1w9VKN+cg7+BDFHUUICB3ku7 3adMqa56JAESSGFb6cDCkGXrqcZ7GZZqnDKzsz7UdK+i5JruJCRoNIaT0sb9/t3Nc2Tl rU2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769177029; x=1769781829; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EoeGlA3h5CpIHkfVehuCUZuXt6jRZ7PdOxFkdAMedEI=; b=WbVxBF2RXitHEUUnhB1HijoxtMKSodFwUwsXdveC1j0vM2IZxcBaKtHfSQqleyCG+2 e2YNMnCWeZtcDdhZFCPrSNbbG/W3miuF9S9Imh7Y2MeGcX3u2Fv0weC/QsKoOrf7ry39 jw5jRh5k83CMu+iH9Dx8vPXqmLnSiNgU8ZMI+KrVaQzl+XSRnZLgq05owjOgrp1DViOq anvl83/efnkOHrhq2NGTCJbRZJlM5CfpSrTENnzEZdcvVcdn/yp1hNDpPA1Xuq6zZKHo Xurq1LDVL+JnQnGBKYMv5v+rfZPqv7Ay+Et34lv/Jp/FagUXaM/TEWV5Ep5ozZ1h8T8O 3SWw== X-Forwarded-Encrypted: i=1; AJvYcCXoo53szOde1agE33QZNQrqRK59PwHqOmFlEc3cA6n4i32ro8VlgJdec9UItQnuybgA0UtROeDqGuDILwc=@vger.kernel.org X-Gm-Message-State: AOJu0YyedOk1elRFb7zGFkEuPcGGHGCOjXR3ID/a2QvCBeXsBgtdfvO0 c28lsQHLkTUZ7erFdF/Str5tkvy+MlRbdrPO50uIXUBKCc7wUEaHnet4itW0DveplKEQabRfD0k eKzxrmGMvPxZwdWmoiQ== X-Received: from wman18.prod.google.com ([2002:a05:600c:6c52:b0:47e:e07c:131b]) (user=aleksbgbg job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:34d0:b0:480:32da:f33e with SMTP id 5b1f17b1804b1-4804c9ae6a0mr56897025e9.17.1769177029295; Fri, 23 Jan 2026 06:03:49 -0800 (PST) Date: Fri, 23 Jan 2026 14:03:44 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog Message-ID: <20260123140344.449458-1-aleksbgbg@google.com> Subject: [PATCH v1] OPP: Return correct value in dev_pm_opp_get_level From: Aleks Todorov To: Viresh Kumar , Nishanth Menon , Stephen Boyd , Ulf Hansson Cc: Aleks Todorov , Viresh Kumar , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Commit 073d3d2ca7d4 ("OPP: Level zero is valid") modified the documentation for this function to indicate that errors should return a non-zero value to avoid colliding with the OPP level zero, however forgot to actually update the return. No in-tree kernel code depends on the error value being 0. Fixes: 073d3d2ca7d4 ("OPP: Level zero is valid") Signed-off-by: Aleks Todorov --- drivers/opp/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/opp/core.c b/drivers/opp/core.c index dbebb8c829bc..ae43c656f108 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.c @@ -241,7 +241,7 @@ unsigned int dev_pm_opp_get_level(struct dev_pm_opp *op= p) { if (IS_ERR_OR_NULL(opp) || !opp->available) { pr_err("%s: Invalid parameters\n", __func__); - return 0; + return U32_MAX; } =20 return opp->level; --=20 2.52.0.457.g6b5491de43-goog