From nobody Sat Feb 7 07:31:37 2026 Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 012952848A7 for ; Fri, 23 Jan 2026 13:49:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.196 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769176182; cv=none; b=Mezje29UBLhP0Y0sYk+6V9CqLcoD+R8LHA8Fw1jpeuYiE4kuoOvraH9YeVcoO1vKDk9CApFjhKuEgDunLxLomZjyV+3ExNtep2+iQyrD1UKKYdLGMHDCfAyZeuZWa70O1iY6eDhJhiHo4WDWk27nkEJW4l1cc551ayN7xqGifLc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769176182; c=relaxed/simple; bh=JEfpS+UTAGn62ghQ+KDGioFO+Fh9+RE2AoSGzN5h6eo=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=dbdA2xkOEP61mBnGodLfdD/lTc1G3Tn9y5xHwgVJdhWrUooOrJm214DVoUQvq9Bys3y+d0LWlplYnONIJJO5p9fp3LG/1NXUfT9H/gz9W2MFrrMOxXRllpvlJQqtr/QqutHgaLW41XWWN1Z3fA83wUcIKHqpK0imSX+3YYWafhs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QhhWmgrJ; arc=none smtp.client-ip=209.85.214.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QhhWmgrJ" Received: by mail-pl1-f196.google.com with SMTP id d9443c01a7336-2a0fe77d141so13151795ad.1 for ; Fri, 23 Jan 2026 05:49:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769176180; x=1769780980; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=BIiPoKASTOCKqRvR5CTVLUKddqYRQAgTLX6eSo6iKKE=; b=QhhWmgrJF44boXQ8wQ88Fe0n6q3IUnynTaeqpsazka/I8y5/VTUyOKA8DP6J3rOSZw tqinwe0JF6Lw+FZOhbaHoVQLdC9Vsp0L2DidgK7bri4SruIgfpqp3xk0CR0yp3CmeFAT t7E+AiMbXA3nfOJWJnI3njp434/YTC8S6rTGK02EkltEss/JWPis7vhzmkudo9iUszKo fQa2/P8htJ+uKU/ypGNCtUptWvSIrjJZcVsKmsfwZubyd+Exx0a5kqVAzXiE48T8H6yJ ADPgiQdgHdHTQADqQ4dzhVWHLBgVyepXZ6NYj0K7kSoKM4w6IFM1KZL8yBCjZjtVf+co BT7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769176180; x=1769780980; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BIiPoKASTOCKqRvR5CTVLUKddqYRQAgTLX6eSo6iKKE=; b=Wld08zn7i3gRhn905ltZ/6WUFa1wgaH3zMoBub+zvyH4jK1BNTUTq9dmC242rXrMnp Zj2Wg15bHSJ/lm9Sn++Yy39K0WnvgsyTTET7TKWEQQ//A85s/A/+vxqtXN2hzq5uxp+p 9kwEN8Bgvzxwbkyrg1v1JOleJDnxi0CeX/TYWdAzcjfNb6+TOrQMtyqO52tUpO91LPcO nJd9yucXBNHLLN3nKvwHXSy+kwqdl4w1FmsGLZ/5uOylxRoryHV9PSoNHva2/GeKhPmx swFaqN+CbT9ic25GO6e/xRZzm0dflkVNFrEE/jtaSNiWVMMqrkreVE4VIh/fFPMowiyq AKaQ== X-Gm-Message-State: AOJu0YyfNUeOiQNyvycBwSdk75MbKf2/enawE0QIsGSjpsF7Z4RKlfhz 2Qjx0V2IFzs3XBFvlPJB5ihSbViXt0+XEl8BdneHL3NTeUZEzXF4CbA1vKFcsVPV X-Gm-Gg: AZuq6aJenah4DThs/ZPi1MX/ZBlMo9mmLUwuMBGk7T7EeuhTvFHBhpiINVPSbhAHimV wK26bk2ua1zrzG3I79jRAVmpskMIEPQeZN3WyqQoN9n2NGcsaIPp98TArBHQnjPgXFSOf6SQVMa q6nrhPhb9dbKo9R59tFdGoM6Aka9zb1A1btBNOGprvmc1PH/iQPCwNxfZvalj/NLStoiMqWx/R2 x7PLYtenAXslVoxpCaspHIkIXslLqBqVO+Tg7t633XeAbbsN0RinS4TgZirO7R3cwNBGRIkv24N mxAEo/xY46HI0VOM7fyrxZcTMzx+Z5LLlTjpwP83PGMSYnlop57Hhaj3C00BMkE/Cip6XgVcAgw y/JCZwMA+EIU3HplCMGBQiCMcVkEaTI/TXgwhQCiuhxdH95DQtpIOtDE1cfjGRy0Rc1znkpvSrY MOReKtzhUcn7s1y0XJwWd+bIuGbNYwpqqdbjM= X-Received: by 2002:a17:902:d485:b0:2a7:c340:4c3d with SMTP id d9443c01a7336-2a80ebd16dbmr11658765ad.13.1769176180001; Fri, 23 Jan 2026 05:49:40 -0800 (PST) Received: from DESKTOP-P5RIK7I.localdomain ([117.172.254.14]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a802f978b8sm20944275ad.46.2026.01.23.05.49.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 05:49:39 -0800 (PST) From: Jianyun Gao To: linux-kernel@vger.kernel.org Cc: Jianyun Gao , Andy Whitcroft , Joe Perches , Dwaipayan Ray , Lukas Bulwahn Subject: [PATCH] checkpatch: make the IS_ENABLED macro check warning clearer Date: Fri, 23 Jan 2026 21:49:19 +0800 Message-Id: <20260123134919.20836-1-jianyungao89@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" When I used checkpatch.pl to check my patch, I received the following warning: WARNING: Prefer IS_ENABLED() to CONFIG_ || CONFIG__MODULE It identified issues with my patch, but the suggested way to fix them still left me a bit confused. I think the following suggestion would be clearer: WARNING: Prefer IS_ENABLED(CONFIG_) to CONFIG_ || CONFIG__= MODULE Signed-off-by: Jianyun Gao --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index c0250244cf7a..e9c45f5d1925 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -7334,7 +7334,7 @@ sub process { if ($line =3D~ /^\+\s*#\s*if\s+defined(?:\s*\(?\s*|\s+)(${CONFIG_}[A-Z_]= +)\s*\)?\s*\|\|\s*defined(?:\s*\(?\s*|\s+)\1_MODULE\s*\)?\s*$/) { my $config =3D $1; if (WARN("PREFER_IS_ENABLED", - "Prefer IS_ENABLED() to ${CONFIG_} || ${CONFIG_}_MODUL= E\n" . $herecurr) && + "Prefer IS_ENABLED(${CONFIG_}) to ${CONFIG_} || ${CONFIG_}<= FOO>_MODULE\n" . $herecurr) && $fix) { $fixed[$fixlinenr] =3D "\+#if IS_ENABLED($config)"; } --=20 2.34.1