From nobody Mon Feb 9 19:52:23 2026 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9CB0E2DAFA8; Fri, 23 Jan 2026 11:37:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769168243; cv=none; b=YaqPwGyIlstZHDj2LbDPxcpBgJ97E3UDQmKxWGQp+UO0RxjHWB3MuKY/BwoBxQOFnUGa3dCtzPmFXKhfm69pz37QK8e+SkjdkfC8zDGtdxgtEGcVmzzbvsrhAB/j9KZ7djuQIFLDLJXplgIWg/+/8HbSwVFEeTOwhVtU34R0MB0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769168243; c=relaxed/simple; bh=+jI3HD8B+IVS8uvyZCT11kkU7aWeR/2FZYRf+KAA9Zc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KthSqwjWy31FHvf+P0k5y3hj3zgGi0mTgt3ynj9Rt02+KQrWGu1HARKuRLl44sP4J1bRHFns3sRhS81yYdkdyAVj2kebaE+B8cSugkv25OQoLLt+dImwPF1pWx7bhXOBNAJyz9lpJU92wG568u/oal256EoXjYNwXEGFCyRMMrs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=lOdLw2lE; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=ZFO+Gcll; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="lOdLw2lE"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ZFO+Gcll" From: Sebastian Andrzej Siewior DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1769168236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7qOzb846ei57EI5/W356PPwgQiNFvbcKpbMgaeDnSO8=; b=lOdLw2lEUpLDRV4eSPKfxLiGbHgLwXMB3pd3nAC4/wrHilJK0SitiIsB0F1XfFNmiHpYPC 3cxXfKo8ottro4FGBYyG9LYkGz5XR+pKojA8Adsnng2rquOLBGYhCP4gqm8flnI4v/3B3y OFk4UZU0hM+X+SM4GggmwL32sNGY9+B0wHS9CQPYNmw/iCeGwg3FyFuJtwXyJWXXzu0Jqx ldU6Gz2Xq3W1/QBTJPuUYXGU/xCLfC5cCHNX4bTvQ4LlDC2PzyPtYdh3HMTTEM7t5Fsp0S TdgvyXP6KjBR+8XChYbWGptCYklNLEodLHaOEdcYFxoZ8J0wOVn6dHs5at0miQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1769168236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7qOzb846ei57EI5/W356PPwgQiNFvbcKpbMgaeDnSO8=; b=ZFO+GclliPGEjyGYyfLTjn7fmzuyiakIx4GP5qebVrUj/hMyc61wfT8tmzK+IjV+srAS3v Ho6dGgO4GqC6vICA== To: linux-kernel@vger.kernel.org Cc: linux-rt-devel@lists.linux.dev, Thomas Gleixner , Sebastian Andrzej Siewior , Dinh Nguyen , Borislav Petkov , Tony Luck , linux-edac@vger.kernel.org Subject: [PATCH 10/21] EDAC/altera: Remove IRQF_ONESHOT Date: Fri, 23 Jan 2026 12:36:56 +0100 Message-ID: <20260123113708.416727-11-bigeasy@linutronix.de> In-Reply-To: <20260123113708.416727-1-bigeasy@linutronix.de> References: <20260123113708.416727-1-bigeasy@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Passing IRQF_ONESHOT ensures that the interrupt source is masked until the secondary (threaded) handler is done. If only a primary handler is used then the flag makes no sense because the interrupt can not fire (again) while its handler is running. The flag also disallows force-threading of the primary handler and the irq-core will warn about this. Remove IRQF_ONESHOT from irqflags. Cc: Dinh Nguyen Cc: Borislav Petkov Cc: Tony Luck Cc: linux-edac@vger.kernel.org Fixes: a29d64a45eed1 ("EDAC, altera: Add IRQ Flags to disable IRQ while han= dling") Signed-off-by: Sebastian Andrzej Siewior --- drivers/edac/altera_edac.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/edac/altera_edac.c b/drivers/edac/altera_edac.c index 0c5b94e64ea15..4edd2088c2db6 100644 --- a/drivers/edac/altera_edac.c +++ b/drivers/edac/altera_edac.c @@ -1563,8 +1563,7 @@ static int altr_portb_setup(struct altr_edac_device_d= ev *device) goto err_release_group_1; } rc =3D devm_request_irq(&altdev->ddev, altdev->sb_irq, - prv->ecc_irq_handler, - IRQF_ONESHOT | IRQF_TRIGGER_HIGH, + prv->ecc_irq_handler, IRQF_TRIGGER_HIGH, ecc_name, altdev); if (rc) { edac_printk(KERN_ERR, EDAC_DEVICE, "PortB SBERR IRQ error\n"); @@ -1587,8 +1586,7 @@ static int altr_portb_setup(struct altr_edac_device_d= ev *device) goto err_release_group_1; } rc =3D devm_request_irq(&altdev->ddev, altdev->db_irq, - prv->ecc_irq_handler, - IRQF_ONESHOT | IRQF_TRIGGER_HIGH, + prv->ecc_irq_handler, IRQF_TRIGGER_HIGH, ecc_name, altdev); if (rc) { edac_printk(KERN_ERR, EDAC_DEVICE, "PortB DBERR IRQ error\n"); @@ -1970,8 +1968,7 @@ static int altr_edac_a10_device_add(struct altr_arria= 10_edac *edac, goto err_release_group1; } rc =3D devm_request_irq(edac->dev, altdev->sb_irq, prv->ecc_irq_handler, - IRQF_ONESHOT | IRQF_TRIGGER_HIGH, - ecc_name, altdev); + IRQF_TRIGGER_HIGH, ecc_name, altdev); if (rc) { edac_printk(KERN_ERR, EDAC_DEVICE, "No SBERR IRQ resource\n"); goto err_release_group1; @@ -1993,7 +1990,7 @@ static int altr_edac_a10_device_add(struct altr_arria= 10_edac *edac, goto err_release_group1; } rc =3D devm_request_irq(edac->dev, altdev->db_irq, prv->ecc_irq_handler, - IRQF_ONESHOT | IRQF_TRIGGER_HIGH, + IRQF_TRIGGER_HIGH, ecc_name, altdev); if (rc) { edac_printk(KERN_ERR, EDAC_DEVICE, "No DBERR IRQ resource\n"); --=20 2.51.0