From nobody Mon Feb 9 13:01:21 2026 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FC88346AD1 for ; Fri, 23 Jan 2026 09:58:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769162334; cv=none; b=laMAfeAATiup40k/WiIXL+LJIMXGDT4n+7J1FIkUJVS94tBoXVVD1SbaIWCs3PNES2KjEXtsbjWBmZWPLffTrZ1Z7pq569zsIQsRZMTy4arsxFNNU7V5Zaxm72ftg8STQi/kwFGGUToeNQmEmMIPi+6jJSIxlgWNEqnI7ruD2M8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769162334; c=relaxed/simple; bh=KdNLRkw9MXL6d5nMWdkiRZMWkJric39ghbr2UylUDEo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GnVgXbzFA2cqR4QCDxL+HB3h7ZqicTnKr7xoKvPVptj1X44te/Akgu5eYtC5/Mdmb4y5Gvbp4JBE7bx5pIfPByrlwqP36ffkpFIUrS7y0zdLk19uLGeSL0lVDHwEel4EtlDV3NySr4jlwPIioIxDXYUaKKb/RtWCTAhsf/oyNuU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W4TCeKi5; arc=none smtp.client-ip=209.85.210.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W4TCeKi5" Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-81ed3e6b8e3so1013397b3a.2 for ; Fri, 23 Jan 2026 01:58:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769162323; x=1769767123; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rhQmLwopz4+2NgChpiCiZqfhz0j7tFgKBCw4Sy+KIWw=; b=W4TCeKi56cZliCLl0CkPpiG6iNc+7crohcLdt48HLgmzHa6/OCNMKfPo2ulDTTa7rl 3mx9Ui01Q0DTOCeqNGITuUhwgFjfPGkwUQnZPnmJ2MZXxuszYK8culWOFWigK07kUnX/ /EtpVaXNH7NAtj5uESWNdL6eGLD8404I9CYCuz+lYkoXeiv0iEzhScjy2BANVix7QgrQ /6c1F5Pn8NTSD0EpEdF3n4RyIgtnzZIiTbk2g7k/RkfxHDDvOyeZEefLqx/LHf2N5kSl EUD3VDD5s3NkZF7s3PiuLGxX8l3sCFAW8yCjG6t2Y6eiWhJUE6b8Hlp7rAArRKo12+8L ZeNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769162323; x=1769767123; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rhQmLwopz4+2NgChpiCiZqfhz0j7tFgKBCw4Sy+KIWw=; b=duVFK81e0kbf3vKjIun1iJ+RhdIEJtUjlY5oT26Azyq82a30EstBJRIP7IKLv8e661 +FeYPp4Ctfyjil7naVreOAgEJpllXSv61kVAOPuXjGsgq4KAS1+HEilF3iHVm00AYXre gEoKZTIqCrZHdR8MQnNZ6R9tmDKHXelRyGP+dfzFIn+hfntPa1wwrLBdSdbFfdhkx2RQ swa3TRxa2sFmjuZfOzZAm0S9LdXxmS2+yUS3KSdQ+Olj5I+3xhNYAaD4ioBTDqUdk7iZ FTm/jARB/SLw5nYzLZ1Z5oZuX7kuhLKLnglYR1F7C6rGbdV8A6xhnAlBFUVt5Lg7Feo7 vkJQ== X-Forwarded-Encrypted: i=1; AJvYcCV8utCtFo1HyJFYMznAKe9MMHBQ0w3WFkWhwtsxtgm+kgS+QIJ5U844lItn1rqte4YXNTzyiuTIoc30I8Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzCadyPROoHPpoDM0Gc0F1kw0d05s/VbYLAiqV7F++lfVqfqKAD COnSiduN16C4ZOAwIHG31ACmIL9RJL9qrcabgY/m+BrZ06Uzh6P+nZ8L X-Gm-Gg: AZuq6aKaW43Vi7gYqzwxiou5F7SKzr26d+Dvc3wxi0FTgYdA9wCokBOmJ9u02eORE8N 2QuAeANrOzysZ09+FWr8kL185CfTCexd5+IJhO4QzK0iDs6kB01vR8P1W3DXASL0d4C8Du9NLbu Lu2r2Xk7q6JoNO4OUsx46lsIdWgoxjKARkOeFc3VB65HjZI8fFTRlY8hPJg7JjiifPs3R7nNZ6w dOgBvzRA+518Q8/1KX3b9CmkWnzJwu64KjDXUunO7zCNZCAs2TTj4+ihAB9qUEYNjS2EfTosKGh RAHlT6OPIXwjVdC505MXjkamOSS/5tGgTbvE87cW3Xd2IO+343LEmNmYXQeTqy8aDuNF6Mr+yDh t4jcMINgiuY+iyZHVGIPMIKOGSJpky50/pZNjM/UgqwqzzB8TMHgbWFoX1fWf7YPusRJ6tP/nQA mfv85KSVA79Ou34J0RfYEwiKVGF6iY9i3F4xtL8qRPs0k= X-Received: by 2002:a05:6a21:3287:b0:38d:ebdc:3546 with SMTP id adf61e73a8af0-38e6f6aaa92mr2511061637.6.1769162323188; Fri, 23 Jan 2026 01:58:43 -0800 (PST) Received: from tehuang-Alienware-m16-R2.. ([50.47.240.160]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c635a412944sm1564838a12.24.2026.01.23.01.58.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 01:58:42 -0800 (PST) From: Michael Huang To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, straube.linux@gmail.com, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Huang Subject: [PATCH v2 2/2] staging: rtl8723bs: remove redundant else after break Date: Fri, 23 Jan 2026 01:57:33 -0800 Message-ID: <20260123095733.49301-3-tehsiu.huang@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260123095733.49301-1-tehsiu.huang@gmail.com> References: <20260123095733.49301-1-tehsiu.huang@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In _rtw_join_timeout_handler(), an else statement followed a break in the previous logic. Removing this else reduces the indentation level of the following code and makes the function easier to read, while maintaining the original logic by ensuring that disconnect indication is still called when roaming fails. Signed-off-by: Michael Huang --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index ed754fdbfe7a..ac47b2a4f65f 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -1559,12 +1559,10 @@ void _rtw_join_timeout_handler(struct timer_list *t) do_join_r =3D rtw_do_join(adapter); if (do_join_r !=3D _SUCCESS) continue; - - break; - } else { - rtw_indicate_disconnect(adapter); break; } + rtw_indicate_disconnect(adapter); + break; } =20 } else { --=20 2.43.0