From nobody Sat Feb 7 23:34:06 2026 Received: from mail-dl1-f73.google.com (mail-dl1-f73.google.com [74.125.82.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E26C533C189 for ; Fri, 23 Jan 2026 06:58:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769151504; cv=none; b=qUpWAlX0iEG1+h2dgvdlWgLZlGGn2b+bL+uWHPtXu477KMfEGEyGqT6Vf69gMmSEP4RJ45lGbKSfeUPV7WrNEexqKaR2eiO3IIZC+mYkx2gh+4d48+MyxGk+EICQy3m6AWLe4q3+deyVKzRkFOfgf7DQdJXOzwoRV6BFKelO1Fs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769151504; c=relaxed/simple; bh=6+3nZjgoHWSP4ea8zSCT148SAOESmqsnhw6/Ni1AyDs=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=MMg27ydlV+LQuiBIJ1Qv/9QhqZ34QDne83BdvnVWRS7X1Nx2vqJkFhlRQmWl7EJ6ZVj8rpE6b7h3yC5APUOC9aFR542PX+NuII8W0BAzxkXY/qD29J6tTBVDGZilQLBmnZkjDnRvwXx7QZrGQAXsJYIU5XViQ0MU2ZOwmP/aWMM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--boolli.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=QoDBF9u8; arc=none smtp.client-ip=74.125.82.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--boolli.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="QoDBF9u8" Received: by mail-dl1-f73.google.com with SMTP id a92af1059eb24-11b94abc09dso2797255c88.1 for ; Thu, 22 Jan 2026 22:58:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769151502; x=1769756302; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=wNuK2/dOALJQhNEGtJ2LlGL6rosoPqMbD+3I0jKBgfc=; b=QoDBF9u80vu0mQmzoIz4rihEci5tnb/dSisJw6uUCJOO9UAvRbH8bzPdcTSdjyfBkq l6rLfbelYxG0YvWhY9gXu1m8oSb0+kZYoIbTjs0wLosnqjFKXQXXqhC40LNbhnhxPZP2 1HsySEibF0mhZcp+R6QMzRqWa0ga/pahzhX7TKWU4lHTTkV0Z+LfzzRy2MwhChoCmW3C WN+nC5Mp2ETCAJEVfn/e7Hdxu/GSuf/YdnUMJHEnFB42PJYyFq65aNXD3qjU8BQPLYdw uyfEf89iIBy02fG2OjrCZ4OotYKzEhmUAL33loWPCfAzfRDp35fTzxAoCGJbwJPBxdl3 CS/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769151502; x=1769756302; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=wNuK2/dOALJQhNEGtJ2LlGL6rosoPqMbD+3I0jKBgfc=; b=TOq+inQfgYYtQpTPCqpQq8F6fMk7eJhM5q2+TqnJJmlGSz9BKqbu6ajPNsJmoKlV7D 9sUprm3gewSQA42GyusmdUrKKml2jjZ07YO2z75QoC+5uujYO+ES9luTz4iCuiVARCqs wMvTMzBBx+XdTl1Jpg0B4MT8Zr8iGRRGB/Fb9SxyAgss7wT3D6MBEs04+J36bGVbsduy w6YrqLQiwuld3ts6cNZnpjJpW7CklhlRgrtJ/37oiKsoJ7eQYjMWx348i9DkUKoRH7GP ThE5kv0YDZM+RdWks6NQuQrbqGQyUjzmO064STpVgGkgg/ZDsPpmJFWfcVr+s6kXfUVL 1sMQ== X-Forwarded-Encrypted: i=1; AJvYcCXKGGulG+N3tIgDkqOvI4iQkxOknhkKD/NClbysZm6YOWVTHci3vz1lalVeN5D3PuZN1shh8XFlI7o7Nvk=@vger.kernel.org X-Gm-Message-State: AOJu0Yxip+FhB311+1Sr4Pgd0uDvk486H4gZytL45FSxAO4Yo81klei8 3D4ilT0P/11F6feJuEzUn14jBk1A605EtKRpPpw7f6EWgABV+E9NDUtXuPejag7r+CBc6fs0+nT 1d49RCg== X-Received: from dlbuy11.prod.google.com ([2002:a05:7022:1e0b:b0:11f:3ccd:73d7]) (user=boolli job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:112:b0:11a:273c:dd98 with SMTP id a92af1059eb24-1247dbb0d6amr858556c88.20.1769151501761; Thu, 22 Jan 2026 22:58:21 -0800 (PST) Date: Fri, 23 Jan 2026 06:58:06 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog Message-ID: <20260123065806.3858623-1-boolli@google.com> Subject: [PATCH v2] idpf: nullify pointers after they are freed From: Li Li To: Tony Nguyen , Przemek Kitszel , "David S. Miller" , Jakub Kicinski , Eric Dumazet , intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Decotigny , Anjali Singhai , Sridhar Samudrala , Brian Vazquez , Li Li , emil.s.tantilov@intel.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rss_data->rss_key needs to be nullified after it is freed. Checks like "if (!rss_data->rss_key)" in the code could fail if it is not nullified. Tested: built and booted the kernel. Fixes: 83f38f210b85 ("idpf: Fix RSS LUT NULL pointer crash on early ethtool= operations") Signed-off-by: Li Li Reviewed-by: Aleksandr Loktionov --- Changes in v2: - Remove the line to nullify vport->q_vector_idxs as it is not necessary. drivers/net/ethernet/intel/idpf/idpf_lib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c b/drivers/net/ether= net/intel/idpf/idpf_lib.c index 131a8121839bd..f63ab58428d2e 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_lib.c +++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c @@ -1308,6 +1308,7 @@ static struct idpf_vport *idpf_vport_alloc(struct idp= f_adapter *adapter, =20 free_rss_key: kfree(rss_data->rss_key); + rss_data->rss_key =3D NULL; free_vector_idxs: kfree(vport->q_vector_idxs); free_vport: --=20 2.52.0.457.g6b5491de43-goog