From nobody Sun Feb 8 02:21:38 2026 Received: from mail-yx1-f54.google.com (mail-yx1-f54.google.com [74.125.224.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89C3E34E75E for ; Fri, 23 Jan 2026 05:47:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769147250; cv=none; b=gd5j8dKV8abut62D2H6rWkBDjyq9vo3f6amYX8m5IVDoFuUXWqUQyXbkZX0jVrTNMQCEqYaH6TCqoEPA14EAyiWoOpMSCeIkqZ/VVhDYANrnQ7WrEkZR+TCLXnocSp+TIJa1Bm6NV1tA7x047Z2J0LGF722amTvnWwTmMlEAYyI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769147250; c=relaxed/simple; bh=jBjebCzVyGhu9pMVkIQMX4aYtoPgjKzFTilzGQofvbE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TPqMkWUYBE8psAhGd930cuvtOoBZIHfJBfeYMQBSGMe/AXvAJsxyUK6zbT49tgu6j/iCGKbA76q0pR5VKby08ftM5AgniK23xY7yHJkyQoD0dfQAV+wqWRfFSUJ0IxWFd+X4poiRou8cdcz4lc7vzM9tvT3o52QyGtaYi4cbw2s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GePm3Bn1; arc=none smtp.client-ip=74.125.224.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GePm3Bn1" Received: by mail-yx1-f54.google.com with SMTP id 956f58d0204a3-648ff033fb2so1879988d50.0 for ; Thu, 22 Jan 2026 21:47:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769147242; x=1769752042; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6Opcnc5dGvJWo1BoZUfzlyhcRhD7x8IvfP/BNkkpQwQ=; b=GePm3Bn1HrMlhk1ZWBMIEI36cmWmu1vaKwAGGeLrtKB+3XBn2JST1WHR1MvFTnfNPx U6/j93GFQvQ36Bv0SFkiPFWCC+++EDTWFE1cFYBpZElo0n3vDBx3e81Ghn9YpzWNubAe ockFESWqto4f5RAadEWM1nx+P0Skj3EEYViOPAyu2MECHMInpcd+MNviscvrCBTTvGly P3s/reCXZnvJ9jXyRgtPM+PhS+DzAanTP2GAJAWtQGdHkrSsINEinhnF/XQXe4kGoqM/ fFEufZgnvqiJ2yRujBSrl5+42t83AawPxtXYMZMcq14WmPbJWqmAmTeWX9Nornzenotk 7zRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769147242; x=1769752042; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6Opcnc5dGvJWo1BoZUfzlyhcRhD7x8IvfP/BNkkpQwQ=; b=XM0IWjLDw9+wlzS7o9aG4x5Y5a0yTaJ0PhDRS2i+Bcjxa5/g08PD4uLiH9lVhNphpv MbdCRgvVGs7oPpegMnsq7mepV9cckN8YOyQFSC8h4SLNgkzFViHmBiEQLPMuKZB1kLd1 t94bhjAiYTNT/t+KqkXxkWmc4OlXfDIcyPVzqp9L42r9nXE3B9Fwju5G29XXnbQFqct3 yvSa4MHitpKPu/pWTYG0E0k5yzgMQhhpQwQMdOvHB9a5VtpSfWv1Q997pjoUcwtysYu2 IDyiBbeoz4KTw/ecxIaH8ck+QVZMNGVUev11J9LnQaq7VRedGdDhCIW+rQgql3KhF5Zi KK+w== X-Forwarded-Encrypted: i=1; AJvYcCWnS5x6CrPTAYN+QAsHeS221gMnNc6asW9JGI82ILJ3lSJdP7SBW3mSiu48fVPRr6TkV2FPEoqb/Aj2vR4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy534QnaPLqavrrQDy+jBfHkZ5bYCIOSeQmTdPR9BfurA+LDUL+ /a2/ylyM4HsrFgZZeN1JNi+WjTaSFiSq7QBFXylUUXZadAkG7iQiTc/M X-Gm-Gg: AZuq6aLwXOzdiNqQc1kw6SKNEyph0P7oMC6p2VVL8/qt4nzV8GNz+IRMFvjNbWOvssQ Ks+Uqre5riwgwKSEgBBcJx33wsnNjL3CGNGzYINUMpabQ9oMM1chD/Z+bpIytI+ZcUbvRpM8srv +RX+Jv8G5PGQQxTcifHWVisUTVfWEFXKGp66WKV68kKoZVIZy4cBZQenFPzpoQyqBt46kS3T92N Z3twAiujckUzjPl0F+D0LKmzs1NyezA1iNt7WF0mm6YZ9ygfhPru+y8WJsY0khDfqn5H/8gEE9p 71llG0gZQheg1B7sv6NFB7/4yLgJIKgkgZXUEG9ZMYQJIjpVJ3Y/7shky0YCZtYdCOieL2vNa2+ 9dy97qNNnFQkc7iJdPBFtAez5MFg6lhrgYrdtWWgZl8f+aTnLasO/MeH+xaaisQ1Pf1E= X-Received: by 2002:a53:5011:0:b0:644:60d9:8654 with SMTP id 956f58d0204a3-6495c03c610mr938196d50.87.1769147241756; Thu, 22 Jan 2026 21:47:21 -0800 (PST) Received: from tux ([2601:7c0:c37c:4c00::ab64]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6495cfc1be1sm743385d50.19.2026.01.22.21.47.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jan 2026 21:47:21 -0800 (PST) From: Ethan Tidmore To: parthiban.veerasooran@microchip.com, christian.gromm@microchip.com, gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH v1] staging: most: dim2: replace macro with static inline function Date: Thu, 22 Jan 2026 23:47:08 -0600 Message-ID: <20260123054708.11140-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Replace unsafe macro with static inline function to avoid side effects. Signed-off-by: Ethan Tidmore --- drivers/staging/most/dim2/dim2.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/d= im2.c index dad2abe6c0c9..a075a2df349e 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -113,10 +113,12 @@ static inline struct dim2_hdm *iface_to_hdm(struct mo= st_interface *iface) return container_of(iface, struct dim2_hdm, most_iface); } =20 -/* Macro to identify a network status message */ -#define PACKET_IS_NET_INFO(p) \ - (((p)[1] =3D=3D 0x18) && ((p)[2] =3D=3D 0x05) && ((p)[3] =3D=3D 0x0C) && \ - ((p)[13] =3D=3D 0x3C) && ((p)[14] =3D=3D 0x00) && ((p)[15] =3D=3D 0x0A)) +/* Identify a network status message */ +static inline bool packet_is_net_info(const u8 *p) +{ + return p[1] =3D=3D 0x18 && p[2] =3D=3D 0x05 && p[3] =3D=3D 0x0C && + p[13] =3D=3D 0x3C && p[14] =3D=3D 0x00 && p[15] =3D=3D 0x0A; +} =20 static ssize_t state_show(struct device *dev, struct device_attribute *att= r, char *buf) @@ -304,7 +306,7 @@ static void service_done_flag(struct dim2_hdm *dev, int= ch_idx) =20 if (hdm_ch->data_type =3D=3D MOST_CH_ASYNC && hdm_ch->direction =3D=3D MOST_CH_RX && - PACKET_IS_NET_INFO(data)) { + packet_is_net_info(data)) { retrieve_netinfo(dev, mbo); =20 spin_lock_irqsave(&dim_lock, flags); --=20 2.52.0