From nobody Sun Feb 8 05:20:09 2026 Received: from mail-dy1-f201.google.com (mail-dy1-f201.google.com [74.125.82.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 46BD036B058 for ; Fri, 23 Jan 2026 05:27:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769146077; cv=none; b=qKBK+my4TNNJyWZbg6uYj0jOsGo9sG9qc8BgEcUxnNYjrk6dlnz09yRYezypNSmPIzmqUGkXTKoYHcq7gmRJFnQVSPJN6Ri7zEYFubDqPtIswVGT1QvyOq/J4zPKPnefoWkq2bFVZMW4u4p6lbGNAZWEnEpHr1wGr2qIPJ1GKBw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769146077; c=relaxed/simple; bh=t+YS0IFF12k/AnkeFlvc6z2MlqpKmEJZch2QYMhzMa0=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=g0CSTP7qcQUbMT9HfLNDtI0+DjUuiNkqCXE2rhkWzkEx+qDCeIbsmn5gMiugQG1MRNciFMyaCC57PeFd+upqxcEzSSaKPVk9HlrarzSWtrN4e11ICqGuYYBZs3p7pYmbsUhA8nbGnUoeWPQHno+i55qOpEpHhvOnQ73QXQSphec= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--boolli.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=jE+cV9TP; arc=none smtp.client-ip=74.125.82.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--boolli.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="jE+cV9TP" Received: by mail-dy1-f201.google.com with SMTP id 5a478bee46e88-2b708fa4093so5961948eec.0 for ; Thu, 22 Jan 2026 21:27:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769146066; x=1769750866; darn=vger.kernel.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=IAZSzyn91YlrkG1tCKbVc9M2F6+GonYziUiLWmXHc7s=; b=jE+cV9TP7FWGbvoJek2TzcrIQ/RyTLYRDpa4YKwB1jjGGHrtRUP5oxm6H1Ea4h/lNe W9aJY7rut8VnLqwRyuQDkSNlswtS7jCV26CUBTxQ1PJHH6NNzTSqRohK8owflqRP6clI lyMjpBf1W56wYjmitozJ2SDbaZ3Hmj5QJ0tewVFTs55uO5zYzxhsSE79MEE52vJHc1mP 8DZd7RYzUH6NdfX+Y3+b+M41YOlX6Dt0ALhMIzNe1d0c3m59B1DLL2nY8Qo0I9vHsM4B ZMhHRbNWHedCsLxd4dQyUJ326gMUXcx3Xiu/KlRdL97D3aUJaoH7r9i0twGBW+xdRX/T cAZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769146066; x=1769750866; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IAZSzyn91YlrkG1tCKbVc9M2F6+GonYziUiLWmXHc7s=; b=TRhtx0NtT8RWKWyaN7n+qjVLeNiSzPfoRSAo1uzCS1N15AoCjymV28I7A2lUqAfCEU HGVQygzpYxaJDUQI1+X8ieurThjRo0Atjm50d5FIFUioQKtMNoFyozhuu9OuvloR6tyd iu08XFWyC75HyyEGceUwBTw/1BMs//9IX6z+tW/XQypy9g/j1SBX975t/Ez+1c1rE/2E rrbC5CBXLRD6kd+uaVxEltzT0IUcw+zObx5H2xsc0sQ0akoUCl76anUbTBVEAxSDEQdq R7x0/BdQNzsAzIpQytOzK3uHaWIegRidwfBIPvRmltKXv6r/5KuVaAatAFyxJZ0vP+YI qjLw== X-Forwarded-Encrypted: i=1; AJvYcCXqHNT5gNp3Fm4ltCutwkX/VBOjqvDHGQM6Uz4w2AwNADakfGeCqlMUy8mOQCsGNg9Dg3Yc0yFm35TurZg=@vger.kernel.org X-Gm-Message-State: AOJu0YxKPLdB0OeLnfH/ek3mfzqCDYVQkWxyFSZgeamstL1SVZV+QIJ6 7Xy/gMpDV+Um7kKoFnM2UwjrVLRZn/ld1Tu84ZinObwWFKRV4wESZWy5Kq5pIsFlkAuJoliGsbH trOXbJQ== X-Received: from dycmg13.prod.google.com ([2002:a05:693c:250d:b0:2b6:ad52:b359]) (user=boolli job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7300:6425:b0:2ab:9f55:d15a with SMTP id 5a478bee46e88-2b739bbffb6mr874638eec.29.1769146066294; Thu, 22 Jan 2026 21:27:46 -0800 (PST) Date: Fri, 23 Jan 2026 05:27:21 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog Message-ID: <20260123052721.3765743-1-boolli@google.com> Subject: [PATCH] idpf: nullify pointers after they are freed From: Li Li To: Tony Nguyen , Przemek Kitszel , "David S. Miller" , Jakub Kicinski , Eric Dumazet , intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Decotigny , Anjali Singhai , Sridhar Samudrala , Brian Vazquez , Li Li , emil.s.tantilov@intel.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rss_data->rss_key and vport->q_vector_idxs need to be nullified after they are freed. Checks like "if (!rss_data->rss_key)" and "if (!vport->q_vector_idxs)" in the code could fail if they are not nullified. Tested: built and booted the kernel. Fixes: 83f38f210b85 ("idpf: Fix RSS LUT NULL pointer crash on early ethtool= operations") Fixes: 8a558cbda51b ("idpf: fix potential memory leak on kcalloc() failure") Signed-off-by: Li Li --- drivers/net/ethernet/intel/idpf/idpf_lib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c b/drivers/net/ether= net/intel/idpf/idpf_lib.c index 131a8121839bd..7af4214ec44de 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_lib.c +++ b/drivers/net/ethernet/intel/idpf/idpf_lib.c @@ -1308,8 +1308,10 @@ static struct idpf_vport *idpf_vport_alloc(struct id= pf_adapter *adapter, =20 free_rss_key: kfree(rss_data->rss_key); + rss_data->rss_key =3D NULL; free_vector_idxs: kfree(vport->q_vector_idxs); + vport->q_vector_idxs =3D NULL; free_vport: kfree(vport); =20 --=20 2.52.0.457.g6b5491de43-goog