From nobody Sat Feb 7 17:41:34 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE6A134888A for ; Fri, 23 Jan 2026 05:26:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769145980; cv=none; b=JrznNUsHYboYPxIhJXqc+3yVAtd7psF+DFBSt7WXaiFLFEQbOovNhw2oxOhpMXQXbFs15Nt9Ch7XzD8fFzYjy4YB+Ia77WoDMH2yTEBssPpDLlWnT7x60UhmuTAdUFl9nOJzsTuS+kQv1F9Er1OeO9FSKfjpFrYnQyhMHvKnMQs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769145980; c=relaxed/simple; bh=YxaD1qulJt0wz4SIjI4LmL/w4ixXaa3TnuPu7TjJfn0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=ghHYJ9Z0RR3sd0fYoUVDudnH7ggxtxW9SfD8QcVXph/QUTaHdZxdPe/cLN/wPtOfhdNUL7v3SK90ffaRhfaNTM/y71d5RTwdPU7Sva80GRjuOJsROz4fp5clAljbIQLCTmpcmVjU2l72vIZZvr8Il5xx3XGt9KNOMo24jzrGsWc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lxGS5+O3; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lxGS5+O3" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-81dab89f286so941557b3a.2 for ; Thu, 22 Jan 2026 21:26:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769145975; x=1769750775; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VQcopxq+sUmUTjLsEEd/iJJhsWiwz/UrdyF1kPVCowM=; b=lxGS5+O3lKfWnJvIqwoibTOvhWQCsQRCd12/zZ66e+8qLOUr1CuX4RnVaXZkb4toHa EUtzPuhXeefM7rTHJeQMLT+tv+xp9tXBSDn8ZIVE/lYJ8UXGf1n2d9Ob/UE1uLc8sOB1 E75K78Jx/edTPNroRifT/L2iI9Va8rip/q97n/rS6e/Sh733AvSuAZfIm7SdRg1INGqf sRkXaMdHjS2kyL9Mch+G6nRQdf9BlmEpqaAqQtSF8hZH17ie3BCqXe5Jrpj12Xr9EU7q ZcLxPXzqN0I3noVEgFClOe8eIc3xeomuh71YzYFN1gGCRbt4HWUqgbYhvWvAHcahvSOE AZOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769145975; x=1769750775; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VQcopxq+sUmUTjLsEEd/iJJhsWiwz/UrdyF1kPVCowM=; b=R7Sltp6rIjI0L8cjRV1rS2jmvACyWP24s3duw24AhcCMw0vcXs3+xHK4SbGHAuv1mk 5Kz/OK9ZAoHVlEI/H7MfbiQbyDcXdvCjXuibcZ+YBMoTZV5xVuqT7xrw1PB7ueQjNA0s 1jN/RrQIJArXbsxU45LixVgXD97q8eRQCUHn/BuH/yza5vwCxu0d9YwXCRNUvMs6ni3J rfNXrTbyYgyNTUHD0XfghdMtfz4Ouo+BsI3W8rjUDMCjP5Ydi34oT6XWbsMaCc+GcwKx 1RgNIXjPG0ccH1QJlGcHXoJYgiidcyPGPSf81p6kIa+0UriA+tBjLCyZcMU68Y6fO/vH h1wA== X-Forwarded-Encrypted: i=1; AJvYcCXlgCmGpnQoDtUmKDnUwwkYlZ0hqlmZj8UbhEifuNkqZwKS0GXJwLyS9urbfZLClbkKUi4B1aIOd5fpJw8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9V32mDyO9s2yKfyaV1zjp6R/Gh6WyNVvljuKPiYIezZmSe7ZD MXdBO9kHEnmSXIU8qI3mQKRGcJ7nAXK2MzT9N/Ve4W+DgBoqCKynj0To X-Gm-Gg: AZuq6aKJDATfLtCCkzgqLFYlBbBOoFGg7QNxcoqTu9TgmZrvm2NgSmugAK2MY4zLEd6 RTignIusVxEXd9Mvt1eIJtK95wu6lDh3QDen2j7DYKAzj0vB0VKfqa82qq4q2ZmFB1Ept700jW5 IMHaQrLxvlVGrBKwQ6QnYlQXwJ4Ef7R4FuMqwPBsIof/BYT2Y4bznSdFlARbaQKBQCnzjo4jSBn qJVRZtAYAsdykOaZm+yqoUKOXkD2pWaw29msmmFpcqkFNCFKRM9Mev5g+UoQWRZT1uxYCG6cfFh YKBIuB4mmF/bsidESN53JX9UnRaApoJCA4byVV3BLEGRnsEaQ6og2Nz/B8lVbIX2euFZ5EtV5fj wfX8ACl2DGLCq+lC7V+Drh7DmKXkkTjkNK/QrfSFanbO45I2BA6HSj6g9SVC66IZRLp+S9Ji8WE s6ElrsAoMRK2Yf8cBIA/V5C33uloBs9ad60G/Or7g+kM+ZDVXrVeyrJ/dfX6RKHeF8mWf3tIHlb fU/ozvtZud8qYCj9dQ/Gp+el6dge70zwX/f3dkO1eQjhHg0kZMKjrNnNw== X-Received: by 2002:a05:6a00:9086:b0:81b:13c5:b6b2 with SMTP id d2e1a72fcca58-82317e00cf9mr1457817b3a.33.1769145974766; Thu, 22 Jan 2026 21:26:14 -0800 (PST) Received: from cc3c93d3b6b2.ap-southeast-2.compute.internal (ec2-54-252-206-51.ap-southeast-2.compute.amazonaws.com. [54.252.206.51]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82318644989sm948391b3a.13.2026.01.22.21.26.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jan 2026 21:26:14 -0800 (PST) From: Weigang He To: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Weigang He Subject: [PATCH] mtd: parsers: ofpart: fix OF node refcount leak in parse_fixed_partitions() Date: Fri, 23 Jan 2026 05:26:08 +0000 Message-Id: <20260123052608.668207-1-geoffreyhe2@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" of_get_child_by_name() returns a node pointer with refcount incremented, which must be released with of_node_put() when done. However, in parse_fixed_partitions(), when dedicated is true (i.e., a "partitions" subnode was found), the ofpart_node obtained from of_get_child_by_name() is never released on any code path. Add of_node_put(ofpart_node) calls on all exit paths when dedicated is true to fix the reference count leak. This bug was detected by our static analysis tool. Fixes: 562b4e91d3b2 ("mtd: parsers: ofpart: fix parsing subpartitions") Signed-off-by: Weigang He --- drivers/mtd/parsers/ofpart_core.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/parsers/ofpart_core.c b/drivers/mtd/parsers/ofpart= _core.c index abfa687989182..09961c6f39496 100644 --- a/drivers/mtd/parsers/ofpart_core.c +++ b/drivers/mtd/parsers/ofpart_core.c @@ -77,6 +77,7 @@ static int parse_fixed_partitions(struct mtd_info *master, of_id =3D of_match_node(parse_ofpart_match_table, ofpart_node); if (dedicated && !of_id) { /* The 'partitions' subnode might be used by another parser */ + of_node_put(ofpart_node); return 0; } =20 @@ -91,12 +92,18 @@ static int parse_fixed_partitions(struct mtd_info *mast= er, nr_parts++; } =20 - if (nr_parts =3D=3D 0) + if (nr_parts =3D=3D 0) { + if (dedicated) + of_node_put(ofpart_node); return 0; + } =20 parts =3D kcalloc(nr_parts, sizeof(*parts), GFP_KERNEL); - if (!parts) + if (!parts) { + if (dedicated) + of_node_put(ofpart_node); return -ENOMEM; + } =20 i =3D 0; for_each_child_of_node(ofpart_node, pp) { @@ -175,6 +182,9 @@ static int parse_fixed_partitions(struct mtd_info *mast= er, if (quirks && quirks->post_parse) quirks->post_parse(master, parts, nr_parts); =20 + if (dedicated) + of_node_put(ofpart_node); + *pparts =3D parts; return nr_parts; =20 @@ -183,6 +193,8 @@ static int parse_fixed_partitions(struct mtd_info *mast= er, master->name, pp, mtd_node); ret =3D -EINVAL; ofpart_none: + if (dedicated) + of_node_put(ofpart_node); of_node_put(pp); kfree(parts); return ret; --=20 2.34.1