From nobody Sat Feb 7 17:41:24 2026 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABF7C32C930 for ; Fri, 23 Jan 2026 00:32:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769128354; cv=none; b=g38gAduv8TuR/IojlfWjt/WA/SXPg11eXiHokKAsBnn1IK8Q2xa3xH3uPBDu6CQiVY3SYL1l6+qhGmsJKPGAVgcMaKgKtmsFnSzlOJVM3F0R0pN28bQe44izPDHjxE36KcsKWJ5wW6Wu5/wycxcOVfd4GHv9CMUzEQMI/G8y6k8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769128354; c=relaxed/simple; bh=hJ89ncWKlGLf6hjmVBwCUvsAU0++EW+pWL/nCGoJB6k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EYSwj4yRQXTV3EkcD8YvLn5HS396oBk7lh85WWwWq4vLVpGqovh4vLBI7WYSQkiqRQAeKLecqTrqwb8SuqEeIB+GZd0K09qaDT4vTALg6c1YoBWwMs5FfKc/D7G8a/719yRyeenpc/B172MGI+B+iESQqm8ReosS88fE8PvryYw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ia2vskeE; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ia2vskeE" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-353576abcfeso429848a91.0 for ; Thu, 22 Jan 2026 16:32:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769128347; x=1769733147; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=r/7hLRIjtb3MQgSdxcpjKlLWrlEfFBG5SgL5jJWgheQ=; b=Ia2vskeE7yPZWQrtM5nNOP8SPIkG3orUbWx9aKkIDXTSjZfOl386RDRsPO60Th3AYl 2xwFcDBod+Cq6BdCBU8/wV1xytOsDURldpgjlOFUoiCjXkqC2D47hKPwyupr1NcNSymP Ypj7wXL4CvF8/eWoMUfS9zOMXh4QVJnsbENl/YwntxyRyHCAkQEjRTB5pAiqdxISbmow WiU22nkEbSJqIncaI3wgojhXSgC0iOJhK2JfsGGYheKNAzaEVRnq5Cn+A7ICwZg2ZpbG qfCPjYpp0j3Li6nkP8QzxQ4blFU7X3Bk8iOLWTRpfBWggt60ofXU4UvQDfzbyj2Pqzyh Oztg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769128347; x=1769733147; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=r/7hLRIjtb3MQgSdxcpjKlLWrlEfFBG5SgL5jJWgheQ=; b=GPLVd/BnWhnGxNcHTdy3Z8dNhm5dyojIZqkRND3mGySGAm9uTUSEhSq0tKzB9DLZyw +LDjcp4p68xOBhOwP14DLOpJoXu29Q8ZcPw7sYPgY9x3RxZjYbIWxVMW0kKi1Hft/jEZ 87bwD83WY4gGHRSoxwp1IP7rU+/akkse99rNOITVPXNDdmYfL9Gen3AX7OsasLQXIHDo sgs0cqQYgoPAIjVl8AYw7SS3oGcwOALx2AetTo8kItQV7muNAUZoZjWTuBx6qP6C59KV m2fC5ME7iGX6opBl96eGWqfilbU4xjVoBjV5GSbyD7PFAIXoQ2TQ6WmAjRXp8X2Fk9B+ ErQQ== X-Forwarded-Encrypted: i=1; AJvYcCUP5wpPX9BWRWXR/+t3WnzAlIv5WwNfTBAp8HKh+0D/Ul6kGaslxWyjhnyXV34TiiuYKvbELIyRbDEA+Go=@vger.kernel.org X-Gm-Message-State: AOJu0YwKJLffSUGH4mp1N57B9lHNlZn6cDr3tri5vQc3npTWtVeQ9A8M M6NSJhchpJm5RbHzP1dURdiTb1PvG4nSI4B/1mBU3N3pr69wVTkRdlO7 X-Gm-Gg: AZuq6aJcwOK1lERevJD+Y+Hsn9uM1UhuY5UimcuSZJGQfegD8InvwE3Q0oC0BPuUIQP 3UrV1ORc9DlJQaAtG69xMENDgm+4sgOtyS/s+i+/2f5HNJFZXmZsgvHSlA2Ap8V19dxOXf+FKWI pNJMTlOlB6bdz95lu/9i6E/SH2f5/jolli1QPmp0haRthcHZOz5aBk6BpX9Ds9gs0OUbubdOIYj 2zTSvnJbRVd+ZJyA65izjgt5BgjLWPMpEJrLX9hTVLUOQ47cqbhKJDE2TwyfQ+Aet1j02LyER9y ayAE/BXpBeABAWvI+2rxAATOXsGvjWBzqQVFKhGWGWLUAj+RWj6wsOMW8EMW+EqBj6jjjj9b5EY uQLJfvkxyF9ysAm5cQ+ggq77hszxq8YbQWMWwhE3lwrwXIAgJRe1az/q28iPvCpeJuY/QEMGJ7J ZMI62YUQ9tTtiuLAYjq4KmHJDlIrHIPjeCiH2O6VNhYN0= X-Received: by 2002:a17:90b:3f44:b0:340:99fd:9676 with SMTP id 98e67ed59e1d1-35367013c64mr817474a91.10.1769128346845; Thu, 22 Jan 2026 16:32:26 -0800 (PST) Received: from tehuang-Alienware-m16-R2.. ([50.47.240.160]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-353355e1161sm3420415a91.17.2026.01.22.16.32.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jan 2026 16:32:26 -0800 (PST) From: Michael Huang To: gregkh@linuxfoundation.org Cc: straube.linux@gmail.com, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Huang Subject: [PATCH] staging: rtl8723bs: fix coding style issues in rtw_mlme.c Date: Thu, 22 Jan 2026 16:32:05 -0800 Message-ID: <20260123003205.33898-1-tehsiu.huang@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This patch fixes several checkpatch.pl issues: 1. Remove redundant else after break/return. 2. Remove unnecessary boolean comparisons (=3D=3D true/false). 3. Fix trailing whitespaces and overly deep indentation. Signed-off-by: Michael Huang --- drivers/staging/rtl8723bs/core/rtw_mlme.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rt= l8723bs/core/rtw_mlme.c index 98704179ad35..71a0efe49bdd 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -710,8 +710,8 @@ void rtw_surveydone_event_callback(struct adapter *adap= ter, u8 *pbuf) rtw_set_signal_stat_timer(&adapter->recvpriv); =20 if (pmlmepriv->to_join) { - if ((check_fwstate(pmlmepriv, WIFI_ADHOC_STATE) =3D=3D true)) { - if (check_fwstate(pmlmepriv, _FW_LINKED) =3D=3D false) { + if (check_fwstate(pmlmepriv, WIFI_ADHOC_STATE)) { + if (!check_fwstate(pmlmepriv, _FW_LINKED)) { set_fwstate(pmlmepriv, _FW_UNDER_LINKING); =20 if (rtw_select_and_join_from_scanned_queue(pmlmepriv) =3D=3D _SUCCESS)= { @@ -1206,10 +1206,9 @@ void rtw_joinbss_event_prehandle(struct adapter *ada= pter, u8 *pbuf) rtw_free_stainfo(adapter, pcur_sta); =20 ptarget_wlan =3D rtw_find_network(&pmlmepriv->scanned_queue, pnetwork= ->network.mac_address); - if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) =3D=3D true) { - if (ptarget_wlan) - ptarget_wlan->fixed =3D true; - } + if (check_fwstate(pmlmepriv, WIFI_STATION_STATE) && + ptarget_wlan) + ptarget_wlan->fixed =3D true; } =20 } else { @@ -1560,10 +1559,6 @@ void _rtw_join_timeout_handler(struct timer_list *t) do_join_r =3D rtw_do_join(adapter); if (do_join_r !=3D _SUCCESS) continue; - - break; - } else { - rtw_indicate_disconnect(adapter); break; } } @@ -2018,7 +2013,7 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *= in_ie, u8 *out_ie, uint in_ return ielength; } =20 -/* Ported from 8185: IsInPreAuthKeyList().=20 +/* Ported from 8185: IsInPreAuthKeyList(). * (Renamed from SecIsInPreAuthKeyList(), 2006-10-13.) * Added by Annie, 2006-05-07. * --=20 2.43.0