From nobody Wed Feb 11 02:14:22 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A503737754D for ; Fri, 23 Jan 2026 07:13:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769152417; cv=none; b=fzIhmwtE8lj9ytIxB5IdI6UR7oNE8eSr7cCW8Any+l9eb8HLDrtW+77QMofcyl9Bx2T8apRl8gUgIQ46988K8PtC6o8cyotsofvkPzlS7PilRh5+Sfz9gXgrg2C7jaEP92VpgXfMZh7F9yaqaKPn6SkUZp/0tr2zS2WM16somf8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769152417; c=relaxed/simple; bh=FAydTEuSpolIPbgdCzPABbxgas2Q93+RqfmxMnmHLg0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=L57CqlV+wb4uIlTM168KK/tsbGWI4OVmuUJ20n5/x1F3nz4aTTinTyp8u1YkOqqYg62UbauC4gUFCrKt3OYrt3TUThNqX/AW9Mmd/m6Fe22gt6bOaA5iPHW+QTTniK5itGrqsbCNySJ/qaDMn6/merf53XNszJKlqE/FywXV1vY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=V256o5J4; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GUsxnhOl; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="V256o5J4"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GUsxnhOl" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60N68RNF3503291 for ; Fri, 23 Jan 2026 07:13:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= dFEJqMm3Lu8V6b4IeyfhRQweFSAUcJ6M7eJtDdl84KU=; b=V256o5J4rtn3+PgF c8cDmbUnmJnTGKIkqWNS7om+1oR7fMTOOJBGAnUFt+bFn+k1AzFAkALmqr5QME6d OOwiYgLFSagAAaWzP1vauMETQOHz2LfbPvr5vQa/tTxUJ+aeRYGpINmggiqRK1bs HbEon9Up/Ej8h+p9dTcaYhdYEVWWn6tfPVY/DEqXwS4ENfYsOAyn8s+XNMt1y0+o xmE0P/jhI4/oKnNcnYtzDKTWPyi9JdI1H9G/cTyNB0wC/OxkDZh3wdjqUahPjxo+ 0Mw4vD5GPCAlZZ6LdfNTMkQYeRzRvqRefVx7Q1RvhK8bJl1QmZdtA6MucssKhsBy p378ow== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bus98242h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 23 Jan 2026 07:13:33 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a0b7eb0a56so17248235ad.1 for ; Thu, 22 Jan 2026 23:13:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769152412; x=1769757212; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=dFEJqMm3Lu8V6b4IeyfhRQweFSAUcJ6M7eJtDdl84KU=; b=GUsxnhOl2aQEM3EDMyQVAy9/MbkjYyYt6QQMd8F0/ram4Nb+sWclmmUlL8kcJZAR2w 5BHBy1OtPwzQHEiUZteEYb9Z/yeiY3nfZR5P4/EEtPCYKXcKZ/IB+3jlY3HChQ6Q1ArG r3ZulT66pHmf5BRzZu8asJKXRmE5vIWskgpUOjPfCrvSGHmEYZig8fXzBYK7gCqytznO UrBC8W9FacbpBFbVqxSJaZlA275Lm4EKbnIY22R5632wB3PR3sN1CtrT8Dgif10zUM/o mTAjjhPQoqtSxBKxUP0uIu41OuvTK/17YA68RJkGVpHbpu6gFYODlNtcCV1tVq5gGMAQ lgKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769152412; x=1769757212; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=dFEJqMm3Lu8V6b4IeyfhRQweFSAUcJ6M7eJtDdl84KU=; b=AcIJyQlguGl7/RZgRyXUUC0MrO/MaT5YkQjVjUvMgVFL/wQVMoRUT/HgTDhDJ0Xg3w 0cXTZmIb6CkWTOUFSFkYS7Y3yIeO9nqiJ/cKMqZjBRTq4q7XrF31u1rXbOKb3BwmqVPH NZSYadBlA7KfRr9EnLUG6jkgvpknOD1cl9wZ0LWijLHfdc/8C6NI7j2m9IaCN88rrF/a 0ue5/4FSbikFwErt7aLqSY3FTWbu52DZvY0g0DANC0HizBXpm3SvQBaHUq4ncqe+LoB3 KM5R2pWO/LwLNrECOVj5OqP7prlIKRkPF4Z2lpPJYEIkHXjIMva+m+31X1YNSwjzkPLS FeJw== X-Forwarded-Encrypted: i=1; AJvYcCUcQcXwqXFz12Tj9/NJz5GjbbGrg40DJTw3MgGuM6SO0ZL9gdpOD3Ejv5kEmFjSxiPrdgXyn5LDpJonG2s=@vger.kernel.org X-Gm-Message-State: AOJu0Yze462yeLrVoFFKhT9Efdks3MWDFilos3NvBlMfxx69QNjEBiCM Znj2wDK1l/P/1ojh5krsnRzgaH6JwKhdtgC6quP0GWkjepJLP0KHUru1AII9i/ZbTAiaYCUCtsF zKb7fbcmMNJnzvYoA/1UfvPiRL7Nq79nOQlXi3bZCXRdyOgAEscln5Io962sF4uwMXIu38JTnL7 A= X-Gm-Gg: AZuq6aIgUS897TgQ1rq3oM5XDAtN0wWxphImWGSPz8upJob6dOUbCxiErQ8kXcrgiKW 9dNcR4Pnt4W70PjFv2l4+OBPki2ndyGFpq7mu+LGxGc7ItlbaKqatnImegaH1k3dNMDk2M7OIo0 wEWZjF8P48hw2CMgFEvYHZVwP3HWSnz6lFgKCKWAnvqqqhkvniHcUcOhIwPRHv9DOuhJCo4FRmV Psp8mXVgzBWUHtWn9PdISQBDn+z4ltLi12ePmKohORysWCVsjHiWlRYdyLniUdXGdP5Qqmzb6fE aNOQwjpuLYZl+UPDbQTk+idXHyBWkmDKgIlkQTRRal0cykLzLioPL6yt04RnFADCtiwE4rQQBMI gP7awomGoemLpzGk3gsh+IE9T+rGsEeN4h7w= X-Received: by 2002:a17:903:1c8:b0:2a0:cb8d:2edc with SMTP id d9443c01a7336-2a7fe55a646mr17345495ad.13.1769152412400; Thu, 22 Jan 2026 23:13:32 -0800 (PST) X-Received: by 2002:a17:903:1c8:b0:2a0:cb8d:2edc with SMTP id d9443c01a7336-2a7fe55a646mr17345215ad.13.1769152411877; Thu, 22 Jan 2026 23:13:31 -0800 (PST) Received: from hu-hdev-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a802f978b8sm10979795ad.46.2026.01.22.23.13.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jan 2026 23:13:31 -0800 (PST) From: Harshal Dev Date: Fri, 23 Jan 2026 12:41:35 +0530 Subject: [PATCH 11/11] soc: qcom: ice: Add explicit power-domain and clock voting calls for ICE Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260123-qcom_ice_power_and_clk_vote-v1-11-e9059776f85c@qti.qualcomm.com> References: <20260123-qcom_ice_power_and_clk_vote-v1-0-e9059776f85c@qti.qualcomm.com> In-Reply-To: <20260123-qcom_ice_power_and_clk_vote-v1-0-e9059776f85c@qti.qualcomm.com> To: Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Abel Vesa , cros-qcom-dts-watchers@chromium.org Cc: Brian Masney , Neeraj Soni , Gaurav Kashyap , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Harshal Dev X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769152357; l=2522; i=hdev@qti.qualcomm.com; s=20251124; h=from:subject:message-id; bh=FAydTEuSpolIPbgdCzPABbxgas2Q93+RqfmxMnmHLg0=; b=ad08EUFi/SNxt8P3OUY3DK1VxPif88I6qLpdUMVODH5gqLymjIDhedZVOx9bmmaCmvtGXDYkN 2h/SiV1SNPUDITiIf7UlCQUEfkG+pYBOVK+g9uzGvyBSHXpzRRVaoNp X-Developer-Key: i=hdev@qti.qualcomm.com; a=ed25519; pk=SHJ8K4SglF5t7KmfMKXl6Mby40WczSeLs4Qus7yFO7c= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIzMDA1NCBTYWx0ZWRfXwy/QqNkFmwHd PVF4bu8BXrJDTYGrYv7FbVJjqZ5oZGb0CgfF/vARMTKpEjxCidsuau5milrsR12zyXonud/wuoZ baQdI1JPQKuhdxtBrw7O0Qh1pDY+v9AGcOy38Y97JN97V+lG+1Qe6rjhnz1A9Qxwe0NiR5WxE8q armOYMgxUrM2GPElZFbGVZmnhQFRbxQzUXrLaw68UFhXSXSQdlhk02kC3G5Y2QtwB0/DfRd0zqn OgyJ5zH7N/gZgDHltPpd+6OpXEzwyvJM53WpYwYoUl1xJumFS9SMDBCETwtZICFNrRR8HEnRzfH rLy5Z4KokgmFzIfZeWjzthZuOWJ3thSAgtSQxvRu7CbDSJWUMzToVbY3SAuxAQqSM0Xvv0+kdXA Jvnnz3Rl39ifqx5AtcCcx9TOl3YDLB8bT7PtClRJHYcbzHP9Z504FoBlUNZX9fP81YNCR5SvgDf Zf2htppFxr3ozfKIVpQ== X-Authority-Analysis: v=2.4 cv=JuX8bc4C c=1 sm=1 tr=0 ts=69731f9d cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=DGDWbsvPyNGGEFbMfx4A:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: vzpAZxJqhnugNO9TyMq0po14EeOy6Zm8 X-Proofpoint-ORIG-GUID: vzpAZxJqhnugNO9TyMq0po14EeOy6Zm8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-22_06,2026-01-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 priorityscore=1501 spamscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 clxscore=1015 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601230054 Since Qualcomm inline-crypto engine (ICE) is now a dedicated driver de-coupled from the QCOM UFS driver, it should explicitly vote for it's needed resources during probe, specifically the UFS_PHY_GDSC power-domain and the 'core' and 'iface' clocks. Also updated the suspend and resume callbacks to handle votes on these resources. Signed-off-by: Harshal Dev --- drivers/soc/qcom/ice.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c index b203bc685cad..4b50d05ca02a 100644 --- a/drivers/soc/qcom/ice.c +++ b/drivers/soc/qcom/ice.c @@ -16,6 +16,8 @@ #include #include #include +#include +#include =20 #include =20 @@ -108,6 +110,7 @@ struct qcom_ice { void __iomem *base; =20 struct clk *core_clk; + struct clk *iface_clk; bool use_hwkm; bool hwkm_init_complete; u8 hwkm_version; @@ -310,12 +313,20 @@ int qcom_ice_resume(struct qcom_ice *ice) struct device *dev =3D ice->dev; int err; =20 + pm_runtime_get_sync(dev); err =3D clk_prepare_enable(ice->core_clk); if (err) { dev_err(dev, "failed to enable core clock (%d)\n", err); return err; } + + err =3D clk_prepare_enable(ice->iface_clk); + if (err) { + dev_err(dev, "failed to enable iface clock (%d)\n", + err); + return err; + } qcom_ice_hwkm_init(ice); return qcom_ice_wait_bist_status(ice); } @@ -323,7 +334,9 @@ EXPORT_SYMBOL_GPL(qcom_ice_resume); =20 int qcom_ice_suspend(struct qcom_ice *ice) { + clk_disable_unprepare(ice->iface_clk); clk_disable_unprepare(ice->core_clk); + pm_runtime_put_sync(ice->dev); ice->hwkm_init_complete =3D false; =20 return 0; @@ -584,6 +597,10 @@ static struct qcom_ice *qcom_ice_create(struct device = *dev, if (IS_ERR(engine->core_clk)) return ERR_CAST(engine->core_clk); =20 + engine->iface_clk =3D devm_clk_get_enabled(dev, "iface_clk"); + if (IS_ERR(engine->iface_clk)) + return ERR_CAST(engine->iface_clk); + if (!qcom_ice_check_supported(engine)) return ERR_PTR(-EOPNOTSUPP); =20 @@ -725,6 +742,9 @@ static int qcom_ice_probe(struct platform_device *pdev) return PTR_ERR(base); } =20 + devm_pm_runtime_enable(&pdev->dev); + pm_runtime_get_sync(&pdev->dev); + engine =3D qcom_ice_create(&pdev->dev, base); if (IS_ERR(engine)) return PTR_ERR(engine); --=20 2.34.1