From nobody Sun Feb 8 15:53:28 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3AF6342C80; Fri, 23 Jan 2026 11:31:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769167892; cv=none; b=nzAmu/oGUAWSE+Fd/YDrzxlLwTAGS6xlVn9GcJz6Lqvcnt8OPvi4dmfg7tBX9LAFSYiH8wRGNmk4s777pcMXWbGxXxpmEBi9qmu+xLlIqMrroR/BhdyQDsED8X5IZrhmyZd1ufdkYK+gj+3Jxwn3PKCHL2tI6mzFKr10yuuhLRg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769167892; c=relaxed/simple; bh=I+GVZKcx+MBYS1PuUVaF2l26z5GWB2GsAag9y9Lqrb0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=U5ZoYaeAxjiVj2j73SWdE3CvvWt66InJ1WgVVTJpPX6/4+PyjzA7ClRjj3mdxdn2WorcSbll7SauKxeBMZCLQEWVMXZAMzIAWABCK8QlBgSWNjnARx1MCH5lQ+7a49NEjLKY/ZdGdZSb4n4hjOGc7fjef1CK2yrGJWmuGG5goQA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jC7l93+a; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jC7l93+a" Received: by smtp.kernel.org (Postfix) with ESMTPS id 52ADBC2BC86; Fri, 23 Jan 2026 11:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769167892; bh=I+GVZKcx+MBYS1PuUVaF2l26z5GWB2GsAag9y9Lqrb0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=jC7l93+aFbKEamIHQywtZW2r2l/k9wiQHB6Cn8V7cvo6kRmhAU6/aDJDTqqBMtwy4 orI6zs2cs7dMc1x+rIkNs+ver88aThjklPUZSxNA8lByKyAah1F7HOEFqaQaiFgXz9 1rDKOsR1FRfz0umqFvh0rsJRFxejq0hkUOGZzqd9wSsg8Q31ddvGTaoiEDYeayLxJr YZc+Ajvkg3eNDuV45sgRIFtUGae484AbrLuJm21D3REZIp37yGKGXWiDMJ+HWOb7Ab i3omf03OQ2xBZMHOECGZSi8MF/UJZau2XekBaTcPm+Zhl0m2oPdFei0wWEjq87GsHq H6X8boe4301Jg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49818D72379; Fri, 23 Jan 2026 11:31:32 +0000 (UTC) From: Maud Spierings via B4 Relay Date: Fri, 23 Jan 2026 12:31:30 +0100 Subject: [PATCH v7 1/4] dt-bindings: backlight: Add max25014 support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260123-max25014-v7-1-15e504b9acc7@gocontroll.com> References: <20260123-max25014-v7-0-15e504b9acc7@gocontroll.com> In-Reply-To: <20260123-max25014-v7-0-15e504b9acc7@gocontroll.com> To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Liam Girdwood , Mark Brown Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Maud Spierings X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769167891; l=3636; i=maudspierings@gocontroll.com; s=20250214; h=from:subject:message-id; bh=ZOQsl8OAiJDWwB3K+E4EP5ngBND6aBuPtx4fJEq8WZA=; b=pbAsLA7HaokmGS2MoTnWAZR9eNOgYVunL9bwZ6CEwq8mJr7yBqsDHh6YlJXJ2Y6dNHGPYLX2d ksZSkvy3C/PD+v5LNVaOo//Ar0Ln0bhEG7At/mxePpLmworMFnuF2l4 X-Developer-Key: i=maudspierings@gocontroll.com; a=ed25519; pk=7chUb8XpaTQDvWhzTdHC0YPMkTDloELEC7q94tOUyPg= X-Endpoint-Received: by B4 Relay for maudspierings@gocontroll.com/20250214 with auth_id=341 X-Original-From: Maud Spierings Reply-To: maudspierings@gocontroll.com From: Maud Spierings The Maxim MAX25014 is a 4-channel automotive grade backlight driver IC with integrated boost controller. Signed-off-by: Maud Spierings Reviewed-by: Rob Herring (Arm) --- In the current implementation the control registers for channel 1, control all channels. So only one led subnode with led-sources is supported right now. If at some point the driver functionality is expanded the bindings can be easily extended with it. --- .../bindings/leds/backlight/maxim,max25014.yaml | 91 ++++++++++++++++++= ++++ MAINTAINERS | 5 ++ 2 files changed, 96 insertions(+) diff --git a/Documentation/devicetree/bindings/leds/backlight/maxim,max2501= 4.yaml b/Documentation/devicetree/bindings/leds/backlight/maxim,max25014.ya= ml new file mode 100644 index 000000000000..c499e6224a8f --- /dev/null +++ b/Documentation/devicetree/bindings/leds/backlight/maxim,max25014.yaml @@ -0,0 +1,91 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/backlight/maxim,max25014.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Maxim max25014 backlight controller + +maintainers: + - Maud Spierings + +properties: + compatible: + enum: + - maxim,max25014 + + reg: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + + default-brightness: + minimum: 0 + maximum: 100 + default: 50 + + enable-gpios: + maxItems: 1 + + interrupts: + maxItems: 1 + + power-supply: + description: Regulator which controls the boost converter input rail. + + pwms: + maxItems: 1 + + maxim,iset: + $ref: /schemas/types.yaml#/definitions/uint32 + maximum: 15 + default: 11 + description: + Value of the ISET field in the ISET register. This controls the curr= ent + scale of the outputs, a higher number means more current. + + maxim,strings: + $ref: /schemas/types.yaml#/definitions/uint32-array + description: + A 4-bit bitfield that describes which led strings to turn on. + minItems: 4 + maxItems: 4 + items: + maximum: 1 + default: + [1 1 1 1] + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + #include + #include + + i2c { + #address-cells =3D <1>; + #size-cells =3D <0>; + + backlight@6f { + compatible =3D "maxim,max25014"; + reg =3D <0x6f>; + #address-cells =3D <1>; + #size-cells =3D <0>; + default-brightness =3D <50>; + enable-gpios =3D <&gpio1 4 GPIO_ACTIVE_HIGH>; + interrupt-parent =3D <&gpio1>; + interrupts =3D <2 IRQ_TYPE_EDGE_FALLING>; + power-supply =3D <®_backlight>; + pwms =3D <&pwm1>; + maxim,iset =3D <7>; + maxim,strings =3D <1 1 1 0>; + }; + }; diff --git a/MAINTAINERS b/MAINTAINERS index 9b1b87d08fac..eb248f4634ac 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15515,6 +15515,11 @@ F: Documentation/userspace-api/media/drivers/max21= 75.rst F: drivers/media/i2c/max2175* F: include/uapi/linux/max2175.h =20 +MAX25014 BACKLIGHT DRIVER +M: Maud Spierings +S: Maintained +F: Documentation/devicetree/bindings/leds/backlight/maxim,max25014.yaml + MAX31335 RTC DRIVER M: Antoniu Miclaus L: linux-rtc@vger.kernel.org --=20 2.52.0 From nobody Sun Feb 8 15:53:28 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99996340A6C; Fri, 23 Jan 2026 11:31:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769167892; cv=none; b=m5VgFT4I8ZwNiROmrBKr6RtNmMrR10RWYIS4pUg0JI8RQ/EkL+nOeYwlUOXSXkzI2t3GrSs7uZl7rARxlJpjQs6gGLVe+1Oh1L21vhiTS/d+18xCUK/7p4E4mlBptszJS4fsUIpUo9QKsQLdyJAVdFRiXXJfgT3nZm7DqrTatu8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769167892; c=relaxed/simple; bh=bs9XdERc7ElI1VxNXIabbjqTfOvsXtw87eNiJK+nM/I=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bS0WHgioXpZ3c2hWsPEfiZcC0PxNpTjllLllMR0Xn3tBCYaqErVea6HpjxzVJLiS9dQ+7MkGKubTDzonjuFtO4UmNSyNqpWVXQ+YvqoiN65dzb0tTTF+o6+7NHESwvYHnEj8+N3zrTMMFDNEepJBoZxROgFfAJkHGM3w3yginFE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=HxWMbE7p; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="HxWMbE7p" Received: by smtp.kernel.org (Postfix) with ESMTPS id 64A6AC2BC9E; Fri, 23 Jan 2026 11:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769167892; bh=bs9XdERc7ElI1VxNXIabbjqTfOvsXtw87eNiJK+nM/I=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=HxWMbE7p/2Erwe+7eKgdyu6xwtOwsIrdsUnw+YIH3STpOue+dzW2PZwRw+m2+2Ft+ poi/bWdXkBohXXpkPqHBC1vmBHREttaSfvOQ2Dif8NuAfbyXUL/zYUkEefFcaMn3Zh oLu89xC4EdHiSzeT12O/k1+qux+hDxcxJJGN86taPVnHgKuJ//dcwl5GP7DxCHOSjW qNnZEe+PL8DUvtilvdGGB1uwJw45BbEnR/5AjASOEpiu3svSOL2BehbIzlfvfM70xa Xe1Po03QVIKhhuxQJu12/CNEZMP6mevstfeCGkWLpP4LjZ1KEqbO3zqcjrFCm1T75+ oYL7yEhbV3UOg== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A0CED72371; Fri, 23 Jan 2026 11:31:32 +0000 (UTC) From: Maud Spierings via B4 Relay Date: Fri, 23 Jan 2026 12:31:31 +0100 Subject: [PATCH v7 2/4] backlight: add max25014atg backlight Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260123-max25014-v7-2-15e504b9acc7@gocontroll.com> References: <20260123-max25014-v7-0-15e504b9acc7@gocontroll.com> In-Reply-To: <20260123-max25014-v7-0-15e504b9acc7@gocontroll.com> To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Liam Girdwood , Mark Brown Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Maud Spierings X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769167891; l=13525; i=maudspierings@gocontroll.com; s=20250214; h=from:subject:message-id; bh=U9qSExVUHQ2JjF6N8ViFOWKBfGCsiMZGq9zTgYXdIIY=; b=70auyRbqNvedGnUYAJLz5vMlYaZAl2XXo5Q6+A3V8eZW1B/7HFLXMhsdYT8iMZIdfleKsDdHm Vxq0hYd9uKkBXTH2RKhF8/TgkI40iJPThlTAeVYxag2xQGPFwtyU8TU X-Developer-Key: i=maudspierings@gocontroll.com; a=ed25519; pk=7chUb8XpaTQDvWhzTdHC0YPMkTDloELEC7q94tOUyPg= X-Endpoint-Received: by B4 Relay for maudspierings@gocontroll.com/20250214 with auth_id=341 X-Original-From: Maud Spierings Reply-To: maudspierings@gocontroll.com From: Maud Spierings The Maxim MAX25014 is a 4-channel automotive grade backlight driver IC with integrated boost controller. Signed-off-by: Maud Spierings --- MAINTAINERS | 1 + drivers/video/backlight/Kconfig | 7 + drivers/video/backlight/Makefile | 1 + drivers/video/backlight/max25014.c | 377 +++++++++++++++++++++++++++++++++= ++++ 4 files changed, 386 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index eb248f4634ac..346a8ede3f71 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15519,6 +15519,7 @@ MAX25014 BACKLIGHT DRIVER M: Maud Spierings S: Maintained F: Documentation/devicetree/bindings/leds/backlight/maxim,max25014.yaml +F: drivers/video/backlight/max25014.c =20 MAX31335 RTC DRIVER M: Antoniu Miclaus diff --git a/drivers/video/backlight/Kconfig b/drivers/video/backlight/Kcon= fig index a7a3fbaf7c29..6cd3a1673511 100644 --- a/drivers/video/backlight/Kconfig +++ b/drivers/video/backlight/Kconfig @@ -282,6 +282,13 @@ config BACKLIGHT_DA9052 help Enable the Backlight Driver for DA9052-BC and DA9053-AA/Bx PMICs. =20 +config BACKLIGHT_MAX25014 + tristate "Backlight driver for the Maxim MAX25014 chip" + depends on I2C + select REGMAP_I2C + help + If you are using a MAX25014 chip as a backlight driver say Y to enable = it. + config BACKLIGHT_MAX8925 tristate "Backlight driver for MAX8925" depends on MFD_MAX8925 diff --git a/drivers/video/backlight/Makefile b/drivers/video/backlight/Mak= efile index 794820a98ed4..21c8313cfb12 100644 --- a/drivers/video/backlight/Makefile +++ b/drivers/video/backlight/Makefile @@ -47,6 +47,7 @@ obj-$(CONFIG_BACKLIGHT_LOCOMO) +=3D locomolcd.o obj-$(CONFIG_BACKLIGHT_LP855X) +=3D lp855x_bl.o obj-$(CONFIG_BACKLIGHT_LP8788) +=3D lp8788_bl.o obj-$(CONFIG_BACKLIGHT_LV5207LP) +=3D lv5207lp.o +obj-$(CONFIG_BACKLIGHT_MAX25014) +=3D max25014.o obj-$(CONFIG_BACKLIGHT_MAX8925) +=3D max8925_bl.o obj-$(CONFIG_BACKLIGHT_MP3309C) +=3D mp3309c.o obj-$(CONFIG_BACKLIGHT_MT6370) +=3D mt6370-backlight.o diff --git a/drivers/video/backlight/max25014.c b/drivers/video/backlight/m= ax25014.c new file mode 100644 index 000000000000..3ee45617261f --- /dev/null +++ b/drivers/video/backlight/max25014.c @@ -0,0 +1,377 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Backlight driver for Maxim MAX25014 + * + * Copyright (C) 2025 GOcontroll B.V. + * Author: Maud Spierings + */ + +#include +#include +#include +#include +#include + +#define MAX25014_ISET_DEFAULT_100 11 +#define MAX_BRIGHTNESS 100 +#define MIN_BRIGHTNESS 0 +#define TON_MAX 130720 /* @153Hz */ +#define TON_STEP 1307 /* @153Hz */ +#define TON_MIN 0 + +#define MAX25014_DEV_ID 0x00 +#define MAX25014_REV_ID 0x01 +#define MAX25014_ISET 0x02 +#define MAX25014_IMODE 0x03 +#define MAX25014_TON1H 0x04 +#define MAX25014_TON1L 0x05 +#define MAX25014_TON2H 0x06 +#define MAX25014_TON2L 0x07 +#define MAX25014_TON3H 0x08 +#define MAX25014_TON3L 0x09 +#define MAX25014_TON4H 0x0A +#define MAX25014_TON4L 0x0B +#define MAX25014_TON_1_4_LSB 0x0C +#define MAX25014_SETTING 0x12 +#define MAX25014_DISABLE 0x13 +#define MAX25014_BSTMON 0x14 +#define MAX25014_IOUT1 0x15 +#define MAX25014_IOUT2 0x16 +#define MAX25014_IOUT3 0x17 +#define MAX25014_IOUT4 0x18 +#define MAX25014_OPEN 0x1B +#define MAX25014_SHORTGND 0x1C +#define MAX25014_SHORTED_LED 0x1D +#define MAX25014_MASK 0x1E +#define MAX25014_DIAG 0x1F + +#define MAX25014_ISET_ENA BIT(5) +#define MAX25014_ISET_PSEN BIT(4) +#define MAX25014_IMODE_HDIM BIT(2) +#define MAX25014_SETTING_FPWM GENMASK(6, 4) +#define MAX25014_DISABLE_DIS_MASK GENMASK(3, 0) +#define MAX25014_DIAG_OT BIT(0) +#define MAX25014_DIAG_OTW BIT(1) +#define MAX25014_DIAG_HW_RST BIT(2) +#define MAX25014_DIAG_BSTOV BIT(3) +#define MAX25014_DIAG_BSTUV BIT(4) +#define MAX25014_DIAG_IREFOOR BIT(5) + +struct max25014 { + struct i2c_client *client; + struct backlight_device *bl; + struct regmap *regmap; + struct gpio_desc *enable; + uint32_t iset; + uint8_t strings_mask; +}; + +static const struct regmap_config max25014_regmap_config =3D { + .reg_bits =3D 8, + .val_bits =3D 8, + .max_register =3D MAX25014_DIAG, +}; + +static int max25014_initial_power_state(struct max25014 *maxim) +{ + uint32_t val; + int ret; + + ret =3D regmap_read(maxim->regmap, MAX25014_ISET, &val); + if (ret) + return ret; + + return val & MAX25014_ISET_ENA ? BACKLIGHT_POWER_ON : BACKLIGHT_POWER_OFF; +} + +static int max25014_check_errors(struct max25014 *maxim) +{ + uint32_t val; + uint8_t i; + int ret; + + ret =3D regmap_read(maxim->regmap, MAX25014_OPEN, &val); + if (ret) + return ret; + if (val) { + dev_err(&maxim->client->dev, "Open led strings detected on:\n"); + for (i =3D 0; i < 4; i++) { + if (val & 1 << i) + dev_err(&maxim->client->dev, "string %d\n", i + 1); + } + return -EIO; + } + + ret =3D regmap_read(maxim->regmap, MAX25014_SHORTGND, &val); + if (ret) + return ret; + if (val) { + dev_err(&maxim->client->dev, "Short to ground detected on:\n"); + for (i =3D 0; i < 4; i++) { + if (val & 1 << i) + dev_err(&maxim->client->dev, "string %d\n", i + 1); + } + return -EIO; + } + + ret =3D regmap_read(maxim->regmap, MAX25014_SHORTED_LED, &val); + if (ret) + return ret; + if (val) { + dev_err(&maxim->client->dev, "Shorted led detected on:\n"); + for (i =3D 0; i < 4; i++) { + if (val & 1 << i) + dev_err(&maxim->client->dev, "string %d\n", i + 1); + } + return -EIO; + } + + ret =3D regmap_read(maxim->regmap, MAX25014_DIAG, &val); + if (ret) + return ret; + /* + * The HW_RST bit always starts at 1 after power up. + * It is reset on first read, does not indicate an error. + */ + if (val && val !=3D MAX25014_DIAG_HW_RST) { + if (val & MAX25014_DIAG_OT) + dev_err(&maxim->client->dev, + "Overtemperature shutdown\n"); + if (val & MAX25014_DIAG_OTW) + dev_err(&maxim->client->dev, + "Chip is getting too hot (>125C)\n"); + if (val & MAX25014_DIAG_BSTOV) + dev_err(&maxim->client->dev, + "Boost converter overvoltage\n"); + if (val & MAX25014_DIAG_BSTUV) + dev_err(&maxim->client->dev, + "Boost converter undervoltage\n"); + if (val & MAX25014_DIAG_IREFOOR) + dev_err(&maxim->client->dev, "IREF out of range\n"); + return -EIO; + } + return 0; +} + +/* + * 1. disable unused strings + * 2. set dim mode + * 3. set setting register + * 4. enable the backlight + */ +static int max25014_configure(struct max25014 *maxim, int initial_state) +{ + uint32_t val; + int ret; + + ret =3D regmap_read(maxim->regmap, MAX25014_DISABLE, &val); + if (ret) + return ret; + + /* + * Strings can only be disabled when MAX25014_ISET_ENA =3D=3D 0, check if + * it needs to be changed at all to prevent the backlight flashing when + * it is configured correctly by the bootloader + */ + if (!((val & MAX25014_DISABLE_DIS_MASK) =3D=3D maxim->strings_mask)) { + if (initial_state =3D=3D BACKLIGHT_POWER_ON) { + ret =3D regmap_write(maxim->regmap, MAX25014_ISET, 0); + if (ret) + return ret; + } + ret =3D regmap_write(maxim->regmap, MAX25014_DISABLE, maxim->strings_mas= k); + if (ret) + return ret; + } + + ret =3D regmap_write(maxim->regmap, MAX25014_IMODE, MAX25014_IMODE_HDIM); + if (ret) + return ret; + + ret =3D regmap_read(maxim->regmap, MAX25014_SETTING, &val); + if (ret) + return ret; + + ret =3D regmap_write(maxim->regmap, MAX25014_SETTING, + val & ~MAX25014_SETTING_FPWM); + if (ret) + return ret; + + return regmap_write(maxim->regmap, MAX25014_ISET, + maxim->iset | MAX25014_ISET_ENA | + MAX25014_ISET_PSEN); +} + +static int max25014_update_status(struct backlight_device *bl_dev) +{ + struct max25014 *maxim =3D bl_get_data(bl_dev); + uint32_t reg; + int ret; + + reg =3D TON_STEP * backlight_get_brightness(bl_dev); + + /* + * 18 bit number lowest, 2 bits in first register, + * next lowest 8 in the L register, next 8 in the H register + * Seemingly setting the strength of only one string controls all of + * them, individual settings don't affect the outcome. + */ + ret =3D regmap_write(maxim->regmap, MAX25014_TON_1_4_LSB, reg & 0b0000001= 1); + if (ret !=3D 0) + return ret; + ret =3D regmap_write(maxim->regmap, MAX25014_TON1L, (reg >> 2) & 0b111111= 11); + if (ret !=3D 0) + return ret; + return regmap_write(maxim->regmap, MAX25014_TON1H, (reg >> 10) & 0b111111= 11); +} + +static const struct backlight_ops max25014_bl_ops =3D { + .options =3D BL_CORE_SUSPENDRESUME, + .update_status =3D max25014_update_status, +}; + +static int max25014_parse_dt(struct max25014 *maxim, + uint32_t *initial_brightness) +{ + struct device *dev =3D &maxim->client->dev; + struct device_node *node =3D dev->of_node; + uint32_t strings[4]; + int res, i; + + res =3D of_property_count_u32_elems(node, "maxim,strings"); + if (res =3D=3D 4) { + of_property_read_u32_array(node, "maxim,strings", strings, 4); + for (i =3D 0; i < 4; i++) { + if (strings[i] =3D=3D 0) + maxim->strings_mask |=3D 1 << i; + } + } else { + maxim->strings_mask =3D 0; + } + + *initial_brightness =3D 50U; + of_property_read_u32(node, "default-brightness", initial_brightness); + + maxim->iset =3D MAX25014_ISET_DEFAULT_100; + of_property_read_u32(node, "maxim,iset", &maxim->iset); + + if (maxim->iset > 15) + return dev_err_probe(dev, -EINVAL, + "Invalid iset, should be a value from 0-15, entered was %d\n", + maxim->iset); + + if (*initial_brightness > 100) + return dev_err_probe(dev, -EINVAL, + "Invalid initial brightness, should be a value from 0-100, entere= d was %d\n", + *initial_brightness); + + return 0; +} + +static int max25014_probe(struct i2c_client *cl) +{ + const struct i2c_device_id *id =3D i2c_client_get_device_id(cl); + struct backlight_properties props; + uint32_t initial_brightness =3D 50; + struct backlight_device *bl; + struct max25014 *maxim; + int ret; + + maxim =3D devm_kzalloc(&cl->dev, sizeof(struct max25014), GFP_KERNEL); + if (!maxim) + return -ENOMEM; + + maxim->client =3D cl; + + ret =3D max25014_parse_dt(maxim, &initial_brightness); + if (ret) + return ret; + + ret =3D devm_regulator_get_enable(&maxim->client->dev, "power"); + if (ret) + return dev_err_probe(&maxim->client->dev, ret, + "failed to get power-supply"); + + maxim->enable =3D devm_gpiod_get_optional(&maxim->client->dev, "enable", + GPIOD_OUT_HIGH); + if (IS_ERR(maxim->enable)) + return dev_err_probe(&maxim->client->dev, PTR_ERR(maxim->enable), + "failed to get enable gpio\n"); + + /* Datasheet Electrical Characteristics tSTARTUP 2ms */ + fsleep(2000); + + maxim->regmap =3D devm_regmap_init_i2c(cl, &max25014_regmap_config); + if (IS_ERR(maxim->regmap)) + return dev_err_probe(&maxim->client->dev, PTR_ERR(maxim->regmap), + "failed to initialize the i2c regmap\n"); + + i2c_set_clientdata(cl, maxim); + + ret =3D max25014_check_errors(maxim); + if (ret) /* error is already reported in the above function */ + return ret; + + ret =3D max25014_initial_power_state(maxim); + if (ret < 0) + return dev_err_probe(&maxim->client->dev, ret, "Could not get enabled st= ate\n"); + + memset(&props, 0, sizeof(struct backlight_properties)); + props.type =3D BACKLIGHT_PLATFORM; + props.max_brightness =3D MAX_BRIGHTNESS; + props.brightness =3D initial_brightness; + props.scale =3D BACKLIGHT_SCALE_LINEAR; + props.power =3D ret; + + ret =3D max25014_configure(maxim, ret); + if (ret) + return dev_err_probe(&maxim->client->dev, ret, "device config error"); + + bl =3D devm_backlight_device_register(&maxim->client->dev, id->name, + &maxim->client->dev, maxim, + &max25014_bl_ops, &props); + if (IS_ERR(bl)) + return dev_err_probe(&maxim->client->dev, PTR_ERR(bl), + "failed to register backlight\n"); + + maxim->bl =3D bl; + + backlight_update_status(maxim->bl); + + return 0; +} + +static void max25014_remove(struct i2c_client *cl) +{ + struct max25014 *maxim =3D i2c_get_clientdata(cl); + + backlight_device_set_brightness(maxim->bl, 0); + gpiod_set_value_cansleep(maxim->enable, 0); +} + +static const struct of_device_id max25014_dt_ids[] =3D { + { .compatible =3D "maxim,max25014", }, + { } +}; +MODULE_DEVICE_TABLE(of, max25014_dt_ids); + +static const struct i2c_device_id max25014_ids[] =3D { + { "max25014" }, + { } +}; +MODULE_DEVICE_TABLE(i2c, max25014_ids); + +static struct i2c_driver max25014_driver =3D { + .driver =3D { + .name =3D KBUILD_MODNAME, + .of_match_table =3D of_match_ptr(max25014_dt_ids), + }, + .probe =3D max25014_probe, + .remove =3D max25014_remove, + .id_table =3D max25014_ids, +}; +module_i2c_driver(max25014_driver); + +MODULE_DESCRIPTION("Maxim MAX25014 backlight driver"); +MODULE_AUTHOR("Maud Spierings "); +MODULE_LICENSE("GPL"); --=20 2.52.0 From nobody Sun Feb 8 15:53:28 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B12FE314A82; Fri, 23 Jan 2026 11:31:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769167892; cv=none; b=htOLuOKAjXV4r+IUcDMA/yWUV2ZP5yO6At2eZb3QFvKhTe2pMHdQaq7yHDeeZYJFWzyw+2qBn1NCA1DU2cLh/Q2YU/9v8OFgX8TY5PJtjWdAAw3Pd7VGu6JsEeMSRAtRfSFoDJoBBqcfJJSZvPgmHYP14qWYrYLv8FNrN3167s0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769167892; c=relaxed/simple; bh=3eouBpsCYS3KwiQrMTwSfyEZVYyKRt7Lop1klIm6hLY=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=hpSRqOc3n8II1/qxPrBAWdy8p5FycxZPMzPrhLVyNQCvrxr9t9RtgogMPU8UyD9ddPnnXsUiejVxEGgy5hXt+DrtRtzqv+lF/7LksRrbKA0V7i1dXSRC7Ad4/IQaRVWO7Z3XnwWeOFOIe8513VftkxwqMlBk02tBcFcm2+NPXA0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JUlWhL+H; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JUlWhL+H" Received: by smtp.kernel.org (Postfix) with ESMTPS id 7AC9AC2BCB4; Fri, 23 Jan 2026 11:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769167892; bh=3eouBpsCYS3KwiQrMTwSfyEZVYyKRt7Lop1klIm6hLY=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=JUlWhL+HEFKDYKZNKq/PxK0nEpu98YLu8/fjMIz5YP3Iay8s0j7Dnl8phXrJjNlMa BBuAuaaxLuybxbCD72oJrnnlp9tFwQ2s0LCl05px2Roxqts3WSmR91ymA2gHAHrWq7 iSqo/D8pZEIcEyKZBEegnygU+dw8qvJqGWFMpsDLj8KDbAhyvKLB3NddLfgZZfv0cV lMEHsaVcNcTUkYFn1PMhr6VBZmAedkleH/yfHx17snx533AA0Qe18Cjq7zDXKqEQMn nor3+iKkkrN3LMDm6pNMKBw1ncvZroADGt00TIdoWlH8/quyOa+8KrNpN493geEAk3 ePIOWtD9UUr6Q== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70E01D7237D; Fri, 23 Jan 2026 11:31:32 +0000 (UTC) From: Maud Spierings via B4 Relay Date: Fri, 23 Jan 2026 12:31:32 +0100 Subject: [PATCH v7 3/4] arm64: dts: freescale: moduline-display-av101hdt-a10: add backlight Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260123-max25014-v7-3-15e504b9acc7@gocontroll.com> References: <20260123-max25014-v7-0-15e504b9acc7@gocontroll.com> In-Reply-To: <20260123-max25014-v7-0-15e504b9acc7@gocontroll.com> To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Liam Girdwood , Mark Brown Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Maud Spierings X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769167891; l=1584; i=maudspierings@gocontroll.com; s=20250214; h=from:subject:message-id; bh=yoZbbwjcGIRaFHZNOFf++juVVVHFWhY7luS0Y8hg838=; b=tfp+vquqBPIZC7eD8kHVG01dBGSnew8QEjleDop0SWkKysFRCl22BfqLQPnmLWxRHd88jg7UG ZNLyvdLwphlDs4+mrnyZNlCiVJJ3BUL5844eBdvcBygyuJazEmYJ+X5 X-Developer-Key: i=maudspierings@gocontroll.com; a=ed25519; pk=7chUb8XpaTQDvWhzTdHC0YPMkTDloELEC7q94tOUyPg= X-Endpoint-Received: by B4 Relay for maudspierings@gocontroll.com/20250214 with auth_id=341 X-Original-From: Maud Spierings Reply-To: maudspierings@gocontroll.com From: Maud Spierings Add the missing backlight driver. Signed-off-by: Maud Spierings --- ...x8p-ml81-moduline-display-106-av101hdt-a10.dtso | 26 ++++++++++++++++++= ++++ 1 file changed, 26 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-displa= y-106-av101hdt-a10.dtso b/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-mo= duline-display-106-av101hdt-a10.dtso index e3965caca6be..e121c58b730b 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-display-106-a= v101hdt-a10.dtso +++ b/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-display-106-a= v101hdt-a10.dtso @@ -17,6 +17,7 @@ =20 panel { compatible =3D "boe,av101hdt-a10"; + backlight =3D <&backlight>; enable-gpios =3D <&gpio1 7 GPIO_ACTIVE_HIGH>; pinctrl-0 =3D <&pinctrl_panel>; pinctrl-names =3D "default"; @@ -40,7 +41,32 @@ reg_vbus: regulator-vbus { }; }; =20 +&i2c4 { + #address-cells =3D <1>; + #size-cells =3D <0>; + + backlight: backlight@6f { + compatible =3D "maxim,max25014"; + reg =3D <0x6f>; + #address-cells =3D <1>; + #size-cells =3D <0>; + default-brightness =3D <50>; + enable-gpios =3D <&gpio1 4 GPIO_ACTIVE_HIGH>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&pinctrl_backlight>; + maxim,iset =3D <7>; + maxim,strings =3D <1 1 1 0>; + }; +}; + &iomuxc { + pinctrl_backlight: backlightgrp { + fsl,pins =3D < + MX8MP_IOMUXC_GPIO1_IO04__GPIO1_IO04 + (MX8MP_PULL_UP | MX8MP_PULL_ENABLE) + >; + }; + pinctrl_panel: panelgrp { fsl,pins =3D < MX8MP_IOMUXC_GPIO1_IO07__GPIO1_IO07 --=20 2.52.0 From nobody Sun Feb 8 15:53:28 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5DB9346E4C; Fri, 23 Jan 2026 11:31:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769167892; cv=none; b=HHjD2GUW2m2g230Yfl0vnpZXZUI2LXCRdq7qkHDev9kc41LDC59iBEB/1IedDMShJ3U1j2pPJYl4H5APhhu0eO7sJj08F/0oeixAT9qDMRglltqg/xGFfFHHQNq06QceYWNPWRsulmsUGzdzm+0IgtkqB3hxfljLTtgV+D/qF8Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769167892; c=relaxed/simple; bh=CCx/kqDg6I83wk0E8eM9gJ1Oj6SxG/mFU/iGTdPjvGQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=m3IDVaAm7bJST9uDv/TzedwfjTv3EHN4vMM3oaY2e0QIASaaJKS2l2f93VeXIhcZkpx/Lq9gfbxzN883fiKUDDsMGiRutKhOuT5Xd8sfCQao3IStgvZwU0C8xKxeAnkIIYexmHqtVQvRpx7ruEXEkxUL+ALq7LOf+N7Pr9tAjQY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aYPz1AY0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aYPz1AY0" Received: by smtp.kernel.org (Postfix) with ESMTPS id 97BC1C2BC87; Fri, 23 Jan 2026 11:31:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769167892; bh=CCx/kqDg6I83wk0E8eM9gJ1Oj6SxG/mFU/iGTdPjvGQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=aYPz1AY0ymxNIwETkFIdBQje9rN4kyXNJg3qNXes/0bcCL40nBWrkruy8SaW3J5cW oUPREw71CvO4BoKKXvde3qdoExyvVo/2rt+eOVSHUhIa3s6mBP0Mf7yioFbtBWsXkf 1fj/pwgFj5CepcDX+Wn0AgpRgE5lESr6Igjk8Oi8/e5Ybj+fDoOsXaEJo1PVhnLf/B JTvYcmlS5Pibjk/Tu+AYOr0sFadmo54W+Y3rlrhhgRPl9I66H6txwrZIGNyzJcErWN hkBzMuvGBZQkVeRTiUx6Q/W0YU9IBUAuyYMMeMULTcQAFHv0KPIBYJYEQbwUu7DNub AfwtHktxho0CA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FB64D7236C; Fri, 23 Jan 2026 11:31:32 +0000 (UTC) From: Maud Spierings via B4 Relay Date: Fri, 23 Jan 2026 12:31:33 +0100 Subject: [PATCH v7 4/4] arm64: dts: freescale: moduline-display-av123z7m-n17: add backlight Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260123-max25014-v7-4-15e504b9acc7@gocontroll.com> References: <20260123-max25014-v7-0-15e504b9acc7@gocontroll.com> In-Reply-To: <20260123-max25014-v7-0-15e504b9acc7@gocontroll.com> To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Liam Girdwood , Mark Brown Cc: dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Maud Spierings X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769167891; l=1565; i=maudspierings@gocontroll.com; s=20250214; h=from:subject:message-id; bh=h3zqJBjPWCRRFOamEmSYnLNeMhZkUwqVa+0eK4+1+KA=; b=URPfA67ijU720rzLEbQWlfOakMi8xMeNSO5lod3dESL/XDlERHc1UehgPCXECcGLOAP0DoU/+ aGAQTPzvL3YAKCu55+Z4zgQXKQhYJLYXTwKd84m2SE/Fvj4M7ngA78r X-Developer-Key: i=maudspierings@gocontroll.com; a=ed25519; pk=7chUb8XpaTQDvWhzTdHC0YPMkTDloELEC7q94tOUyPg= X-Endpoint-Received: by B4 Relay for maudspierings@gocontroll.com/20250214 with auth_id=341 X-Original-From: Maud Spierings Reply-To: maudspierings@gocontroll.com From: Maud Spierings Add the missing backlight. Signed-off-by: Maud Spierings --- ...tx8p-ml81-moduline-display-106-av123z7m-n17.dtso | 21 +++++++++++++++++= +++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-displa= y-106-av123z7m-n17.dtso b/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-mo= duline-display-106-av123z7m-n17.dtso index 3eb665ce9d5d..66d98a18d898 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-display-106-a= v123z7m-n17.dtso +++ b/arch/arm64/boot/dts/freescale/imx8mp-tx8p-ml81-moduline-display-106-a= v123z7m-n17.dtso @@ -16,6 +16,7 @@ =20 panel { compatible =3D "boe,av123z7m-n17"; + backlight =3D <&backlight>; enable-gpios =3D <&gpio1 7 GPIO_ACTIVE_HIGH>; pinctrl-0 =3D <&pinctrl_panel>; pinctrl-names =3D "default"; @@ -91,10 +92,28 @@ lvds1_out: endpoint { }; }; =20 - /* max25014 @ 0x6f */ + backlight: backlight@6f { + compatible =3D "maxim,max25014"; + reg =3D <0x6f>; + #address-cells =3D <1>; + #size-cells =3D <0>; + default-brightness =3D <50>; + enable-gpios =3D <&gpio1 4 GPIO_ACTIVE_HIGH>; + pinctrl-names =3D "default"; + pinctrl-0 =3D <&pinctrl_backlight>; + maxim,iset =3D <7>; + maxim,strings =3D <1 1 1 1>; + }; }; =20 &iomuxc { + pinctrl_backlight: backlightgrp { + fsl,pins =3D < + MX8MP_IOMUXC_GPIO1_IO04__GPIO1_IO04 + (MX8MP_PULL_UP | MX8MP_PULL_ENABLE) + >; + }; + pinctrl_lvds_bridge: lvdsbridgegrp { fsl,pins =3D < MX8MP_IOMUXC_SAI1_TXD2__GPIO4_IO14 --=20 2.52.0