From nobody Tue Feb 10 01:14:59 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 394A630649A; Fri, 23 Jan 2026 16:34:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769186057; cv=none; b=BEpRG3dMIBiG2Zb1I1ODWd7niXd6AMuFDBonpOmsVqfNg3ndZCGy9SizGhCGtwi70kpLNOBFqiVNJVqzGKot79yMRAKUL1DvTiNgdiQaeVckpGoPfoL03UIJsWftn6V+rYtU94zAnkvp1KzhiwWYw9lylYVKyFfrEXkNgfSQRmE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769186057; c=relaxed/simple; bh=mA693d2B+lCutFgSWj64GcSrZarkiCgLGJixz53RjCk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XeOk5LNgZFQPtENvPyfLalmzPVMcVacUoQ4GVvTmhKZTqCF/798X6sGBIl+MiHv7ZqCfOC6qu0rpWY9I3jbdMSejbn/CpVS+8nBej6g7wEwYHyQw32FdHgpxmTHACLMDKD95OOVOF2HyUIEpodlNYPWf8hBfHttdxXH+cMuCd5s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=t2enw8dH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="t2enw8dH" Received: by smtp.kernel.org (Postfix) with ESMTPS id D5EACC19422; Fri, 23 Jan 2026 16:34:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769186056; bh=mA693d2B+lCutFgSWj64GcSrZarkiCgLGJixz53RjCk=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=t2enw8dHZyxTEK2l+4YEqkG81wTj2Bngqv2Hec++sETMkzrZ5omooaOb/1kyn+HGI URrZ3u8C5Qg4ljQMFv2UaOnIUul4SUoUZ66HH++MIDsj8rj2UuEFfSHKe323lZUSCp Z0GHoJopD4Wqt2kqmypjqa0W0FziEODzp9HZW+lSid781834KYHE0M3MA/fmCGhDzQ qhDAkESyZZ/gqL/jIp35PWLTZ472diwBClrPL3CbGDwVmF32kDx9A1xpbziiv80vLD ECK1UZZH0HHS7eQzy4krsqfgy3aTAQ3KESkC+9fP3DMi4hwAkjybJInLuzIAbkG2bO 0FyZKyPWr2z9A== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C63BED74EFF; Fri, 23 Jan 2026 16:34:16 +0000 (UTC) From: Abdurrahman Hussain via B4 Relay Date: Fri, 23 Jan 2026 16:34:14 +0000 Subject: [PATCH v4 1/5] i2c: xiic: minor cosmetic cleanup Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260123-i2c-xiic-v4-1-4a3eba3510ce@nexthop.ai> References: <20260123-i2c-xiic-v4-0-4a3eba3510ce@nexthop.ai> In-Reply-To: <20260123-i2c-xiic-v4-0-4a3eba3510ce@nexthop.ai> To: Michal Simek , Andi Shyti Cc: Andy Shevchenko , linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Abdurrahman Hussain X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769186056; l=5157; i=abdurrahman@nexthop.ai; s=20260119; h=from:subject:message-id; bh=0QQ3AZ9kvIaYMsjGFuaC+WxbuuTcDJrOZdiaoj9V0Us=; b=Zf7buBeB54Kay6AbbJHNDAjugWSFk0yHlrcN4HOY2Hq5Wi2h+6lrkFZzLQA+6j8jrNNdJCUg7 cQ1pQvOONErDAKhgYM8Xj9qQDKILPCCwW1tG/eoiQcQp3MEtSyc4WvO X-Developer-Key: i=abdurrahman@nexthop.ai; a=ed25519; pk=S+ysnf+NwMcBdHBlyKIUEAtaFGSIhQwcJcgcXhq0osg= X-Endpoint-Received: by B4 Relay for abdurrahman@nexthop.ai/20260119 with auth_id=608 X-Original-From: Abdurrahman Hussain Reply-To: abdurrahman@nexthop.ai From: Abdurrahman Hussain Add a temporary dev variable and reuse it instead of referencing pdev->dev everywhere. Signed-off-by: Abdurrahman Hussain --- drivers/i2c/busses/i2c-xiic.c | 57 ++++++++++++++++++++++-----------------= ---- 1 file changed, 29 insertions(+), 28 deletions(-) diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index 28015d77599d..12321654055f 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -1423,6 +1423,7 @@ MODULE_DEVICE_TABLE(of, xiic_of_match); =20 static int xiic_i2c_probe(struct platform_device *pdev) { + struct device *dev =3D &pdev->dev; struct xiic_i2c *i2c; struct xiic_i2c_platform_data *pdata; const struct of_device_id *match; @@ -1431,11 +1432,11 @@ static int xiic_i2c_probe(struct platform_device *p= dev) u8 i; u32 sr; =20 - i2c =3D devm_kzalloc(&pdev->dev, sizeof(*i2c), GFP_KERNEL); + i2c =3D devm_kzalloc(dev, sizeof(*i2c), GFP_KERNEL); if (!i2c) return -ENOMEM; =20 - match =3D of_match_node(xiic_of_match, pdev->dev.of_node); + match =3D of_match_node(xiic_of_match, dev->of_node); if (match && match->data) { const struct xiic_version_data *data =3D match->data; =20 @@ -1450,50 +1451,49 @@ static int xiic_i2c_probe(struct platform_device *p= dev) if (irq < 0) return irq; =20 - pdata =3D dev_get_platdata(&pdev->dev); + pdata =3D dev_get_platdata(dev); =20 /* hook up driver to tree */ platform_set_drvdata(pdev, i2c); i2c->adap =3D xiic_adapter; i2c_set_adapdata(&i2c->adap, i2c); - i2c->adap.dev.parent =3D &pdev->dev; - i2c->adap.dev.of_node =3D pdev->dev.of_node; + i2c->adap.dev.parent =3D dev; + i2c->adap.dev.of_node =3D dev->of_node; snprintf(i2c->adap.name, sizeof(i2c->adap.name), DRIVER_NAME " %s", pdev->name); =20 mutex_init(&i2c->lock); spin_lock_init(&i2c->atomic_lock); =20 - i2c->clk =3D devm_clk_get_enabled(&pdev->dev, NULL); + i2c->clk =3D devm_clk_get_enabled(dev, NULL); if (IS_ERR(i2c->clk)) - return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk), + return dev_err_probe(dev, PTR_ERR(i2c->clk), "failed to enable input clock.\n"); =20 - i2c->dev =3D &pdev->dev; - pm_runtime_set_autosuspend_delay(i2c->dev, XIIC_PM_TIMEOUT); - pm_runtime_use_autosuspend(i2c->dev); - pm_runtime_set_active(i2c->dev); - pm_runtime_enable(i2c->dev); + i2c->dev =3D dev; + pm_runtime_set_autosuspend_delay(dev, XIIC_PM_TIMEOUT); + pm_runtime_use_autosuspend(dev); + pm_runtime_set_active(dev); + pm_runtime_enable(dev); =20 /* SCL frequency configuration */ i2c->input_clk =3D clk_get_rate(i2c->clk); - ret =3D of_property_read_u32(pdev->dev.of_node, "clock-frequency", + ret =3D of_property_read_u32(dev->of_node, "clock-frequency", &i2c->i2c_clk); /* If clock-frequency not specified in DT, do not configure in SW */ if (ret || i2c->i2c_clk > I2C_MAX_FAST_MODE_PLUS_FREQ) i2c->i2c_clk =3D 0; =20 - ret =3D devm_request_threaded_irq(&pdev->dev, irq, NULL, - xiic_process, IRQF_ONESHOT, - pdev->name, i2c); + ret =3D devm_request_threaded_irq(dev, irq, NULL, xiic_process, + IRQF_ONESHOT, pdev->name, i2c); =20 if (ret < 0) { - dev_err_probe(&pdev->dev, ret, "Cannot claim IRQ\n"); + dev_err_probe(dev, ret, "Cannot claim IRQ\n"); goto err_pm_disable; } =20 i2c->singlemaster =3D - of_property_read_bool(pdev->dev.of_node, "single-master"); + of_property_read_bool(dev->of_node, "single-master"); =20 /* * Detect endianness @@ -1509,7 +1509,7 @@ static int xiic_i2c_probe(struct platform_device *pde= v) =20 ret =3D xiic_reinit(i2c); if (ret < 0) { - dev_err_probe(&pdev->dev, ret, "Cannot xiic_reinit\n"); + dev_err_probe(dev, ret, "Cannot xiic_reinit\n"); goto err_pm_disable; } =20 @@ -1526,38 +1526,39 @@ static int xiic_i2c_probe(struct platform_device *p= dev) i2c_new_client_device(&i2c->adap, pdata->devices + i); } =20 - dev_dbg(&pdev->dev, "mmio %08lx irq %d scl clock frequency %d\n", + dev_dbg(dev, "mmio %08lx irq %d scl clock frequency %d\n", (unsigned long)res->start, irq, i2c->i2c_clk); =20 return 0; =20 err_pm_disable: - pm_runtime_disable(&pdev->dev); - pm_runtime_set_suspended(&pdev->dev); + pm_runtime_disable(dev); + pm_runtime_set_suspended(dev); =20 return ret; } =20 static void xiic_i2c_remove(struct platform_device *pdev) { + struct device *dev =3D &pdev->dev; struct xiic_i2c *i2c =3D platform_get_drvdata(pdev); int ret; =20 /* remove adapter & data */ i2c_del_adapter(&i2c->adap); =20 - ret =3D pm_runtime_get_sync(i2c->dev); + ret =3D pm_runtime_get_sync(dev); =20 if (ret < 0) - dev_warn(&pdev->dev, "Failed to activate device for removal (%pe)\n", + dev_warn(dev, "Failed to activate device for removal (%pe)\n", ERR_PTR(ret)); else xiic_deinit(i2c); =20 - pm_runtime_put_sync(i2c->dev); - pm_runtime_disable(&pdev->dev); - pm_runtime_set_suspended(&pdev->dev); - pm_runtime_dont_use_autosuspend(&pdev->dev); + pm_runtime_put_sync(dev); + pm_runtime_disable(dev); + pm_runtime_set_suspended(dev); + pm_runtime_dont_use_autosuspend(dev); } =20 static const struct dev_pm_ops xiic_dev_pm_ops =3D { --=20 2.52.0