From nobody Sun Feb 8 06:04:41 2026 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50B08378832 for ; Thu, 22 Jan 2026 17:17:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769102251; cv=none; b=O3+TYYIFswNF14t9GMjSZSVX7CVD/1WRE+XtpzdlYE9jbqy/ZwQABroyYogKIUrcAijLTkEWRfOkDW1wtbDfXz0NZT2WnUr/vn2GMAXVsRm9ykaGAPR0iG3GZtyM06NvMhbFus7XPZfMaG7ux5l3iQYdyuBxyic0iEo8+Aqo18k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769102251; c=relaxed/simple; bh=evG4RfQJYRo/3pFv7i+uMNlovxZnzcoKlntEeOtLbZM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=eYsZoXyTNgwzIk0yb6bL9/SZ/JzdJnQknZ1YBY1Hagw7E3fd27CDMtvSbqMwwkx8KbBxcyZYNA+X8pUIRi1iRZCuFSCf2Gr3a3fgbm94bomQTnnGnyTm+i7R/SlDfgTurG3PBLioRK7ALkCoMJcxJ/HJXSr6HkunGXVTtzBqXMI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=MNlHsC3q; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MNlHsC3q" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-34c868b197eso1027615a91.2 for ; Thu, 22 Jan 2026 09:17:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769102236; x=1769707036; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=f8NFYeC0VnU4tU7qZl9s2DqzXH53qrThNK5lEVTJREs=; b=MNlHsC3qaE1GVbj35qav4MydC3NQxLd90EiiBZhyVklseeaAMIBLs207OyoeAOpeEy EOBOz7TMkTUs0XtH2mcgbNz4Cb9eVw89iaVwLDQKRrQAy0DW88hIac0vLyC1E4P2GaMG S/6k71dVAoLblfOCEzkO4qr0pVesz2xwP8QOhAc19wn4sVm87O0Uq2jpKFW9Iv2Osixm tcUESPCo3lOtIwzsnxGNjsEMOs27MNIh9DW2zb0L01BTfb6qDtQ/y6C7mnXGaX8qrI/c A7INaGOIjAqm24++rZr7KUihONwNwAuR8Cfy/6CTY7wGU823iEJHscHwsW5T2ue1qETe k5gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769102236; x=1769707036; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f8NFYeC0VnU4tU7qZl9s2DqzXH53qrThNK5lEVTJREs=; b=XCKuzXyQ+L1O2zH35BEjYnNLqlPZXPMbt52D/SrFeDRM8f7XkWBw1hsQ8oiBDz5Nb6 4HUlbDnwLorUBq1Y8f7S015SKC87TpsZluVa/OAT0e8uSGN4FA/0pZebMqjhcdbgNCPq 2WgpRX7ItqYse0aSe3ktqc/b+nGNNkwHklys/Duns9yDRWb4mAJVwnRjIRaB1QknZfIy SeSL9JfdDKkRxr3g85LbfxgU9ItG3vEnf9MAHi9uEX0An3uEcsZMikgELUIg0RX06L1D oJ/0RyeDv+k7kYUyt3CdUY5tbrvmkqWLTs1d9l+V5xmAVanfK/p3Zu9N+s9BWGM0sxPx d66g== X-Forwarded-Encrypted: i=1; AJvYcCVufJs1sEt9125R/4xr55TFud05CMY8jxfCMhdWnrQWB+vvCOw+7JgaIhY8+pRY7baRHtCkCdAiIXZDPO8=@vger.kernel.org X-Gm-Message-State: AOJu0YxWmTzh0evPeEu809cmVoJw1S/VHN87dbBWmFButWuyicL1JBFs qiEcyvko+WeAP0ViLC26KitUey8UoCQIutg4mgqaXj6ghffBOjuexjnJ X-Gm-Gg: AZuq6aIP0rA0F2ZP+xuKvbbHpZ9V/D635HBfOUxgVH+pdnY1Dz5nbs2liz+o/xb/Zdm zpZ+ypclmTp70evnl6o3f3lhmH5z2PZUAsahjoWp519yKx44sHqerD+/goG932IqwToH9Zlyc/T eiwzsJ6yK+9DPNgrpCOX6nG0S2BU994ZZTmBnMaob73rFJh0g5rwyGFjve+DGmB3Y8Jre4lwtgL GwjW+mOi6F9CiSbGwAFdIuW8N7uCmnrAlObA/3ZrHO6lQy+OUOG20VBdPWOgh2S7/TdgfHOJZfd u/wQrR9mG0Icfi/8k9B4Qrx/fr7f/ptjzk0cSO814bpZCqrz96bTTt4/vOF1pZ0f6JjD2N9aiXD UcCf1fY7p6GeTiPfQzgtDt+JcBrAa1x2ic1/SmjmX5JIoM54oCiWAVdEPGQ+94GJEksdt6yg7X+ qyK23bdI2hHLoZ0Y36TSk= X-Received: by 2002:a17:90b:1f88:b0:343:66e2:5f9b with SMTP id 98e67ed59e1d1-353689530cdmr170446a91.24.1769102235826; Thu, 22 Jan 2026 09:17:15 -0800 (PST) Received: from archlinux ([205.254.163.11]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-353354cdd03sm3005284a91.15.2026.01.22.09.17.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jan 2026 09:17:15 -0800 (PST) From: Suchit Karunakaran To: acme@kernel.org, mingo@redhat.com, namhyung@kernel.org, peterz@infradead.org Cc: adrian.hunter@intel.com, alexander.shishkin@linux.intel.com, irogers@google.com, james.clark@linaro.org, jolsa@kernel.org, mark.rutland@arm.com, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Suchit Karunakaran Subject: [PATCH] perf annotate: Fix memcpy size in arch__grow_instructions Date: Thu, 22 Jan 2026 22:47:04 +0530 Message-ID: <20260122171704.142218-1-suchitkarunakaran@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The memcpy in arch__grow_instructions() is copying the wrong number of bytes when growing from a non-allocated table. It should copy arch->nr_instructions * sizeof(struct ins) bytes, not just arch->nr_instructions bytes. This bug causes data corruption as only a partial copy of the instruction table is made, leading to garbage data in most entries and potential crashes Signed-off-by: Suchit Karunakaran Reviewed-by: Ian Rogers --- tools/perf/util/disasm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/disasm.c b/tools/perf/util/disasm.c index 50b9433f3f8e..6faa9df8e373 100644 --- a/tools/perf/util/disasm.c +++ b/tools/perf/util/disasm.c @@ -81,7 +81,7 @@ static int arch__grow_instructions(struct arch *arch) if (new_instructions =3D=3D NULL) return -1; =20 - memcpy(new_instructions, arch->instructions, arch->nr_instructions); + memcpy(new_instructions, arch->instructions, arch->nr_instructions * size= of(struct ins)); goto out_update_instructions; } =20 --=20 2.52.0