From nobody Sun Feb 8 02:56:06 2026 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CFBBD3D5F23 for ; Thu, 22 Jan 2026 17:05:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769101562; cv=none; b=jEHt1aDtvpXOgZEPLvhZJkJOKLjeCG/oicESyhB+6/Z3madtshQAN9EydgNlDSLBuEKiJNkUbm/dkhhanntzNprDl35a2MaYmrhAJ6sr9pgffNn3ZgEb0RNhaE53jPo58V1u+f+3Y+MC0CFLxdVPdALVlA0zJcQ3otK8gc8X+6c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769101562; c=relaxed/simple; bh=yv4xKODfxfq+wy1Y+Bo1fBawePnmFjDbAAErAv67a0E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=cmgNCfsWC9ICa7CEVn+AYeXmZ9pBdGHnq4BLIuJ3BAk5odSED5AfKMDtpve5EA5ifPu8O3GJ43AuQV+xq+sFGiVw/NidWp0u0+/bNZ4omJVlN+juOBPodgH43zuv/QX/3aBaR6ib6YJhv1I05MYYdE7KVNYphQki6opvDzD1CsQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=b2KfBpzD; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="b2KfBpzD" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-b4755f37c3eso746179a12.3 for ; Thu, 22 Jan 2026 09:05:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769101551; x=1769706351; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=3UvjAXki3OZEHPndISMzpaWlTeQRauyvYG4EdwXf6i0=; b=b2KfBpzDWljmBRGGUvBr53u/zVy/JXt4XQvDcmjbIV7pX1KcYm/KxgeFsn33OdbUU+ 9a0VPNkddKwUjQ6votZELUN+cPD3sMR4nR1XzMdz8wvZijeau85IDC1oIlEpYY495gXV a7nLfVUcYDCaj+YIXqBQl8TuZFZtpEDRWXOwaW+RZ9AS6ZD0Eh39wPmF+B4EOlcpAXnF srgaPWIy1Km/3eFpNXHBk0mLOkl/gzeLGH275WgI1SAljLZb11FAVmpYeuebFwHvtJnz YVzWs3OJHXhVKsSq8CT3dUZinCNkxDmbE5f8YxUiTf1OMbLvLLWVVOyUCyFJwlOmzVfL h8BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769101551; x=1769706351; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3UvjAXki3OZEHPndISMzpaWlTeQRauyvYG4EdwXf6i0=; b=FSyOor4n9am3PhnBozEtecrkC5j86vAFv80fbpJRDZLb9s6g7e3ghCg+rD90gPCCMU aWSH3V6n0b7xMT4gyCxOmFKxU3zXnMXe7zVd+yEp75XXxhFWb5dL9QeBkoNK3zAM/xXw G/51qlHI0kv1gTLXDzGsHPtFGsTJT76FeC8phtZQCWmGrW8+8/R5e8baynyONDTWBT3q Fh/xr4IF0VIdo5hIjE/R6dtO5dSxgLd4jYrF0u720SGkxzgnVP+JfGNCGXkSbw8cQJHF sTlDNwlohU2op7yXA/wIOPNeQ7Mq5Yh8ELUbSb0s7boDvQylR+2LUItNonJsitn34zS4 ir2A== X-Forwarded-Encrypted: i=1; AJvYcCXccn1B7LV0ILljY7bPv9kAE2RnBrxbmVl7OZZ0Vssvh2l6fqfrHU1QMKyDQhe57de9neMF8QKT0qdGiXY=@vger.kernel.org X-Gm-Message-State: AOJu0YzR+JLr59ABbn9TAhnI1Slp3WZhnqNR8ch9Ax4fCyAKQU82h+t0 0R+XEx3zIGu1z57/5Drw0ueys7cBzOew8IGe4V/HslpzGcK4cyRTrRkg X-Gm-Gg: AZuq6aIdtrAKq9iCaGcWw7VXilw15WxQxzVaw5hraKHbvgIDoeEpMP3CwjYY5jR+YLl TpALL3mQTU40fN8TB0Uz99DAxO2lhN1maDehujaWIvAWzPLhz741qk5PklHGZMLBRtlh8e2rufA quxA0QQLruLSZ2XfFusDSbAoPN+nkY8HUuuPYPMjQmKeg3y2DoNzYbi3+ifvj3AxML83EhAEYrt QQ1v3tYA75lAEkhkiqqddcTo/qWL1bk+XdkC9AxXuFO7e96UTQfIWF6YKRorjsyQmIJ9Y18r4u4 hpT2XjRWlac+HewBBTfvOaM20WNnMcNVjRrYdW1Mp5lCouZPqXse0Z2VwAF8Ab4/7iX04UN7oQg /enb1kjAKOyQV7W+Ry5gOCKTqofdPBUwADNvbTsxbVY7QHkeDOsnrhODNIaPpUBLmeBHLcUOA01 5CJwuEJTbe45BOjHjVrNeVMudBihBNsiXDKSCLSV+brDlsHlb0xTBgKg== X-Received: by 2002:a17:90b:4f8a:b0:32e:7bbc:bf13 with SMTP id 98e67ed59e1d1-35368f28fd0mr134794a91.34.1769101551003; Thu, 22 Jan 2026 09:05:51 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3536ac58fb9sm8953a91.4.2026.01.22.09.05.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jan 2026 09:05:50 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Dan Carpenter , David Laight , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: [PATCH net v6] net: dsa: yt921x: Fix MIB overflow wraparound routine Date: Fri, 23 Jan 2026 01:05:09 +0800 Message-ID: <20260122170512.2713738-1-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Reported by the following Smatch static checker warning: drivers/net/dsa/yt921x.c:702 yt921x_read_mib() warn: was expecting a 64 bit value instead of '(~0)' Fixes: 186623f4aa72 ("net: dsa: yt921x: Add support for Motorcomm YT921x") Reported-by: Dan Carpenter Closes: https://lore.kernel.org/netdev/aPsjYKQMzpY0nSXm@stanley.mountain/ Suggested-by: David Laight Signed-off-by: David Yang --- v6: https://lore.kernel.org/r/20260118013019.1078847-1-mmyangfl@gmail.com - send only the first patch targeting net tree v5: https://lore.kernel.org/r/20260114114745.213252-1-mmyangfl@gmail.com - avoid type casting - split patches v4: https://lore.kernel.org/r/20260108004309.4087448-1-mmyangfl@gmail.com - add missing u64_stats_init v3: https://lore.kernel.org/r/20260105020905.3522484-1-mmyangfl@gmail.com - use u64_stats_t - fix calculations of rx_frames/tx_frames v2: https://lore.kernel.org/r/20251025171314.1939608-1-mmyangfl@gmail.com - run tests and fix MIB parsing in 510026a39849 - no major changes between versions v1: https://lore.kernel.org/r/20251024084918.1353031-1-mmyangfl@gmail.com - take suggestion from David Laight - protect MIB stats with a lock drivers/net/dsa/yt921x.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/yt921x.c index 1c511f5dc6ab..7b8c1549a0fb 100644 --- a/drivers/net/dsa/yt921x.c +++ b/drivers/net/dsa/yt921x.c @@ -682,21 +682,22 @@ static int yt921x_read_mib(struct yt921x_priv *priv, = int port) const struct yt921x_mib_desc *desc =3D &yt921x_mib_descs[i]; u32 reg =3D YT921X_MIBn_DATA0(port) + desc->offset; u64 *valp =3D &((u64 *)mib)[i]; - u64 val =3D *valp; u32 val0; - u32 val1; + u64 val; =20 res =3D yt921x_reg_read(priv, reg, &val0); if (res) break; =20 if (desc->size <=3D 1) { - if (val < (u32)val) - /* overflow */ - val +=3D (u64)U32_MAX + 1; - val &=3D ~U32_MAX; - val |=3D val0; + u64 old_val =3D *valp; + + val =3D (old_val & ~(u64)U32_MAX) | val0; + if (val < old_val) + val +=3D 1ull << 32; } else { + u32 val1; + res =3D yt921x_reg_read(priv, reg + 4, &val1); if (res) break; --=20 2.51.0