From nobody Sun Feb 8 21:47:09 2026 Received: from mail-dy1-f202.google.com (mail-dy1-f202.google.com [74.125.82.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C782F36680A for ; Thu, 22 Jan 2026 16:54:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.202 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769100881; cv=none; b=dUunAeJq9ix0vs5flGjhfwFsTUJFVNjQQ3h88oxISJs9QDT9uYyFJvFP7/LQ1iCZim9xJKWNxuYsDigmn1+KFAN1wQzvqsVwvw8V8GDVKZSt/ettzzJN8RqM9kgEq0WrSY4nrCX9ydLl9OzlYQXKc1x4NfE8S+Jq0FxvsK3GM08= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769100881; c=relaxed/simple; bh=WqOiFcX/heg3IGph3C/ogbRzFLpcL0diaA21e5ry5lo=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=ewj9r3zf+h6x3Mtu6MAuKx6sqCzGYeDW55txLkLPd1ap6oE/SJAk+fAWbgimMejQtLkuUppGNy4/iU0sSfg2ttXgvutXFyCH6qn8MkxBI76rQCYeUgNVh1V29kvkL2eZkxCBrzsK5xDU4dl3ElWLSegxiIqEmxcF+PaUP4vK39g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=uSOMAGss; arc=none smtp.client-ip=74.125.82.202 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="uSOMAGss" Received: by mail-dy1-f202.google.com with SMTP id 5a478bee46e88-2b6f0b345e3so6299669eec.0 for ; Thu, 22 Jan 2026 08:54:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769100860; x=1769705660; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=DnbHjkP7sr2MY8dvLIuI6wPgadGKGFiX6WTYohRo5Kw=; b=uSOMAGssh5dmLUIRtCZrmMb7VsAbqQZI773U2nrsh6m8PA55jIRS0RSIxlIKsCJ6iK Zhz9zetOv1Nu1TWCqnEY+EPbsLXuBXCN5uamUaEsA+Av8Ca9ubrvqplOew9lZKCAABrG OB4v8bO/RrpH48a7eA/TXKHwOqWoWGRVPE6Z+scupxkZi8D/W6eUMH954qd8LCDcmY2/ 4LkK8iuqSNuvDzZRDOj0NuwtwqG/84gW1vWTdXj33Mmt5eTjsPMNmI/Uyuq6EGezVw4+ fT6h0FVyqLO/ydTVbYlAffpMZtIqzrbaAAdBrZ4vOCMEQi9l1elMNwOz7p75WaV/b1dE 7PPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769100860; x=1769705660; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DnbHjkP7sr2MY8dvLIuI6wPgadGKGFiX6WTYohRo5Kw=; b=ZMDY1P2ILtjAPxfzIsTOo3/8VDRGqeb0ASfXVw02M2fFwJ0THUdIWTS7ZggYKbq+wg f+kYwX9JC2sD5y7R1sA1FnZHrrUvpJebRG+HOyX7dLHMryD27X9REVyZ4mDXEwqzbFrR FNcqjohAKMk8D+zsuIDwCo+U7eDg3Ty6l62ruN/7mIQQjirgV+st0y9OlPOe64ACW4DO U/O9q2DntO4ajMUHGZiQgOc8AEnhS0d74jeM+XZLrYHCL0o/JGY7pfktPXpWSFEjwgA7 nSoO/sfaXDYoY74hRblKa7g+SbKmDwVGnkjp9sO/u/E0/ufLRDT2J4RmnHIz1RAOJF8o 6YKQ== X-Forwarded-Encrypted: i=1; AJvYcCULrkGfyDQuyaEZe9dLGCtnoc3c2udZ4qZVdNL3I5J6GqqAwaWn6+YJyMk8pVaKMigG1wmPFPDtdNkyJgI=@vger.kernel.org X-Gm-Message-State: AOJu0YycgTHWAR06y2/5r9sAG8CJfPEEi+D6yogy7KT7ssIRkG5J/qk9 GigRaSo/fPi1P4mcwEA9pVgrzHqnwc3O7TU21B7trR34Ne7mt7jJElCSljTEll5kCtWcOcLQ/82 wLzlAG/lbFg== X-Received: from dycue4.prod.google.com ([2002:a05:7300:84:b0:2ae:5283:d72f]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7300:7c13:b0:2ae:824e:31ba with SMTP id 5a478bee46e88-2b6b3eed5d9mr19877803eec.7.1769100860046; Thu, 22 Jan 2026 08:54:20 -0800 (PST) Date: Thu, 22 Jan 2026 08:53:58 -0800 In-Reply-To: <20260122165407.561888-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260122165407.561888-1-irogers@google.com> X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog Message-ID: <20260122165407.561888-4-irogers@google.com> Subject: [PATCH v2 03/12] perf maps: Fix reference count leak in maps__find_ams From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , John Garry , Will Deacon , Leo Yan , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Zecheng Li , Tianyou Li , Thomas Falcon , Julia Lawall , Suchit Karunakaran , Athira Rajeev , Aditya Bodkhe , Howard Chu , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , "Dr. David Alan Gilbert" , Shimin Guo , Sergei Trofimovich , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ams and so ams->ms.map is an in argument, however, it is also overwritten. As a map is reference counted, ensure a map__put is done before overwriting it. Signed-off-by: Ian Rogers Fixes: 42fd623b58db ("perf maps: Get map before returning in maps__find") --- tools/perf/util/maps.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf/util/maps.c b/tools/perf/util/maps.c index 8ccc46d515b6..4092211cff62 100644 --- a/tools/perf/util/maps.c +++ b/tools/perf/util/maps.c @@ -708,6 +708,7 @@ int maps__find_ams(struct maps *maps, struct addr_map_s= ymbol *ams) if (ams->addr < map__start(ams->ms.map) || ams->addr >=3D map__end(ams->m= s.map)) { if (maps =3D=3D NULL) return -1; + map__put(ams->ms.map); ams->ms.map =3D maps__find(maps, ams->addr); if (ams->ms.map =3D=3D NULL) return -1; --=20 2.52.0.457.g6b5491de43-goog