From nobody Mon Feb 9 23:45:06 2026 Received: from mail-dy1-f201.google.com (mail-dy1-f201.google.com [74.125.82.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8674436EA9C for ; Thu, 22 Jan 2026 16:54:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769100864; cv=none; b=BBoYsVQACzXxaE1VVvspNqXAqNTTNTBhsDzE22SXsbpxNq5yUWR7BkT3XkTnJ5VtXEoKcJFL3pO4nx0thealwLR2f8Mtv6TesKhr/Y/0GMYZqw85EmQ5TJzYK1g14y9WYwsb6ctkpKCYj9V0fgh5CPSi5RhzXd8TKvVDO5yNqeE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769100864; c=relaxed/simple; bh=U3CxrbAAlN8gTA3wMaXLOq+KQ2KCxALBwEtyEmQVEng=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=M1Rzz4Rat2D/2+7H6bSDBgTWlB4fq60dy3V5+z8t5kVg8rCg9HW9UrKIcgS+jhQz5GEs1T5AC+qi0p4/C16zunCymqUkP0zmaV+MxvRP5WQuSvGReK/gj+56w5VCJs+OETs0vC+IKma1PzGxdTTE+O+H/XzZjbN2dj6Zvynal5o= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=oEImuKVd; arc=none smtp.client-ip=74.125.82.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="oEImuKVd" Received: by mail-dy1-f201.google.com with SMTP id 5a478bee46e88-2b7155ca88cso921461eec.1 for ; Thu, 22 Jan 2026 08:54:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769100856; x=1769705656; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=zalmwLrK8cPj7cYoTUj/KkGE6/xfnap/Tev3VqTduZw=; b=oEImuKVdED36izjuwCT+ZZuLoE4ZtXRodRbC7Z5dfZhJO/A3UO/nxuoeLZmrvPq1n4 UwUaOVfvYxuqxx/060C3wvyLW/AATEEx3HJwYmkZFlDVpCiUDp+6xMoCImKS/mZEkxuO 58ZeIRXe83rbDmu0afEZGyIGIEnjUEAZFFInRRvK9XUCWoDBVbd/2BELtkrJbSffcvwm ojBHUKbVvZHtrPJJchO5hiydHyxNpp8dQQv5aSmAaGtpuE2jiQ9gPoNQupSpQPgBrSD0 1Ulbu8dnaPpfeshjO/QmVhhl6agiPifTUsS/qugjs3WW/ncDmCmZpqxGPGis7OIHrY/p ANaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769100856; x=1769705656; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zalmwLrK8cPj7cYoTUj/KkGE6/xfnap/Tev3VqTduZw=; b=i6RAB2D+GyDdYy1++T4kvJUzyNd107pUAbkuuRtOtXY6D2PEFFKDKj16k9r+PGH/G9 qM8LQ53eih/HEP8YfYszIgG1TwR/CkBY0GwhpEZCF7dNBm61jZuVUT9frrSjw32nPL7d 8sSKUPlj9Sr3/OrjWgwiDlStzHttUa9isRJxTrH1uj/OHDZBde55iiKvrctspKo/q3oE 9Ls5nyMIQ3kr9mrMs0vb22VjmhlZfnuxX9UsqIjVe3tgbyibeI0gZLyITN4V3mkBmNRH pT+M/Nf2m7M/Orn1b9C4qjuSaxFa5jlIZoQLaU/kWo89xNwP+tR73Xwc68KmaAdWXLDd XXTw== X-Forwarded-Encrypted: i=1; AJvYcCVobsaiSlSOKXUeARA57LIb6EGbqIDW8dhoRrQ0DwpYXI0bPLwwyBb4Cf3t6P3EGNpJ7K0WqZMY3Y3tQB4=@vger.kernel.org X-Gm-Message-State: AOJu0YyBsvErOWp838F9+LZQTchg9pJ7d2kCHVginnGGwqlSgAvrW+yp Wh/jkEhUHN9PuCDYKOxP9fPUDevE8L8GLboSzeQzMGoE1TgrpVAEp1kx5ykeDmvmXp4SrO9EFDS gLFXwa/gp5w== X-Received: from dlbqj5.prod.google.com ([2002:a05:7022:ec05:b0:123:2b17:f461]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:4582:b0:11b:95fe:bee3 with SMTP id a92af1059eb24-1246aabf3f6mr7269627c88.37.1769100856331; Thu, 22 Jan 2026 08:54:16 -0800 (PST) Date: Thu, 22 Jan 2026 08:53:56 -0800 In-Reply-To: <20260122165407.561888-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260122165407.561888-1-irogers@google.com> X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog Message-ID: <20260122165407.561888-2-irogers@google.com> Subject: [PATCH v2 01/12] perf header: Fix memory leaks in process_cpu_domain_info From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , John Garry , Will Deacon , Leo Yan , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Zecheng Li , Tianyou Li , Thomas Falcon , Julia Lawall , Suchit Karunakaran , Athira Rajeev , Aditya Bodkhe , Howard Chu , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , "Dr. David Alan Gilbert" , Shimin Guo , Sergei Trofimovich , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" do_read_string returns a string in allocated memory, for some reason there was unused memory allocations and unnecessary strdups. Remove these and make the "perf annotate basic tests" leak sanitizer clean. Signed-off-by: Ian Rogers Fixes: d40c68a49f69 ("perf header: Support CPU DOMAIN relation info") --- tools/perf/util/header.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c index 9a15dd4b7640..eefd1cd73b6a 100644 --- a/tools/perf/util/header.c +++ b/tools/perf/util/header.c @@ -3634,6 +3634,7 @@ static int process_cpu_domain_info(struct feat_fd *ff= , void *data __maybe_unused if (!d_info) return -1; =20 + assert(cd_map[cpu]->domains[domain] =3D=3D NULL); cd_map[cpu]->domains[domain] =3D d_info; d_info->domain =3D domain; =20 @@ -3642,30 +3643,20 @@ static int process_cpu_domain_info(struct feat_fd *= ff, void *data __maybe_unused if (!dname) return -1; =20 - d_info->dname =3D zalloc(strlen(dname) + 1); - if (!d_info->dname) - return -1; - - d_info->dname =3D strdup(dname); + d_info->dname =3D dname; } =20 cpumask =3D do_read_string(ff); if (!cpumask) return -1; =20 - d_info->cpumask =3D zalloc(strlen(cpumask) + 1); - if (!d_info->cpumask) - return -1; - d_info->cpumask =3D strdup(cpumask); + d_info->cpumask =3D cpumask; =20 cpulist =3D do_read_string(ff); if (!cpulist) return -1; =20 - d_info->cpulist =3D zalloc(strlen(cpulist) + 1); - if (!d_info->cpulist) - return -1; - d_info->cpulist =3D strdup(cpulist); + d_info->cpulist =3D cpulist; } } =20 --=20 2.52.0.457.g6b5491de43-goog