From nobody Sun Feb 8 15:58:21 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A0BB42189F for ; Thu, 22 Jan 2026 15:19:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769095143; cv=none; b=VoiSY1hPIXsApuW/rcxhMWlNV4W5VMbSB/O0qeJ+78bU9j48I00CPWMSdFQ80vgk5+P9xDI47LgjPJMcu2w16/AvTmPqbWLViQSnW1kgbAIr1sp7k0ewLarW3fEtHdIrNDvQwxpc8XpewXZYvwxpaqrJ470c67XOmAkmLkUuiyA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769095143; c=relaxed/simple; bh=Nt47UFsOfhU+/Sa/WsYZT61v6HKZPeC+3cKH72ng46Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Sv2xbk6MrCzxb9OQ5uVg6iED2qs2pBWFNHP+u35aATNhkJx11sLSIRiFuTMGudTBr3DAMzVBW+rvmGT+kS9BZr8BhiozLTAJ8FnveTImyCrWj5m4aYXWMLA4TsQ4MdM8UP1DFqqbKcYIdWjTXaDH3XC7bfAEj+o0gk9ovIW4n/Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=F27+4tl9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F27+4tl9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96069C116C6; Thu, 22 Jan 2026 15:19:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769095143; bh=Nt47UFsOfhU+/Sa/WsYZT61v6HKZPeC+3cKH72ng46Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F27+4tl9g5ai8OC/CPoK5ZI5qEZbkL/ZYyabatTcmWCRlJZ+qSU5GhSWXfbluvDRt BtQ+mSG8+NomVY0I+YeTgZzKOwsCH3AGiYmurkdawxOpWRfxqBSEZQJFMQ4yXLWcAA f8ZdIs2pxZB3n6LL5N8Z4sRLXFpYdb0aMJMIDLVAUuyWorLkLC46xxtiOaE+WCK4VG vmFsGllHJ3JKNKcCksAYjlTOPftjQ14TqnI4z7BTYC8B1SW4ffjXFAMEpvezN0OxEs uuDfpz/yOOnqxVWefmXGAyMjoIOKjzFSKmLG31gmByZ+njmcOPWOS2ogmYq0gQGWFP MQmcyahrNeGvA== From: Pratyush Yadav To: Hugh Dickins , Baolin Wang , Andrew Morton , Pasha Tatashin , Mike Rapoport , Pratyush Yadav Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] mm: memfd_luo: restore and free memfd_luo_ser on failure Date: Thu, 22 Jan 2026 16:18:41 +0100 Message-ID: <20260122151842.4069702-4-pratyush@kernel.org> X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog In-Reply-To: <20260122151842.4069702-1-pratyush@kernel.org> References: <20260122151842.4069702-1-pratyush@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Pratyush Yadav (Google)" memfd_luo_ser has the serialization metadata. It is of no use once restoration fails. Free it on failure. Fixes: b3749f174d68 ("mm: memfd_luo: allow preserving memfd") Signed-off-by: Pratyush Yadav (Google) Reviewed-by: Mike Rapoport (Microsoft) Reviewed-by: Pasha Tatashin --- mm/memfd_luo.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/mm/memfd_luo.c b/mm/memfd_luo.c index 01a72e4d3ef6..a34fccc23b6a 100644 --- a/mm/memfd_luo.c +++ b/mm/memfd_luo.c @@ -447,7 +447,8 @@ static int memfd_luo_retrieve(struct liveupdate_file_op= _args *args) file =3D memfd_alloc_file("", 0); if (IS_ERR(file)) { pr_err("failed to setup file: %pe\n", file); - return PTR_ERR(file); + err =3D PTR_ERR(file); + goto free_ser; } =20 vfs_setpos(file, ser->pos, MAX_LFS_FILESIZE); @@ -473,7 +474,8 @@ static int memfd_luo_retrieve(struct liveupdate_file_op= _args *args) =20 put_file: fput(file); - +free_ser: + kho_restore_free(ser); return err; } =20 --=20 2.52.0.457.g6b5491de43-goog