From nobody Mon Feb 9 23:16:14 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE5E0355038 for ; Thu, 22 Jan 2026 15:10:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769094633; cv=none; b=TVEWPzj7PDSY78F7Et8T7uYqmEFwdzA/TcYIilp+6uHITVLv5pk4phl9a75f4FLax3AQiNeDCx1ilgE8D40zpQ7JosjJsI0sg5T7C1j4NJGucULveqFdOJjhJP08lUzbLn3NCWoPnkmRa2+p+GDXU9cROYqa0VzPs7rl7F6FVSc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769094633; c=relaxed/simple; bh=C4Hy5jJgJFgiJtT3bfjDFpiGxmP13VJ69+n4ZwRm4iY=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=s9v9uQT5oo/ux4fiPGe0GNJ1+DZGzoXSzLuigkSXOwCzYcQb9m62Z2Y6J3p8xN8iV4RkemUAjBt3FfHPcVZtNwyAzRIF0a/M6gwaAZ5ruHTkNrEUiEF7+/L1rAHnycurCV90Q+dkw1exv5uXX+mJtH7RTL28F+igRmBREbX0z1U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=DWlLbwaU; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=R9COu89r; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="DWlLbwaU"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="R9COu89r" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60M7XSmr107156 for ; Thu, 22 Jan 2026 15:10:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=ALflICnLm9d AF6K/Wk1dDN+VobBIOAmN5UmZDdeZ3Sg=; b=DWlLbwaU89OwpYB5NALN5kI0wFo 6SdDodiRPewHE7XycaYJDXRV6Eby2hpYMKW412A9UzSblA/fHA++H5OZ858AUigN AuSPYns2szMwS7diSmRV69XRGQcpgZXqSq/o90ueO5tsG3I13lmqtGAuD4KLBFin SxLTlNjZ/AxR0Lq7F+zPiIeU8/8O3wBZaOYLoq7lBwpIcczzllnQxFBzHVfI7mwi H1IK8epNZ+9rzx5nOIJ9YAO3SWNutC4a+k8gUz3RXNYQUmrABrxvhJlmiPSmPYWS egB60wp6hbx7d55wUCknbfmdA7fFRNaZ48uH2Hw9RAZyEvAVtFDvLBReppQ== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bu6pgtvuq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 22 Jan 2026 15:10:29 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-81f4c1412b8so182780b3a.2 for ; Thu, 22 Jan 2026 07:10:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769094628; x=1769699428; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ALflICnLm9dAF6K/Wk1dDN+VobBIOAmN5UmZDdeZ3Sg=; b=R9COu89r+IaD3z2dFRTBn1hAaWV2F2u0F+DVwSwQouLoHiRsHCtRj25wC89YIjRP3N pEdduqzdBNbsj78BAk8xub71Y37Et8CmrHrurUl0XrRn2DomQ3tFusJUv4i1cHtZnJuE da/fQ41sEPAexCFN1N/HljtD7De5L+9ubfVkS77yph9RnkcO9xgWz5wzUuN8dYKc5JRq GCSpgk7KtCfG1TFGHQruyugU4X87MSQYjrAhOp3n8qmytgedFt5xR6iVE0TEeX5itg5y E9W5N914XB1CJHiWivPDvyv2t5zjSdiAQRjdZMyXN8CPh6FsqGczkbfguQChsvC1Vu8U rAoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769094628; x=1769699428; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ALflICnLm9dAF6K/Wk1dDN+VobBIOAmN5UmZDdeZ3Sg=; b=n+Iwz8McBgFJaTPm0jvdi2q0RH5mOzvGP6qwPbJQdnr4eEfqFd6w8qfjaR+r6nOtBd xGmLzCxfrNBLVaFaR28/LfYoHyjaU0l7XzAdC0CVjbURId00o3HOB5Q/58M4nnxHv/Ts oFpgjrBT2mhb5cEI7z4FHDIzbMZM/5uDvt/3EWJH6swrPgWj+WIJLYbXWTEn6FxDgIhF YGF5DYOXX8VshJ1+DuiSicCH6+UvuX1am78vGMmdBZtbNEf2Uts47/CEfhpuSSt4LjEh 8j8WyM8fj4CzKegXq6oBlS+9lNTJK9GrW54rzfDOn7wKlcnM6F16SvDdq/MKzYHbPApe 4lFw== X-Forwarded-Encrypted: i=1; AJvYcCVEKLBqzC3qhIXGOt/ZkiX4m/XReeoV3WFF4wOfZTyuClApZgdkuB8wudiAv8gQW9gx1O2+ZUKst8aeXT0=@vger.kernel.org X-Gm-Message-State: AOJu0YymW4AbWgrYA6RV5u+h/mJ95v1FBvvsDM4Z4WCRiG+4jTo5H0PN P/CoT3kkYjHqNjWza4ZxpB3n+1SKuezGemv54v8iy+CBB2xY2MNwiUR0Z3vMfx9hQ+iDbVfCsZn cwSBLCl6ifnnrYq9JMfUa2SwLIun/IKrEjj02hfx9WrNrAK86HcvZx9s+epyl+okbldc= X-Gm-Gg: AZuq6aKrCIaDuMnE1UsoXoTxooojPirKL5d83p24Rhyw4mfQhVJiHS6WOmB8KBe/lGJ lwUgGj8+7DIsE8OTmQXcqJhZZFBA/QlD3aUqDC7cDd7gISV8keuGjAWQ/oDRqtO4maMy90hXyxN X0/vMd7C9qOq6aIWc7bYyfGhr9GXAhig41kEByZyws2JGTw6aAE8FH0GIw8CEzlnbib8EakNW+v 1aiezqdYwpyknGy8WtMDcQpAp6NMATt4XdWZXg1H93QGev4gxnHFAUtNyZKy0EmlUIn4TJpEgyY PR0vIjAmkfab6QAen2Jveh+TcqaCgXRjPamJq2o7B7LlnKMydH4It2r1hq0qThiC6nImVmJeg4N HZow06o8dpw+eGfbnphjINs76NrbXUtyCUCrqDrhmQdI= X-Received: by 2002:a05:6a00:4b0f:b0:81e:a17c:b439 with SMTP id d2e1a72fcca58-81fe87e9f3dmr8191829b3a.27.1769094627762; Thu, 22 Jan 2026 07:10:27 -0800 (PST) X-Received: by 2002:a05:6a00:4b0f:b0:81e:a17c:b439 with SMTP id d2e1a72fcca58-81fe87e9f3dmr8191782b3a.27.1769094627030; Thu, 22 Jan 2026 07:10:27 -0800 (PST) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8217c258fa7sm4328182b3a.17.2026.01.22.07.10.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jan 2026 07:10:26 -0800 (PST) From: Praveen Talari To: Mark Brown , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, mukesh.savaliya@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, Praveen Talari Subject: [PATCH v1 2/3] spi: geni-qcom: Fix abort sequence execution for serial engine errors Date: Thu, 22 Jan 2026 20:40:07 +0530 Message-Id: <20260122151008.2149252-3-praveen.talari@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260122151008.2149252-1-praveen.talari@oss.qualcomm.com> References: <20260122151008.2149252-1-praveen.talari@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIyMDExNiBTYWx0ZWRfXwMmUkzdZsx7h U3T8Ck7GWbBgqjzKdNy/xfjjx0RBkE5JSwqQaqzj0Lm/h179of9y9/LyPN8RkjTyCmzpgUZAZIY TmlHP1VkQrcgzpItIDBgQLkHi/O9tuwJZYdnIUJjpnI6PDbBjn+2V9cSJCEvYEnk/7s6kTYQtu4 HHzP1HBC28uiDBaioPbM39yY3X93JtO94hoyV4DKlRCS1AatIQ6pRH1UStwn1tJlm9IapqDeZ1v fysgir2XruE4C5h7r/dgygcCL27rndDy+Tl3Z0+8QI6ua3+lD+wI3VnHQrLtuuiueI18G5vay11 BrVTBWRQaLMF1AUiWRTp38Fs19H5cPpnUTZXPtleHetxQhFj667xJniswoLg6Tq4rZEqzldMnXL HCANbttYE7FKnXVo2fjihS151ZNzAzABf0RdkWeuw49FksLG5qHvCnVs/FpHR7HnzR6XRDqRa88 PwBG0DRCIfOge9ZuIJw== X-Authority-Analysis: v=2.4 cv=OZGVzxTY c=1 sm=1 tr=0 ts=69723de5 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=PwoySFKYIoUPqChjOH0A:9 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-ORIG-GUID: fu0-epE5gE6tMMXwqdR0ixGGriIw-mHg X-Proofpoint-GUID: fu0-epE5gE6tMMXwqdR0ixGGriIw-mHg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-22_02,2026-01-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 adultscore=0 suspectscore=0 clxscore=1015 phishscore=0 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601220116 Content-Type: text/plain; charset="utf-8" The driver currently skips the abort sequence for target mode when serial engine errors occur. This leads to improper error recovery as the serial engine may remain in an undefined state without proper cleanup, potentially causing subsequent operations to fail or behave unpredictably. Fix this by ensuring the abort sequence and DMA reset always execute during error recovery, as both are required for proper serial engine error handling. Signed-off-by: Praveen Talari --- drivers/spi/spi-geni-qcom.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c index f5d05025b196..e5320e2fb834 100644 --- a/drivers/spi/spi-geni-qcom.c +++ b/drivers/spi/spi-geni-qcom.c @@ -167,7 +167,7 @@ static void handle_se_timeout(struct spi_controller *sp= i, * doesn`t support CMD Cancel sequnece */ spin_unlock_irq(&mas->lock); - goto reset_if_dma; + goto abort; } =20 reinit_completion(&mas->cancel_done); @@ -178,6 +178,7 @@ static void handle_se_timeout(struct spi_controller *sp= i, if (time_left) goto reset_if_dma; =20 +abort: spin_lock_irq(&mas->lock); reinit_completion(&mas->abort_done); geni_se_abort_m_cmd(se); --=20 2.34.1