From nobody Tue Feb 10 01:59:10 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA54234FF60 for ; Thu, 22 Jan 2026 15:10:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769094626; cv=none; b=KHTltlUQzH8FcJ2LilgT3I0grdPCsB6XL+d67FZfkw04BFbu8V+0yTyd1U1SjI16KoLjeXqb1qcO4KV/EFRGfGxCQaFxGwjaqKjpAQC80wnDvXZy1Zm0FFEkRjkHMBn4IlU1nLMBGUvDfy4dbK9DO3Di+lo/vmGCaOdrTOvGM0s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769094626; c=relaxed/simple; bh=wRMlMUOjNaNt0fRe8bIGnbbQF2FAo1GXnXeodrX1dvI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Z3jhCHoCfwwREJkrbz7T6qQTvlcI4nhHluFIzeTGKEKKCBD1cnST2yblQ/6FWz/e8KABDPhpghQUelMcjERj79o7rS5E16RNuUHF67ux3SaNAnzAMC5H3i8OG1zUFTx5TZ94vyGqpSXj0A3eUTDiF7E706h0oGK2CwzEDmYg/LE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QzDPhdyg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=iDfSyZUq; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QzDPhdyg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="iDfSyZUq" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60M7jcp9788839 for ; Thu, 22 Jan 2026 15:10:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=xyqIphb3PH9 WrLK8b/LVLC85X+KOkuonBJmPjmbkCOo=; b=QzDPhdygolWmuxVj6WLzmBK0XTD zE6RFeebgWQHlZ3BTAoIh3HIikDh9yFOrlxjoUgaxoW59BDSeW9oeqKxAhAENmlY WmWvjsuPd7H2o8xhz33VKZcJ1eUsBENfzmnWum4h9ewb49KojXCRIr99vR0L5/MZ EvI0S3rGu/4X+SOVD3V9fXD/PFsYIyFg7Rk9UYqZtkU5pQigj4iUxkRjFOsaA2E0 zAGSmkfK+CVbeT4q1CUaZiL/8XDiv72tynnaB4uPJ76dgHPM2tknWh3yW/JkIPHj ij0tiykYYxaGOaIRxQlDXgt9rOYx7dcKmo9M6hno0ISaU4bozPu9cf/lmog== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bu6p1jvbj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 22 Jan 2026 15:10:23 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-81f8c209cfbso741469b3a.2 for ; Thu, 22 Jan 2026 07:10:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769094623; x=1769699423; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xyqIphb3PH9WrLK8b/LVLC85X+KOkuonBJmPjmbkCOo=; b=iDfSyZUqb3Jc62ORRurQZDhusV2rNIIPSkS/yD6njb7oWWX+f+wuLlaAUc6CYuUn0C jCID6TYGM+bFX77rChJv0Q8mqIKmF1UZCipSI2XzSz4L4IJEruO7Kx6hvq2vkeTFJ1xJ r+c9tolqGJ0MGUot4am42NS2S4ZjCaeoTlmzMgVf18rl9RwKDPDZ1mbWKbzmS6msTa3d ciM5R0E9f1Zxy3jbD14DUtpWyPcG60X7+UYgO8dRFCEduZEbJifmLpnr5sLGe2OfSKxi EgO8ytzG+D0rJNmmYAvd8lL5TjzzOJq2hGlVRzXY1s3N9eK/c0Fz0gETac/9nfxujx8U ADqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769094623; x=1769699423; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xyqIphb3PH9WrLK8b/LVLC85X+KOkuonBJmPjmbkCOo=; b=MjBLxC2eGBsg16fSxBu0lor8nzA3hG/Dd2XQoR1CpI4euDp9gkXWhODeOOeOpEYRif 8MjjEg4QyIaMwBRzPWOGAJzHbAxY25ymq/P0S262SJcp1NmszS9htzmvxYnofIfpXygL 6N7SC854pWX4zdNQ5Mwo4WVTq5xYsYhRlxYm0Smj74shxY7UkRLhys56ovgUiXBgpHae YYKDvChZUoCkSOISNMqDwRaqMBSprjTQAQxHT1arzNbDTJ4rQFj6wX9cKQ5+RY0KpOMw a39Jq2GwjVuUYVMGpFzpr83csSnD9/yqsobDv0ItNnb6NymH5rqRU9rNVuKJEtP+Cz5b dlAw== X-Forwarded-Encrypted: i=1; AJvYcCUM8JvzvwaBKG0IllmkBUDskvCPlEiqTEnAMbYNUcZN0E5K+A2YT/kVdJh3uYEeq00kPdKNg/e6Zbo8YX8=@vger.kernel.org X-Gm-Message-State: AOJu0YwQjiuTEUgQOG/zfI11JBTn1Mc9ei+dayDn0YmDNpNqP1atM2AC q18Kwjq1kJpMhiacoz9eQdE/jffpSw/bwdzUEnwMtNR+3PAtVmW82feIWnGgLGTnpsTsLmkbhQB w/F0LBNWQpMOT0xdYgdZlhD28izqSt3jUAKoWTMzK1pE6HOeFEJS9UxWGwjB63Hor+8k= X-Gm-Gg: AZuq6aIpyxvypii4ibMXGq5qxOPxCVe2Bcfrp65vtjoGma2T2DNZ4u1l3VeQJIdmos3 hZjE27CD0GabB1dBcE84roSKINyKlHWWATZbgQMjJtS6iXmqhWjJnRmYX4KgVbixdU3eoPZumWU zlmnWtXucjl7smSH1uahxcvegQgGHiiIvEiwwVa8UE8/llMOwddQvYK5mEKh/V58alNBaA+r50s ptk5vXtT0VDJLM6zpHx7FK+mfC7N2lwfk5c7/n21G1uNcF/V0pSxW85Xv9dJfiRqmYL6N7qpd83 KSNAG3waKfqYvhsGZ1Va2NlPesAwc/Dvpgiy2YNutPSxBI9SQFov0kGKCUS4KFs2y5pLCL8VPms 8d9u0WakVrkGRN3sReC/Cc4N+p95WlJCpImyqI3TJaug= X-Received: by 2002:a05:6a00:10c4:b0:81f:42b7:e589 with SMTP id d2e1a72fcca58-81fa0354717mr18941125b3a.45.1769094622622; Thu, 22 Jan 2026 07:10:22 -0800 (PST) X-Received: by 2002:a05:6a00:10c4:b0:81f:42b7:e589 with SMTP id d2e1a72fcca58-81fa0354717mr18941090b3a.45.1769094622030; Thu, 22 Jan 2026 07:10:22 -0800 (PST) Received: from hu-ptalari-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8217c258fa7sm4328182b3a.17.2026.01.22.07.10.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jan 2026 07:10:21 -0800 (PST) From: Praveen Talari To: Mark Brown , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, konrad.dybcio@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, mukesh.savaliya@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com, Praveen Talari Subject: [PATCH v1 1/3] spi: geni-qcom: Improve target mode allocation by using proper allocation functions Date: Thu, 22 Jan 2026 20:40:06 +0530 Message-Id: <20260122151008.2149252-2-praveen.talari@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260122151008.2149252-1-praveen.talari@oss.qualcomm.com> References: <20260122151008.2149252-1-praveen.talari@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-ORIG-GUID: FfEgCuF8qmAFmT6FwNof8JSWYvSahdnd X-Authority-Analysis: v=2.4 cv=N7ck1m9B c=1 sm=1 tr=0 ts=69723ddf cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=Bup7t0bCmiTjNce0pOAA:9 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-GUID: FfEgCuF8qmAFmT6FwNof8JSWYvSahdnd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIyMDExNiBTYWx0ZWRfX8e4L1FLS/hlC cSsWMVSak30Yc3/o3GXM2xUmCcd72kxSFVBhUFxcXF+iVPc0vKcIiCmaXTvcgRfblzk4WtM7jCG JrfnT5fQmt+cEjtMznl4bPoVqunQODTrNfO3SpCOMCSQGX7dFRuaYdJAQY9eJ1yHKIDqAbDmGwJ F/xBnF1iCM/OSZHM3MLciBVlali8BWFN/7RQMs2kcuLmpa1KdutCVsWnaQoX/f/OxZcSC1ghTsR fitkZM81yT3Ipe+dnDQGut0izMHV2MO5OTPgeNHD9wphUZYqQJQNjzioZdEt4M94R0dZaUdRwGU 26Nd1gtAN97I42b040pW/qA6G00BFngcX73f76B9XY5pzMYVVJTYHGEaHuzIptY5ZQBGSe3DHLT /hnYrbKsYjU2r2hTgOLxZ0XAiss+5g+IFT3CwhZN1ece65eyUp+alx3HZqUAeM4uV0TujyMlRTO O7yNpjAsmOoVtCBJ/iQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-22_02,2026-01-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 phishscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 adultscore=0 impostorscore=0 suspectscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601220116 Content-Type: text/plain; charset="utf-8" The current implementation always allocates a host controller and sets the target flag later when the "spi-slave" device tree property is present. This approach is suboptimal as it doesn't utilize the dedicated allocation functions designed for target mode. Use devm_spi_alloc_target() when "spi-slave" device tree property is present, otherwise use devm_spi_alloc_host(). This replaces the previous approach of always allocating a host controller and setting target flag later. Signed-off-by: Praveen Talari --- drivers/spi/spi-geni-qcom.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c index 0e5fd9df1a8f..f5d05025b196 100644 --- a/drivers/spi/spi-geni-qcom.c +++ b/drivers/spi/spi-geni-qcom.c @@ -1017,6 +1017,14 @@ static int spi_geni_probe(struct platform_device *pd= ev) struct clk *clk; struct device *dev =3D &pdev->dev; =20 + if (device_property_read_bool(dev, "spi-slave")) + spi =3D devm_spi_alloc_target(dev, sizeof(*mas)); + else + spi =3D devm_spi_alloc_host(dev, sizeof(*mas)); + + if (!spi) + return -ENOMEM; + irq =3D platform_get_irq(pdev, 0); if (irq < 0) return irq; @@ -1033,10 +1041,6 @@ static int spi_geni_probe(struct platform_device *pd= ev) if (IS_ERR(clk)) return PTR_ERR(clk); =20 - spi =3D devm_spi_alloc_host(dev, sizeof(*mas)); - if (!spi) - return -ENOMEM; - platform_set_drvdata(pdev, spi); mas =3D spi_controller_get_devdata(spi); mas->irq =3D irq; @@ -1087,9 +1091,6 @@ static int spi_geni_probe(struct platform_device *pde= v) if (ret) return ret; =20 - if (device_property_read_bool(&pdev->dev, "spi-slave")) - spi->target =3D true; - /* Set the bus quota to a reasonable value for register access */ mas->se.icc_paths[GENI_TO_CORE].avg_bw =3D Bps_to_icc(CORE_2X_50_MHZ); mas->se.icc_paths[CPU_TO_GENI].avg_bw =3D GENI_DEFAULT_BW; --=20 2.34.1