From nobody Sat Feb 7 05:44:23 2026 Received: from relay14.grserver.gr (relay14.grserver.gr [157.180.73.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC40830E85B; Thu, 22 Jan 2026 07:51:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=157.180.73.62 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769068281; cv=none; b=NHvPTz5tABUI9xO6xhUCOxOTFp7QvV7Ki5I5rxvlzm7HpgSDwj3YNpvEz7sFyr/iTegXRpcr2u+i0SGu+qdLnoSeXtVyHI84V0RGUmIvtWYkuTdr07RSqazaatu9rFMQFhmNgX0aK12RRp9ecuCBqw2qP9fxuGnSVxR66ip0jOI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769068281; c=relaxed/simple; bh=pc0TynEBwSOWQe+RRBaebtQ2S+ycUYyHP0N+DQGCVAM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=K2sto5JyhUsXoHKSzdaUTe+qNA+CYoQuB/gB6ydk+1L5yGF9z37VKPltgVjeeNnkCz5Dc2ijZMomSzSMtTJtOrUgAT1WQmvhfD546ALo4SelFHifXdgdRWjC5GVIxoY6DpUykuzslvDulnN6CyaPW4MwiwmfQNxbFCVhI5VeVeg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=antheas.dev; spf=pass smtp.mailfrom=antheas.dev; dkim=pass (2048-bit key) header.d=antheas.dev header.i=@antheas.dev header.b=GnmWiFpH; arc=none smtp.client-ip=157.180.73.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=antheas.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=antheas.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=antheas.dev header.i=@antheas.dev header.b="GnmWiFpH" Received: from relay14 (localhost [127.0.0.1]) by relay14.grserver.gr (Proxmox) with ESMTP id 51A66409C2; Thu, 22 Jan 2026 07:51:07 +0000 (UTC) Received: from linux3247.grserver.gr (linux3247.grserver.gr [213.158.90.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by relay14.grserver.gr (Proxmox) with ESMTPS id 831F7408F9; Thu, 22 Jan 2026 07:51:06 +0000 (UTC) Received: from antheas-z13 (unknown [IPv6:2a05:f6c3:fefd:0:42c:a43d:2848:c282]) by linux3247.grserver.gr (Postfix) with ESMTPSA id 305F11FD632; Thu, 22 Jan 2026 09:51:01 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=antheas.dev; s=default; t=1769068266; bh=yj7c46aPPtuuE4eFf8Cac1PSO4Q1/0CiciGLO51xuAs=; h=From:To:Subject; b=GnmWiFpHCkYHCd49aE/SwegldxcnnyRt0PSROVUHZuXH3NwOPCiIw1Jk8yE2qRdot Lrl1KWshmii9oLeX7O8h4AL+lnOhVpspu6HsuuP5Ox35Q6exUr3lqdpoqQB0Nr90zX UZsobLMUC+w+VUa6oAavnRoqc3VN07V/ZJimgO+PT5RYAqC2VoPxP85dBguVSexdmq Zn1FuYObzMzYzVoQxcq+HR3f4IqMqT3bxd+M9EH2AjAXJWVzvyuMR/sIEufgjzKbFy 1GjU5mbQKtoRHu9lt4RlqZ+84hZBMEg2K8wgVusLO4/EWCUkUHg/eXJ7zBtvvZuni0 2zilRS8bH/xNw== Authentication-Results: linux3247.grserver.gr; spf=pass (sender IP is 2a05:f6c3:fefd:0:42c:a43d:2848:c282) smtp.mailfrom=lkml@antheas.dev smtp.helo=antheas-z13 Received-SPF: pass (linux3247.grserver.gr: connection is authenticated) From: Antheas Kapenekakis To: platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Corentin Chary , "Luke D . Jones" , Hans de Goede , =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Denis Benato , Antheas Kapenekakis , Denis Benato Subject: [PATCH v12 03/11] HID: asus: use same report_id in response Date: Thu, 22 Jan 2026 08:50:36 +0100 Message-ID: <20260122075044.5070-4-lkml@antheas.dev> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260122075044.5070-1-lkml@antheas.dev> References: <20260122075044.5070-1-lkml@antheas.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-PPP-Message-ID: <176906826578.713286.10678181367894666234@linux3247.grserver.gr> X-PPP-Vhost: antheas.dev X-Virus-Scanned: clamav-milter 1.4.3 at linux3247.grserver.gr X-Virus-Status: Clean Content-Type: text/plain; charset="utf-8" Currently, asus_kbd_get_functions prods the device using feature report report_id, but then is hardcoded to check the response through FEATURE_KBD_REPORT_ID. This only works if report_id is that value (currently true). So, use report_id in the response as well to maintain functionality if that value changes in the future. Reviewed-by: Denis Benato Acked-by: Benjamin Tissoires Signed-off-by: Antheas Kapenekakis --- drivers/hid/hid-asus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c index 92904b5a700c..2ff2170dc30a 100644 --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -424,7 +424,7 @@ static int asus_kbd_get_functions(struct hid_device *hd= ev, if (!readbuf) return -ENOMEM; =20 - ret =3D hid_hw_raw_request(hdev, FEATURE_KBD_REPORT_ID, readbuf, + ret =3D hid_hw_raw_request(hdev, report_id, readbuf, FEATURE_KBD_REPORT_SIZE, HID_FEATURE_REPORT, HID_REQ_GET_REPORT); if (ret < 0) { --=20 2.52.0