From nobody Sun Feb 8 06:54:27 2026 Received: from mail-dl1-f73.google.com (mail-dl1-f73.google.com [74.125.82.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CBB4480DDC for ; Thu, 22 Jan 2026 07:31:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769067107; cv=none; b=Qx/fnwVHgpgUujenh/WZlD5DQeFjvDGhrlDA9BY9TAsDbCh0witbNPsA2P07ql4nUY0ZggZ1mBTEydqJMX01jZpVhyaVOCDJtkjBt+vJVA7zhaPsxPDfvSn1Cox5UZENjGTMeGSw8XckrZlSmdXkX/5oFDivbif55ey0rZRF6nk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769067107; c=relaxed/simple; bh=1bW1Peu/3bHriuNX0VZiSQoCul8ziTpIqzATgln7d90=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Content-Type; b=nMPoNcvceVVPp2Vt9ZKTbYocZnlTNrunM8GY/xLyLbYsoVowsXZ/BoQF6ZJae1/ZNiMGv6aNATb69Oyuk//yFNa6W6/hGz4zyusZzuRIoeEJJgo8GJAg863myN6Hx8/d0qkELeodARi9lc+qBdB3Zkg9mP0e0FgwR9bKIzae4F8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=q430DyJ1; arc=none smtp.client-ip=74.125.82.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--irogers.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="q430DyJ1" Received: by mail-dl1-f73.google.com with SMTP id a92af1059eb24-124627fc58dso1350364c88.1 for ; Wed, 21 Jan 2026 23:31:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769067098; x=1769671898; darn=vger.kernel.org; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :from:to:cc:subject:date:message-id:reply-to; bh=G3Q6y9uuDnZT4fchJSYQvOs3qoNM/plkLt24+BhC4KM=; b=q430DyJ1JzMiGC27Gnhb6Zzjv9Xwt7Cs3VXudQxo3LrgCa1g+WgAmmcvH5KE8wWutn mOdzH58wtunyEwAN0TPtsvPfut5UVxjRbq2KlJe9/ECg74pXGOXyi8IXNmffEI3tM/YI zglhBk3Wwh/tSpdgzHUiwdo9SUGpTE+NSQbHy8mivQyDjFPkSrCsV2nEIipX5coKIjPs RiS4quIGJpg0flVPlyOFEf+N/RvQSesd8fqDX6mFjtBzVVCUaxmJzUixJipjO+Resewq Sjevi00jSw7mBNoFx/qG4CxY52ZDCHtM9TJSDPnpJWujqckqDPuNUQli7VpJSVW4cBf8 GfCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769067098; x=1769671898; h=to:from:subject:message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G3Q6y9uuDnZT4fchJSYQvOs3qoNM/plkLt24+BhC4KM=; b=ePhCGVBWWpgBvIhqnucWLB4Ale7zuXY6V5kQPF5dYZwrR/1dU8GBtApkggIvVcOfer BbfnDpMF8nj66Mc4x03aBYsyqlm3c16RSQtgaLFGXEyYL0S8ZeYFmi9lPFimXvhBPK/w z2KJlRof8OSU/MFa84eyxOz87L+Wuiy6tXExSl/OO+/M9IZXSAUyQ0PUDS00knv7e8Xj buG07VPtxh82kUkpipq+FtFPGZaID8UQXrRI/r37kEA5LQoOM6B0jisaWN4qwBbadXwk javFWPPG7diGLfJbQHXSqj5M9BSS1hMkpXnEcfnFjHtGRxGLYs5D0N+OoTMYdqvChdB8 gjQQ== X-Forwarded-Encrypted: i=1; AJvYcCVcFBDZ/66mqLmUisxbNBuq5adH7ZCuEep1qhCgcH1IE+ufanptN3yISQvmh/r2C40z3bWAx9gZ1LIwN1c=@vger.kernel.org X-Gm-Message-State: AOJu0YxbLuvfzF2FcofxSpZd9MdhA+GxqAgPInUJF7caljUqSapOmnSY caZe1M+Dw07ufdfTYvmEBBaErzLSjniz89kBH90zSRu41vfWFgmJJWmc1yoz/3B/cx4EyxCkSU+ LUs8mGd627A== X-Received: from dlbvv19.prod.google.com ([2002:a05:7022:5f13:b0:119:9f33:34a6]) (user=irogers job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:6b93:b0:122:3a5:fc42 with SMTP id a92af1059eb24-1246aa67352mr4639077c88.20.1769067097397; Wed, 21 Jan 2026 23:31:37 -0800 (PST) Date: Wed, 21 Jan 2026 23:31:20 -0800 In-Reply-To: <20260122073127.375139-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260122073127.375139-1-irogers@google.com> X-Mailer: git-send-email 2.52.0.457.g6b5491de43-goog Message-ID: <20260122073127.375139-5-irogers@google.com> Subject: [PATCH v1 04/11] perf disasm: Constify use of struct ins_op From: Ian Rogers To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , John Garry , Will Deacon , Leo Yan , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Zecheng Li , Tianyou Li , Thomas Falcon , Julia Lawall , Suchit Karunakaran , Athira Rajeev , Aditya Bodkhe , Howard Chu , "=?UTF-8?q?Krzysztof=20=C5=81opatowski?=" , "Dr. David Alan Gilbert" , Shimin Guo , Sergei Trofimovich , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The struct ins_op holds variables to function pointers that are read but not written. Change uses to be for a "const struct ins_op *" version to capture this immutability. Signed-off-by: Ian Rogers --- tools/perf/arch/arm/annotate/instructions.c | 4 +- tools/perf/arch/arm64/annotate/instructions.c | 6 +-- tools/perf/arch/csky/annotate/instructions.c | 6 +-- .../arch/loongarch/annotate/instructions.c | 8 ++-- tools/perf/arch/mips/annotate/instructions.c | 4 +- .../perf/arch/powerpc/annotate/instructions.c | 6 +-- .../perf/arch/riscv64/annotate/instructions.c | 4 +- tools/perf/arch/s390/annotate/instructions.c | 8 ++-- tools/perf/arch/sparc/annotate/instructions.c | 4 +- tools/perf/util/disasm.c | 46 +++++++++---------- tools/perf/util/disasm.h | 6 +-- 11 files changed, 51 insertions(+), 51 deletions(-) diff --git a/tools/perf/arch/arm/annotate/instructions.c b/tools/perf/arch/= arm/annotate/instructions.c index 5e667b0f5512..b997d127fedd 100644 --- a/tools/perf/arch/arm/annotate/instructions.c +++ b/tools/perf/arch/arm/annotate/instructions.c @@ -11,10 +11,10 @@ struct arm_annotate { jump_insn; }; =20 -static struct ins_ops *arm__associate_instruction_ops(struct arch *arch, c= onst char *name) +static const struct ins_ops *arm__associate_instruction_ops(struct arch *a= rch, const char *name) { struct arm_annotate *arm =3D arch->priv; - struct ins_ops *ops; + const struct ins_ops *ops; regmatch_t match[2]; =20 if (!regexec(&arm->call_insn, name, 2, match, 0)) diff --git a/tools/perf/arch/arm64/annotate/instructions.c b/tools/perf/arc= h/arm64/annotate/instructions.c index 5099fa36180d..363af2f55122 100644 --- a/tools/perf/arch/arm64/annotate/instructions.c +++ b/tools/perf/arch/arm64/annotate/instructions.c @@ -63,15 +63,15 @@ static int arm64_mov__parse(const struct arch *arch __m= aybe_unused, static int mov__scnprintf(struct ins *ins, char *bf, size_t size, struct ins_operands *ops, int max_ins_name); =20 -static struct ins_ops arm64_mov_ops =3D { +static const struct ins_ops arm64_mov_ops =3D { .parse =3D arm64_mov__parse, .scnprintf =3D mov__scnprintf, }; =20 -static struct ins_ops *arm64__associate_instruction_ops(struct arch *arch,= const char *name) +static const struct ins_ops *arm64__associate_instruction_ops(struct arch = *arch, const char *name) { struct arm64_annotate *arm =3D arch->priv; - struct ins_ops *ops; + const struct ins_ops *ops; regmatch_t match[2]; =20 if (!regexec(&arm->jump_insn, name, 2, match, 0)) diff --git a/tools/perf/arch/csky/annotate/instructions.c b/tools/perf/arch= /csky/annotate/instructions.c index 14270311d215..4a55c84a320a 100644 --- a/tools/perf/arch/csky/annotate/instructions.c +++ b/tools/perf/arch/csky/annotate/instructions.c @@ -3,10 +3,10 @@ =20 #include =20 -static struct ins_ops *csky__associate_ins_ops(struct arch *arch, - const char *name) +static const struct ins_ops *csky__associate_ins_ops(struct arch *arch, + const char *name) { - struct ins_ops *ops =3D NULL; + const struct ins_ops *ops =3D NULL; =20 /* catch all kind of jumps */ if (!strcmp(name, "bt") || diff --git a/tools/perf/arch/loongarch/annotate/instructions.c b/tools/perf= /arch/loongarch/annotate/instructions.c index 4ca4fb6bbcf9..ee360faad420 100644 --- a/tools/perf/arch/loongarch/annotate/instructions.c +++ b/tools/perf/arch/loongarch/annotate/instructions.c @@ -49,7 +49,7 @@ static int loongarch_call__parse(const struct arch *arch,= struct ins_operands *o return 0; } =20 -static struct ins_ops loongarch_call_ops =3D { +static const struct ins_ops loongarch_call_ops =3D { .parse =3D loongarch_call__parse, .scnprintf =3D call__scnprintf, }; @@ -98,15 +98,15 @@ static int loongarch_jump__parse(const struct arch *arc= h, struct ins_operands *o return 0; } =20 -static struct ins_ops loongarch_jump_ops =3D { +static const struct ins_ops loongarch_jump_ops =3D { .parse =3D loongarch_jump__parse, .scnprintf =3D jump__scnprintf, }; =20 static -struct ins_ops *loongarch__associate_ins_ops(struct arch *arch, const char= *name) +const struct ins_ops *loongarch__associate_ins_ops(struct arch *arch, cons= t char *name) { - struct ins_ops *ops =3D NULL; + const struct ins_ops *ops =3D NULL; =20 if (!strcmp(name, "bl")) ops =3D &loongarch_call_ops; diff --git a/tools/perf/arch/mips/annotate/instructions.c b/tools/perf/arch= /mips/annotate/instructions.c index b50b46c613d6..0fbe0a7df95a 100644 --- a/tools/perf/arch/mips/annotate/instructions.c +++ b/tools/perf/arch/mips/annotate/instructions.c @@ -1,9 +1,9 @@ // SPDX-License-Identifier: GPL-2.0 =20 static -struct ins_ops *mips__associate_ins_ops(struct arch *arch, const char *nam= e) +const struct ins_ops *mips__associate_ins_ops(struct arch *arch, const cha= r *name) { - struct ins_ops *ops =3D NULL; + const struct ins_ops *ops =3D NULL; =20 if (!strncmp(name, "bal", 3) || !strncmp(name, "bgezal", 6) || diff --git a/tools/perf/arch/powerpc/annotate/instructions.c b/tools/perf/a= rch/powerpc/annotate/instructions.c index ca567cfdcbdb..d1be55425e35 100644 --- a/tools/perf/arch/powerpc/annotate/instructions.c +++ b/tools/perf/arch/powerpc/annotate/instructions.c @@ -1,10 +1,10 @@ // SPDX-License-Identifier: GPL-2.0 #include =20 -static struct ins_ops *powerpc__associate_instruction_ops(struct arch *arc= h, const char *name) +static const struct ins_ops *powerpc__associate_instruction_ops(struct arc= h *arch, const char *name) { int i; - struct ins_ops *ops; + const struct ins_ops *ops; =20 /* * - Interested only if instruction starts with 'b'. @@ -189,7 +189,7 @@ static int cmp_offset(const void *a, const void *b) return (val1->value - val2->value); } =20 -static struct ins_ops *check_ppc_insn(struct disasm_line *dl) +static const struct ins_ops *check_ppc_insn(struct disasm_line *dl) { int raw_insn =3D dl->raw.raw_insn; int opcode =3D PPC_OP(raw_insn); diff --git a/tools/perf/arch/riscv64/annotate/instructions.c b/tools/perf/a= rch/riscv64/annotate/instructions.c index 55cf911633f8..a34798864fab 100644 --- a/tools/perf/arch/riscv64/annotate/instructions.c +++ b/tools/perf/arch/riscv64/annotate/instructions.c @@ -1,9 +1,9 @@ // SPDX-License-Identifier: GPL-2.0 =20 static -struct ins_ops *riscv64__associate_ins_ops(struct arch *arch, const char *= name) +const struct ins_ops *riscv64__associate_ins_ops(struct arch *arch, const = char *name) { - struct ins_ops *ops =3D NULL; + const struct ins_ops *ops =3D NULL; =20 if (!strncmp(name, "jal", 3) || !strncmp(name, "jr", 2) || diff --git a/tools/perf/arch/s390/annotate/instructions.c b/tools/perf/arch= /s390/annotate/instructions.c index 8d66c0ea3810..38f7e918ebf8 100644 --- a/tools/perf/arch/s390/annotate/instructions.c +++ b/tools/perf/arch/s390/annotate/instructions.c @@ -46,7 +46,7 @@ static int s390_call__parse(const struct arch *arch, stru= ct ins_operands *ops, return 0; } =20 -static struct ins_ops s390_call_ops =3D { +static const struct ins_ops s390_call_ops =3D { .parse =3D s390_call__parse, .scnprintf =3D call__scnprintf, }; @@ -100,14 +100,14 @@ static int s390_mov__parse(const struct arch *arch __= maybe_unused, } =20 =20 -static struct ins_ops s390_mov_ops =3D { +static const struct ins_ops s390_mov_ops =3D { .parse =3D s390_mov__parse, .scnprintf =3D mov__scnprintf, }; =20 -static struct ins_ops *s390__associate_ins_ops(struct arch *arch, const ch= ar *name) +static const struct ins_ops *s390__associate_ins_ops(struct arch *arch, co= nst char *name) { - struct ins_ops *ops =3D NULL; + const struct ins_ops *ops =3D NULL; =20 /* catch all kind of jumps */ if (strchr(name, 'j') || diff --git a/tools/perf/arch/sparc/annotate/instructions.c b/tools/perf/arc= h/sparc/annotate/instructions.c index 68c31580ccfc..a08d8734c883 100644 --- a/tools/perf/arch/sparc/annotate/instructions.c +++ b/tools/perf/arch/sparc/annotate/instructions.c @@ -117,9 +117,9 @@ static int is_branch_float_cond(const char *cond) return 0; } =20 -static struct ins_ops *sparc__associate_instruction_ops(struct arch *arch,= const char *name) +static const struct ins_ops *sparc__associate_instruction_ops(struct arch = *arch, const char *name) { - struct ins_ops *ops =3D NULL; + const struct ins_ops *ops =3D NULL; =20 if (!strcmp(name, "call") || !strcmp(name, "jmp") || diff --git a/tools/perf/util/disasm.c b/tools/perf/util/disasm.c index d41a0f96a6f6..dbeb89047fd1 100644 --- a/tools/perf/util/disasm.c +++ b/tools/perf/util/disasm.c @@ -33,15 +33,15 @@ static regex_t file_lineno; =20 /* These can be referred from the arch-dependent code */ -static struct ins_ops call_ops; -static struct ins_ops dec_ops; -static struct ins_ops jump_ops; -static struct ins_ops mov_ops; -static struct ins_ops nop_ops; -static struct ins_ops lock_ops; -static struct ins_ops ret_ops; -static struct ins_ops load_store_ops; -static struct ins_ops arithmetic_ops; +static const struct ins_ops call_ops; +static const struct ins_ops dec_ops; +static const struct ins_ops jump_ops; +static const struct ins_ops mov_ops; +static const struct ins_ops nop_ops; +static const struct ins_ops lock_ops; +static const struct ins_ops ret_ops; +static const struct ins_ops load_store_ops; +static const struct ins_ops arithmetic_ops; =20 static int jump__scnprintf(struct ins *ins, char *bf, size_t size, struct ins_operands *ops, int max_ins_name); @@ -85,7 +85,7 @@ static int arch__grow_instructions(struct arch *arch) goto out_update_instructions; } =20 -static int arch__associate_ins_ops(struct arch* arch, const char *name, st= ruct ins_ops *ops) +static int arch__associate_ins_ops(struct arch *arch, const char *name, co= nst struct ins_ops *ops) { struct ins *ins; =20 @@ -334,7 +334,7 @@ static int call__scnprintf(struct ins *ins, char *bf, s= ize_t size, return scnprintf(bf, size, "%-*s *%" PRIx64, max_ins_name, ins->name, ops= ->target.addr); } =20 -static struct ins_ops call_ops =3D { +static const struct ins_ops call_ops =3D { .parse =3D call__parse, .scnprintf =3D call__scnprintf, }; @@ -487,7 +487,7 @@ static void jump__delete(struct ins_operands *ops __may= be_unused) */ } =20 -static struct ins_ops jump_ops =3D { +static const struct ins_ops jump_ops =3D { .free =3D jump__delete, .parse =3D jump__parse, .scnprintf =3D jump__scnprintf, @@ -579,7 +579,7 @@ static void lock__delete(struct ins_operands *ops) zfree(&ops->target.name); } =20 -static struct ins_ops lock_ops =3D { +static const struct ins_ops lock_ops =3D { .free =3D lock__delete, .parse =3D lock__parse, .scnprintf =3D lock__scnprintf, @@ -688,7 +688,7 @@ static int mov__scnprintf(struct ins *ins, char *bf, si= ze_t size, ops->target.name ?: ops->target.raw); } =20 -static struct ins_ops mov_ops =3D { +static const struct ins_ops mov_ops =3D { .parse =3D mov__parse, .scnprintf =3D mov__scnprintf, }; @@ -738,7 +738,7 @@ static int arithmetic__parse(const struct arch *arch __= maybe_unused, struct ins_ return 0; } =20 -static struct ins_ops arithmetic_ops =3D { +static const struct ins_ops arithmetic_ops =3D { .parse =3D arithmetic__parse, .scnprintf =3D arithmetic__scnprintf, }; @@ -772,7 +772,7 @@ static int load_store__parse(const struct arch *arch __= maybe_unused, struct ins_ return 0; } =20 -static struct ins_ops load_store_ops =3D { +static const struct ins_ops load_store_ops =3D { .parse =3D load_store__parse, .scnprintf =3D load_store__scnprintf, }; @@ -813,7 +813,7 @@ static int dec__scnprintf(struct ins *ins, char *bf, si= ze_t size, ops->target.name ?: ops->target.raw); } =20 -static struct ins_ops dec_ops =3D { +static const struct ins_ops dec_ops =3D { .parse =3D dec__parse, .scnprintf =3D dec__scnprintf, }; @@ -824,11 +824,11 @@ static int nop__scnprintf(struct ins *ins __maybe_unu= sed, char *bf, size_t size, return scnprintf(bf, size, "%-*s", max_ins_name, "nop"); } =20 -static struct ins_ops nop_ops =3D { +static const struct ins_ops nop_ops =3D { .scnprintf =3D nop__scnprintf, }; =20 -static struct ins_ops ret_ops =3D { +static const struct ins_ops ret_ops =3D { .scnprintf =3D ins__raw_scnprintf, }; =20 @@ -869,7 +869,7 @@ static void ins__sort(struct arch *arch) qsort(arch->instructions, nmemb, sizeof(struct ins), ins__cmp); } =20 -static struct ins_ops *__ins__find(const struct arch *arch, const char *na= me, +static const struct ins_ops *__ins__find(const struct arch *arch, const ch= ar *name, struct disasm_line *dl) { struct ins *ins; @@ -880,7 +880,7 @@ static struct ins_ops *__ins__find(const struct arch *a= rch, const char *name, * For powerpc, identify the instruction ops * from the opcode using raw_insn. */ - struct ins_ops *ops; + const struct ins_ops *ops; =20 ops =3D check_ppc_insn(dl); if (ops) @@ -916,9 +916,9 @@ static struct ins_ops *__ins__find(const struct arch *a= rch, const char *name, return ins ? ins->ops : NULL; } =20 -struct ins_ops *ins__find(const struct arch *arch, const char *name, struc= t disasm_line *dl) +const struct ins_ops *ins__find(const struct arch *arch, const char *name,= struct disasm_line *dl) { - struct ins_ops *ops =3D __ins__find(arch, name, dl); + const struct ins_ops *ops =3D __ins__find(arch, name, dl); =20 if (!ops && arch->associate_instruction_ops) ops =3D arch->associate_instruction_ops((struct arch *)arch, name); diff --git a/tools/perf/util/disasm.h b/tools/perf/util/disasm.h index 273a9c906514..dc5233f2a773 100644 --- a/tools/perf/util/disasm.h +++ b/tools/perf/util/disasm.h @@ -22,7 +22,7 @@ struct arch { struct ins *instructions; size_t nr_instructions; size_t nr_instructions_allocated; - struct ins_ops *(*associate_instruction_ops)(struct arch *arch, const ch= ar *name); + const struct ins_ops *(*associate_instruction_ops)(struct arch *arch, co= nst char *name); bool sorted_instructions; bool initialized; const char *insn_suffix; @@ -52,7 +52,7 @@ struct arch { =20 struct ins { const char *name; - struct ins_ops *ops; + const struct ins_ops *ops; }; =20 struct ins_operands { @@ -108,7 +108,7 @@ struct annotate_args { const struct arch *arch__find(const char *name); bool arch__is(const struct arch *arch, const char *name); =20 -struct ins_ops *ins__find(const struct arch *arch, const char *name, struc= t disasm_line *dl); +const struct ins_ops *ins__find(const struct arch *arch, const char *name,= struct disasm_line *dl); =20 bool ins__is_call(const struct ins *ins); bool ins__is_jump(const struct ins *ins); --=20 2.52.0.457.g6b5491de43-goog