From nobody Sat Feb 7 14:39:23 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3511F36B065; Thu, 22 Jan 2026 03:09:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769051355; cv=none; b=qIj8417qUI1OGoK82kRtfl6kGSepSsGihs//zpu8AWe6tsXzLtOmGl5gQOluUaw9mQZxAU6JPWPPHPXPptJHSWSMp+4F7gQFia6mSik0j3EfYfRu/uPIR0s0DhmeMO8vBLoJIVseCJ6t6MtAQc9j3uB319FZBjTonwWMqQAxfe8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769051355; c=relaxed/simple; bh=5edyFhinTJ4kJ9oghaK75bFMOFjyWeVoOxX/jRXbqsw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n01sxsT6D7zJFNO/S3RouJoWzIY544TOKNHAjKzg6NLo+2WlZ7q045qYMGroiZjFZl+kVFkQpcSiCySdRWWF0wOuCDrHj2sBDetpppeRL4dmbn3a/ONUO+wQYXrJ4r0InfhBtRxDFXxAvohkuxVTYKsq6TIoLHT1zWfIJyOu40Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ATmkP3bE; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ATmkP3bE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769051354; x=1800587354; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=5edyFhinTJ4kJ9oghaK75bFMOFjyWeVoOxX/jRXbqsw=; b=ATmkP3bEDpK7hVG46N52aFwEvUIHtyOEJK4nIs08hFRkcBx/hYh4kU8E GEA5rjENU/JNuK1A1Z5uWciFrmAK7W/LWb/l/mRx3ApVX13eT347Xdt1N JzFJJhlZqeNz1jGEew0uu8VHTVZ8xWe2UaQLPdLLKFATzzQaZQWjsnk0g jyHaxSu7t98gHXrR7hEDs9dZuyIinr94qqf7dfD0HikZa194BZBYBMy7S hIsQTHIIR2JfWWA/+S3uNiYK+rhUPE8l7qjP81ei3uMSZd3l003qaoJs+ vWzzTKPZs92trPRpfKQeeS1Q5zAf0DrdM3FMNKiGObX4f29sU+TG/5UN2 g==; X-CSE-ConnectionGUID: a7zJPgqgTp+8bTq5b5tSOQ== X-CSE-MsgGUID: o6bwQDWdQJiCVY8Z6qV3PQ== X-IronPort-AV: E=McAfee;i="6800,10657,11678"; a="81733090" X-IronPort-AV: E=Sophos;i="6.21,245,1763452800"; d="scan'208";a="81733090" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2026 19:09:12 -0800 X-CSE-ConnectionGUID: XFxxqX2gQLGBXASSs0kDaA== X-CSE-MsgGUID: ysZpLgJ+RUuGkax96631bQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,245,1763452800"; d="scan'208";a="211058815" Received: from debox1-desk4.jf.intel.com ([10.88.27.138]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2026 19:09:11 -0800 From: "David E. Box" To: thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com, irenic.rajneesh@gmail.com, ilpo.jarvinen@linux.intel.com, srinivas.pandruvada@linux.intel.com, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, xi.pardee@linux.intel.com Cc: "David E. Box" , hansg@kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH v3 1/6] platform/x86/intel/vsec: Refactor base_addr handling Date: Wed, 21 Jan 2026 19:08:56 -0800 Message-ID: <20260122030903.3247167-2-david.e.box@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260122030903.3247167-1-david.e.box@linux.intel.com> References: <20260122030903.3247167-1-david.e.box@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The base_addr field in intel_vsec_platform_info was originally added to support devices that emulate PCI VSEC capabilities in MMIO. Previously, the code would check at registration time whether base_addr was set, falling back to the PCI BAR if not. Refactor this by making base_addr an explicit function parameter. This clarifies ownership of the value and removes conditional logic from intel_vsec_add_dev(). It also enables making intel_vsec_platform_info const in a later patch, since the function no longer needs to write to info->base_addr. No functional change intended. Signed-off-by: David E. Box --- v3: - No change v2: - Use pci_resource_start() macro instead of direct pdev->resource array a= ccess (suggested by Ilpo) drivers/platform/x86/intel/vsec.c | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel= /vsec.c index ecfc7703f201..a10e2c65205c 100644 --- a/drivers/platform/x86/intel/vsec.c +++ b/drivers/platform/x86/intel/vsec.c @@ -271,14 +271,13 @@ EXPORT_SYMBOL_NS_GPL(intel_vsec_add_aux, "INTEL_VSEC"= ); =20 static int intel_vsec_add_dev(struct pci_dev *pdev, struct intel_vsec_head= er *header, struct intel_vsec_platform_info *info, - unsigned long cap_id) + unsigned long cap_id, u64 base_addr) { struct intel_vsec_device __free(kfree) *intel_vsec_dev =3D NULL; struct resource __free(kfree) *res =3D NULL; struct resource *tmp; struct device *parent; unsigned long quirks =3D info->quirks; - u64 base_addr; int i; =20 if (info->parent) @@ -310,11 +309,6 @@ static int intel_vsec_add_dev(struct pci_dev *pdev, st= ruct intel_vsec_header *he if (quirks & VSEC_QUIRK_TABLE_SHIFT) header->offset >>=3D TABLE_OFFSET_SHIFT; =20 - if (info->base_addr) - base_addr =3D info->base_addr; - else - base_addr =3D pdev->resource[header->tbir].start; - /* * The DVSEC/VSEC contains the starting offset and count for a block of * discovery tables. Create a resource array of these tables to the @@ -412,7 +406,8 @@ static int get_cap_id(u32 header_id, unsigned long *cap= _id) =20 static int intel_vsec_register_device(struct pci_dev *pdev, struct intel_vsec_header *header, - struct intel_vsec_platform_info *info) + struct intel_vsec_platform_info *info, + u64 base_addr) { const struct vsec_feature_dependency *consumer_deps; struct vsec_priv *priv; @@ -428,7 +423,7 @@ static int intel_vsec_register_device(struct pci_dev *p= dev, * For others using the exported APIs, add the device directly. */ if (!pci_match_id(intel_vsec_pci_ids, pdev)) - return intel_vsec_add_dev(pdev, header, info, cap_id); + return intel_vsec_add_dev(pdev, header, info, cap_id, base_addr); =20 priv =3D pci_get_drvdata(pdev); if (priv->state[cap_id] =3D=3D STATE_REGISTERED || @@ -444,7 +439,7 @@ static int intel_vsec_register_device(struct pci_dev *p= dev, =20 consumer_deps =3D get_consumer_dependencies(priv, cap_id); if (!consumer_deps || suppliers_ready(priv, consumer_deps, cap_id)) { - ret =3D intel_vsec_add_dev(pdev, header, info, cap_id); + ret =3D intel_vsec_add_dev(pdev, header, info, cap_id, base_addr); if (ret) priv->state[cap_id] =3D STATE_SKIP; else @@ -464,7 +459,7 @@ static bool intel_vsec_walk_header(struct pci_dev *pdev, int ret; =20 for ( ; *header; header++) { - ret =3D intel_vsec_register_device(pdev, *header, info); + ret =3D intel_vsec_register_device(pdev, *header, info, info->base_addr); if (!ret) have_devices =3D true; } @@ -512,7 +507,8 @@ static bool intel_vsec_walk_dvsec(struct pci_dev *pdev, pci_read_config_dword(pdev, pos + PCI_DVSEC_HEADER2, &hdr); header.id =3D PCI_DVSEC_HEADER2_ID(hdr); =20 - ret =3D intel_vsec_register_device(pdev, &header, info); + ret =3D intel_vsec_register_device(pdev, &header, info, + pci_resource_start(pdev, header.tbir)); if (ret) continue; =20 @@ -557,7 +553,8 @@ static bool intel_vsec_walk_vsec(struct pci_dev *pdev, header.tbir =3D INTEL_DVSEC_TABLE_BAR(table); header.offset =3D INTEL_DVSEC_TABLE_OFFSET(table); =20 - ret =3D intel_vsec_register_device(pdev, &header, info); + ret =3D intel_vsec_register_device(pdev, &header, info, + pci_resource_start(pdev, header.tbir)); if (ret) continue; =20 --=20 2.43.0 From nobody Sat Feb 7 14:39:23 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E6103939D1; Thu, 22 Jan 2026 03:09:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769051358; cv=none; b=sWyQFb9TIMWR2Mde3BF4FINeFG+PufupiA+R/7mb5ARHang2u8NugMB8yrj3o5wDwXBXSnKJ2r/J1tI1k8s9znKt4xTSLFKs2hBAPc2uXd4X5v/2TOH+vR6jgP4gnfU6b8RJR4GcJKgBxBp76WW9WekV+mtU3yWc3s651mzWQZM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769051358; c=relaxed/simple; bh=RMZpjfq8F5QnLTVCjHfzTJ7GN2Ovg4ezerjmJfRehkM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ha0/yrV1xIC4vR9TcdIMO13DGntIpEuITdOAV431BfxOH9KC8ulmH8RPO5a3GughLaG5Sst5m5io7129hjHDL/4Brqyj+g//UeZzetjOBhvYb+PL5g3Z26+p2Z+u4I93lQ+YJFxnGMD98uimfT0xmDdNqXrRkYh/qsHd8GAuC+U= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Q1CI+tLR; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Q1CI+tLR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769051356; x=1800587356; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RMZpjfq8F5QnLTVCjHfzTJ7GN2Ovg4ezerjmJfRehkM=; b=Q1CI+tLRk+JG/dUfmoTwuNWmUGMn99D5XW4OX+q70LRhscjmzxVs9vZ9 oEsm0p9UiRs+jxR3AJmkaQ1LRDOAgYy96zPZD/gDjcdpuMiXU9OAiPooy 44y7PutTsfVox+cStOh8U9v+x2G4WBz/0QuQkOBo8ILoSFKrFWasi57tx BfjYJbwEYUc7vZ+YRs9DXYLr8x1rcrjvlsNMULDKHJhsnpaHOUQBBTxsb e2TV2iH3ffTy78k6mGEb/+lzn447J5HlrwcVzvFvJ5TLyuSjfurw3xBjk qbGcDdKOQNB5lklCZ6/+cfQACwnzc0U33Ed91IkfGLCHqee2C1KjIJNU4 w==; X-CSE-ConnectionGUID: Z5STK6mYSd2Df/IvY0votA== X-CSE-MsgGUID: AL+iCMdST1ih32Hj1kAx/A== X-IronPort-AV: E=McAfee;i="6800,10657,11678"; a="81733094" X-IronPort-AV: E=Sophos;i="6.21,245,1763452800"; d="scan'208";a="81733094" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2026 19:09:13 -0800 X-CSE-ConnectionGUID: 9HUn4mueSQeLyKpX6E+OGQ== X-CSE-MsgGUID: u/wTQ+M4Tq+5Q9aNrZjskA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,245,1763452800"; d="scan'208";a="211058821" Received: from debox1-desk4.jf.intel.com ([10.88.27.138]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2026 19:09:11 -0800 From: "David E. Box" To: thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com, irenic.rajneesh@gmail.com, ilpo.jarvinen@linux.intel.com, srinivas.pandruvada@linux.intel.com, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, xi.pardee@linux.intel.com Cc: "David E. Box" , hansg@kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH v3 2/6] platform/x86/intel/vsec: Make driver_data info const Date: Wed, 21 Jan 2026 19:08:57 -0800 Message-ID: <20260122030903.3247167-3-david.e.box@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260122030903.3247167-1-david.e.box@linux.intel.com> References: <20260122030903.3247167-1-david.e.box@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Treat PCI id->driver_data (intel_vsec_platform_info) as read-only by making vsec_priv->info a const pointer and updating all function signatures to accept const intel_vsec_platform_info *. This improves const-correctness and clarifies that the platform info data from the driver_data table is not meant to be modified at runtime. No functional changes intended. Signed-off-by: David E. Box --- v3: - No change v2: - New patch drivers/platform/x86/intel/vsec.c | 20 ++++++++++---------- include/linux/intel_vsec.h | 4 ++-- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel= /vsec.c index a10e2c65205c..61b32ae7f064 100644 --- a/drivers/platform/x86/intel/vsec.c +++ b/drivers/platform/x86/intel/vsec.c @@ -42,7 +42,7 @@ enum vsec_device_state { }; =20 struct vsec_priv { - struct intel_vsec_platform_info *info; + const struct intel_vsec_platform_info *info; struct device *suppliers[VSEC_FEATURE_COUNT]; struct oobmsm_plat_info plat_info; enum vsec_device_state state[VSEC_FEATURE_COUNT]; @@ -270,7 +270,7 @@ int intel_vsec_add_aux(struct pci_dev *pdev, struct dev= ice *parent, EXPORT_SYMBOL_NS_GPL(intel_vsec_add_aux, "INTEL_VSEC"); =20 static int intel_vsec_add_dev(struct pci_dev *pdev, struct intel_vsec_head= er *header, - struct intel_vsec_platform_info *info, + const struct intel_vsec_platform_info *info, unsigned long cap_id, u64 base_addr) { struct intel_vsec_device __free(kfree) *intel_vsec_dev =3D NULL; @@ -406,7 +406,7 @@ static int get_cap_id(u32 header_id, unsigned long *cap= _id) =20 static int intel_vsec_register_device(struct pci_dev *pdev, struct intel_vsec_header *header, - struct intel_vsec_platform_info *info, + const struct intel_vsec_platform_info *info, u64 base_addr) { const struct vsec_feature_dependency *consumer_deps; @@ -452,7 +452,7 @@ static int intel_vsec_register_device(struct pci_dev *p= dev, } =20 static bool intel_vsec_walk_header(struct pci_dev *pdev, - struct intel_vsec_platform_info *info) + const struct intel_vsec_platform_info *info) { struct intel_vsec_header **header =3D info->headers; bool have_devices =3D false; @@ -468,7 +468,7 @@ static bool intel_vsec_walk_header(struct pci_dev *pdev, } =20 static bool intel_vsec_walk_dvsec(struct pci_dev *pdev, - struct intel_vsec_platform_info *info) + const struct intel_vsec_platform_info *info) { bool have_devices =3D false; int pos =3D 0; @@ -519,7 +519,7 @@ static bool intel_vsec_walk_dvsec(struct pci_dev *pdev, } =20 static bool intel_vsec_walk_vsec(struct pci_dev *pdev, - struct intel_vsec_platform_info *info) + const struct intel_vsec_platform_info *info) { bool have_devices =3D false; int pos =3D 0; @@ -565,7 +565,7 @@ static bool intel_vsec_walk_vsec(struct pci_dev *pdev, } =20 int intel_vsec_register(struct pci_dev *pdev, - struct intel_vsec_platform_info *info) + const struct intel_vsec_platform_info *info) { if (!pdev || !info || !info->headers) return -EINVAL; @@ -578,7 +578,7 @@ int intel_vsec_register(struct pci_dev *pdev, EXPORT_SYMBOL_NS_GPL(intel_vsec_register, "INTEL_VSEC"); =20 static bool intel_vsec_get_features(struct pci_dev *pdev, - struct intel_vsec_platform_info *info) + const struct intel_vsec_platform_info *info) { bool found =3D false; =20 @@ -622,7 +622,7 @@ static void intel_vsec_skip_missing_dependencies(struct= pci_dev *pdev) =20 static int intel_vsec_pci_probe(struct pci_dev *pdev, const struct pci_dev= ice_id *id) { - struct intel_vsec_platform_info *info; + const struct intel_vsec_platform_info *info; struct vsec_priv *priv; int num_caps, ret; int run_once =3D 0; @@ -633,7 +633,7 @@ static int intel_vsec_pci_probe(struct pci_dev *pdev, c= onst struct pci_device_id return ret; =20 pci_save_state(pdev); - info =3D (struct intel_vsec_platform_info *)id->driver_data; + info =3D (const struct intel_vsec_platform_info *)id->driver_data; if (!info) return -EINVAL; =20 diff --git a/include/linux/intel_vsec.h b/include/linux/intel_vsec.h index 1a0f357c2427..d551174b0049 100644 --- a/include/linux/intel_vsec.h +++ b/include/linux/intel_vsec.h @@ -200,13 +200,13 @@ static inline struct intel_vsec_device *auxdev_to_ivd= ev(struct auxiliary_device =20 #if IS_ENABLED(CONFIG_INTEL_VSEC) int intel_vsec_register(struct pci_dev *pdev, - struct intel_vsec_platform_info *info); + const struct intel_vsec_platform_info *info); int intel_vsec_set_mapping(struct oobmsm_plat_info *plat_info, struct intel_vsec_device *vsec_dev); struct oobmsm_plat_info *intel_vsec_get_mapping(struct pci_dev *pdev); #else static inline int intel_vsec_register(struct pci_dev *pdev, - struct intel_vsec_platform_info *info) + const struct intel_vsec_platform_info *info) { return -ENODEV; } --=20 2.43.0 From nobody Sat Feb 7 14:39:23 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1159A30FC1F; Thu, 22 Jan 2026 03:09:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769051357; cv=none; b=dlgwZCp2uVWve4UNjEz10lPT7uAEtE3ix8+PkKJLM2XF4/DX1w0b5/hT3WuiLrNAb+I9H90xp/tCe83Jki8mBlhEv33BF9scumiDuJ/Hptin8Nmg6IIAqGFWgdlmATE2DR1uCPqmCL0M6eqZK+DgC1c74T8DH9W2Z7dSH2X4GbQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769051357; c=relaxed/simple; bh=qDqbfIee7pKsafEmYG7DwNAfcGe8Ua+GpIWsgAWLb0Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=LLAOGcYDfsvyI4aKOoYCXz3++Ee165aZS0RwEeugvZ3G0qzBLPRw74MfO1K021etXkRINx8+olGa7bGd36x/CvsFb3bhwfYC2Np3w0KkIxJ9kxZN+rkhuSJnj0NJZsOr9sxu/rnI5RRocqvvsKhS2/cAt3VzD4Y8ahDMswUm07w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=JCUJGmCK; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="JCUJGmCK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769051356; x=1800587356; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qDqbfIee7pKsafEmYG7DwNAfcGe8Ua+GpIWsgAWLb0Y=; b=JCUJGmCKyNbN9iy+EpeXv2VmGgCHJVnA1a0YfNU4nPX7/ANeSD01eIZ5 CtulhEJoWLMwYMeJjeR5XXqj8RPPRAgA8YDb4GtclqE8XH3q505zZm/VI ZJU3QAmdfWLOGSV9QRDkvZvWjwUFfDzJnBLYPjWoTwltCpdoFlZItfqI5 eeqtxm6ODp7Z0gT6ka8l0rPGXGBKOMsT6dJSRviEWivskdXCUuKxBjK5I cfZQBDRw98BPQ4mLC5Zm83bf6Fnv2cupqCX97vbOYWMTttgmr7TMGxJZ1 F/cP+Gtenyu7RkLBflclv7R3Bs2O09s1eOalIfGmxavPff38Ch6912HMU g==; X-CSE-ConnectionGUID: V83GzOsBSYC1jfIm+AJiYA== X-CSE-MsgGUID: sh4LSyccR1mciwFpdKUfyA== X-IronPort-AV: E=McAfee;i="6800,10657,11678"; a="81733098" X-IronPort-AV: E=Sophos;i="6.21,245,1763452800"; d="scan'208";a="81733098" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2026 19:09:14 -0800 X-CSE-ConnectionGUID: W+skS0UmTqGI9nsYQmZL8g== X-CSE-MsgGUID: RCHralVqReC/qfVjCnjocg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,245,1763452800"; d="scan'208";a="211058832" Received: from debox1-desk4.jf.intel.com ([10.88.27.138]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2026 19:09:12 -0800 From: "David E. Box" To: thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com, irenic.rajneesh@gmail.com, ilpo.jarvinen@linux.intel.com, srinivas.pandruvada@linux.intel.com, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, xi.pardee@linux.intel.com Cc: "David E. Box" , hansg@kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH v3 3/6] platform/x86/intel/vsec: Decouple add/link helpers from PCI Date: Wed, 21 Jan 2026 19:08:58 -0800 Message-ID: <20260122030903.3247167-4-david.e.box@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260122030903.3247167-1-david.e.box@linux.intel.com> References: <20260122030903.3247167-1-david.e.box@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This refactor is prepares for adding ACPI-enumerated PMT endpoints. While intel_vsec is bound to PCI today, some helpers are used by code that will also register PMT endpoints from non-PCI (ACPI) paths. Clean up PCI-specific plumbing where it isn=E2=80=99t strictly required and rely on generic struct device where possible. Signed-off-by: David E. Box Reviewed-by: Ilpo J=C3=A4rvinen --- v3: - No change v2: - No changes (previous patch 1) drivers/platform/x86/intel/vsec.c | 13 +++++++++---- drivers/platform/x86/intel/vsec_tpmi.c | 2 +- include/linux/intel_vsec.h | 2 +- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel= /vsec.c index 61b32ae7f064..f850343491fc 100644 --- a/drivers/platform/x86/intel/vsec.c +++ b/drivers/platform/x86/intel/vsec.c @@ -158,18 +158,23 @@ static bool vsec_driver_present(int cap_id) */ static const struct pci_device_id intel_vsec_pci_ids[]; =20 -static int intel_vsec_link_devices(struct pci_dev *pdev, struct device *de= v, +static int intel_vsec_link_devices(struct device *parent, struct device *d= ev, int consumer_id) { const struct vsec_feature_dependency *deps; enum vsec_device_state *state; struct device **suppliers; struct vsec_priv *priv; + struct pci_dev *pdev; int supplier_id; =20 if (!consumer_id) return 0; =20 + if (!dev_is_pci(parent)) + return 0; + + pdev =3D to_pci_dev(parent); if (!pci_match_id(intel_vsec_pci_ids, pdev)) return 0; =20 @@ -204,7 +209,7 @@ static int intel_vsec_link_devices(struct pci_dev *pdev= , struct device *dev, return 0; } =20 -int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent, +int intel_vsec_add_aux(struct device *parent, struct intel_vsec_device *intel_vsec_dev, const char *name) { @@ -252,7 +257,7 @@ int intel_vsec_add_aux(struct pci_dev *pdev, struct dev= ice *parent, if (ret) goto cleanup_aux; =20 - ret =3D intel_vsec_link_devices(pdev, &auxdev->dev, intel_vsec_dev->cap_i= d); + ret =3D intel_vsec_link_devices(parent, &auxdev->dev, intel_vsec_dev->cap= _id); if (ret) goto cleanup_aux; =20 @@ -343,7 +348,7 @@ static int intel_vsec_add_dev(struct pci_dev *pdev, str= uct intel_vsec_header *he * Pass the ownership of intel_vsec_dev and resource within it to * intel_vsec_add_aux() */ - return intel_vsec_add_aux(pdev, parent, no_free_ptr(intel_vsec_dev), + return intel_vsec_add_aux(parent, no_free_ptr(intel_vsec_dev), intel_vsec_name(header->id)); } =20 diff --git a/drivers/platform/x86/intel/vsec_tpmi.c b/drivers/platform/x86/= intel/vsec_tpmi.c index 7748b5557a18..180bc5e18e06 100644 --- a/drivers/platform/x86/intel/vsec_tpmi.c +++ b/drivers/platform/x86/intel/vsec_tpmi.c @@ -655,7 +655,7 @@ static int tpmi_create_device(struct intel_tpmi_info *t= pmi_info, * feature_vsec_dev and res memory are also freed as part of * device deletion. */ - return intel_vsec_add_aux(vsec_dev->pcidev, &vsec_dev->auxdev.dev, + return intel_vsec_add_aux(&vsec_dev->pcidev->dev, feature_vsec_dev, feature_id_name); } =20 diff --git a/include/linux/intel_vsec.h b/include/linux/intel_vsec.h index d551174b0049..49a746ec0128 100644 --- a/include/linux/intel_vsec.h +++ b/include/linux/intel_vsec.h @@ -184,7 +184,7 @@ struct pmt_feature_group { struct telemetry_region regions[]; }; =20 -int intel_vsec_add_aux(struct pci_dev *pdev, struct device *parent, +int intel_vsec_add_aux(struct device *parent, struct intel_vsec_device *intel_vsec_dev, const char *name); =20 --=20 2.43.0 From nobody Sat Feb 7 14:39:23 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8464D3939B4; Thu, 22 Jan 2026 03:09:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769051358; cv=none; b=ec3RbWByODntBQ0iat/oFJPEiwgHZFwQ6b2KLeShWvbfOGawdsQTk6Oa68HloIXiKolTxNAdwYn+4J2fZtgO9Z53EQoYjKdBjlqTAH+WUORZ+uJNi0imJzVDXTzepElu1QFRz7L6PKYoj2Hm3Z7NlxMAz1AZzL3ue7xqze3//kY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769051358; c=relaxed/simple; bh=F3S9pcMpWUhjkaFBJxhE3jFQgiMwd2iAVeFVK6MIsFY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=YaYfh3WH8T4HKLl3vxWtM9IYLDNz9/SA9wwKXjESauK/c9UXahg/drAg83Dr7nTHIFn2cuGR4FN/Yf63BWhzZ7IDBLmUmKFseaEla/Gg9NeyrsuwUcoC8VuYejehT0Ay7v2G1e5XDt76iYWjvKcoVWYYiASnI8HTxQn6hXV415g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=cBhMiT+T; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="cBhMiT+T" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769051356; x=1800587356; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=F3S9pcMpWUhjkaFBJxhE3jFQgiMwd2iAVeFVK6MIsFY=; b=cBhMiT+TIWAN7mULRIF0Dsc2xC0oB8ePdbJXseq8HVTC3QS0mXycMowN ppK0hRhhddUneS/cGe49RbSQ6JF3ceJanf2QoPJqtVI5WkTGmReHnHiQ4 nihEGHeR1U7VwtJ9kw4pzIOBVZ/tOcqzNZF6ENk+4wwSs1WNUEmwYZxYX wwwsRXUntvgjdNyZ4i+/eoZPsdlSc452jQEAyRsspXMqSB8CTdH6L/Ive gxBXa6eVLrD/vJEDpQXBS8F3U/DqIwNX/5XcZSF+C/2I5tYwm+4rITv/g 0HqwA8W6XAAAAy2tTwmf03++IiobYn+i7i7M0UzkM8zccOB0gixyBQlrQ Q==; X-CSE-ConnectionGUID: h7cvNtRzRFmN0HzgsMCM4Q== X-CSE-MsgGUID: isRcEKAbRFmfqx5byNkDuQ== X-IronPort-AV: E=McAfee;i="6800,10657,11678"; a="81733103" X-IronPort-AV: E=Sophos;i="6.21,245,1763452800"; d="scan'208";a="81733103" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2026 19:09:14 -0800 X-CSE-ConnectionGUID: vf4Bb2fQQ0imAi9Cq0yZAw== X-CSE-MsgGUID: YGSCy5bRTmGntBakL8jCNw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,245,1763452800"; d="scan'208";a="211058836" Received: from debox1-desk4.jf.intel.com ([10.88.27.138]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2026 19:09:13 -0800 From: "David E. Box" To: thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com, irenic.rajneesh@gmail.com, ilpo.jarvinen@linux.intel.com, srinivas.pandruvada@linux.intel.com, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, xi.pardee@linux.intel.com Cc: "David E. Box" , hansg@kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH v3 4/6] platform/x86/intel/vsec: Switch exported helpers from pci_dev to device Date: Wed, 21 Jan 2026 19:08:59 -0800 Message-ID: <20260122030903.3247167-5-david.e.box@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260122030903.3247167-1-david.e.box@linux.intel.com> References: <20260122030903.3247167-1-david.e.box@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Preparatory refactor for ACPI-enumerated PMT endpoints. Several exported PMT/VSEC interfaces and structs carried struct pci_dev * even though callers only need a generic struct device. Move those to struct device * so the same APIs work for PCI and ACPI parents. Signed-off-by: David E. Box Acked-by: Rodrigo Vivi --- v3: - No change v2: - Add forward declarations for struct device in class.h, telemetry.h - Restore struct pci_dev forward declaration in intel_vsec.h that was rem= oved - Remove base_addr parameter changes (moved to separate patch) - Remove erroneous hunk in intel_vsec_pci_probe() (review comments by Ilpo J=C3=A4rvinen) drivers/gpu/drm/xe/xe_debugfs.c | 2 +- drivers/gpu/drm/xe/xe_hwmon.c | 2 +- drivers/gpu/drm/xe/xe_vsec.c | 7 ++- drivers/gpu/drm/xe/xe_vsec.h | 2 +- drivers/platform/x86/intel/pmc/core.c | 4 +- .../platform/x86/intel/pmc/ssram_telemetry.c | 2 +- drivers/platform/x86/intel/pmt/class.c | 8 ++-- drivers/platform/x86/intel/pmt/class.h | 5 ++- drivers/platform/x86/intel/pmt/discovery.c | 4 +- drivers/platform/x86/intel/pmt/telemetry.c | 13 +++--- drivers/platform/x86/intel/pmt/telemetry.h | 12 ++--- drivers/platform/x86/intel/sdsi.c | 5 ++- drivers/platform/x86/intel/vsec.c | 44 +++++++++++-------- drivers/platform/x86/intel/vsec_tpmi.c | 10 ++--- include/linux/intel_vsec.h | 13 +++--- 15 files changed, 72 insertions(+), 61 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_debugfs.c b/drivers/gpu/drm/xe/xe_debugf= s.c index e91da9589c5f..d07b2aad300f 100644 --- a/drivers/gpu/drm/xe/xe_debugfs.c +++ b/drivers/gpu/drm/xe/xe_debugfs.c @@ -45,7 +45,7 @@ static void read_residency_counter(struct xe_device *xe, = struct xe_mmio *mmio, u64 residency =3D 0; int ret; =20 - ret =3D xe_pmt_telem_read(to_pci_dev(xe->drm.dev), + ret =3D xe_pmt_telem_read(xe->drm.dev, xe_mmio_read32(mmio, PUNIT_TELEMETRY_GUID), &residency, offset, sizeof(residency)); if (ret !=3D sizeof(residency)) { diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c index 97879daeefc1..556072a0ac10 100644 --- a/drivers/gpu/drm/xe/xe_hwmon.c +++ b/drivers/gpu/drm/xe/xe_hwmon.c @@ -464,7 +464,7 @@ xe_hwmon_energy_get(struct xe_hwmon *hwmon, int channel= , long *energy) if (hwmon->xe->info.platform =3D=3D XE_BATTLEMAGE) { u64 pmt_val; =20 - ret =3D xe_pmt_telem_read(to_pci_dev(hwmon->xe->drm.dev), + ret =3D xe_pmt_telem_read(hwmon->xe->drm.dev, xe_mmio_read32(mmio, PUNIT_TELEMETRY_GUID), &pmt_val, BMG_ENERGY_STATUS_PMT_OFFSET, sizeof(pmt_val)); if (ret !=3D sizeof(pmt_val)) { diff --git a/drivers/gpu/drm/xe/xe_vsec.c b/drivers/gpu/drm/xe/xe_vsec.c index 8f23a27871b6..997fe0c8858e 100644 --- a/drivers/gpu/drm/xe/xe_vsec.c +++ b/drivers/gpu/drm/xe/xe_vsec.c @@ -141,10 +141,10 @@ static int xe_guid_decode(u32 guid, int *index, u32 *= offset) return 0; } =20 -int xe_pmt_telem_read(struct pci_dev *pdev, u32 guid, u64 *data, loff_t us= er_offset, +int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user= _offset, u32 count) { - struct xe_device *xe =3D pdev_to_xe_device(pdev); + struct xe_device *xe =3D kdev_to_xe_device(dev); void __iomem *telem_addr =3D xe->mmio.regs + BMG_TELEMETRY_OFFSET; u32 mem_region; u32 offset; @@ -197,7 +197,6 @@ void xe_vsec_init(struct xe_device *xe) { struct intel_vsec_platform_info *info; struct device *dev =3D xe->drm.dev; - struct pci_dev *pdev =3D to_pci_dev(dev); enum xe_vsec platform; =20 platform =3D get_platform_info(xe); @@ -220,6 +219,6 @@ void xe_vsec_init(struct xe_device *xe) * Register a VSEC. Cleanup is handled using device managed * resources. */ - intel_vsec_register(pdev, info); + intel_vsec_register(dev, info); } MODULE_IMPORT_NS("INTEL_VSEC"); diff --git a/drivers/gpu/drm/xe/xe_vsec.h b/drivers/gpu/drm/xe/xe_vsec.h index dabfb4e02d70..74ac575cd68c 100644 --- a/drivers/gpu/drm/xe/xe_vsec.h +++ b/drivers/gpu/drm/xe/xe_vsec.h @@ -10,6 +10,6 @@ struct pci_dev; struct xe_device; =20 void xe_vsec_init(struct xe_device *xe); -int xe_pmt_telem_read(struct pci_dev *pdev, u32 guid, u64 *data, loff_t us= er_offset, u32 count); +int xe_pmt_telem_read(struct device *dev, u32 guid, u64 *data, loff_t user= _offset, u32 count); =20 #endif diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/i= ntel/pmc/core.c index 7d7ae8a40b0e..4abe5e1f574d 100644 --- a/drivers/platform/x86/intel/pmc/core.c +++ b/drivers/platform/x86/intel/pmc/core.c @@ -1288,7 +1288,7 @@ static struct telem_endpoint *pmc_core_register_endpo= int(struct pci_dev *pcidev, unsigned int i; =20 for (i =3D 0; guids[i]; i++) { - ep =3D pmt_telem_find_and_register_endpoint(pcidev, guids[i], 0); + ep =3D pmt_telem_find_and_register_endpoint(&pcidev->dev, guids[i], 0); if (!IS_ERR(ep)) return ep; } @@ -1573,7 +1573,7 @@ static int pmc_core_get_telem_info(struct pmc_dev *pm= cdev, struct pmc_dev_info * if (!pmc->map->lpm_req_guid) return -ENXIO; =20 - ep =3D pmt_telem_find_and_register_endpoint(pcidev, pmc->map->lpm_req_gu= id, 0); + ep =3D pmt_telem_find_and_register_endpoint(&pcidev->dev, pmc->map->lpm_= req_guid, 0); if (IS_ERR(ep)) { dev_dbg(&pmcdev->pdev->dev, "couldn't get telem endpoint %pe", ep); return -EPROBE_DEFER; diff --git a/drivers/platform/x86/intel/pmc/ssram_telemetry.c b/drivers/pla= tform/x86/intel/pmc/ssram_telemetry.c index 03fad9331fc0..6f6e83e70fc5 100644 --- a/drivers/platform/x86/intel/pmc/ssram_telemetry.c +++ b/drivers/platform/x86/intel/pmc/ssram_telemetry.c @@ -60,7 +60,7 @@ pmc_ssram_telemetry_add_pmt(struct pci_dev *pcidev, u64 s= sram_base, void __iomem info.base_addr =3D ssram_base; info.parent =3D &pcidev->dev; =20 - return intel_vsec_register(pcidev, &info); + return intel_vsec_register(&pcidev->dev, &info); } =20 static inline u64 get_base(void __iomem *addr, u32 offset) diff --git a/drivers/platform/x86/intel/pmt/class.c b/drivers/platform/x86/= intel/pmt/class.c index 7c3023d5d91d..8077274726b5 100644 --- a/drivers/platform/x86/intel/pmt/class.c +++ b/drivers/platform/x86/intel/pmt/class.c @@ -60,11 +60,11 @@ pmt_memcpy64_fromio(void *to, const u64 __iomem *from, = size_t count) return count; } =20 -int pmt_telem_read_mmio(struct pci_dev *pdev, struct pmt_callbacks *cb, u3= 2 guid, void *buf, +int pmt_telem_read_mmio(struct device *dev, struct pmt_callbacks *cb, u32 = guid, void *buf, void __iomem *addr, loff_t off, u32 count) { if (cb && cb->read_telem) - return cb->read_telem(pdev, guid, buf, off, count); + return cb->read_telem(dev, guid, buf, off, count); =20 addr +=3D off; =20 @@ -99,7 +99,7 @@ intel_pmt_read(struct file *filp, struct kobject *kobj, if (count > entry->size - off) count =3D entry->size - off; =20 - count =3D pmt_telem_read_mmio(entry->pcidev, entry->cb, entry->header.gui= d, buf, + count =3D pmt_telem_read_mmio(entry->ep->dev, entry->cb, entry->header.gu= id, buf, entry->base, off, count); =20 return count; @@ -208,7 +208,7 @@ static int intel_pmt_populate_entry(struct intel_pmt_en= try *entry, struct intel_vsec_device *ivdev, struct resource *disc_res) { - struct pci_dev *pci_dev =3D ivdev->pcidev; + struct pci_dev *pci_dev =3D to_pci_dev(ivdev->dev); struct device *dev =3D &ivdev->auxdev.dev; struct intel_pmt_header *header =3D &entry->header; u8 bir; diff --git a/drivers/platform/x86/intel/pmt/class.h b/drivers/platform/x86/= intel/pmt/class.h index 3c5ad5f52bca..1ae56a5baad2 100644 --- a/drivers/platform/x86/intel/pmt/class.h +++ b/drivers/platform/x86/intel/pmt/class.h @@ -19,11 +19,12 @@ #define GET_BIR(v) ((v) & GENMASK(2, 0)) #define GET_ADDRESS(v) ((v) & GENMASK(31, 3)) =20 +struct device; struct pci_dev; extern struct class intel_pmt_class; =20 struct telem_endpoint { - struct pci_dev *pcidev; + struct device *dev; struct telem_header header; struct pmt_callbacks *cb; void __iomem *base; @@ -65,7 +66,7 @@ struct intel_pmt_namespace { struct intel_pmt_entry *entry); }; =20 -int pmt_telem_read_mmio(struct pci_dev *pdev, struct pmt_callbacks *cb, u3= 2 guid, void *buf, +int pmt_telem_read_mmio(struct device *dev, struct pmt_callbacks *cb, u32 = guid, void *buf, void __iomem *addr, loff_t off, u32 count); bool intel_pmt_is_early_client_hw(struct device *dev); int intel_pmt_dev_create(struct intel_pmt_entry *entry, diff --git a/drivers/platform/x86/intel/pmt/discovery.c b/drivers/platform/= x86/intel/pmt/discovery.c index e500aa327d23..c482368bfaae 100644 --- a/drivers/platform/x86/intel/pmt/discovery.c +++ b/drivers/platform/x86/intel/pmt/discovery.c @@ -542,7 +542,7 @@ static int pmt_features_probe(struct auxiliary_device *= auxdev, const struct auxi if (!priv) return -ENOMEM; =20 - priv->parent =3D &ivdev->pcidev->dev; + priv->parent =3D ivdev->dev; auxiliary_set_drvdata(auxdev, priv); =20 priv->dev =3D device_create(&intel_pmt_class, &auxdev->dev, MKDEV(0, 0), = priv, @@ -609,7 +609,7 @@ void intel_pmt_get_features(struct intel_pmt_entry *ent= ry) =20 mutex_lock(&feature_list_lock); list_for_each_entry(feature, &pmt_feature_list, list) { - if (feature->priv->parent !=3D &entry->ep->pcidev->dev) + if (feature->priv->parent !=3D entry->ep->dev) continue; =20 pmt_get_features(entry, feature); diff --git a/drivers/platform/x86/intel/pmt/telemetry.c b/drivers/platform/= x86/intel/pmt/telemetry.c index a4dfca6cac19..e11f7bde41b2 100644 --- a/drivers/platform/x86/intel/pmt/telemetry.c +++ b/drivers/platform/x86/intel/pmt/telemetry.c @@ -112,7 +112,7 @@ static int pmt_telem_add_endpoint(struct intel_vsec_dev= ice *ivdev, return -ENOMEM; =20 ep =3D entry->ep; - ep->pcidev =3D ivdev->pcidev; + ep->dev =3D ivdev->dev; ep->header.access_type =3D entry->header.access_type; ep->header.guid =3D entry->header.guid; ep->header.base_offset =3D entry->header.base_offset; @@ -204,7 +204,7 @@ int pmt_telem_get_endpoint_info(int devid, struct telem= _endpoint_info *info) goto unlock; } =20 - info->pdev =3D entry->ep->pcidev; + info->dev =3D entry->ep->dev; info->header =3D entry->ep->header; =20 unlock: @@ -218,9 +218,10 @@ static int pmt_copy_region(struct telemetry_region *re= gion, struct intel_pmt_entry *entry) { =20 + struct pci_dev *pdev =3D to_pci_dev(entry->ep->dev); struct oobmsm_plat_info *plat_info; =20 - plat_info =3D intel_vsec_get_mapping(entry->ep->pcidev); + plat_info =3D intel_vsec_get_mapping(pdev); if (IS_ERR(plat_info)) return PTR_ERR(plat_info); =20 @@ -308,7 +309,7 @@ int pmt_telem_read(struct telem_endpoint *ep, u32 id, u= 64 *data, u32 count) if (offset + NUM_BYTES_QWORD(count) > size) return -EINVAL; =20 - pmt_telem_read_mmio(ep->pcidev, ep->cb, ep->header.guid, data, ep->base, = offset, + pmt_telem_read_mmio(ep->dev, ep->cb, ep->header.guid, data, ep->base, off= set, NUM_BYTES_QWORD(count)); =20 return ep->present ? 0 : -EPIPE; @@ -335,7 +336,7 @@ int pmt_telem_read32(struct telem_endpoint *ep, u32 id,= u32 *data, u32 count) EXPORT_SYMBOL_NS_GPL(pmt_telem_read32, "INTEL_PMT_TELEMETRY"); =20 struct telem_endpoint * -pmt_telem_find_and_register_endpoint(struct pci_dev *pcidev, u32 guid, u16= pos) +pmt_telem_find_and_register_endpoint(struct device *dev, u32 guid, u16 pos) { int devid =3D 0; int inst =3D 0; @@ -348,7 +349,7 @@ pmt_telem_find_and_register_endpoint(struct pci_dev *pc= idev, u32 guid, u16 pos) if (err) return ERR_PTR(err); =20 - if (ep_info.header.guid =3D=3D guid && ep_info.pdev =3D=3D pcidev) { + if (ep_info.header.guid =3D=3D guid && ep_info.dev =3D=3D dev) { if (inst =3D=3D pos) return pmt_telem_register_endpoint(devid); ++inst; diff --git a/drivers/platform/x86/intel/pmt/telemetry.h b/drivers/platform/= x86/intel/pmt/telemetry.h index d45af5512b4e..0f88c5e7d90e 100644 --- a/drivers/platform/x86/intel/pmt/telemetry.h +++ b/drivers/platform/x86/intel/pmt/telemetry.h @@ -6,8 +6,8 @@ #define PMT_TELEM_TELEMETRY 0 #define PMT_TELEM_CRASHLOG 1 =20 +struct device; struct telem_endpoint; -struct pci_dev; =20 struct telem_header { u8 access_type; @@ -17,7 +17,7 @@ struct telem_header { }; =20 struct telem_endpoint_info { - struct pci_dev *pdev; + struct device *dev; struct telem_header header; }; =20 @@ -71,8 +71,8 @@ int pmt_telem_get_endpoint_info(int devid, struct telem_e= ndpoint_info *info); =20 /** * pmt_telem_find_and_register_endpoint() - Get a telemetry endpoint from - * pci_dev device, guid and pos - * @pdev: PCI device inside the Intel vsec + * device, guid and pos + * @dev: device inside the Intel vsec * @guid: GUID of the telemetry space * @pos: Instance of the guid * @@ -80,8 +80,8 @@ int pmt_telem_get_endpoint_info(int devid, struct telem_e= ndpoint_info *info); * * endpoint - On success returns pointer to the telemetry endpoint * * -ENXIO - telemetry endpoint not found */ -struct telem_endpoint *pmt_telem_find_and_register_endpoint(struct pci_dev= *pcidev, - u32 guid, u16 pos); +struct telem_endpoint * +pmt_telem_find_and_register_endpoint(struct device *dev, u32 guid, u16 pos= ); =20 /** * pmt_telem_read() - Read qwords from counter sram using sample id diff --git a/drivers/platform/x86/intel/sdsi.c b/drivers/platform/x86/intel= /sdsi.c index da75f53d0bcc..d7e37d4ace23 100644 --- a/drivers/platform/x86/intel/sdsi.c +++ b/drivers/platform/x86/intel/sdsi.c @@ -599,13 +599,14 @@ static int sdsi_get_layout(struct sdsi_priv *priv, st= ruct disc_table *table) return 0; } =20 -static int sdsi_map_mbox_registers(struct sdsi_priv *priv, struct pci_dev = *parent, +static int sdsi_map_mbox_registers(struct sdsi_priv *priv, struct device *= dev, struct disc_table *disc_table, struct resource *disc_res) { u32 access_type =3D FIELD_GET(DT_ACCESS_TYPE, disc_table->access_info); u32 size =3D FIELD_GET(DT_SIZE, disc_table->access_info); u32 tbir =3D FIELD_GET(DT_TBIR, disc_table->offset); u32 offset =3D DT_OFFSET(disc_table->offset); + struct pci_dev *parent =3D to_pci_dev(dev); struct resource res =3D {}; =20 /* Starting location of SDSi MMIO region based on access type */ @@ -681,7 +682,7 @@ static int sdsi_probe(struct auxiliary_device *auxdev, = const struct auxiliary_de return ret; =20 /* Map the SDSi mailbox registers */ - ret =3D sdsi_map_mbox_registers(priv, intel_cap_dev->pcidev, &disc_table,= disc_res); + ret =3D sdsi_map_mbox_registers(priv, intel_cap_dev->dev, &disc_table, di= sc_res); if (ret) return ret; =20 diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel= /vsec.c index f850343491fc..675074c90b79 100644 --- a/drivers/platform/x86/intel/vsec.c +++ b/drivers/platform/x86/intel/vsec.c @@ -274,7 +274,7 @@ int intel_vsec_add_aux(struct device *parent, } EXPORT_SYMBOL_NS_GPL(intel_vsec_add_aux, "INTEL_VSEC"); =20 -static int intel_vsec_add_dev(struct pci_dev *pdev, struct intel_vsec_head= er *header, +static int intel_vsec_add_dev(struct device *dev, struct intel_vsec_header= *header, const struct intel_vsec_platform_info *info, unsigned long cap_id, u64 base_addr) { @@ -288,18 +288,18 @@ static int intel_vsec_add_dev(struct pci_dev *pdev, s= truct intel_vsec_header *he if (info->parent) parent =3D info->parent; else - parent =3D &pdev->dev; + parent =3D dev; =20 if (!intel_vsec_supported(header->id, info->caps)) return -EINVAL; =20 if (!header->num_entries) { - dev_dbg(&pdev->dev, "Invalid 0 entry count for header id %d\n", header->= id); + dev_dbg(dev, "Invalid 0 entry count for header id %d\n", header->id); return -EINVAL; } =20 if (!header->entry_size) { - dev_dbg(&pdev->dev, "Invalid 0 entry size for header id %d\n", header->i= d); + dev_dbg(dev, "Invalid 0 entry size for header id %d\n", header->id); return -EINVAL; } =20 @@ -331,7 +331,7 @@ static int intel_vsec_add_dev(struct pci_dev *pdev, str= uct intel_vsec_header *he release_mem_region(tmp->start, resource_size(tmp)); } =20 - intel_vsec_dev->pcidev =3D pdev; + intel_vsec_dev->dev =3D dev; intel_vsec_dev->resource =3D no_free_ptr(res); intel_vsec_dev->num_resources =3D header->num_entries; intel_vsec_dev->quirks =3D info->quirks; @@ -409,13 +409,14 @@ static int get_cap_id(u32 header_id, unsigned long *c= ap_id) return 0; } =20 -static int intel_vsec_register_device(struct pci_dev *pdev, +static int intel_vsec_register_device(struct device *dev, struct intel_vsec_header *header, const struct intel_vsec_platform_info *info, u64 base_addr) { const struct vsec_feature_dependency *consumer_deps; struct vsec_priv *priv; + struct pci_dev *pdev; unsigned long cap_id; int ret; =20 @@ -427,8 +428,12 @@ static int intel_vsec_register_device(struct pci_dev *= pdev, * Only track dependencies for devices probed by the VSEC driver. * For others using the exported APIs, add the device directly. */ + if (!dev_is_pci(dev)) + return intel_vsec_add_dev(dev, header, info, cap_id, base_addr); + + pdev =3D to_pci_dev(dev); if (!pci_match_id(intel_vsec_pci_ids, pdev)) - return intel_vsec_add_dev(pdev, header, info, cap_id, base_addr); + return intel_vsec_add_dev(dev, header, info, cap_id, base_addr); =20 priv =3D pci_get_drvdata(pdev); if (priv->state[cap_id] =3D=3D STATE_REGISTERED || @@ -444,7 +449,7 @@ static int intel_vsec_register_device(struct pci_dev *p= dev, =20 consumer_deps =3D get_consumer_dependencies(priv, cap_id); if (!consumer_deps || suppliers_ready(priv, consumer_deps, cap_id)) { - ret =3D intel_vsec_add_dev(pdev, header, info, cap_id, base_addr); + ret =3D intel_vsec_add_dev(dev, header, info, cap_id, base_addr); if (ret) priv->state[cap_id] =3D STATE_SKIP; else @@ -456,7 +461,7 @@ static int intel_vsec_register_device(struct pci_dev *p= dev, return -EAGAIN; } =20 -static bool intel_vsec_walk_header(struct pci_dev *pdev, +static bool intel_vsec_walk_header(struct device *dev, const struct intel_vsec_platform_info *info) { struct intel_vsec_header **header =3D info->headers; @@ -464,7 +469,7 @@ static bool intel_vsec_walk_header(struct pci_dev *pdev, int ret; =20 for ( ; *header; header++) { - ret =3D intel_vsec_register_device(pdev, *header, info, info->base_addr); + ret =3D intel_vsec_register_device(dev, *header, info, info->base_addr); if (!ret) have_devices =3D true; } @@ -512,7 +517,7 @@ static bool intel_vsec_walk_dvsec(struct pci_dev *pdev, pci_read_config_dword(pdev, pos + PCI_DVSEC_HEADER2, &hdr); header.id =3D PCI_DVSEC_HEADER2_ID(hdr); =20 - ret =3D intel_vsec_register_device(pdev, &header, info, + ret =3D intel_vsec_register_device(&pdev->dev, &header, info, pci_resource_start(pdev, header.tbir)); if (ret) continue; @@ -558,7 +563,7 @@ static bool intel_vsec_walk_vsec(struct pci_dev *pdev, header.tbir =3D INTEL_DVSEC_TABLE_BAR(table); header.offset =3D INTEL_DVSEC_TABLE_OFFSET(table); =20 - ret =3D intel_vsec_register_device(pdev, &header, info, + ret =3D intel_vsec_register_device(&pdev->dev, &header, info, pci_resource_start(pdev, header.tbir)); if (ret) continue; @@ -569,13 +574,13 @@ static bool intel_vsec_walk_vsec(struct pci_dev *pdev, return have_devices; } =20 -int intel_vsec_register(struct pci_dev *pdev, +int intel_vsec_register(struct device *dev, const struct intel_vsec_platform_info *info) { - if (!pdev || !info || !info->headers) + if (!dev || !info || !info->headers) return -EINVAL; =20 - if (!intel_vsec_walk_header(pdev, info)) + if (!intel_vsec_walk_header(dev, info)) return -ENODEV; else return 0; @@ -601,7 +606,7 @@ static bool intel_vsec_get_features(struct pci_dev *pde= v, found =3D true; =20 if (info && (info->quirks & VSEC_QUIRK_NO_DVSEC) && - intel_vsec_walk_header(pdev, info)) + intel_vsec_walk_header(&pdev->dev, info)) found =3D true; =20 return found; @@ -673,7 +678,10 @@ int intel_vsec_set_mapping(struct oobmsm_plat_info *pl= at_info, { struct vsec_priv *priv; =20 - priv =3D pci_get_drvdata(vsec_dev->pcidev); + if (!dev_is_pci(vsec_dev->dev)) + return -ENODEV; + + priv =3D pci_get_drvdata(to_pci_dev(vsec_dev->dev)); if (!priv) return -EINVAL; =20 @@ -819,7 +827,7 @@ static pci_ers_result_t intel_vsec_pci_slot_reset(struc= t pci_dev *pdev) =20 xa_for_each(&auxdev_array, index, intel_vsec_dev) { /* check if pdev doesn't match */ - if (pdev !=3D intel_vsec_dev->pcidev) + if (&pdev->dev !=3D intel_vsec_dev->dev) continue; devm_release_action(&pdev->dev, intel_vsec_remove_aux, &intel_vsec_dev->auxdev); diff --git a/drivers/platform/x86/intel/vsec_tpmi.c b/drivers/platform/x86/= intel/vsec_tpmi.c index 180bc5e18e06..11203b07f1a8 100644 --- a/drivers/platform/x86/intel/vsec_tpmi.c +++ b/drivers/platform/x86/intel/vsec_tpmi.c @@ -530,7 +530,7 @@ static const struct file_operations mem_write_ops =3D { .release =3D single_release, }; =20 -#define tpmi_to_dev(info) (&info->vsec_dev->pcidev->dev) +#define tpmi_to_dev(info) ((info)->vsec_dev->dev) =20 static void tpmi_dbgfs_register(struct intel_tpmi_info *tpmi_info) { @@ -642,7 +642,7 @@ static int tpmi_create_device(struct intel_tpmi_info *t= pmi_info, tmp->flags =3D IORESOURCE_MEM; } =20 - feature_vsec_dev->pcidev =3D vsec_dev->pcidev; + feature_vsec_dev->dev =3D vsec_dev->dev; feature_vsec_dev->resource =3D res; feature_vsec_dev->num_resources =3D pfs->pfs_header.num_entries; feature_vsec_dev->priv_data =3D &tpmi_info->plat_info; @@ -655,8 +655,8 @@ static int tpmi_create_device(struct intel_tpmi_info *t= pmi_info, * feature_vsec_dev and res memory are also freed as part of * device deletion. */ - return intel_vsec_add_aux(&vsec_dev->pcidev->dev, - feature_vsec_dev, feature_id_name); + return intel_vsec_add_aux(vsec_dev->dev, feature_vsec_dev, + feature_id_name); } =20 static int tpmi_create_devices(struct intel_tpmi_info *tpmi_info) @@ -742,7 +742,7 @@ static int tpmi_fetch_pfs_header(struct intel_tpmi_pm_f= eature *pfs, u64 start, i static int intel_vsec_tpmi_init(struct auxiliary_device *auxdev) { struct intel_vsec_device *vsec_dev =3D auxdev_to_ivdev(auxdev); - struct pci_dev *pci_dev =3D vsec_dev->pcidev; + struct pci_dev *pci_dev =3D to_pci_dev(vsec_dev->dev); struct intel_tpmi_info *tpmi_info; u64 pfs_start =3D 0; int ret, i; diff --git a/include/linux/intel_vsec.h b/include/linux/intel_vsec.h index 49a746ec0128..4eecb2a6bac4 100644 --- a/include/linux/intel_vsec.h +++ b/include/linux/intel_vsec.h @@ -29,6 +29,7 @@ #define INTEL_DVSEC_TABLE_OFFSET(x) ((x) & GENMASK(31, 3)) #define TABLE_OFFSET_SHIFT 3 =20 +struct device; struct pci_dev; struct resource; =20 @@ -82,14 +83,14 @@ enum intel_vsec_quirks { * struct pmt_callbacks - Callback infrastructure for PMT devices * @read_telem: when specified, called by client driver to access PMT * data (instead of direct copy). - * * pdev: PCI device reference for the callback's use + * * dev: device reference for the callback's use * * guid: ID of data to acccss * * data: buffer for the data to be copied * * off: offset into the requested buffer * * count: size of buffer */ struct pmt_callbacks { - int (*read_telem)(struct pci_dev *pdev, u32 guid, u64 *data, loff_t off, = u32 count); + int (*read_telem)(struct device *dev, u32 guid, u64 *data, loff_t off, u3= 2 count); }; =20 struct vsec_feature_dependency { @@ -122,7 +123,7 @@ struct intel_vsec_platform_info { /** * struct intel_vsec_device - Auxbus specific device information * @auxdev: auxbus device struct for auxbus access - * @pcidev: pci device associated with the device + * @dev: struct device associated with the device * @resource: any resources shared by the parent * @ida: id reference * @num_resources: number of resources @@ -135,7 +136,7 @@ struct intel_vsec_platform_info { */ struct intel_vsec_device { struct auxiliary_device auxdev; - struct pci_dev *pcidev; + struct device *dev; struct resource *resource; struct ida *ida; int num_resources; @@ -199,13 +200,13 @@ static inline struct intel_vsec_device *auxdev_to_ivd= ev(struct auxiliary_device } =20 #if IS_ENABLED(CONFIG_INTEL_VSEC) -int intel_vsec_register(struct pci_dev *pdev, +int intel_vsec_register(struct device *dev, const struct intel_vsec_platform_info *info); int intel_vsec_set_mapping(struct oobmsm_plat_info *plat_info, struct intel_vsec_device *vsec_dev); struct oobmsm_plat_info *intel_vsec_get_mapping(struct pci_dev *pdev); #else -static inline int intel_vsec_register(struct pci_dev *pdev, +static inline int intel_vsec_register(struct device *dev, const struct intel_vsec_platform_info *info) { return -ENODEV; --=20 2.43.0 From nobody Sat Feb 7 14:39:23 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 87D473A6402; Thu, 22 Jan 2026 03:09:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769051360; cv=none; b=NCkWwkKCEcGhsdbZOgIFnwlKDsz8Oh+SM1V3Ad3JqS407B77R2vztNrD3YloiXyPH9hVkP/7cT7A1CahlKYzaResNlNFRiR8ISJYRn9YaCX0BhIsB1ffRyvK5LYwk+/DwvL/u057OB3APTuK/ZM//DM9FCOV14HOlxfSA77tMzU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769051360; c=relaxed/simple; bh=gYeoo7q2gcsmWeWAuD66ivUnD+WG3xUpRH1yys6edd4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hNEzI+6aZv4n13lZV4clgpP8NfLprWkkAsPeQIFSLhC9yiNW0h3ihogJN3xXjZ0QM7Pf3Mzy+YHrziI21wIAyxmYlUkdg9NDdce1IEzVAR4PgbnGQnjbZzB8o8z6A/oQgNyfj9YW6GbluoulXIe7Qvz7ZF+koDM5gI376RDjKBI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=MJarm4g3; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="MJarm4g3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769051358; x=1800587358; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=gYeoo7q2gcsmWeWAuD66ivUnD+WG3xUpRH1yys6edd4=; b=MJarm4g3hMlo4DwEeTkBIdtCwwTVonbSejXitUz3eaXV9nXi6t/BPCNr Qo3b9MJBykuvbELITw9fxO2rot4zb5jWKwXjhOmzKzGZHIgZLXnXm4yJC olcJlPx4+A9xYAHTxdPz9frY9lxxIHrsFgS63Zb0J7xRvcyTEA50kqFEs 7vW6Bl1ofVFXoCIgoXvmZygMZUBq9Dg8O42GcjvCqVEFuEw6oxs5QwCH9 rJUpmlxT621C4IMNjtO5HQkTfJcicI/44rX4pSc3qpD/aCz85t8mvD0Lu 4GENNymQptQo4+tVvgEUJo+SVNASR2v0cT/1Fax/8urn2l7ZdbaIJ5rO4 A==; X-CSE-ConnectionGUID: dWHEVe4oQHqvjJJgcKuRAw== X-CSE-MsgGUID: 0rR9puvpR7KVq0djo2zRJQ== X-IronPort-AV: E=McAfee;i="6800,10657,11678"; a="81733107" X-IronPort-AV: E=Sophos;i="6.21,245,1763452800"; d="scan'208";a="81733107" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2026 19:09:15 -0800 X-CSE-ConnectionGUID: Lj9AS5Z/S72vq/xcea1n2A== X-CSE-MsgGUID: EphVaxp/S2iui1r/3891dA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,245,1763452800"; d="scan'208";a="211058841" Received: from debox1-desk4.jf.intel.com ([10.88.27.138]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2026 19:09:14 -0800 From: "David E. Box" To: thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com, irenic.rajneesh@gmail.com, ilpo.jarvinen@linux.intel.com, srinivas.pandruvada@linux.intel.com, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, xi.pardee@linux.intel.com Cc: "David E. Box" , hansg@kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH v3 5/6] platform/x86/intel/vsec: Return real error codes from registration path Date: Wed, 21 Jan 2026 19:09:00 -0800 Message-ID: <20260122030903.3247167-6-david.e.box@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260122030903.3247167-1-david.e.box@linux.intel.com> References: <20260122030903.3247167-1-david.e.box@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Stop collapsing registration results into booleans. Make intel_vsec_walk_header() return int and propagate the first non-zero error from intel_vsec_register_device(). intel_vsec_register() now returns that error directly and 0 on success. This preserves success behavior while surfacing meaningful errors instead of hiding them behind a bool/-ENODEV, which makes debugging and probe ordering issues clearer. Signed-off-by: David E. Box Reviewed-by: Ilpo J=C3=A4rvinen --- v3: - No change v2: - No change (previous patch 3) drivers/platform/x86/intel/vsec.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel= /vsec.c index 675074c90b79..4aeb0728b435 100644 --- a/drivers/platform/x86/intel/vsec.c +++ b/drivers/platform/x86/intel/vsec.c @@ -461,20 +461,19 @@ static int intel_vsec_register_device(struct device *= dev, return -EAGAIN; } =20 -static bool intel_vsec_walk_header(struct device *dev, - const struct intel_vsec_platform_info *info) +static int intel_vsec_walk_header(struct device *dev, + const struct intel_vsec_platform_info *info) { struct intel_vsec_header **header =3D info->headers; - bool have_devices =3D false; int ret; =20 for ( ; *header; header++) { ret =3D intel_vsec_register_device(dev, *header, info, info->base_addr); - if (!ret) - have_devices =3D true; + if (ret) + return ret; } =20 - return have_devices; + return 0; } =20 static bool intel_vsec_walk_dvsec(struct pci_dev *pdev, @@ -580,10 +579,7 @@ int intel_vsec_register(struct device *dev, if (!dev || !info || !info->headers) return -EINVAL; =20 - if (!intel_vsec_walk_header(dev, info)) - return -ENODEV; - else - return 0; + return intel_vsec_walk_header(dev, info); } EXPORT_SYMBOL_NS_GPL(intel_vsec_register, "INTEL_VSEC"); =20 --=20 2.43.0 From nobody Sat Feb 7 14:39:23 2026 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A05D3A7DF4; Thu, 22 Jan 2026 03:09:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769051361; cv=none; b=iHPI2g5xlbI25zbX/QZqRbRif71o2aTD5rO2okHKrP5CL7FS22PCmeIKwzj6S6IVJ/cfGaA7TqVGRXCUED9XrbV8fIF8kmhUpS/MFLDh9xaZY8nedx3EQl6Lp5k9M1yw90NkB/ciB/X/JZSsaXkPAVzAgWC9C2ogt+TF0zjKVPE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769051361; c=relaxed/simple; bh=n1Cwwmr9V3C+h6eVfi4rilYGDktfff8Gh5kbbJ6IATQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=p+OHrpEeJGP2lqyFrEadbluT9VVUiTwiu+WSYmwJxNbRl3r1ceQB3IUsmCtodEG8THlzH7VLNmjlx/6URBI2gaOSXTnBiePmNqn9v5KQczxk7XL/iMiF29zJ6/BLXzpzDNF5YEWna3sMGr/i8xfL7j2EppFxFrBLs4qiH+gDidQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=D+4JG82h; arc=none smtp.client-ip=198.175.65.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="D+4JG82h" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1769051359; x=1800587359; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=n1Cwwmr9V3C+h6eVfi4rilYGDktfff8Gh5kbbJ6IATQ=; b=D+4JG82h7G0zxhOjY1Vv6vcqyScVfsZdILzHJef0EHGjh4DfLM4vqh+A 1znwHFvusszK3i0IBx7cNIMIzM6BuuuOKoa+JtsYJbOdIWNScclY5pOOW h31i6rEtGmppuZkoxnVse3zZs6wn8Yk2+EwDvdinSMwMUGMOsFzcfXEWl RIO/JEWeytZX0rgQS6jhbmR7+CQTHuWR7BxYULTDDrAIVg0PYwSypf6Cb Wf46AzfT9A1VyRBczNKcqBWccOpYai6jZ4Fosmnkjj82+sthNJDokFGRN ASGkrAgDsPNG2Gjle0MQL1LgVyiSnx/NOJNvoOYAVec2PNt3p/I4Bh/I6 g==; X-CSE-ConnectionGUID: DFh8N8sQS/+BwC0Gqc/2LQ== X-CSE-MsgGUID: hUDWGPxKRdm5WZchqr0jBQ== X-IronPort-AV: E=McAfee;i="6800,10657,11678"; a="81733111" X-IronPort-AV: E=Sophos;i="6.21,245,1763452800"; d="scan'208";a="81733111" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2026 19:09:16 -0800 X-CSE-ConnectionGUID: sdTmNE0nQburkC6eywKKFQ== X-CSE-MsgGUID: 3EuGZH2OQ6+k95godpkKdA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,245,1763452800"; d="scan'208";a="211058847" Received: from debox1-desk4.jf.intel.com ([10.88.27.138]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jan 2026 19:09:14 -0800 From: "David E. Box" To: thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com, irenic.rajneesh@gmail.com, ilpo.jarvinen@linux.intel.com, srinivas.pandruvada@linux.intel.com, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, xi.pardee@linux.intel.com Cc: "David E. Box" , hansg@kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Subject: [PATCH v3 6/6] platform/x86/intel/vsec: Plumb ACPI PMT discovery tables through vsec Date: Wed, 21 Jan 2026 19:09:01 -0800 Message-ID: <20260122030903.3247167-7-david.e.box@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260122030903.3247167-1-david.e.box@linux.intel.com> References: <20260122030903.3247167-1-david.e.box@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Some platforms expose PMT discovery via ACPI instead of PCI BARs. Add a generic discovery source flag and carry ACPI discovery entries alongside the existing PCI resource path so PMT clients can consume either. Changes: - Add enum intel_vsec_disc_source { _PCI, _ACPI }. - Extend intel_vsec_platform_info and intel_vsec_device with source enum and ACPI discovery table pointer/ - When src=3D=3DACPI, skip BAR resource setup and copy the ACPI discovery entries into the aux device. No user-visible behavior change yet; this only wires ACPI data through vsec in preparation for ACPI-enumerated PMT clients. Signed-off-by: David E. Box --- v3: - Re-send with all changes intended for v2 which was sent without them being applied. v2: - Improve comment to clarify BAR resource setup doesn't apply to ACPI discovery - Add missing #include for kmemdup() - Use array_size() for overflow protection (review comments by Ilpo J=C3=A4rvinen) drivers/platform/x86/intel/vsec.c | 24 ++++++++++++++++++++++++ include/linux/intel_vsec.h | 20 +++++++++++++++++++- 2 files changed, 43 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel= /vsec.c index 4aeb0728b435..b1465e67feef 100644 --- a/drivers/platform/x86/intel/vsec.c +++ b/drivers/platform/x86/intel/vsec.c @@ -24,7 +24,9 @@ #include #include #include +#include #include +#include #include =20 #define PMT_XA_START 0 @@ -109,6 +111,7 @@ static void intel_vsec_dev_release(struct device *dev) =20 ida_free(intel_vsec_dev->ida, intel_vsec_dev->auxdev.id); =20 + kfree(intel_vsec_dev->acpi_disc); kfree(intel_vsec_dev->resource); kfree(intel_vsec_dev); } @@ -320,6 +323,13 @@ static int intel_vsec_add_dev(struct device *dev, stru= ct intel_vsec_header *head * auxiliary device driver. */ for (i =3D 0, tmp =3D res; i < header->num_entries; i++, tmp++) { + /* + * Skip resource mapping check for ACPI-based discovery + * since those tables are read from _DSD, not MMIO. + */ + if (info->src =3D=3D INTEL_VSEC_DISC_ACPI) + break; + tmp->start =3D base_addr + header->offset + i * (header->entry_size * si= zeof(u32)); tmp->end =3D tmp->start + (header->entry_size * sizeof(u32)) - 1; tmp->flags =3D IORESOURCE_MEM; @@ -338,6 +348,20 @@ static int intel_vsec_add_dev(struct device *dev, stru= ct intel_vsec_header *head intel_vsec_dev->base_addr =3D info->base_addr; intel_vsec_dev->priv_data =3D info->priv_data; intel_vsec_dev->cap_id =3D cap_id; + intel_vsec_dev->src =3D info->src; + + if (info->src =3D=3D INTEL_VSEC_DISC_ACPI) { + size_t bytes; + + bytes =3D array_size(intel_vsec_dev->num_resources, + sizeof(info->acpi_disc[0])); + if (!bytes) + return -EOVERFLOW; + + intel_vsec_dev->acpi_disc =3D kmemdup(info->acpi_disc, bytes, GFP_KERNEL= ); + if (!intel_vsec_dev->acpi_disc) + return -ENOMEM; + } =20 if (header->id =3D=3D VSEC_ID_SDSI) intel_vsec_dev->ida =3D &intel_vsec_sdsi_ida; diff --git a/include/linux/intel_vsec.h b/include/linux/intel_vsec.h index 4eecb2a6bac4..1fe5665a9d02 100644 --- a/include/linux/intel_vsec.h +++ b/include/linux/intel_vsec.h @@ -33,6 +33,11 @@ struct device; struct pci_dev; struct resource; =20 +enum intel_vsec_disc_source { + INTEL_VSEC_DISC_PCI, /* PCI, default */ + INTEL_VSEC_DISC_ACPI, /* ACPI */ +}; + enum intel_vsec_id { VSEC_ID_TELEMETRY =3D 2, VSEC_ID_WATCHER =3D 3, @@ -103,6 +108,10 @@ struct vsec_feature_dependency { * @parent: parent device in the auxbus chain * @headers: list of headers to define the PMT client devices to create * @deps: array of feature dependencies + * @acpi_disc: ACPI discovery tables, each entry is two QWORDs + * in little-endian format as defined by the PMT ACPI spec. + * Valid only when @provider =3D=3D INTEL_VSEC_DISC_ACPI. + * @src: source of discovery table data * @priv_data: private data, usable by parent devices, currently a callback * @caps: bitmask of PMT capabilities for the given headers * @quirks: bitmask of VSEC device quirks @@ -113,6 +122,8 @@ struct intel_vsec_platform_info { struct device *parent; struct intel_vsec_header **headers; const struct vsec_feature_dependency *deps; + u32 (*acpi_disc)[4]; + enum intel_vsec_disc_source src; void *priv_data; unsigned long caps; unsigned long quirks; @@ -124,7 +135,12 @@ struct intel_vsec_platform_info { * struct intel_vsec_device - Auxbus specific device information * @auxdev: auxbus device struct for auxbus access * @dev: struct device associated with the device - * @resource: any resources shared by the parent + * @resource: PCI discovery resources (BAR windows), one per discovery + * instance. Valid only when @src =3D=3D INTEL_VSEC_DISC_P= CI + * @acpi_disc: ACPI discovery tables, each entry is two QWORDs + * in little-endian format as defined by the PMT ACPI spec. + * Valid only when @src =3D=3D INTEL_VSEC_DISC_ACPI. + * @src: source of discovery table data * @ida: id reference * @num_resources: number of resources * @id: xarray id @@ -138,6 +154,8 @@ struct intel_vsec_device { struct auxiliary_device auxdev; struct device *dev; struct resource *resource; + u32 (*acpi_disc)[4]; + enum intel_vsec_disc_source src; struct ida *ida; int num_resources; int id; /* xa */ --=20 2.43.0