From nobody Sat Feb 7 15:40:21 2026 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3245357A46 for ; Thu, 22 Jan 2026 02:10:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769047851; cv=none; b=BCUuGSvQvVs4QBU4WXas58WQ+ULnNA96vmks92uIEx+WQwIsDRft9ECwKZznGeO1n8EtG2LmjF0fiBlVeglNNecsJpCyyBFKocqWDQE+XKCqTnaG1LyWuW/Kz2llGEKtJaYdSRSP98Ph165mSFwQW1DDAGpzXcZLW4T18WvLgdY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769047851; c=relaxed/simple; bh=G66EWuJIRf3dPEbAum1+c7XXWoBPspYm0WKrtwIzvEE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=s/qqyqjDZIa8OL0Sfy+F8F2e8lGUqRk66GUZJ2ZEvYpvmI2KpgyOIGayNfz+Gvc273RUNjR+TBnLJXnWSLJfyJrWRY5JjBP1hAlUIgsimFmSeMxb3gTjyYVRLXbEWp/GYEWEQYXZQDHAwBxv+lyHjn933YbWkjWn0CnBS6h70hk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ec0og6xl; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ec0og6xl" Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-2a0834769f0so3273735ad.2 for ; Wed, 21 Jan 2026 18:10:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769047849; x=1769652649; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=U+v2634kVJ+SsDKjB7tM4SD9Z9ptuM0rR4tFrzs+qLY=; b=Ec0og6xlVoYPyp3Hncmj458qx0jX3EM6gu8BfSbo9/DLHbih8kUu0/uD2PgKV5qrGZ VAAcJnnqlEatqAiMSIDqnNKsME0cbZShTgySUxCgHoVddkW/T4J5dTN7xMvg8hvFkVr5 GJB387Z88mRM3oMl50iAZVWcE+6ypBX4C+2ain1Yy7k1V4UcZuPYZt+v0JMFJur5W6vM fqecJ2y/lqlCKq6oZ6QxIwtYnJMnkBAHj3tTtAYjAIlKtC3CcBZtba/6udFc41Fcod6J rZ/tTnhGNVRXz7eaT2WNZ+CQ2p7M7bbvIPoDHXi3xeDd6TTDH7gebiYC5yNF3nurEVqo xwVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769047849; x=1769652649; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=U+v2634kVJ+SsDKjB7tM4SD9Z9ptuM0rR4tFrzs+qLY=; b=fKJ9JBpsq7X+4bDJyMbqwLlR/WhyUPiIDaWdu8BxLA6ELSQ2YjBeAFn1dEtLntxqJa ZHajc0MZ+lrKBtK4njZMg+GwSkHaX2h2x7RPaYVTu9pTTUNO5Z+ETsFuE7ef5h91D1R0 GhvBKQgxLtdHeV+bJRwrB+sPbAL0BINQvGK2Nrd7SnUcDOL1tLgBMsUEmrs2n2qovAbk /pQ6+0RU3m9DeVxUrEOpMKRHbPO5KEQtZAq5vzrauLpOzo5UIaHxKnvDXgw+VjUiPEF3 iKpeNZ1/meQq/tdAu/LxOycMD0nrWGN/YeOXuqprWUvMANB6qjQW16+/9vXN3DbdVTod 9/8Q== X-Forwarded-Encrypted: i=1; AJvYcCU5037KATGP0lTLs5osg/WUihKbL3hUQQ1XkYs2Fey/zXkVEONNTFQT3MwoovFdpc+apxiOFjCG/ZkdoYI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz923lvXOluvwTfajMRL0v3JZPfYPzLY/pqGs5ca2kL2F91jqlU cmYqjPJslMhv+xbpkHWWEJ5riNd7oNZaQ0NdcdWm3NlPkT3lcqY1KfI= X-Gm-Gg: AZuq6aJ8/H1nUpm3S3R428nO2wu9J6y6dXR4IyLMW6GvO9Loy4w1u28gWRa2Xv3nhLP f7+uZTNENPxfZ2DlpNbp36zSSJxkBiqF5Bp1QbApk+ItCrWlr/utEEaLhl/eFpMvtAUz8y4shav 5B85T738ES9iotYQf/I/HxJDrl9haLO/Hcmt+MYJfKrUpg4EUYI/L0fbnH9NF7e0D0UA82kTUnn ZmeDtdD8XceXbnHjcPRfo4qh1nH/6Jlx6SQ7AxbrICE2zxRU67wxREMIhXDdTOzT1b8QzQdRwxn vA0UTGS6jlTWFkFJ20FiY3d3m+OGhfslPmGw6ldwaB0bKbqtKQbt1vML7omZ7K4QoXQVctsztHr n1h3AVvxz7H2FUECbxR4QhjJD2MHljBGrKm7w6AstXkD8MFDDR8ZaC81P9FDK4fM3XbUAgmQ4zc jZ5UH+kJuEwYxfgoo= X-Received: by 2002:a17:903:1ca:b0:295:ceaf:8d76 with SMTP id d9443c01a7336-2a71893cf55mr199951955ad.47.1769047848994; Wed, 21 Jan 2026 18:10:48 -0800 (PST) Received: from DESKTOP-BKIPFGN ([38.76.140.13]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a7c975c386sm12590035ad.73.2026.01.21.18.10.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 18:10:48 -0800 (PST) From: Kery Qi To: linkinjeon@kernel.org, smfrench@gmail.com Cc: senozhatsky@chromium.org, tom@talpey.com, mmakassikis@freebox.fr, linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, Kery Qi Subject: [PATCH] ksmbd: validate DataOffset in smb2_write_pipe() Date: Thu, 22 Jan 2026 10:10:16 +0800 Message-ID: <20260122021015.1954-2-qikeyu2017@gmail.com> X-Mailer: git-send-email 2.50.1.windows.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The check of DataOffset in smb2_write_pipe() is insufficient. If DataOffset is 0 or smaller than offsetof(struct smb2_write_req, Buffer), data_buf will point to the SMB2 header instead of the actual data buffer, leading to out-of-bounds read. This is the same issue that was fixed in smb2_write() by commit ac60778b87e4 ("ksmbd: prevent out of bound read for SMB2_WRITE"), but the fix was not applied to smb2_write_pipe(). Add a check to ensure DataOffset is at least offsetof(struct smb2_write_req, Buffer) to prevent this issue. Fixes: 158a66b245739 ("ksmbd: validate length in smb2_write()") Signed-off-by: Kery Qi --- fs/smb/server/smb2pdu.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c index 2fcd0d4d1fb0..1f1086023e74 100644 --- a/fs/smb/server/smb2pdu.c +++ b/fs/smb/server/smb2pdu.c @@ -6932,6 +6932,12 @@ static noinline int smb2_write_pipe(struct ksmbd_wor= k *work) goto out; } =20 + if (le16_to_cpu(req->DataOffset) < + offsetof(struct smb2_write_req, Buffer)) { + err =3D -EINVAL; + goto out; + } + data_buf =3D (char *)(((char *)&req->hdr.ProtocolId) + le16_to_cpu(req->DataOffset)); =20 --=20 2.34.1