drivers/soc/aspeed/aspeed-socinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
The siliconid_to_name function currently masks the input silicon ID with
0xff00ffff, but compares it against unmasked table entries. This causes
matching to fail if the table entries contain non-zero values in the
bits covered by the mask (bits 16-23).
Update the logic to apply the 0xff00ffff mask to the table entries
during comparison. This ensures that only the relevant model and
revision bits are considered, providing a consistent match across
different manufacturing batches.
Signed-off-by: Potin Lai <potin.lai.pt@gmail.com>
---
drivers/soc/aspeed/aspeed-socinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/aspeed/aspeed-socinfo.c b/drivers/soc/aspeed/aspeed-socinfo.c
index 67e9ac3d08ec..a90b100f4d10 100644
--- a/drivers/soc/aspeed/aspeed-socinfo.c
+++ b/drivers/soc/aspeed/aspeed-socinfo.c
@@ -39,7 +39,7 @@ static const char *siliconid_to_name(u32 siliconid)
unsigned int i;
for (i = 0 ; i < ARRAY_SIZE(rev_table) ; ++i) {
- if (rev_table[i].id == id)
+ if ((rev_table[i].id & 0xff00ffff) == id)
return rev_table[i].name;
}
---
base-commit: 24d479d26b25bce5faea3ddd9fa8f3a6c3129ea7
change-id: 20260122-soc_aspeed_name_fix-a64cfaa2d84c
Best regards,
--
Potin Lai <potin.lai.pt@gmail.com>
On Thu, 22 Jan 2026 16:37:56 +0800, Potin Lai wrote: > The siliconid_to_name function currently masks the input silicon ID with > 0xff00ffff, but compares it against unmasked table entries. This causes > matching to fail if the table entries contain non-zero values in the > bits covered by the mask (bits 16-23). > > Update the logic to apply the 0xff00ffff mask to the table entries > during comparison. This ensures that only the relevant model and > revision bits are considered, providing a consistent match across > different manufacturing batches. > > [...] Thanks, I've applied this to the BMC tree. -- Andrew Jeffery <andrew@codeconstruct.com.au>
© 2016 - 2026 Red Hat, Inc.