From nobody Wed Feb 11 00:36:41 2026 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 925F93876DD; Thu, 22 Jan 2026 15:14:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769094865; cv=none; b=DUsBDeDb0mNK7fyQQBjgmtiKZrISbS6pGFTugI6/WZUMQ7u6ysGWEXnn/JdLN9JQ/FzWO4JAp6L44N9zTVM/2MAcRrtuDGqLBjuLU1Y/yBTkNu1aQi+XHHpBO2EAAEISzN4RXmMEnEiwkhjdTsRPfPqH320qtlWO68/7afDzycw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769094865; c=relaxed/simple; bh=dFUCWl21YbgvBCq8xPVkOI7yQqSUl80HaquGBhW8og0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ipBEKsGemMltLYpgrY7rhch5e0kwmr83Z6OomEi1PzYjJ10C9de04XMWskO4OQK865WiMVOuSnQPd9D/HhtsaYLGr0Ke+I39ffv+Wue+TYpA3ht1tu0xeUR7Ay2fK1S38OXKIjYtaAISKuXTPs4S5S+oHM6yw9yLOQii7JtFvk0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=O7nk/K1a; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="O7nk/K1a" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 2672B4E421F2; Thu, 22 Jan 2026 15:14:22 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id F152A606B6; Thu, 22 Jan 2026 15:14:21 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id C8485119B82CA; Thu, 22 Jan 2026 16:14:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1769094860; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=HV3WvR0v32aL9umhOvkyMORoTk5J59HmOATBu7qOfE8=; b=O7nk/K1aD43An8ypmicbRKMP6V3vrpJBh0te44LpnHf+3igHOqoxCNN0dk2C5rH3nCMMFq UQKI3GVzYqM+gCS9uIOfXRbSQvcF+SuvUgRuLmWM89jX2dgr0FQHnoW4PeUXwiKKzQl0OS D3BK/UUJLn/OoYzJy0D54HdGMH2wDZ4u9ktNt5qC5q3yB5k0oP98MD7aj19qJsNG/2Lpr/ mHCwZ8tqRl/iwJkzg+wZFyC0Q+HjNSbSAgIazvq8rExdp2YzEw+EBX/FOUWEjy44GE1D/B Z4M90MhnFAvzuTmPKhM+bGjrccsIhsTsrtsZm3GeMUCH7Kqcl9S6LXt3MCOugQ== From: "Miquel Raynal (Schneider Electric)" Date: Thu, 22 Jan 2026 16:13:38 +0100 Subject: [PATCH v4 13/15] spi: cadence-qspi: Use a default value for cdns,fifo-width Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260122-schneider-6-19-rc1-qspi-v4-13-f9c21419a3e6@bootlin.com> References: <20260122-schneider-6-19-rc1-qspi-v4-0-f9c21419a3e6@bootlin.com> In-Reply-To: <20260122-schneider-6-19-rc1-qspi-v4-0-f9c21419a3e6@bootlin.com> To: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Vaishnav Achath Cc: Thomas Petazzoni , =?utf-8?q?Herv=C3=A9_Codina?= , Wolfram Sang , Vignesh Raghavendra , Santhosh Kumar K , Pratyush Yadav , Pascal Eberhard , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, "Miquel Raynal (Schneider Electric)" X-Mailer: b4 0.14.3 X-Last-TLS-Session-Version: TLSv1.3 Bindings expect 4 to be the default value for cdns,fifo-width. Said otherwise, if the property (which is not mandatory) is not provided, the OS, in order to comply with the bindings, should not error out and take 4 as default value. Comply with the bindings. This would have slighlty simplyfied my testing if it had been implemented correctly in the first place, but in practice it should have no impact on the existing boards using this controller, as they all set cdns,fifo-width to 4 explicitly in their upstream DTS. Tested-by: Wolfram Sang Signed-off-by: Miquel Raynal (Schneider Electric) --- drivers/spi/spi-cadence-quadspi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-qu= adspi.c index e0e4423baed9..5f3a914e45f7 100644 --- a/drivers/spi/spi-cadence-quadspi.c +++ b/drivers/spi/spi-cadence-quadspi.c @@ -1596,10 +1596,8 @@ static int cqspi_of_get_pdata(struct cqspi_st *cqspi) cqspi->fifo_depth =3D 0; } =20 - if (of_property_read_u32(np, "cdns,fifo-width", &cqspi->fifo_width)) { - dev_err(dev, "couldn't determine fifo-width\n"); - return -ENXIO; - } + if (of_property_read_u32(np, "cdns,fifo-width", &cqspi->fifo_width)) + cqspi->fifo_width =3D 4; =20 if (of_property_read_u32(np, "cdns,trigger-address", &cqspi->trigger_address)) { --=20 2.51.1