From nobody Tue Feb 10 06:25:43 2026 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB82E44CF42 for ; Thu, 22 Jan 2026 15:43:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769096643; cv=none; b=HIWr1KrW9ZVfHomP1pPPRqUxwsVXAy53R3gDdYP2dtrMMD+xzIgZFfl2eVIzbwzDHgjshhGt+ck/r5GSWhQ6Oc0d1UM7EA3kIVOt+BTIXUUjE215iO0CU3NeXciYwVJK1U4ohv126idcuvmtAuU6M4TRxCNh6nEIBtMT4MFdA64= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769096643; c=relaxed/simple; bh=Uql4wLrPIchDLzM+Qxxz/zEpZfEFgb0aDGiWtLWAr5Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=N650IWoPBrWt1CNuoxLMjxNeRfH42VboLYgmbJg9/TkkUY0mtYQuxlxyjRUgKWZYuIPzzZT+h7voBUjZ4Ojpbdal/ZpUAfMfYlwN5CJKJeWNYNyhvP+awxvGVcKxuvFNouD9NI2xh199P9cXlvmSxCgXUqM2j2lFKEFOh334unY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=W24v/O/6; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="W24v/O/6" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-6581327d6baso1789048a12.3 for ; Thu, 22 Jan 2026 07:43:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769096625; x=1769701425; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=bweKrz1EAxpVR/K3C13UOoNEyjPdH8YKZynfcS9WhMU=; b=W24v/O/6peMIUrlUcf8CRKAPI1riHUG+qu6g6zRwcglS9UEOX5aOsSdP6Z5k974Xx3 D11Z6LiUKmo4Mn6Cpj9/YLCi2VjhrNe8LAo4U7xVcN5eW08++PdvzXGGMWKT9hozqSqE S3oA9udxnFa9749495UFEJTW+J37AE1/Fw2IhPYBt3U0EShBVL1zpw6a0QDy/0vwcioI ObgnSAhaHTSBHqTHyQAE43uYyGdokUGm3PsZkleQCXHzTF1HDVoQFlkOAFmxZh5RqYan K7o9g3aaHNS93+yfu8jSYPhnPSy4qQcY2yZk+7rzpc8iexrBtivcL3TQJyl+cKJ5fezy iISA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769096625; x=1769701425; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bweKrz1EAxpVR/K3C13UOoNEyjPdH8YKZynfcS9WhMU=; b=ttf7pl53NT/LHq3sFHO/uJuppJem29fexUo7/YlnX2LmOzXEFEdQlLT0KTqly6+DgH mnCTwPDOKXr2iHQDFuA6C0iKgEOpaEIdVH/dvIzH93mlLyNnptzwJR4nq7Db2SSb9a8n 1lmg4DjIsSpXidFO02ispdVCjHKvnZ73nTQvL3SoE8HfVtDjOkfSaQUadph0UDfWWMsL nPSPf94bb3uqWNxkLBuUXHKpcJ4CN4Wh5HnsQSK9+qz7jrG4UdTeB4aL2qSR43ZgM0j5 mOVjStAklW2CNLVVj7trdmDog8as7In7Mbylqdo3VBGhilZwhBvBqn5HKpWGAAqS4OYO 8Krw== X-Forwarded-Encrypted: i=1; AJvYcCWHtNj5gpLDsrDfLGh+6fpBsSVPa5UTlD2wbiLlIDuDwZGY2graGh11T/q3Taso0tkhfi+UYwQcB59sLOY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8JZu6HEymh0juaPkpGmR9o1BmT1YHqG7StnLFQJf+hxVKA+zJ gMSSoqerpQ7+12cw0Jm3iV3TQzdVyBcqn+R7SRT9XbTpk3//nu5x20+igpRrPngK4As= X-Gm-Gg: AZuq6aLpN9iN2YwsaXBw/2IYE1gRBOBp+uPSMd2wvWWFf4BwrW+Z2vbGE22LBSn58e5 7ETlNL9RGXYKX6wt5nww3QQ3CVAK8+GGn1qpJQwDHz9VOhtE6mstZBpE/Lxg99gKzJbmx6wZKei ockeH7hBgn6jH9Z8+vZ3X1y+rgzyLEryzpDmAq3NkBinM3u8fmoBgyE36TdORlFqBd8sl0d0Bmz BBuU/r8OARsOKeXg/eZW/KaQ3zObxs0f9sQOZ+21R49UGbOmZNxBLtNp7N0gxJs/rsF3fC+TQJA bnOYWCAlO3IfrzoctKJNtvTsS/Dg48xunT+GwgfK5LH7Oixgrc98E1zyS6QQ/KMt4CEIyinkD5K qtTfMrd1Y3y0cT5bRzXC9BXjFBX50MYHX1RXcUU8VauOqKeP2FotVnAdCiwprWSJF4mBDi1GnA/ T9gN5+36Oi43Tkm/ZBnrKO36yva1HsuW2w12GIikHmm78OYf21sOC50x7M3xrsXFde1qyngXPeF juvCRpM+7OqJkLy X-Received: by 2002:a05:6402:1468:b0:64d:ab6b:17cf with SMTP id 4fb4d7f45d1cf-658487d5f67mr15227a12.33.1769096624685; Thu, 22 Jan 2026 07:43:44 -0800 (PST) Received: from puffmais2.c.googlers.com (244.175.141.34.bc.googleusercontent.com. [34.141.175.244]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-654535c49f4sm16334363a12.31.2026.01.22.07.43.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jan 2026 07:43:44 -0800 (PST) From: =?utf-8?q?Andr=C3=A9_Draszik?= Date: Thu, 22 Jan 2026 15:43:39 +0000 Subject: [PATCH v7 12/20] regulator: s2mps11: use dev_err_probe() where appropriate Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260122-s2mpg1x-regulators-v7-12-3b1f9831fffd@linaro.org> References: <20260122-s2mpg1x-regulators-v7-0-3b1f9831fffd@linaro.org> In-Reply-To: <20260122-s2mpg1x-regulators-v7-0-3b1f9831fffd@linaro.org> To: Tudor Ambarus , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Lee Jones , Linus Walleij , Bartosz Golaszewski , Krzysztof Kozlowski , Linus Walleij , Bartosz Golaszewski Cc: Peter Griffin , Will McVicker , Juan Yescas , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, =?utf-8?q?Andr=C3=A9_Draszik?= , Krzysztof Kozlowski X-Mailer: b4 0.14.2 dev_err_probe() exists to simplify code and harmonise error messages, there's no reason not to use it here. While at it, harmonise some error messages to add regulator name and ID like in other messages in this driver, and update messages to be more similar to other child-drivers of this PMIC (e.g. RTC). Reviewed-by: Krzysztof Kozlowski Signed-off-by: Andr=C3=A9 Draszik --- drivers/regulator/s2mps11.c | 29 ++++++++++++++--------------- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c index 1f51fbc6c7b6e158f9707c04d9f030b9eee5e842..30586e9884bfb998ff07e314881= 3344b307506c0 100644 --- a/drivers/regulator/s2mps11.c +++ b/drivers/regulator/s2mps11.c @@ -1249,9 +1249,9 @@ static int s2mps11_pmic_probe(struct platform_device = *pdev) BUILD_BUG_ON(S2MPS_REGULATOR_MAX < ARRAY_SIZE(s2mpu05_regulators)); break; default: - dev_err(&pdev->dev, "Invalid device type: %u\n", - s2mps11->dev_type); - return -EINVAL; + return dev_err_probe(&pdev->dev, -ENODEV, + "Unsupported device type %d\n", + s2mps11->dev_type); } =20 s2mps11->ext_control_gpiod =3D devm_kcalloc(&pdev->dev, rdev_num, @@ -1290,21 +1290,20 @@ static int s2mps11_pmic_probe(struct platform_devic= e *pdev) devm_gpiod_unhinge(&pdev->dev, config.ena_gpiod); regulator =3D devm_regulator_register(&pdev->dev, ®ulators[i], &config); - if (IS_ERR(regulator)) { - dev_err(&pdev->dev, "regulator init failed for %d\n", - i); - return PTR_ERR(regulator); - } + if (IS_ERR(regulator)) + return dev_err_probe(&pdev->dev, PTR_ERR(regulator), + "regulator init failed for %d/%s\n", + regulators[i].id, + regulators[i].name); =20 if (config.ena_gpiod) { ret =3D s2mps14_pmic_enable_ext_control(s2mps11, - regulator); - if (ret < 0) { - dev_err(&pdev->dev, - "failed to enable GPIO control over %s: %d\n", - regulator->desc->name, ret); - return ret; - } + regulator); + if (ret < 0) + return dev_err_probe(&pdev->dev, ret, + "failed to enable GPIO control over %d/%s\n", + regulator->desc->id, + regulator->desc->name); } } =20 --=20 2.52.0.457.g6b5491de43-goog