From nobody Sun Feb 8 05:28:22 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1ACD1E0DD8; Thu, 22 Jan 2026 16:44:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769100279; cv=none; b=YkyQYw2GOuTGQ1q80wMZcCzBhHwSfnW9wPQHfftWwo57I11xOuNW/yiZNbq8ZNjgDIQXCvuDmRjP422BRoJIxcxqf+E8oo9beenyhHz8bpRwt3S1FVsdDu4IJ00JRd4eLksOa/A0CIAQ516PfYu/WIWTCEkQMbMgJ4BakXrQz38= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769100279; c=relaxed/simple; bh=JC52RpmU/eEqAbLLOYq4VyCvG0i40uK2mOQjuoMBLUM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=E58LmkXgKkFJcpyBv5N9KS7+6hkZXxHez2sYHDvj3m2MpstajUwO6enyI6SiMHCeWU7r9X4rWEe3nbtKixwZjlQrvwWVPGUbzFJ4uUJh8uBsQgLIGgcAd2bDt1B3sCimGuPz0q6gRY2CZk48OMufXlTOewYOM/H2rdVBQ2aTScY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pTxLINgN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pTxLINgN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81AA5C116C6; Thu, 22 Jan 2026 16:44:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769100277; bh=JC52RpmU/eEqAbLLOYq4VyCvG0i40uK2mOQjuoMBLUM=; h=From:Date:Subject:To:Cc:From; b=pTxLINgN0aMgtL7ViUw1cB7hYh7W3Byn5q6oaUBA8O4IJLcUYJzUq7oTZm7c2gdnQ 6X2DagrtVWEjkQ/7HqHaxXSo7a+P4A8jDDA/JGvFmdzW+PWY0U9hUXBAy90+CpLtCo fDn/53MBBMa9vRVp7exjEAt33DWmQfnanKYxUL9Nd7N5cM9OOp7UrfbUgD8GoPugzA f76+IEs7H/mplkYE5mL31vjRfr5B5XUrB2uyRcwjnxcUV9q6RVVi7y1MxJGDDJtKVj AuncnVAvXGH253mSrfbQaH+K/9N2r2MNbFwfcKRRq3upN5JIjY5dVvXv9wt6CIie7Q +f/8EtCyzxGlA== From: Tamir Duberstein Date: Thu, 22 Jan 2026 11:44:33 -0500 Subject: [PATCH] scripts: generate_rust_analyzer.py: avoid FD leak Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260122-rust-analyzer-fd-leak-v1-1-945577813b20@kernel.org> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXMQQ6CQAxA0auQrmkyVDMar2JYDEzRKhlJCwYk3 N0Rl2/x/wrGKmxwKVZQfovJK2VUZQHtPaQbo8RsIEfeVUSok40YUuiXDyt2EXsOT2zoeDofXPT eM+R2UO5k3r/X+m+bmge3428G2/YFIIjSMnkAAAA= X-Change-ID: 20260122-rust-analyzer-fd-leak-b247830d666e To: Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Alex Gaynor , Fiona Behrens , Boris-Chengbiao Zhou Cc: Kees Cook , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Daniel Almeida , Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1769100275; l=1288; i=tamird@kernel.org; h=from:subject:message-id; bh=JC52RpmU/eEqAbLLOYq4VyCvG0i40uK2mOQjuoMBLUM=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QAogqhziJkc867yHN5uGBWLh5t4PjCYlX/rtV4VUjJOmhXaNlTxTZocYgIGPgOGKjd3DvmaDPvb DP8Xut9+y8A4= X-Developer-Key: i=tamird@kernel.org; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Use a context manager to avoid leaking file descriptors. Fixes: 8c4555ccc55c ("scripts: add `generate_rust_analyzer.py`") Cc: stable@vger.kernel.org Reviewed-by: Daniel Almeida Tested-by: Daniel Almeida Reviewed-by: Fiona Behrens Reviewed-by: Trevor Gross Signed-off-by: Tamir Duberstein --- scripts/generate_rust_analyzer.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_anal= yzer.py index 3b645da90092..5ed375c8aa3f 100755 --- a/scripts/generate_rust_analyzer.py +++ b/scripts/generate_rust_analyzer.py @@ -190,7 +190,8 @@ def generate_crates(srctree, objtree, sysroot_src, exte= rnal_src, cfgs, core_edit =20 def is_root_crate(build_file, target): try: - return f"{target}.o" in open(build_file).read() + with open(build_file) as f: + return f"{target}.o" in f.read() except FileNotFoundError: return False =20 --- base-commit: 2af6ad09fc7dfe9b3610100983cccf16998bf34d change-id: 20260122-rust-analyzer-fd-leak-b247830d666e Best regards, -- =20 Tamir Duberstein