From nobody Mon Feb 9 19:30:00 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE396368290 for ; Thu, 22 Jan 2026 02:08:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769047737; cv=none; b=Dhmba9njEzkFvKLfq0hUmXYzhvCNzchm1NMJp9MjwtZOk71KvNLYjUjXMYlbdOpl1mR+C1zt5R06kyMgQPLgOEJlIU+YYVDFJUTnxVqtDBWinpyTCnoCkAdhOryGVcp11NN/eIgiFJJhZudbeXxs5kFOsT7VbbbfcceiHHt32us= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769047737; c=relaxed/simple; bh=iOBlKE7wcNNqdQg697EHs/307n7EmzHjJxd5G5rMLIU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ccpAwKeqqFjCanV9usCs//VoGmCSyl5NPEt9ZuhWUGbA48/YE3/aKsU4AZJKjkSCSolDk4JYVBL27EqIOXA8w/+y7JUwMMzqDgfUpwTUbWpto1ZbkHAFcQRbWGD01ipiYd6NDZB7zc1INKsWS3I5/zqU2RRoSnY/o1IhbiZGLFU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jOTKGa0k; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=N0arxgzH; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jOTKGa0k"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="N0arxgzH" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60LNT6A82727071 for ; Thu, 22 Jan 2026 02:08:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4Jay9EfBX3UpMTwsvQnGvQgNS5FLBeKOwQWuoZ1I2KI=; b=jOTKGa0kbLdt4M3S ss4f2RVWpeRnYfiOZRvKwAa65qoXvAYFlW2vC2XW6m3E9B4RBbcg9CT0USwV/F91 nmi2jJimwFA29KGkF6mu+Y0cPhfkUjKDs6GSZTvGS35C1tR0iVmpelljY9un9Uzi MFAkcmO87emgRINJfGBL2hBqzouHHK7c0XV/AKrJd/NXs9xAFR9s6nI3FlIdx288 2Ev6b8LsIivRUp0l3wOrsvACF5VwgDs8nxIX5QZVUOlYGwnJXdUHtvWsU6UdAAZZ yDB3ulQI62FtnPdYhwW2j7tMyTCa6RzVwzOewZCW1SxovYRA4RLBQ5GPPXlDB5Xw /oZ9/g== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4btysft6tk-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 22 Jan 2026 02:08:53 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a377e15716so9164805ad.3 for ; Wed, 21 Jan 2026 18:08:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769047733; x=1769652533; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=4Jay9EfBX3UpMTwsvQnGvQgNS5FLBeKOwQWuoZ1I2KI=; b=N0arxgzHuSn01W9a+vgbWr6+0uE4gJ6OvQm4pBN3Pq/IF81BsBI/2aTD+fCGUr2XuU a70tAqbuAE5gcvtSD8VOGryzR4iIeE491lj5WurxOiwntKuffi7D11RsLLXMiu8vvL+b KBzPyMWn7s1rylCW/kxIqg/eIOH+qCctFVTUOfIffr1BxYlX33HzL0eqtUvsG5B8IHY5 UoNk7e5sIHo86wHpMdITcGwz7WFkPr4wJHTj6oohEtseeMjtXSK9kFuNQ1GRFLlwVHlG UhI9/oM8QV9jGjIVQvsbGzD/26K5L39ip1oKw5hDYjYtqAFi+vqG+ADAZ5Z96HYEk/LM Snzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769047733; x=1769652533; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=4Jay9EfBX3UpMTwsvQnGvQgNS5FLBeKOwQWuoZ1I2KI=; b=Q/s4j43LzlfiquKtZt9XsF3JeGNnJr72bbi9baqPDELA/O7tJq1EAqFbeZr0QSsn6v KSik9ZWrPs1NqIIHrCltjtjnCr8HNCcrEJ49OESrwS5hTKExawX8nmvlAQErASe8nm8H P8IcIxSDt1II5DwvxSO+rwXEGAhxFjA4X/ELKC+FS066Dn+kfW+UwUl8DOujJ70S19IN txRFV/WruGh103S0ovF3VaMgw9Yy9WjCE70ek/0Vfw1ft5zLYa8wNw7C4tKrd3f140zl bQnvN27DJda4I+rD1J1qXtFEmy8cfUorNKeena+MQXg6/po+9/S6rxKPEUE5KjSrZTLA TY1Q== X-Forwarded-Encrypted: i=1; AJvYcCWsER1tWtuaOVwOLFQFaS2b8aJncShpbccxHi+GV9GOuH8qpq92bln6tBeRDCwO6PPmG7uQuIOH3zNBdYU=@vger.kernel.org X-Gm-Message-State: AOJu0Yx97OGMDLwOuNLNfUm/l29vu+O0YmtBYrWVoCVN5z7s8hAFXMI+ KfM1+U4FUJiBmoZpU7M7krVPCZls9BOgoSe00E3rvFmqf9Li2I6l6/N6qJDFe6QhjwlmBe6Y/2/ 0f7zcysw5YwEwPv54KWOfA7JtcTCHm7ML+fogRWNKiuyaaBWHt7Qz0jQT1GWsNGww9E0= X-Gm-Gg: AZuq6aKyRWXZP34luWbGVLlLZ1YdJlNgfmIl5SRDnYeYgj2qHnS8aWQayWlULiUNfUD KIe/LBVVLXsez9LATwxOgeNMIyprWSmEAQQ1nfHyf2vHng1zfGf1j7STQMeUbmTnyV40YNvVk9A g8O64mpbeOY5vnPI2yGKVQFg2rOjrPPhYDzahPvSDYxvT/IVfUahuY8fYMd1a3yRZCBre9mSzmq 8zyqfdbeBLjfp+zaGl5tJFnQ0HKtYKUoVIrRiT16j+S6ToQHgr1O1INzBl2Vo9pKiJCDjGUvkUP iiVFgiecZVMkdm2Wm6c1zDwPUCD81TdL3g8F/wuMv1LZsNxNN8I4XLkBlASzlGk+dysuV+iBGDA ua3U+YT8Qxn8GMgEcNdpC+BWMC2caOBfrPp3NPIIe845fqWQHBQ9JB2p12epslrQypW8PrSdG X-Received: by 2002:a17:902:d50e:b0:2a0:d7f6:e030 with SMTP id d9443c01a7336-2a7188f7fc8mr194760405ad.29.1769047732472; Wed, 21 Jan 2026 18:08:52 -0800 (PST) X-Received: by 2002:a17:902:d50e:b0:2a0:d7f6:e030 with SMTP id d9443c01a7336-2a7188f7fc8mr194760195ad.29.1769047731908; Wed, 21 Jan 2026 18:08:51 -0800 (PST) Received: from jiegan-gv.ap.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a780a4631csm49710305ad.18.2026.01.21.18.08.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 18:08:50 -0800 (PST) From: Jie Gan Date: Thu, 22 Jan 2026 10:08:15 +0800 Subject: [PATCH v10 2/8] coresight: tmc: add create/clean functions for etr_buf_list Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260122-enable-byte-cntr-for-ctcu-v10-2-22978e3c169f@oss.qualcomm.com> References: <20260122-enable-byte-cntr-for-ctcu-v10-0-22978e3c169f@oss.qualcomm.com> In-Reply-To: <20260122-enable-byte-cntr-for-ctcu-v10-0-22978e3c169f@oss.qualcomm.com> To: Suzuki K Poulose , Mike Leach , James Clark , Alexander Shishkin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tingwei Zhang , Mao Jinlong , Bjorn Andersson , Konrad Dybcio Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Jie Gan X-Mailer: b4 0.14.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769047715; l=6192; i=jie.gan@oss.qualcomm.com; s=20250909; h=from:subject:message-id; bh=iOBlKE7wcNNqdQg697EHs/307n7EmzHjJxd5G5rMLIU=; b=jzEtsNMGYZsrezqPbkw/udFfJW0/Nm0vvbpPfSfQrPo9FocDTUoW4Gq9F64MOuJTwGaKjv/CS /Wey+mTfDgkBfANVJnQTGDzMuaCQqpeYVBl1+4BFFYZCRlJjG5tA5BD X-Developer-Key: i=jie.gan@oss.qualcomm.com; a=ed25519; pk=3LxxUZRPCNkvPDlWOvXfJNqNO4SfGdy3eghMb8puHuk= X-Authority-Analysis: v=2.4 cv=N8Ik1m9B c=1 sm=1 tr=0 ts=697186b5 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=AScg1gZdVb1XvqdcXssA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: JjsprnzZyKHzU4Zf6lqR6Lsg7W4pvFaG X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIyMDAxNSBTYWx0ZWRfXx3W3UOOW+8Ps o984YVIW7NVFVwSo5yMyC69UbauSZiaWPNTh41V3rxN5Nvrb86XlSbZLXYeXPgGWQPb3slVyLw6 E9+H8ZdNeOgwGtApEFwbp521LA/DfWfFH7kdkWK1AZqiVZppgGMYA1g1nvtFQXke3Gh6kUe+4kL cncACF+u/oGvFv0HVFDwrPYbNoNFCTNkf7f2I5dCdKE3XOvKuwdnCiuqO8tJ/4qSYK4gyjWvjXR gquf/qpYxclbb8FZLRE/FPVnwbOpiy08F1FozvGYtxgX9xUtwsH7W6VdpUzUieOAQoJOFkk4YUB mED2GGSLDFOo8IQXaMXyTRh0scM6lCJNgULDdFhB7GYB03jXt8ZgfLW5nROtiq8wYm1kVkwNNdr Y9hQZj7BtKcucstlbI/kudcaIt9ZC6siZ3TLhzcabTZkzZEf78jsvt/N5A7FSEEwpcEjV/2cjoX btDTYNrE5ZMDAD6PFjA== X-Proofpoint-ORIG-GUID: JjsprnzZyKHzU4Zf6lqR6Lsg7W4pvFaG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-21_04,2026-01-20_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 lowpriorityscore=0 impostorscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 adultscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601220015 Introduce functions for creating and inserting or removing the etr_buf_node to/from the etr_buf_list. The byte-cntr functionality requires two etr_buf to receive trace data. The active etr_buf collects the trace data from source device, while the byte-cntr reading function accesses the deactivated etr_buf after is has been filled and synced, transferring data to the userspace. Reviewed-by: Mike Leach Signed-off-by: Jie Gan --- drivers/hwtracing/coresight/coresight-tmc-core.c | 1 + drivers/hwtracing/coresight/coresight-tmc-etr.c | 94 ++++++++++++++++++++= ++++ drivers/hwtracing/coresight/coresight-tmc.h | 19 +++++ 3 files changed, 114 insertions(+) diff --git a/drivers/hwtracing/coresight/coresight-tmc-core.c b/drivers/hwt= racing/coresight/coresight-tmc-core.c index 36599c431be6..1ea255ffa67c 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-core.c +++ b/drivers/hwtracing/coresight/coresight-tmc-core.c @@ -840,6 +840,7 @@ static int __tmc_probe(struct device *dev, struct resou= rce *res) idr_init(&drvdata->idr); mutex_init(&drvdata->idr_mutex); dev_list =3D &etr_devs; + INIT_LIST_HEAD(&drvdata->etr_buf_list); break; case TMC_CONFIG_TYPE_ETF: desc.groups =3D coresight_etf_groups; diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtr= acing/coresight/coresight-tmc-etr.c index e0d83ee01b77..cbbb15648fb7 100644 --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c @@ -1919,6 +1919,100 @@ const struct coresight_ops tmc_etr_cs_ops =3D { .panic_ops =3D &tmc_etr_sync_ops, }; =20 +/** + * tmc_clean_etr_buf_list - clean the etr_buf_list. + * @drvdata: driver data of the TMC device. + * + * Remove the allocated node from the list and free the extra buffer. + */ +void tmc_clean_etr_buf_list(struct tmc_drvdata *drvdata) +{ + struct etr_buf_node *nd, *next; + + list_for_each_entry_safe(nd, next, &drvdata->etr_buf_list, node) { + if (nd->sysfs_buf =3D=3D drvdata->sysfs_buf) { + if (coresight_get_mode(drvdata->csdev) =3D=3D CS_MODE_DISABLED) { + drvdata->sysfs_buf =3D NULL; + tmc_free_etr_buf(nd->sysfs_buf); + nd->sysfs_buf =3D NULL; + } + list_del(&nd->node); + kfree(nd); + } else { + /* Free allocated buffers which are not utilized by ETR */ + list_del(&nd->node); + tmc_free_etr_buf(nd->sysfs_buf); + nd->sysfs_buf =3D NULL; + kfree(nd); + } + } +} +EXPORT_SYMBOL_GPL(tmc_clean_etr_buf_list); + +/** + * tmc_create_etr_buf_list - create a list to manage the etr_buf_node. + * @drvdata: driver data of the TMC device. + * @num_nodes: number of nodes want to create with the list. + * + * Return 0 upon success and return the error number if fail. + */ +int tmc_create_etr_buf_list(struct tmc_drvdata *drvdata, int num_nodes) +{ + struct etr_buf_node *new_node; + struct etr_buf *sysfs_buf; + int i =3D 0, ret =3D 0; + + /* We dont need a list if there is only one node */ + if (num_nodes < 2) + return -EINVAL; + + /* We expect that sysfs_buf in drvdata has already been allocated. */ + if (drvdata->sysfs_buf) { + /* Directly insert the allocated sysfs_buf into the list first */ + new_node =3D kzalloc(sizeof(struct etr_buf_node), GFP_KERNEL); + if (IS_ERR(new_node)) + return PTR_ERR(new_node); + + new_node->sysfs_buf =3D drvdata->sysfs_buf; + new_node->is_free =3D false; + list_add(&new_node->node, &drvdata->etr_buf_list); + i++; + } + + while (i < num_nodes) { + new_node =3D kzalloc(sizeof(struct etr_buf_node), GFP_KERNEL); + if (IS_ERR(new_node)) { + ret =3D PTR_ERR(new_node); + break; + } + + sysfs_buf =3D tmc_alloc_etr_buf(drvdata, drvdata->size, 0, cpu_to_node(0= ), NULL); + if (IS_ERR(sysfs_buf)) { + kfree(new_node); + ret =3D PTR_ERR(sysfs_buf); + break; + } + + /* We dont have a available sysfs_buf in drvdata, setup one */ + if (!drvdata->sysfs_buf) { + drvdata->sysfs_buf =3D sysfs_buf; + new_node->is_free =3D false; + } else + new_node->is_free =3D true; + + new_node->sysfs_buf =3D sysfs_buf; + list_add(&new_node->node, &drvdata->etr_buf_list); + i++; + } + + /* Clean the list if there is an error */ + if (ret) + tmc_clean_etr_buf_list(drvdata); + + return ret; +} +EXPORT_SYMBOL_GPL(tmc_create_etr_buf_list); + int tmc_read_prepare_etr(struct tmc_drvdata *drvdata) { int ret =3D 0; diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracin= g/coresight/coresight-tmc.h index 95473d131032..9b3c4e6f0a5e 100644 --- a/drivers/hwtracing/coresight/coresight-tmc.h +++ b/drivers/hwtracing/coresight/coresight-tmc.h @@ -208,6 +208,19 @@ struct tmc_resrv_buf { s64 len; }; =20 +/** + * @sysfs_buf: Allocated sysfs_buf. + * @is_free: Indicates whether the buffer is free to choose. + * @pos: Position of the buffer. + * @node: Node in etr_buf_list. + */ +struct etr_buf_node { + struct etr_buf *sysfs_buf; + bool is_free; + loff_t pos; + struct list_head node; +}; + /** * struct tmc_drvdata - specifics associated to an TMC component * @atclk: optional clock for the core parts of the TMC. @@ -243,6 +256,8 @@ struct tmc_resrv_buf { * (after crash) by default. * @crash_mdata: Reserved memory for storing tmc crash metadata. * Used by ETR/ETF. + * @etr_buf_list: List that is used to manage allocated etr_buf. + * @reading_node: Available buffer_node for byte-cntr reading. */ struct tmc_drvdata { struct clk *atclk; @@ -273,6 +288,8 @@ struct tmc_drvdata { struct etr_buf *perf_buf; struct tmc_resrv_buf resrv_buf; struct tmc_resrv_buf crash_mdata; + struct list_head etr_buf_list; + struct etr_buf_node *reading_node; }; =20 struct etr_buf_operations { @@ -445,5 +462,7 @@ struct etr_buf *tmc_etr_get_buffer(struct coresight_dev= ice *csdev, enum cs_mode mode, struct coresight_path *path); extern const struct attribute_group coresight_etr_group; +void tmc_clean_etr_buf_list(struct tmc_drvdata *drvdata); +int tmc_create_etr_buf_list(struct tmc_drvdata *drvdata, int num_nodes); =20 #endif --=20 2.34.1