From nobody Sat Feb 7 17:09:52 2026 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 72C1C35295D for ; Wed, 21 Jan 2026 19:13:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769022815; cv=none; b=jzwjP37KA01r+x3VXJRdzQ9PH+SG45exv6DlSPvmEuhz12Y0eP40SlqV24RKOixuYtDh/ULy6525aLEEovaXbJkxApYyuJJtSWbN4sZjJlPH86WdGgiP2qqaP68kv50Ic1RsFSk2t2ctBAsGAD2BCiDz6I0BRIhRQzu5+Cx+5NQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769022815; c=relaxed/simple; bh=7gMI1TsP9spLwC9HiR3XTx+iLr7v/aUUSQU73Af3yWs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=pM9Kn4n9CO9Di9mkiipm/EPNtwo/kTz/mxe8QUWhgmR9Mp3Kv40fnG/1+uuIaUWgbjmM1QAJOAhwgEMM2WGyLGoNAgtmsT/QQ/9CyZ/+MuflNNLYemoMC3bvI087F0hs7AKQsM//MGenNbqI4Vj8PElS4aYhp05T1LFCmpvr82A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Ha1fmR0x; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ha1fmR0x" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769022812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=49OPiVw3AsdRRD7f8ruuY3VOWZX2Ei/vee0/0X9WHUQ=; b=Ha1fmR0xH4R0ppz97wSUtlPpH5mlRBLvmzcj5GA7ZnHNZQNP7oOVaCm0G7+PrmNpmvzQqN pcgtc4AYVlnY1hpAhbko+uWOCGQ18jk+8kWbwzUX2tfbm/vI2+iTBlyR2+jTR2J2JSVYGg +pziAtF8j8XLkkF2rPLx4keoUv3m/GM= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-675-mD4iWvf3PWi6QrpwgzgEdQ-1; Wed, 21 Jan 2026 14:13:26 -0500 X-MC-Unique: mD4iWvf3PWi6QrpwgzgEdQ-1 X-Mimecast-MFC-AGG-ID: mD4iWvf3PWi6QrpwgzgEdQ_1769022805 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A85FC1800451; Wed, 21 Jan 2026 19:13:24 +0000 (UTC) Received: from GoldenWind.redhat.com (unknown [10.22.89.232]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A32CE19560AB; Wed, 21 Jan 2026 19:13:22 +0000 (UTC) From: Lyude Paul To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, nouveau@lists.freedesktop.org Cc: stable@vger.kernel.org, "Maarten Lankhorst" , "Simona Vetter" , "David Airlie" , "Thomas Zimmermann" , "Maxime Ripard" , "Danilo Krummrich" , "Lyude Paul" Subject: [PATCH] drm/nouveau/disp: Set drm_mode_config_funcs.atomic_(check|commit) Date: Wed, 21 Jan 2026 14:13:10 -0500 Message-ID: <20260121191320.210342-1-lyude@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 Content-Type: text/plain; charset="utf-8" Apparently we never actually filled these in, despite the fact that we do in fact technically support atomic modesetting. Since not having these filled in causes us to potentially forget to disable fbdev and friends during suspend/resume, let's fix it. Signed-off-by: Lyude Paul Cc: stable@vger.kernel.org Reviewed-by: Dave Airlie --- drivers/gpu/drm/nouveau/nouveau_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/no= uveau/nouveau_display.c index 00515623a2cc7..829c2b573971c 100644 --- a/drivers/gpu/drm/nouveau/nouveau_display.c +++ b/drivers/gpu/drm/nouveau/nouveau_display.c @@ -352,6 +352,8 @@ nouveau_user_framebuffer_create(struct drm_device *dev, =20 static const struct drm_mode_config_funcs nouveau_mode_config_funcs =3D { .fb_create =3D nouveau_user_framebuffer_create, + .atomic_commit =3D drm_atomic_helper_commit, + .atomic_check =3D drm_atomic_helper_check, }; =20 =20 base-commit: 68b271a3a94cfd6c7695a96b6398b52feb89e2c2 --=20 2.52.0