From nobody Wed Feb 11 02:09:41 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC3664A5B0C for ; Wed, 21 Jan 2026 15:01:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769007717; cv=none; b=tbyD+816YzvJxrInDtA8GBNJQyipnD+7UTZ6UQ1arw646Dx0u17b0Gp9xRPwL/4hZU9o7/oio3TypjY1nbh6djAQkEp9cdvwqKfdwU8J4rew7RdI4xv2RZVuv4BnsFAofrgXNpKugl2D/6nBKXMd+c4hZucBzjclOP3sfaX6dKQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769007717; c=relaxed/simple; bh=Uv/AGRuhXvq3F9DY+5eCJmGmm21g50CP40fZHe9h8kw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fZoffXsyj/iKVy1x0w5P1d7usIwmktUUmf4B4RSnJZi0SFoASbFeMFccaOi+WSLc/9GMgNTAIsTtyT7u+f2qSsr+b3hCqWwXv6e/gC0vAGj3Xq3y4avwC2oBi/pzi3K9gX4+eKoyG6QUc94i7df0bazyY9JNUKW5fEtzb7K5RiI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AYTf7pOq; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AYTf7pOq" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-47edd6111b4so64595245e9.1 for ; Wed, 21 Jan 2026 07:01:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769007714; x=1769612514; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JVOkMNI/Fpx1qxHV4Yo6OdiJq8KEdcXkySh96FrgdkQ=; b=AYTf7pOqKW0HwC5fw8pHUYAn26Wo4BS6lZVi7oeq5urwvEMQ+dQLiVCS4Jj3ZVLU94 YnUaIx2DlSlYkx8mTxhOvb1CLbR41uIFfUbmjvJb6+MvfZwOqBix4b4gv3BUcQt3hrNu PhmUvBLB1l/S4KZAXEsHxpKctySMogxPQssvQOjCrqjU+lMqsECd0rK5tAuba+s9V0Ll NLN4dLwpav7q8zUt4On2WWtirx0M5SuW7bZ7THLGww2uuwgoMovjcAlt/Vm0h22jlZlS ZQb6skTllaXQWEPR6LItHHnW1mNIkcgrIqXq5PxTfaHftR6dgifYy7TLLksse9SKEJhG R/7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769007714; x=1769612514; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JVOkMNI/Fpx1qxHV4Yo6OdiJq8KEdcXkySh96FrgdkQ=; b=dSBSetIOApT5DpIdQkouQG8xQX+NRHxuUQxJcO6ewOiYkVD4YM6CPmYuAF+U5blaUS NQxI0IxW1vocIuT0mZEULqzgx2+LCpCnJC8IY9PgQq2pyFrKDI6gYwgpOR6AvbXxfw4N h8IUSJwIhKngmUlnHSTR+Nd8uJa2pUUKyC0nAeFxjXysH3VDLyi6JgbzWMJ1XO5flZ9N U5gEIuvXuTwt1evKeodZ1tMVic8sN7Lb9qP+TlukMFBbMA4nQukFDlh8dBz653meUyqK 2y2YHawvXkt+h1ZwiTVeIPjzWpnJtrlr1FxMAQ1TObxc8rITXh88ZRL9PE9eGrV3y8JM YnsQ== X-Gm-Message-State: AOJu0YwxsYfg8r0SmuezXogdysRL0SWWdH5mjOq4RzvevDYxz7czsWtp SgTYXBtkqJIAkCvyQe3U/vkJmOPGSCD7av0nbrLRevnZpovim8oxdpum X-Gm-Gg: AZuq6aJTLAoAXQSfdes8Bjd26mnQzLnUlIaxRNG+K8i7rFDQ93twhWELlojHlLlPuqy SG9UaUofVTqiYdX194eelyOcC4fX4BXaGEA03Hjb8DU6zfbkKyVzoTX5w7Yts/8dBZJeb/s91bQ 0yW/E9OUMFXdBhu9xuuuBEYkzh1ePFxl/eOHXgmzLLw5GC7J68gMg74bXSMIcCmpnMrcx+Uv571 7NlaQwzTniG3BJcrfSk9lqv6YYF7ELTt1QB+eXcoEdwpMDKaZd8TDhgwBhKbjOndVS5DG5uPOBe oHx6Z9ppKuLdU8/IB4N1LYXhvN7HPqf2a/wsksL/6fMGvjEYfSecxxMdXYhwW8Uk/kzIeO65Rg8 6T21aWx3LoxX3WUeCL4MkRrgiAQTXbI+r5CC2emwP76/OmyRd1brAw8VKDP5lTNqSS/LjQPth6T I+XsuuJg/b62zZXgywWorMn/rP9orMtApcGmurCnpW+XX9eUJZ0xr0+IxFqtAiFnj8Yald/uVsv WYcDuf9Xzq2fJXNkkS2RslBVVxSNalr X-Received: by 2002:a05:600d:644f:10b0:47b:da85:b9ef with SMTP id 5b1f17b1804b1-4801e2fef40mr219703485e9.16.1769007713835; Wed, 21 Jan 2026 07:01:53 -0800 (PST) Received: from iku.example.org ([2a06:5906:61b:2d00:3190:c653:bb13:4ca]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48042b6a3e2sm24787585e9.1.2026.01.21.07.01.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 07:01:53 -0800 (PST) From: Prabhakar X-Google-Original-From: Prabhakar To: Thomas Gleixner , Philipp Zabel , Geert Uytterhoeven , Magnus Damm Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH 3/6] irqchip/renesas-rzv2h: Switch to using dev_err_probe() Date: Wed, 21 Jan 2026 15:01:34 +0000 Message-ID: <20260121150137.3364865-4-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260121150137.3364865-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260121150137.3364865-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Make use of dev_err_probe() to simplify rzv2h_icu_probe_common(). Keep dev_err() for -ENOMEM paths, as dev_err_probe() does not print for allocation failures, ensuring they remain visible in logs. Signed-off-by: Lad Prabhakar --- drivers/irqchip/irq-renesas-rzv2h.c | 32 ++++++++++------------------- 1 file changed, 11 insertions(+), 21 deletions(-) diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-rene= sas-rzv2h.c index 766b981cf3d8..4aa772ba1a1f 100644 --- a/drivers/irqchip/irq-renesas-rzv2h.c +++ b/drivers/irqchip/irq-renesas-rzv2h.c @@ -560,10 +560,8 @@ static int rzv2h_icu_probe_common(struct platform_devi= ce *pdev, struct device_no int ret; =20 parent_domain =3D irq_find_host(parent); - if (!parent_domain) { - dev_err(dev, "cannot find parent domain\n"); - return -ENODEV; - } + if (!parent_domain) + return dev_err_probe(dev, -ENODEV, "cannot find parent domain\n"); =20 rzv2h_icu_data =3D devm_kzalloc(dev, sizeof(*rzv2h_icu_data), GFP_KERNEL); if (!rzv2h_icu_data) @@ -576,29 +574,21 @@ static int rzv2h_icu_probe_common(struct platform_dev= ice *pdev, struct device_no return PTR_ERR(rzv2h_icu_data->base); =20 ret =3D rzv2h_icu_parse_interrupts(rzv2h_icu_data, node); - if (ret) { - dev_err(dev, "cannot parse interrupts: %d\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "cannot parse interrupts\n"); =20 resetn =3D devm_reset_control_get_exclusive_deasserted(dev, NULL); - if (IS_ERR(resetn)) { - ret =3D PTR_ERR(resetn); - dev_err(dev, "failed to acquire deasserted reset: %d\n", ret); - return ret; - } + if (IS_ERR(resetn)) + return dev_err_probe(dev, PTR_ERR(resetn), + "failed to acquire deasserted reset\n"); =20 ret =3D devm_pm_runtime_enable(dev); - if (ret < 0) { - dev_err(dev, "devm_pm_runtime_enable failed, %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "devm_pm_runtime_enable failed\n"); =20 ret =3D pm_runtime_resume_and_get(dev); - if (ret < 0) { - dev_err(dev, "pm_runtime_resume_and_get failed: %d\n", ret); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "pm_runtime_resume_and_get failed\n"); =20 raw_spin_lock_init(&rzv2h_icu_data->lock); =20 --=20 2.52.0