From nobody Tue Feb 10 13:34:24 2026 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 433454A5AFE for ; Wed, 21 Jan 2026 15:01:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769007717; cv=none; b=Kf7HNVqJYWT/eold5kCuLLsvPvVkS3vzH15z//ymJ0Kp/rYaj9P0USx3RlvjcNN6xQLKFkqnPyCPAHfeIu0d8NwnuOKPJLygbuKDHZPBSjWbwgnK4w8ntOSXap7jVpGTXF2T+8/s/HexBpQrU/Wzs17mMxx8x6yHJsKO0F1rnS4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769007717; c=relaxed/simple; bh=nu5eb5oRynroGMCnNukqj+nJoO3Q/QblFeLpl2shU4g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e0P0XTVMzLHmIIKmQSle7YElXEP2H4uTRJFPClmVR45n+6xriyDWjubkcfLufL/d4a/lgDbb9V6Di2zdxJqZ8dkHuWjerEQU26IbVC4FIskALrc5aXpGkpt3XQNMaKfgKVfkMxn9Hm3/Q0Wksx4X0QuzAbQ1zf+zQDpQG1AfKZQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YzSlOTFM; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YzSlOTFM" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-480142406b3so38996125e9.1 for ; Wed, 21 Jan 2026 07:01:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769007714; x=1769612514; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IKfiqRkh5XtZUA4S099iclsE8WGfK6hAsLNATgk0+LQ=; b=YzSlOTFMUnxYn9hlBcGEqMpiBPNJAHWf2wPpmPF5W76cNULktAF6sn3lI9iL5hLVU9 jnezAH2hOcu+l6PW7+Fk/Y9TJM/ctzayR82UAOouS5MgiFafm+yXJdLuszk4jBhqBwZJ p/Y2Zp9RxmnrKPoArS8oPBaQ0FrR/ZidbYGXKjs01NmqbPS+6VUERJyxwG6n6MV3hO41 TJ+DWN4YqLwxgat3kSYLbZvxV51WloDtk0NoitDoyy1oqU24EEh3jxnCl8+mB0aKGP5w WjvfGB1li9AhSv8TovxZnA343kWq+Of2NWKVQyfiGqZ07LksxXTnTTuUwG9v8YEguXdN DWwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769007714; x=1769612514; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=IKfiqRkh5XtZUA4S099iclsE8WGfK6hAsLNATgk0+LQ=; b=TGnK3PfmoO1Jlo6mjANJvIJp5s4VvHByDq+AxPCCMOJ7ieGfLY7nLQuegmSTtyQVoN UO+QPK1B9P54TGvkXVP/HS69Sy8z9D/enY5zM0m2sJmPjMolVJl12b75tVYkozp0qSnV B80ttT82U/wk+3KdmoRsRxAJOfH426LId0cXyB5Xw8S/pG+y+/36ur0dnaWn8iLNwXC3 To4CBSisoydwz7S9TCjorOmeH134uWUso9vI0md1T6UBc8lheqZhZH/78v+RlshY2mz4 br0mGcTnopyXTSCkgWDJkY4FOjgs9vAFPWCqNGqUrhjAFiQu3wVRvwXdPSjIUuAtqotC +Wfw== X-Gm-Message-State: AOJu0YzEEZKRlWhm8kfqPaN39/0VWTB4kfCsdGbi2unDSNd7H9kHCOt/ 1YP9sx3+KDyq1nWSw1zH7VyX1i9b7s0ZzzMTY2blV4nW9iBf+2PTqzcx X-Gm-Gg: AZuq6aIRmPL2EJ5BpKrbUvkaD9RgOWzFdahEwge2h+HdqylqFzFcBH9S2YmvZ3Uy9IN tSnENOF+1zjkarSf/PlWF0gF8v/xkAJOn66R4WacmDsEvcN58h5RNvgm5QIB59w+c2yBASkfyA7 q2+1yqPjv9ZqKtT3saz5JEYssN8hPKBq2r31TatSbKNfBHjEP5Rg7mE7J5AzsdF0ltazT5Wy0LA 5CgJCnpoor5k9UIvDUU2CY8+WEgbh5bMZSjIy165bn3EluxYfE6G2eW9hdzLlCGgsRKJHuw7gUr ks8TU0S4tc5KEhq0s4HFRzCta7BELYe+fiIXEK0JSJBTGOvQoYCHxpqxZ7CPffLZnXMF2jV7rWq f+hG7ZUMoXthjhc2cetBBIQdw4KJOdiDrasHWw7rkapEU42E4IxthKr/luwJHGPZSKPOsBduOdx J254vUhuFnvXz28nZfDhCCl8AvC25ZwPCZi+k0/n1+MbOsHOqRDjLOZpZBt5zwfQdJVIPlQjK2l wZf6QlmAnZ0VCJQs7x5WlGS/gEJUFdSyPZKhKz9AHQ= X-Received: by 2002:a05:600c:8b27:b0:480:3bba:1cac with SMTP id 5b1f17b1804b1-4803bba1da2mr99684705e9.6.1769007712723; Wed, 21 Jan 2026 07:01:52 -0800 (PST) Received: from iku.example.org ([2a06:5906:61b:2d00:3190:c653:bb13:4ca]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48042b6a3e2sm24787585e9.1.2026.01.21.07.01.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 07:01:51 -0800 (PST) From: Prabhakar X-Google-Original-From: Prabhakar To: Thomas Gleixner , Philipp Zabel , Geert Uytterhoeven , Magnus Damm Cc: linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Subject: [PATCH 2/6] irqchip/renesas-rzv2h: Use local device pointer in ICU probe Date: Wed, 21 Jan 2026 15:01:33 +0000 Message-ID: <20260121150137.3364865-3-prabhakar.mahadev-lad.rj@bp.renesas.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260121150137.3364865-1-prabhakar.mahadev-lad.rj@bp.renesas.com> References: <20260121150137.3364865-1-prabhakar.mahadev-lad.rj@bp.renesas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Lad Prabhakar Use a local struct device pointer in rzv2h_icu_probe_common() to avoid repeated dereferencing of pdev->dev. Signed-off-by: Lad Prabhakar --- drivers/irqchip/irq-renesas-rzv2h.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/irqchip/irq-renesas-rzv2h.c b/drivers/irqchip/irq-rene= sas-rzv2h.c index 20c0cd11ef25..766b981cf3d8 100644 --- a/drivers/irqchip/irq-renesas-rzv2h.c +++ b/drivers/irqchip/irq-renesas-rzv2h.c @@ -555,57 +555,58 @@ static int rzv2h_icu_probe_common(struct platform_dev= ice *pdev, struct device_no { struct irq_domain *irq_domain, *parent_domain; struct device_node *node =3D pdev->dev.of_node; + struct device *dev =3D &pdev->dev; struct reset_control *resetn; int ret; =20 parent_domain =3D irq_find_host(parent); if (!parent_domain) { - dev_err(&pdev->dev, "cannot find parent domain\n"); + dev_err(dev, "cannot find parent domain\n"); return -ENODEV; } =20 - rzv2h_icu_data =3D devm_kzalloc(&pdev->dev, sizeof(*rzv2h_icu_data), GFP_= KERNEL); + rzv2h_icu_data =3D devm_kzalloc(dev, sizeof(*rzv2h_icu_data), GFP_KERNEL); if (!rzv2h_icu_data) return -ENOMEM; =20 platform_set_drvdata(pdev, rzv2h_icu_data); =20 - rzv2h_icu_data->base =3D devm_of_iomap(&pdev->dev, node, 0, NULL); + rzv2h_icu_data->base =3D devm_of_iomap(dev, node, 0, NULL); if (IS_ERR(rzv2h_icu_data->base)) return PTR_ERR(rzv2h_icu_data->base); =20 ret =3D rzv2h_icu_parse_interrupts(rzv2h_icu_data, node); if (ret) { - dev_err(&pdev->dev, "cannot parse interrupts: %d\n", ret); + dev_err(dev, "cannot parse interrupts: %d\n", ret); return ret; } =20 - resetn =3D devm_reset_control_get_exclusive_deasserted(&pdev->dev, NULL); + resetn =3D devm_reset_control_get_exclusive_deasserted(dev, NULL); if (IS_ERR(resetn)) { ret =3D PTR_ERR(resetn); - dev_err(&pdev->dev, "failed to acquire deasserted reset: %d\n", ret); + dev_err(dev, "failed to acquire deasserted reset: %d\n", ret); return ret; } =20 - ret =3D devm_pm_runtime_enable(&pdev->dev); + ret =3D devm_pm_runtime_enable(dev); if (ret < 0) { - dev_err(&pdev->dev, "devm_pm_runtime_enable failed, %d\n", ret); + dev_err(dev, "devm_pm_runtime_enable failed, %d\n", ret); return ret; } =20 - ret =3D pm_runtime_resume_and_get(&pdev->dev); + ret =3D pm_runtime_resume_and_get(dev); if (ret < 0) { - dev_err(&pdev->dev, "pm_runtime_resume_and_get failed: %d\n", ret); + dev_err(dev, "pm_runtime_resume_and_get failed: %d\n", ret); return ret; } =20 raw_spin_lock_init(&rzv2h_icu_data->lock); =20 irq_domain =3D irq_domain_create_hierarchy(parent_domain, 0, ICU_NUM_IRQ, - dev_fwnode(&pdev->dev), &rzv2h_icu_domain_ops, + dev_fwnode(dev), &rzv2h_icu_domain_ops, rzv2h_icu_data); if (!irq_domain) { - dev_err(&pdev->dev, "failed to add irq domain\n"); + dev_err(dev, "failed to add irq domain\n"); ret =3D -ENOMEM; goto pm_put; } @@ -616,12 +617,12 @@ static int rzv2h_icu_probe_common(struct platform_dev= ice *pdev, struct device_no =20 /* * coccicheck complains about a missing put_device call before returning,= but it's a false - * positive. We still need &pdev->dev after successfully returning from t= his function. + * positive. We still need dev after successfully returning from this fun= ction. */ return 0; =20 pm_put: - pm_runtime_put(&pdev->dev); + pm_runtime_put(dev); =20 return ret; } --=20 2.52.0