From nobody Mon Feb 9 15:27:12 2026 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECC6648C8B0 for ; Wed, 21 Jan 2026 14:32:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.155.50.34 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769005981; cv=none; b=Ht9PyqIQ6maV+OrX2dUWvdpCyctLnbAEh8tZECRm1/WlzVtwTwRhIwsILuq+hG4TCat59war+HcHhjn/m9D4lvjTuB2J/qK2aAO2H5R7Fdgdu29e9de5S3dd4I9lz32s2NwomMmM/ikhomcOnEZx+XXfpsME1Jy5c8r8xKsUsJo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769005981; c=relaxed/simple; bh=kP9qwF25rFwsyAe2CjEdFD7qKhadcPIVO6R6IVS5VWo=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type; b=aXttill7QztweK9tO9iH2iiuqpoVcBXnnBc3DPHhnEjWq3p1Ulvkx1pktFgmUHBG0US4ZedlmVqK7zoiUBFzZn5mauzqi2d5jRwXluZEyw6Of2Ue77Rk/bw63AC+vxKgGZN4OXoOdD/roXA8E2HCqWXdDRWMU8l39TvUm+6ghJ0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=lbmeDdfU; arc=none smtp.client-ip=90.155.50.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="lbmeDdfU" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Type:MIME-Version:References: Subject:Cc:To:From:Date:Message-ID:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:In-Reply-To; bh=n/GjM0sBpJmMGxTCTtDukJeLriXosPGRF+iVt8tH2n8=; b=lbmeDdfU1B7GwAp7fK9RYExvNJ +DtPz2G4x6Khk6eV/EzQ1q8hDyvf/RHowQ4hV5w8DdjhYIpPppQycAYBRqCrukaucH1o8Q23ASnHD z8hlYdhbXy1HiL/1eFn4tYdt8teMyRuFXLLyjm1kO9Hv9lBMn7c95chSS6L7A+yOJd7ovNMYWCjBf TH8I+LojaLRwMMNPJersVDyX3CTqqVO/bSn2cG6wQR+iG84QbzhVpROuE8JwtmBaThjRcFnVYM9UZ tN1W95+sXwVD/nyeK+Hmw0ZARtBuXT96Hz7+iqtUljAquB/GW25gAGZQo2BI4ehQiR5Ei0gXjgwnB 77fs1NYg==; Received: from 2001-1c00-8d85-5700-266e-96ff-fe07-7dcc.cable.dynamic.v6.ziggo.nl ([2001:1c00:8d85:5700:266e:96ff:fe07:7dcc] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98.2 #2 (Red Hat Linux)) id 1viZGF-0000000GTKF-2epY; Wed, 21 Jan 2026 14:32:43 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 0) id 9640C300BD1; Wed, 21 Jan 2026 15:32:42 +0100 (CET) Message-ID: <20260121143208.219595606@infradead.org> User-Agent: quilt/0.68 Date: Wed, 21 Jan 2026 15:25:01 +0100 From: Peter Zijlstra To: tglx@linutronix.de, mathieu.desnoyers@efficios.com Cc: linux-kernel@vger.kernel.org, peterz@infradead.org, paulmck@kernel.org, boqun.feng@gmail.com, corbet@lwn.net, prakash.sangappa@oracle.com, vineethr@linux.ibm.com, kprateek.nayak@amd.com, rostedt@goodmis.org, bigeasy@linutronix.de, arnd@arndb.de, rdunlap@infradead.org, rongevarg@gmail.com, longman@redhat.com Subject: [PATCH 4/5] hrtimer: Fix trace oddity References: <20260121142457.242071831@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It turns out that __run_hrtimer() will trace like: -0 [032] d.h2. 20705.474563: hrtimer_cancel: hrti= mer=3D0xff2db8f77f8226e8 -0 [032] d.h1. 20705.474563: hrtimer_expire_entry: hrti= mer=3D0xff2db8f77f8226e8 now=3D20699452001850 function=3Dtick_nohz_handler/= 0x0 Which is a bit nonsensical, the timer doesn't get canceled on expiration. The cause is the use of the incorrect debug helper. Fixes: c6a2a1770245 ("hrtimer: Add tracepoint for hrtimers") Reported-by: Peter Zijlstra (Intel) Signed-off-by: Thomas Gleixner Signed-off-by: Peter Zijlstra (Intel) --- kernel/time/hrtimer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/kernel/time/hrtimer.c +++ b/kernel/time/hrtimer.c @@ -1750,7 +1750,7 @@ static void __run_hrtimer(struct hrtimer =20 lockdep_assert_held(&cpu_base->lock); =20 - debug_deactivate(timer); + debug_hrtimer_deactivate(timer); base->running =3D timer; =20 /*