From nobody Sat Feb 7 17:48:35 2026 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B936A47A0AB for ; Wed, 21 Jan 2026 08:24:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768983871; cv=none; b=Xm/87knfhSOK8ZP8zWVzNoOD3pjODfFyrBAbnPMY2cYY01Sgi5NZnLtVQe6Z5hzVUZHYIvPOjKmOFsVvUu88WxLl2uchTGoRMrozwhXH2/nKmdwbtCkv0AIG4qwUG8oCCfhOFetaxdYBw0KDZP3JaZOe6meykNhi3WCZFEciABU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768983871; c=relaxed/simple; bh=sSFv0IdAf9sQinLXNohXO+H7ajTSZl9Iu+sA6q9NtgI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FPQ1kYhw44lrhjpXa5gLBVBmzuhs5u2SD5gQhz25V3YiDL5LUT3O0jwmww7Vdn9/P+gsA2K0c66kHWBlXnRmzNioqcfhMf7332c6IlsEHgwttW/I07pHwT5b+8AunvnmoYIDO55QnCOrnU8BUt2x3Aqm0kIGSLiyv+Puab1D2lE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jaThl1eo; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jaThl1eo" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-34c1d98ba11so4678563a91.3 for ; Wed, 21 Jan 2026 00:24:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768983867; x=1769588667; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kpk5WVvh/foJx73m2kZTvwGkZZ/a/ld0lKy/L+I+Z1w=; b=jaThl1eoY7BtYXQ7/97xutwdB9+A6bwF4q/dhJehBUOA22Yc96zAsrX3oSZQPNWw43 qN/6goMTuWKHJP78kGugMwLh4Mo1Pn2fQ2WZMAiTkmRCsnoZwz4WS4+cRnLZ1ex50gO5 VqxjPhQgzuz1l0LvsNuaGnS+DV42bs195adWzT2h+wKN3xpy7yiIrrYbZUNJLxtkl5RT sZKBkT5xaCUqNm/N7OTxJmzk4ujpsD31fmRkxRkWwrUSFp/kmAyHYiSo+pfdhCwYE4Hp Zef9J9GyQ8+ciAGVuBCuk3ppHHNqBd4zxpwxvNapNV3fJjCAe14kI+0pUjUNnyFd+qTt y9VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768983867; x=1769588667; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kpk5WVvh/foJx73m2kZTvwGkZZ/a/ld0lKy/L+I+Z1w=; b=nzY3hRTXPTrZ12goIGqC2F3BCrGidvk7EB9CpFTc9rFgnASpaUoRE66smELNoSiVx/ O/SRdW5GXViTSNyF8633tSA3rAL25D2sY/hHkQ0aBYSPF4TYeaB9Ive6HUKwvtaLcbqM qdZ4A6BsTROj+2dpr2AVQJYiIW0KMqdxv9PrENZsUk4FLvm9mLlb4MlSuGWwfx+JrX2K tXNxCDhlfhF68hTUgZjF6jcTb9DBkFw7wJTra1/rhGXlOl2edEoJLHTLjT5tabz/mSnQ 4h/H3cGCbO8XsZz5jQmp3KTnDAw8Q7S7QoK+QUj2upES1hMoURyEF8tbAFGy9L8PVZQ3 bQ7Q== X-Forwarded-Encrypted: i=1; AJvYcCVgLO8+rE1oWVMaVPq25+e7ZkQM9EFF6N/T8xo+puNHgxDcFecJTDrseJUkaGNVZdc9wEWAF/UuXqo4vPA=@vger.kernel.org X-Gm-Message-State: AOJu0YwW+RVVqyqKvAAorpdKCICBl7ErmYHoiYra/IDrlFvSL9ojPsfV qQofKn2KzkUM+PLwUhvPMnQtC9T77bmLvsusS27M0r+RtcODmdGv50e/ X-Gm-Gg: AZuq6aJQfXPDndNGq8Q0R8wuumuVQzJShOhcZjmnWXl8P/C5fVF59SSp9BkdjzMzLZx BNp4tFwb7fEHdNb3daQuCr46NX+DiPN+4PGpg7Iyj6cKgcK0+VPSQGQYdpvn3RzCBh1m98CEoqB vdlq3PzAhPB5T+zxyPupN9jJak4CaPtLc9xj9RpxfURLX+b3ig42GjUm14Kprt6lAit3CfQ4OvU v28e+A3ZMspDQHgYont4SFoUn51WbKGE6Ka2g+tNCtqqAMKU0R6LTeWEbNY4Q6bPmN3X5piRcpC Qtez2cDL8Gf6665DZQNR2wD+65fWmD/MsjjwmG5QXto/zEFq7MbKZ63CqgyWnz7Qy/qbIeh5tWR 0xfIWeF0ttZ7D1wLqYcCB5kW3WTOaRKzbkNd7g6HXlwvLUr3Kegd2bLHsHT3uAr0itWJ2847vkm v+6cD7FxJLzxr7WXD90CKLuVAfUG/oonf6dXyA7TtYPZoycwmi6Lih6g== X-Received: by 2002:a17:90b:37d0:b0:33b:8ac4:1ac4 with SMTP id 98e67ed59e1d1-3527329c896mr15564081a91.35.1768983866637; Wed, 21 Jan 2026 00:24:26 -0800 (PST) Received: from d.home.mmyangfl.tk ([2001:19f0:8001:1644:5400:5ff:fe3e:12b1]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-352c150faa1sm4265728a91.7.2026.01.21.00.24.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 00:24:26 -0800 (PST) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org Subject: [PATCH net-next] net: ifb: use u64_stats_t with u64_stats_sync properly Date: Wed, 21 Jan 2026 16:23:44 +0800 Message-ID: <20260121082348.2388314-1-mmyangfl@gmail.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On 64bit arches, struct u64_stats_sync is empty and provides no help against load/store tearing. Convert to u64_stats_t to ensure atomic operations. Signed-off-by: David Yang --- drivers/net/ifb.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/ifb.c b/drivers/net/ifb.c index d3dc0914450a..6da801748189 100644 --- a/drivers/net/ifb.c +++ b/drivers/net/ifb.c @@ -39,8 +39,8 @@ #define TX_Q_LIMIT 32 =20 struct ifb_q_stats { - u64 packets; - u64 bytes; + u64_stats_t packets; + u64_stats_t bytes; struct u64_stats_sync sync; }; =20 @@ -81,8 +81,8 @@ static int ifb_close(struct net_device *dev); static void ifb_update_q_stats(struct ifb_q_stats *stats, int len) { u64_stats_update_begin(&stats->sync); - stats->packets++; - stats->bytes +=3D len; + u64_stats_inc(&stats->packets); + u64_stats_add(&stats->bytes, len); u64_stats_update_end(&stats->sync); } =20 @@ -163,16 +163,16 @@ static void ifb_stats64(struct net_device *dev, for (i =3D 0; i < dev->num_tx_queues; i++,txp++) { do { start =3D u64_stats_fetch_begin(&txp->rx_stats.sync); - packets =3D txp->rx_stats.packets; - bytes =3D txp->rx_stats.bytes; + packets =3D u64_stats_read(&txp->rx_stats.packets); + bytes =3D u64_stats_read(&txp->rx_stats.bytes); } while (u64_stats_fetch_retry(&txp->rx_stats.sync, start)); stats->rx_packets +=3D packets; stats->rx_bytes +=3D bytes; =20 do { start =3D u64_stats_fetch_begin(&txp->tx_stats.sync); - packets =3D txp->tx_stats.packets; - bytes =3D txp->tx_stats.bytes; + packets =3D u64_stats_read(&txp->tx_stats.packets); + bytes =3D u64_stats_read(&txp->tx_stats.bytes); } while (u64_stats_fetch_retry(&txp->tx_stats.sync, start)); stats->tx_packets +=3D packets; stats->tx_bytes +=3D bytes; @@ -248,7 +248,7 @@ static void ifb_fill_stats_data(u64 **data, start =3D u64_stats_fetch_begin(&q_stats->sync); for (j =3D 0; j < IFB_Q_STATS_LEN; j++) { offset =3D ifb_q_stats_desc[j].offset; - (*data)[j] =3D *(u64 *)(stats_base + offset); + (*data)[j] =3D u64_stats_read((u64_stats_t *)(stats_base + offset)); } } while (u64_stats_fetch_retry(&q_stats->sync, start)); =20 --=20 2.51.0