From nobody Sun Feb 8 06:55:49 2026 Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC24C37F726 for ; Wed, 21 Jan 2026 07:00:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.25 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768978846; cv=none; b=loqZCZ2z4ejSq/M+yeZTRM0Zgq7ghSHNNnPEvfIXXb0tuZLlUhfWyuu5/hb+NbVdrfsv6OqABEtnagt3FXlkLrRyIbuhRAEypiyac15eAkjfGZyymO03aaSFYUb+hqiEVHNs3d8de7q6IPFTfQG0RUimtVyKZjM5wBedFiRGTU8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768978846; c=relaxed/simple; bh=WnKGtndWDvdK4W52T0Zx45m220krEQGQRrR9ni8FBN8=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type: References; b=KPw8l+KXFjhAjdIaKxcZP3oW545i73mtStNxqa0Abr1g8idXSbrEa6nlGXfs1syVLU3Z1JHT+dxMiaZjAXoJxRpb+SufBa4TttOyn7PEJzWFHdBpx5gSVFeOnEqoMKGCZLurgUNgZUL0Khl7bp+66Fp2IMh+tegSFkuIQT9XVIg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=GHnpBwIq; arc=none smtp.client-ip=203.254.224.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="GHnpBwIq" Received: from epcas5p2.samsung.com (unknown [182.195.41.40]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20260121070041epoutp02e5f9b63e92321fb8bfd9f9b50bf76c47~MrOJf89rL3191031910epoutp02c for ; Wed, 21 Jan 2026 07:00:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20260121070041epoutp02e5f9b63e92321fb8bfd9f9b50bf76c47~MrOJf89rL3191031910epoutp02c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1768978841; bh=XnK+KinQJ9dYBwjYD5+UzxC6+YDiKsYq0vJbllct4hg=; h=From:To:Subject:Date:References:From; b=GHnpBwIqmozTTLl9FspgPU2+nUR10rffXblG0Ubn2nmjV0y9FVBfb+1ISezVnu229 V56AkDAMBGBC5Iq7Avdewdzvdtzg8VVmYlMzCgZTaAtTaLpQD7hONGhB5sABgVgnn3 2YWq+FnAghP7pG1tt4swuW+KknbWVqAKESs/k45Y= Received: from epsnrtp01.localdomain (unknown [182.195.42.153]) by epcas5p1.samsung.com (KnoxPortal) with ESMTPS id 20260121070041epcas5p141dbd17f6f7c9503c515d85df698da54~MrOJKvyVh1653216532epcas5p1-; Wed, 21 Jan 2026 07:00:41 +0000 (GMT) Received: from epcas5p4.samsung.com (unknown [182.195.41.42]) by epsnrtp01.localdomain (Postfix) with ESMTP id 4dww7s3xyzz6B9mL; Wed, 21 Jan 2026 07:00:41 +0000 (GMT) Received: from epsmtip2.samsung.com (unknown [182.195.34.31]) by epcas5p4.samsung.com (KnoxPortal) with ESMTPA id 20260121070041epcas5p4687d60f28911c7e97497a80adb87232c~MrOIueSMQ1496114961epcas5p4h; Wed, 21 Jan 2026 07:00:41 +0000 (GMT) Received: from hzsscr.. (unknown [109.120.22.104]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20260121070040epsmtip24bf4115cb398a12f02bf556b25d02423~MrOILzOKo3054030540epsmtip2m; Wed, 21 Jan 2026 07:00:40 +0000 (GMT) From: "ping.gao" To: jh80.chung@samsung.com, sebastian.reichel@collabora.com, shawn.lin@rock-chips.com, ulf.hansson@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, hy50.seo@samsung.com, kwangwon.min@samsung.com, ping.gao@samsung.com Subject: [PATCH] drivers: clk: keystone: Fix parameter judgment in clk_prepare Date: Wed, 21 Jan 2026 15:05:03 +0800 Message-ID: <20260121070503.100283-1-ping.gao@samsung.com> X-Mailer: git-send-email 2.49.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CMS-MailID: 20260121070041epcas5p4687d60f28911c7e97497a80adb87232c X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" CMS-TYPE: 105P X-CMS-RootMailID: 20260121070041epcas5p4687d60f28911c7e97497a80adb87232c References: The clk may return NULL or an ERR_PTR. Don't treat an ERR_PTR as valid. for example: biu_clk in dwmmc driver request fail, but it's ERR_PTR, no= t null , it will panic when call clk_prepare log is below: [ 438.400868] [7: binder:436_2: 4998] Unable to handle kernel paging= request at virtual address fffffffffffffffe [ 438.400877] [7: binder:436_2: 4998] Mem abort info: [ 438.400881] [7: binder:436_2: 4998] ESR =3D 0x0000000096000005 [ 438.400887] [7: binder:436_2: 4998] EC =3D 0x25: DABT (current E= L), IL =3D 32 bits [ 438.400894] [7: binder:436_2: 4998] SET =3D 0, FnV =3D 0 [ 438.400899] [7: binder:436_2: 4998] EA =3D 0, S1PTW =3D 0 [ 438.400904] [7: binder:436_2: 4998] FSC =3D 0x05: level 1 transl= ation fault ... [ 438.409424] [7: binder:436_2: 4998] Call trace: [ 438.409429] [7: binder:436_2: 4998] clk_prepare+0x10/0x24 [ 438.409439] [7: binder:436_2: 4998] dw_mci_runtime_resume+0x50/0x= 2d8 [dw_mmc_samsung cd210e210975263404c28fc89778f369f8398f0c] [ 438.409471] [7: binder:436_2: 4998] dw_mci_exynos_runtime_resume+= 0x18/0x58 [dw_mmc_exynos_samsung 2735a594c7c9c9e8c65b0b87523fbf70dcaabfff] [ 438.409496] [7: binder:436_2: 4998] pm_generic_runtime_resume+0x4= 0/0x58 [ 438.409506] [7: binder:436_2: 4998] pm_runtime_force_resume+0x9c/= 0x134 [ 438.409517] [7: binder:436_2: 4998] platform_pm_resume+0x40/0x8c [ 438.409529] [7: binder:436_2: 4998] dpm_run_callback+0x64/0x230 [ 438.409540] [7: binder:436_2: 4998] __device_resume+0x1d8/0x394 [ 438.409551] [7: binder:436_2: 4998] dpm_resume+0x110/0x2b8 [ 438.409561] [7: binder:436_2: 4998] dpm_resume_end+0x1c/0x38 [ 438.409570] [7: binder:436_2: 4998] suspend_devices_and_enter+0x8= 28/0xab0 [ 438.409582] [7: binder:436_2: 4998] pm_suspend+0x334/0x618 [ 438.409592] [7: binder:436_2: 4998] state_store+0x104/0x144 [ 438.409601] [7: binder:436_2: 4998] kobj_attr_store+0x30/0x48 [ 438.409610] [7: binder:436_2: 4998] sysfs_kf_write+0x54/0x6c [ 438.409619] [7: binder:436_2: 4998] kernfs_fop_write_iter+0x104/0= x1a8 [ 438.409628] [7: binder:436_2: 4998] vfs_write+0x24c/0x2f4 [ 438.409640] [7: binder:436_2: 4998] ksys_write+0x78/0xe8 [ 438.409652] [7: binder:436_2: 4998] __arm64_sys_write+0x1c/0x2c [ 438.409664] [7: binder:436_2: 4998] invoke_syscall+0x58/0x114 [ 438.409676] [7: binder:436_2: 4998] el0_svc_common+0xac/0xe0 [ 438.409687] [7: binder:436_2: 4998] do_el0_svc+0x1c/0x28 [ 438.409698] [7: binder:436_2: 4998] el0_svc+0x38/0x68 [ 438.409705] [7: binder:436_2: 4998] el0t_64_sync_handler+0x68/0xbc [ 438.409712] [7: binder:436_2: 4998] el0t_64_sync+0x1a8/0x1ac Signed-off-by: ping.gao --- drivers/clk/clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c index 85d2f2481acf..6d62f69323b5 100644 --- a/drivers/clk/clk.c +++ b/drivers/clk/clk.c @@ -1171,7 +1171,7 @@ static int clk_core_prepare_lock(struct clk_core *cor= e) */ int clk_prepare(struct clk *clk) { - if (!clk) + if (IS_ERR_OR_NULL(clk)) return 0; =20 return clk_core_prepare_lock(clk->core); --=20 2.50.1