From nobody Tue Feb 10 10:55:01 2026 Received: from cstnet.cn (smtp84.cstnet.cn [159.226.251.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C26F30DEA7; Wed, 21 Jan 2026 01:22:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.226.251.84 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768958579; cv=none; b=NQW7UR1noVaaMfTgKa82KQIS3Wqd0VARbDZlXrqICjjN8ft9UcbA7wZ7y1de1vZjNfM8QSZuKCOB1PjZDY8Wenzi5SKWa8ysF6OUbVejUsbr/nT93b2rDtWMcwdlE1xzHuiUN4CKvWZH9dJfl7IjDir00HbcGHNf42ut/qutbXQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768958579; c=relaxed/simple; bh=B6kvndOuGcIDLEeK2haT6VFwiZMfgxKr5nxP7WS9dNs=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=LAyjX7YLhmL5NuV83fdM4fMv4gT7dZ5xHGia5HePYOXScqVG7Sfgg0f38OIGKFHGoMlNWVjrQhV2k0YHfPeXMquXSob/v2NKMjel53mdhCa+kpXXJ5iaYUUTnlkRcvNFYcVdjoJZ0YiAAnAdHXVHa//oUJjFBWG/s2Og9tY3m3I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn; spf=pass smtp.mailfrom=isrc.iscas.ac.cn; arc=none smtp.client-ip=159.226.251.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=isrc.iscas.ac.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=isrc.iscas.ac.cn Received: from localhost.localdomain (unknown [36.112.3.108]) by APP-05 (Coremail) with SMTP id zQCowAB3zhFdKnBpw6_aBQ--.10840S3; Wed, 21 Jan 2026 09:22:41 +0800 (CST) From: Haoxiang Li To: mturquette@baylibre.com, sboyd@kernel.org, bmasney@redhat.com Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Haoxiang Li , stable@vger.kernel.org Subject: [PATCH v2 1/7] clk: st: clkgen-pll: Fix a memory leak in clkgen_odf_register() Date: Wed, 21 Jan 2026 09:22:17 +0800 Message-Id: <20260121012223.186199-2-lihaoxiang@isrc.iscas.ac.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20260121012223.186199-1-lihaoxiang@isrc.iscas.ac.cn> References: <20260121012223.186199-1-lihaoxiang@isrc.iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: zQCowAB3zhFdKnBpw6_aBQ--.10840S3 X-Coremail-Antispam: 1UD129KBjvdXoWrKFyftw4rJw4rXr13Gr1rJFb_yoWfCwbEyr W2q3sav34rCF43A3WUAw47ZryF93Wkurn3Wa1ftrW5K34UXry8KrWFq395Jr15WFWrCryD Gws7J3s8Cr47ZjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbhAFF20E14v26r4j6ryUM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28IrcIa0xkI8VA2jI8067AKxVWUGwA2048vs2IY02 0Ec7CjxVAFwI0_JFI_Gr1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xv wVC0I7IYx2IY67AKxVWUJVWUCwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwA2z4 x0Y4vEx4A2jsIE14v26r1j6r4UM28EF7xvwVC2z280aVCY1x0267AKxVW8JVW8Jr1le2I2 62IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcV AFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG 0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc7CjxVAaw2AFwI0_JF0_Jw1l42 xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWU GwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI4 8JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4U MIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I 8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfUemhwUUUUU X-CM-SenderInfo: 5olkt0x0ld0ww6lv2u4olvutnvoduhdfq/1tbiDAYOE2lwF8I5OgAAsY Content-Type: text/plain; charset="utf-8" If clk_register_composite() fails, call kfree() to release div and gate. Fixes: b9b8e614b580 ("clk: st: Support for PLLs inside ClockGenA(s)") Cc: stable@vger.kernel.org Signed-off-by: Haoxiang Li Reviewed-by: Brian Masney --- drivers/clk/st/clkgen-pll.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/clk/st/clkgen-pll.c b/drivers/clk/st/clkgen-pll.c index c258ff87a171..a7d605b52cf3 100644 --- a/drivers/clk/st/clkgen-pll.c +++ b/drivers/clk/st/clkgen-pll.c @@ -742,8 +742,11 @@ static struct clk * __init clkgen_odf_register(const c= har *parent_name, &div->hw, &clk_divider_ops, &gate->hw, &clk_gate_ops, flags); - if (IS_ERR(clk)) + if (IS_ERR(clk)) { + kfree(div); + kfree(gate); return clk; + } =20 pr_debug("%s: parent %s rate %lu\n", __clk_get_name(clk), --=20 2.25.1