From nobody Tue Feb 10 10:20:34 2026 Received: from smtpout-04.galae.net (smtpout-04.galae.net [185.171.202.116]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36A264DA55E; Wed, 21 Jan 2026 17:05:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.171.202.116 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769015143; cv=none; b=p0hkk0MQyylbfFz5eprptNIUiuPoBGHExcH8FqUSgexUa7tuaxLjzqphctgl1iA2OI67CvCPzWudnrq4ZuHJ/vSw6LJKQJhsMQ/Zd1TkT+5shG6186CNIFc/wVfMslZlUalVd/e3VHnbyJ7i/wSDejrDEf5ypfl1vsFh4o2z0Vo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769015143; c=relaxed/simple; bh=VMbYoKu+7IgsIV37YiNQ2Hu+o2Jq4vUZtELmNqTnQ3E=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bbj8hhMT2Q1cy/ghnxZlcldZ3XllxIlsnCjD5GCC+mfoln5MnMzb8ub26xOTmkEnPQnnTrt4r2ncxaVNZSFzEiVHzI1EO1VYaJXcodRuoD9nvKZfeYCLkxcMabk5J4Q9BxQBh/Pee6TMhTVdtqxRhLjjuCuko5X4k287frLU/vk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=cHlIbbiV; arc=none smtp.client-ip=185.171.202.116 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="cHlIbbiV" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-04.galae.net (Postfix) with ESMTPS id 52BAAC21A90; Wed, 21 Jan 2026 17:05:12 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 87FEB6070A; Wed, 21 Jan 2026 17:05:39 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 3BD50119B1746; Wed, 21 Jan 2026 18:05:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1769015138; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=nPmyVELRcoYpEy2eRks8PaTVcSMPd+ySGhdTlPunCeo=; b=cHlIbbiVxnRpmG+nNuwdVsuEao/WFC3F/1omhX+XpVFFTTlOGyjKJfK2BoWCQy09hKMaPA kM/UVQPKu7q2OxvJPKIzTATGPfUEMNBfx/FSh64js3uMUkilJU/Mw0Hti3bGt7bxJu9r91 HB2SKB5iETigvi47piSrkvyeF3Cr29MGzH3W8c/cW5vRsnxOEyeYuALWkbXJxs8bS00vTx U3voNNKpwY9C+mnS4XcI3WPF9JOdXYjjIKzouZmHNi78ncPnFhE8ZV2+ilxUKOYzJ6uuuE kyH4SKShSKPGVAgu0KrMqp2paH3Z+7MGiLFUiZAWVsBafyNozJV+vJoyyVkEDA== From: "Miquel Raynal (Schneider Electric)" Date: Wed, 21 Jan 2026 18:05:11 +0100 Subject: [PATCH v3 15/17] spi: cadence-qspi: Use a default value for cdns,fifo-width Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260121-schneider-6-19-rc1-qspi-v3-15-43e70fab4444@bootlin.com> References: <20260121-schneider-6-19-rc1-qspi-v3-0-43e70fab4444@bootlin.com> In-Reply-To: <20260121-schneider-6-19-rc1-qspi-v3-0-43e70fab4444@bootlin.com> To: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Magnus Damm , Vaishnav Achath Cc: Thomas Petazzoni , =?utf-8?q?Herv=C3=A9_Codina?= , Wolfram Sang , Vignesh Raghavendra , Santhosh Kumar K , Pratyush Yadav , Pascal Eberhard , linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, "Miquel Raynal (Schneider Electric)" X-Mailer: b4 0.14.3 X-Last-TLS-Session-Version: TLSv1.3 Bindings expect 4 to be the default value for cdns,fifo-width. Said otherwise, if the property (which is not mandatory) is not provided, the OS, in order to comply with the bindings, should not error out and take 4 as default value. Comply with the bindings. This would have slighlty simplyfied my testing if it had been implemented correctly in the first place, but in practice it should have no impact on the existing boards using this controller, as they all set cdns,fifo-width to 4 explicitly in their upstream DTS. Signed-off-by: Miquel Raynal (Schneider Electric) --- drivers/spi/spi-cadence-quadspi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/spi/spi-cadence-quadspi.c b/drivers/spi/spi-cadence-qu= adspi.c index e0e4423baed9..5f3a914e45f7 100644 --- a/drivers/spi/spi-cadence-quadspi.c +++ b/drivers/spi/spi-cadence-quadspi.c @@ -1596,10 +1596,8 @@ static int cqspi_of_get_pdata(struct cqspi_st *cqspi) cqspi->fifo_depth =3D 0; } =20 - if (of_property_read_u32(np, "cdns,fifo-width", &cqspi->fifo_width)) { - dev_err(dev, "couldn't determine fifo-width\n"); - return -ENXIO; - } + if (of_property_read_u32(np, "cdns,fifo-width", &cqspi->fifo_width)) + cqspi->fifo_width =3D 4; =20 if (of_property_read_u32(np, "cdns,trigger-address", &cqspi->trigger_address)) { --=20 2.51.1