From nobody Mon Feb 9 10:30:42 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14F752C21C3 for ; Wed, 21 Jan 2026 15:51:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769010682; cv=none; b=pe6ONhLL/pCWYmu0SP6ZhY1fYDr8i3utKWA731C/ccGJqwDmSAPjm8ippv5OLxSN3avI14vYBM2U27I2o2zWWiqz+NRkHi2udB/q90N9gXoDPuJYV7UhX9Gywd80/4oOjXJYJeQ17vPKljtOVUa4NqzJBXDw2Rc0J3I4EwhfBKQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769010682; c=relaxed/simple; bh=UUE836v8cvihk8IfosjMQaRYSGydDbQU3XprtYIeQiA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=S/Y22nubr5sWamPOLACsE2HGYwPaofhIPb6xb9HrpqtpNHvvTVyMLny06uEL7IZchO7roDUR0FaM4TkZf8+ZBf/wRH6DQU16tVPfxsRPuMaF87X7yEes7o+U+xIKaaBr+3SZIwVoeKoUIGkL14N12zYxpU6X++NxwAybrtcV+kE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IsasMCDM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IsasMCDM" Received: by smtp.kernel.org (Postfix) with ESMTPS id B37F5C19421; Wed, 21 Jan 2026 15:51:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769010681; bh=UUE836v8cvihk8IfosjMQaRYSGydDbQU3XprtYIeQiA=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=IsasMCDMbVYUpfPWTwJ+KyKl0MaTDTK6oEW7yRtUDCPXm82/T+kW5Z+9W5sYu5M8Q lKCnB7WyfuuMlkNMRbHLa5FHTOBSYCS+fFxrEhREyyOJu3ERCe1ljQF73kARsopbTV nRBkpxdAUYFH71b4WPGkVSkZWO/uHAgcNRTzuxJK4gDa+71VLV1CdBl1LvA6JeWWg5 +R8FDOoMrMebuEbxVYj7nxOM1CJxQBfItEM2SynUEt4cIazjhbZuyHxDuJyN2+ZR0x brBpF81k1QX+p156090D6o3934xt3o8uZPGwDzWDAEXWhZ8HTb7NmzNA3xmHP0p6uL PRMbeTQcWFHYA== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8B94D46950; Wed, 21 Jan 2026 15:51:21 +0000 (UTC) From: Andrea Scian via B4 Relay Date: Wed, 21 Jan 2026 16:51:03 +0100 Subject: [PATCH 1/2] mtd: rawnand: pl353: Fix software ECC support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260121-pl353-soft-ecc-support-v1-1-00ad8e160d83@dave.eu> References: <20260121-pl353-soft-ecc-support-v1-0-00ad8e160d83@dave.eu> In-Reply-To: <20260121-pl353-soft-ecc-support-v1-0-00ad8e160d83@dave.eu> To: Miquel Raynal , Michal Simek , Richard Weinberger , Vignesh Raghavendra Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Andrea Scian X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769010680; l=930; i=andrea.scian@dave.eu; s=20260121; h=from:subject:message-id; bh=pjp7e5XqvjwdI+0l+aByZIcrYrWvIGxc1jaHj+aNu4Q=; b=wEfXL24bmliEiOvDo17zS+BJG8c3FiWIrlardBZflj7/oV7+sc4HEGIKNuA7Lun59cUh2bhe+ ocgi6K3cLrYCKyoxgzlodA176byaPsu2DWTnMSAumVl36UrBKX9vTnG X-Developer-Key: i=andrea.scian@dave.eu; a=ed25519; pk=PMQL72nEsyoiJCobnq0uEXwUFpVmkwoWIx317WvaQOU= X-Endpoint-Received: by B4 Relay for andrea.scian@dave.eu/20260121 with auth_id=613 X-Original-From: Andrea Scian Reply-To: andrea.scian@dave.eu From: Andrea Scian We need to set another couple of fields in ecc structure to allow choosing SW ECC instead of HW one, otherwise write operation fail. Signed-off-by: Andrea Scian --- drivers/mtd/nand/raw/pl35x-nand-controller.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/nand/raw/pl35x-nand-controller.c b/drivers/mtd/nan= d/raw/pl35x-nand-controller.c index 11bd90e3f18cb..fcb62b9ec947b 100644 --- a/drivers/mtd/nand/raw/pl35x-nand-controller.c +++ b/drivers/mtd/nand/raw/pl35x-nand-controller.c @@ -976,6 +976,8 @@ static int pl35x_nand_attach_chip(struct nand_chip *chi= p) fallthrough; case NAND_ECC_ENGINE_TYPE_NONE: case NAND_ECC_ENGINE_TYPE_SOFT: + chip->ecc.algo =3D NAND_ECC_ALGO_HAMMING; + chip->ecc.write_page_raw =3D nand_monolithic_write_page_raw; break; case NAND_ECC_ENGINE_TYPE_ON_HOST: ret =3D pl35x_nand_init_hw_ecc_controller(nfc, chip); --=20 2.43.0 From nobody Mon Feb 9 10:30:42 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1503D2F9C2C for ; Wed, 21 Jan 2026 15:51:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769010682; cv=none; b=sGeLOBs1ac0mwhwDob29Dv+YuG4nep5WVMU7jhlRqGB5JVlz6eafjP1HnGhtkQDdRYjz+h9Hj/wu1dIr7i42DaGSx9au5xf5W0LYA5/636lUW2xfKKQ3ffb6GroQ7kKVu2WjcU8/yF7anHzxaVI75rHNjaSI3ycC60FCf/9OW1I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769010682; c=relaxed/simple; bh=R/vNw5kb01VZ9yh8YhT4drwzWiS3+BnRToSbIvTD/E0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ZJkD9p/fH4EA6IFp0hZ17M4x/sJ2FLsszHg/zoCXFzpYl3Ztq6LhbnE6uRpRZxT1YGaLmSmpmYDBM9x3U6O6Hnr3olxtebw/YodD016VDM5yI7BPYx9KLtj+n9PBOE+mHl1EL0Sfkn0opW/adLbPMzeJUirfzb2NvuQZ3X38cEo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CNbDYGS0; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CNbDYGS0" Received: by smtp.kernel.org (Postfix) with ESMTPS id C1A81C116D0; Wed, 21 Jan 2026 15:51:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769010681; bh=R/vNw5kb01VZ9yh8YhT4drwzWiS3+BnRToSbIvTD/E0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=CNbDYGS01Jo7nL3kOAvFXipOSMOx2HBYtNUfVcRFC2ioj1wFcMQsPGTx7AV/ICN/M jw07hUTIjoPRUFUh7d6Ov102vMmi517hW4zq0F9FKr1Fq9Ehqf+Mq024a709lcaJ/w p2PQ7T0ruO9v3MZN0x0ynDmuuU5oPxa07deIpV7KZnJIuKDFsOXKKOqvqc1zu+JMUk Rqv8SFFwcCTf1AvQbz3T/yK66iIfmSHhNHlUSJe1VoCDlKKXKlgPjSozKoz1ly4Q34 40v7W3wEVgrHGiBED/xX5OFUxlr1bid0E67qR/B0NchW8PWfRRQFggc9i5NcLn5YPW 59kTwPitRVSWQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7E4FD4694F; Wed, 21 Jan 2026 15:51:21 +0000 (UTC) From: Andrea Scian via B4 Relay Date: Wed, 21 Jan 2026 16:51:04 +0100 Subject: [PATCH 2/2] mtd: rawnand: pl353: Add message about ECC mode Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260121-pl353-soft-ecc-support-v1-2-00ad8e160d83@dave.eu> References: <20260121-pl353-soft-ecc-support-v1-0-00ad8e160d83@dave.eu> In-Reply-To: <20260121-pl353-soft-ecc-support-v1-0-00ad8e160d83@dave.eu> To: Miquel Raynal , Michal Simek , Richard Weinberger , Vignesh Raghavendra Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Andrea Scian X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769010680; l=1276; i=andrea.scian@dave.eu; s=20260121; h=from:subject:message-id; bh=z/f8ENeXWTXwmxoaenLS81E+i7n9GAGaHSJK6q7dSKQ=; b=cg54ZpaogNFDpXRGOnMDOdNx5iTXN4a1vEajXtKcCRkZVsbPdztye8DOZOhngStVT4r5YBoQp fJIlNPeM73EBcbynH723hUzgiF0uWGr/geyi1IXbsBP8gPkQke0C8q2 X-Developer-Key: i=andrea.scian@dave.eu; a=ed25519; pk=PMQL72nEsyoiJCobnq0uEXwUFpVmkwoWIx317WvaQOU= X-Endpoint-Received: by B4 Relay for andrea.scian@dave.eu/20260121 with auth_id=613 X-Original-From: Andrea Scian Reply-To: andrea.scian@dave.eu From: Andrea Scian This just add some information on kernel log about the selected ECC Signed-off-by: Andrea Scian --- drivers/mtd/nand/raw/pl35x-nand-controller.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mtd/nand/raw/pl35x-nand-controller.c b/drivers/mtd/nan= d/raw/pl35x-nand-controller.c index fcb62b9ec947b..4ce4c6f59b827 100644 --- a/drivers/mtd/nand/raw/pl35x-nand-controller.c +++ b/drivers/mtd/nand/raw/pl35x-nand-controller.c @@ -970,16 +970,19 @@ static int pl35x_nand_attach_chip(struct nand_chip *c= hip) =20 switch (chip->ecc.engine_type) { case NAND_ECC_ENGINE_TYPE_ON_DIE: + dev_info(nfc->dev, "Using on-die ECC\n"); /* Keep these legacy BBT descriptors for ON_DIE situations */ chip->bbt_td =3D &bbt_main_descr; chip->bbt_md =3D &bbt_mirror_descr; fallthrough; case NAND_ECC_ENGINE_TYPE_NONE: case NAND_ECC_ENGINE_TYPE_SOFT: + dev_info(nfc->dev, "Using software ECC (Hamming 1-bit/512B)\n"); chip->ecc.algo =3D NAND_ECC_ALGO_HAMMING; chip->ecc.write_page_raw =3D nand_monolithic_write_page_raw; break; case NAND_ECC_ENGINE_TYPE_ON_HOST: + dev_info(nfc->dev, "Using hardware ECC\n"); ret =3D pl35x_nand_init_hw_ecc_controller(nfc, chip); if (ret) return ret; --=20 2.43.0