From nobody Sat Feb 7 09:34:48 2026 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 674E5481AA4 for ; Wed, 21 Jan 2026 13:08:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769000909; cv=none; b=bqXh7f+M7a9cCtbEAQak9yU/iUQiL6VQ/OrirlvKbAeXMS93VmGZg/NmOiXrD8dx8QV86PbcchsG7NglHxfWGLkPUxIxaHVejTfztQcxSLAiqbHxaIpMWNt1gnR4FtWA57gxehRlNn1zSEJ1qKSPcOBMaC7IcSgSiXd3oVXouxI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769000909; c=relaxed/simple; bh=WrpyBYrLRPsDYxS10ClCNybzyU3ZizE078W5ZmsR7jg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=EWT517M696Dy4znQkegXlSFISZG9KkjRucGfgp7eF2cVuiZjUWlVaAOB+Y8wvlDGEMEpIA8+EsUlvck+jleL/yJjn8auzEHFY0TJJdUPRzib/wlk5dS+92qek9F/SNBAIj0BYKchHtT9C1yW6dWfcB9ZuCAfruqY3O5QYfd/VhQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P1RFNSfH; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P1RFNSfH" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-81f46b5e2ccso3404274b3a.0 for ; Wed, 21 Jan 2026 05:08:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769000908; x=1769605708; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=NMHqsnCQRyn8ggYcyKGe99xv1siVufF+RsMTHXZ7p+M=; b=P1RFNSfHQBv6LSvfnCxyYe88AbXk42OAYDt7zR51oiHvL9Now60Tb+Hv3c4P920/0H Q96ngRE6Uu5eo4hlndPfoMcSJvm3tGvqq5U9EO0v7w7CPLGPeXqCb79vEC9VCuzZXq/u P/ymei2g4ErroD9Woq5HyyM29PFSBbFX82P6awOcZlfXQ/uH3zss20yZA7JfPyp3h/MJ 7fQpIIkrAIWgIcAv3DYlungmj5Bl9vYo2Hse2y4bW1syasCAR5E8TebUd+scOjbu4tOd qho02W2qrfCNX/W20AHEGqMHfPG8t3urNvJVp1yh0mx2tOPseWhC1aPshFWlUvOztr/U CiRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769000908; x=1769605708; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NMHqsnCQRyn8ggYcyKGe99xv1siVufF+RsMTHXZ7p+M=; b=gyKD8zM6MniXZ9UnVXjOPUktYOwk2MCYrrez/wyiP4F5Xxve5NnSJuDkehpLMVGxRs DPqpIM6zZrHgbeu3fofhlKCt/NY5gWGJaGBZqKJbMYoUE0x3GCW7HZfU4D4cM52Dqviy YK/sasf/DtcE52uVqFxt5B87wVgFoiFtv3zy7A50rsdZl8QUd3Gs4y8rZ80Yny7gRtqo W4NZb7Z3xLCErcjKxhVG0S8Y+EqfQ+gUdlQHZGX2P9qFWZ3Zjb6Kz5xUMYXm+kFWaMBj F65WOyGQjOV2P+DehdUutY12SkHEJ33cJJCcahS//kIi2XTpwpQ0iqAZROu7EmvyYLvS eOUw== X-Forwarded-Encrypted: i=1; AJvYcCUh0Y+MUUMHU7dAbJsAo/LfMRDjjpscok0qZrSwwEdTw3WibRxBai19rZXzVM2ALpjn9sDzboP62u1Mwow=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+apiO9XIDDeFkdoua22eCvLe/mbcAvWnoOv15bxD8O0oGA4V7 WUiLKR8fpPDU+ec9ZBaE2mv8Hw8Cne4/jHc9t9qgxlFxrAZBkEt+dd1u X-Gm-Gg: AZuq6aLFoJdmY2kIsX/DOzRkMpL52EDeXjNZSfOcXfy3/DupUaCBcZ2PobVQt5v3kbi Jc5J5Y9hutZ4lHTNc1KN4eGFJJq1aa3ev2pYlOIa0U7fEzT3P1EnBlPpuwXiZQ4g4gHRqxvV4FP nxTNElCtcyNKfIi64qbb7J3zAqmIKzPbjv7aktBFua+SIe+u9nPi7hCl+PFUmqvb1yevp+En4/7 xA3ASgXW5YcDpBf+1KxMpERHAPYOwcQSbz69VU8+LlkbPdi+d9iULIqmAOOgUOCnysLycKsM9i7 +Z3UxHf+aIINoPsYFMxcDLgdyY2VDC3u7hgppwqoM57so3NQEepdY9DTtCRyk6E9dm+2rH/djRC BULD4fQEwswNv9gjVqrkESwR0aLwJ0dqRQPKxp689Mp277DA/KuOoQrAQSLCAmF/x+nSxV+Vk6l NSPtKfXT7VuV1nWYB0e6ZrKpo9 X-Received: by 2002:a05:6a00:1388:b0:81f:45ff:48b0 with SMTP id d2e1a72fcca58-81fe87db4d4mr4982900b3a.13.1769000907655; Wed, 21 Jan 2026 05:08:27 -0800 (PST) Received: from junjungu-PC.localdomain ([188.253.124.89]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-821812a12aesm379876b3a.43.2026.01.21.05.08.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 05:08:27 -0800 (PST) From: Felix Gu Date: Wed, 21 Jan 2026 21:08:19 +0800 Subject: [PATCH v2] firmware: arm_scpi: Fix device_node reference leak in scpi_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260121-arm_scpi_2-v2-1-702d7fa84acb@gmail.com> X-B4-Tracking: v=1; b=H4sIAMLPcGkC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyjHQUlJIzE vPSU3UzU4B8JSMDIzMDQyND3cSi3Pji5ILMeCNdE5NUA4MkA+M0E1MzJaCGgqLUtMwKsGHRsbW 1AKQF5cJcAAAA X-Change-ID: 20260121-arm_scpi_2-44e00b03f456 To: Sudeep Holla , Cristian Marussi Cc: arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Felix Gu X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1769000903; l=1791; i=ustc.gu@gmail.com; h=from:subject:message-id; bh=WrpyBYrLRPsDYxS10ClCNybzyU3ZizE078W5ZmsR7jg=; b=Wuqb9gFAWeVQpz2me9m/Lf1notADMj2TBwywBe9OwE7Ku2k6ISfu734YtWAiG6v8tzEzBCnWd icQ+770y/XaB3ON8aHW9aomXLWuM1MOTxCfeV74szl+qFe/yw2Cu942 X-Developer-Key: i=ustc.gu@gmail.com; a=ed25519; pk=fjUXwmjchVN7Ja6KGP55IXOzFeCl9edaHoQIEUA+/hw= In scpi_probe(), if of_match_node() fails and the function returns early, the shmem reference is not released. Use __free(device_node) scope-based cleanup to automatically release the reference when the variable goes out of scope. Fixes: ed7ecb883901 ("firmware: arm_scpi: Add compatibility checks for shme= m node") Signed-off-by: Felix Gu --- Changes in v2: - Fixed build failure reported by kernel test robot. - Link to v1: https://lore.kernel.org/arm-scmi/tencent_845B889AF1A932F1347E= E0C09F350E491009@qq.com/ --- drivers/firmware/arm_scpi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c index 87c323de17b9..398642cc25d9 100644 --- a/drivers/firmware/arm_scpi.c +++ b/drivers/firmware/arm_scpi.c @@ -18,6 +18,7 @@ =20 #include #include +#include #include #include #include @@ -940,13 +941,13 @@ static int scpi_probe(struct platform_device *pdev) int idx =3D scpi_drvinfo->num_chans; struct scpi_chan *pchan =3D scpi_drvinfo->channels + idx; struct mbox_client *cl =3D &pchan->cl; - struct device_node *shmem =3D of_parse_phandle(np, "shmem", idx); + struct device_node *shmem __free(device_node) =3D + of_parse_phandle(np, "shmem", idx); =20 if (!of_match_node(shmem_of_match, shmem)) return -ENXIO; =20 ret =3D of_address_to_resource(shmem, 0, &res); - of_node_put(shmem); if (ret) { dev_err(dev, "failed to get SCPI payload mem resource\n"); return ret; --- base-commit: 053966c344dbd346e71305f530e91ea77916189f change-id: 20260121-arm_scpi_2-44e00b03f456 Best regards, --=20 Felix Gu